👌 address comments

parent 1a467a8c
...@@ -3607,16 +3607,10 @@ class basic_json ...@@ -3607,16 +3607,10 @@ class basic_json
// remember array size before resizing // remember array size before resizing
const auto previous_size = m_value.array->size(); const auto previous_size = m_value.array->size();
#endif #endif
m_value.array->resize(idx + 1); m_value.array->resize(idx + 1);
#if JSON_DIAGNOSTICS
// set parent for values added above // set parent for values added above
for (auto i = previous_size; i <= idx; ++i) set_parents(begin() + previous_size, idx + 1 - previous_size);
{
set_parent(m_value.array->operator[](i));
}
#endif
} }
return m_value.array->operator[](idx); return m_value.array->operator[](idx);
...@@ -5985,6 +5979,7 @@ class basic_json ...@@ -5985,6 +5979,7 @@ class basic_json
std::swap(m_value, other.m_value); std::swap(m_value, other.m_value);
set_parents(); set_parents();
other.set_parents();
assert_invariant(); assert_invariant();
} }
......
...@@ -20362,16 +20362,10 @@ class basic_json ...@@ -20362,16 +20362,10 @@ class basic_json
// remember array size before resizing // remember array size before resizing
const auto previous_size = m_value.array->size(); const auto previous_size = m_value.array->size();
#endif #endif
m_value.array->resize(idx + 1); m_value.array->resize(idx + 1);
#if JSON_DIAGNOSTICS
// set parent for values added above // set parent for values added above
for (auto i = previous_size; i <= idx; ++i) set_parents(begin() + previous_size, idx + 1 - previous_size);
{
set_parent(m_value.array->operator[](i));
}
#endif
} }
return m_value.array->operator[](idx); return m_value.array->operator[](idx);
...@@ -22740,6 +22734,7 @@ class basic_json ...@@ -22740,6 +22734,7 @@ class basic_json
std::swap(m_value, other.m_value); std::swap(m_value, other.m_value);
set_parents(); set_parents();
other.set_parents();
assert_invariant(); assert_invariant();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment