Commit 08de5060 authored by Dennis Jenkins's avatar Dennis Jenkins

Compiler warning reduction (-Weffc++).

parent 48661c36
...@@ -262,6 +262,7 @@ private: ...@@ -262,6 +262,7 @@ private:
, transport(other.transport) , transport(other.transport)
, armed(other.armed) , armed(other.armed)
, timerFd(other.timerFd) , timerFd(other.timerFd)
, peer()
{ } { }
Timeout(Tcp::Transport* transport_, Timeout(Tcp::Transport* transport_,
...@@ -272,8 +273,8 @@ private: ...@@ -272,8 +273,8 @@ private:
, transport(transport_) , transport(transport_)
, armed(false) , armed(false)
, timerFd(-1) , timerFd(-1)
{ , peer()
} { }
template<typename Ptr> template<typename Ptr>
void associatePeer(const Ptr& ptr) { void associatePeer(const Ptr& ptr) {
...@@ -569,6 +570,7 @@ public: ...@@ -569,6 +570,7 @@ public:
private: private:
ResponseWriter(Tcp::Transport* transport, Request request, Handler* handler) ResponseWriter(Tcp::Transport* transport, Request request, Handler* handler)
: Response(request.version()) : Response(request.version())
, peer_()
, buf_(DefaultStreamSize) , buf_(DefaultStreamSize)
, transport_(transport) , transport_(transport)
, timeout_(transport, handler, std::move(request)) , timeout_(transport, handler, std::move(request))
...@@ -691,7 +693,9 @@ namespace Private { ...@@ -691,7 +693,9 @@ namespace Private {
class ParserBase { class ParserBase {
public: public:
ParserBase() ParserBase()
: cursor(&buffer) : buffer()
, cursor(&buffer)
, allSteps()
, currentStep(0) , currentStep(0)
{ } { }
...@@ -724,6 +728,7 @@ namespace Private { ...@@ -724,6 +728,7 @@ namespace Private {
Parser() Parser()
: ParserBase() : ParserBase()
, request()
{ {
allSteps[0].reset(new RequestLineStep(&request)); allSteps[0].reset(new RequestLineStep(&request));
allSteps[1].reset(new HeadersStep(&request)); allSteps[1].reset(new HeadersStep(&request));
...@@ -732,6 +737,7 @@ namespace Private { ...@@ -732,6 +737,7 @@ namespace Private {
Parser(const char* data, size_t len) Parser(const char* data, size_t len)
: ParserBase() : ParserBase()
, request()
{ {
allSteps[0].reset(new RequestLineStep(&request)); allSteps[0].reset(new RequestLineStep(&request));
allSteps[1].reset(new HeadersStep(&request)); allSteps[1].reset(new HeadersStep(&request));
...@@ -756,6 +762,7 @@ namespace Private { ...@@ -756,6 +762,7 @@ namespace Private {
public: public:
Parser() Parser()
: ParserBase() : ParserBase()
, response()
{ {
allSteps[0].reset(new ResponseLineStep(&response)); allSteps[0].reset(new ResponseLineStep(&response));
allSteps[1].reset(new HeadersStep(&response)); allSteps[1].reset(new HeadersStep(&response));
...@@ -764,6 +771,7 @@ namespace Private { ...@@ -764,6 +771,7 @@ namespace Private {
Parser(const char* data, size_t len) Parser(const char* data, size_t len)
: ParserBase() : ParserBase()
, response()
{ {
allSteps[0].reset(new ResponseLineStep(&response)); allSteps[0].reset(new ResponseLineStep(&response));
allSteps[1].reset(new HeadersStep(&response)); allSteps[1].reset(new HeadersStep(&response));
......
...@@ -35,6 +35,10 @@ struct LowercaseEqual { ...@@ -35,6 +35,10 @@ struct LowercaseEqual {
class Collection { class Collection {
public: public:
Collection()
: headers()
, rawHeaders()
{ }
template<typename H> template<typename H>
typename std::enable_if< typename std::enable_if<
......
...@@ -21,7 +21,7 @@ struct Prototype { ...@@ -21,7 +21,7 @@ struct Prototype {
#define PROTOTYPE_OF(Base, Class) \ #define PROTOTYPE_OF(Base, Class) \
private: \ private: \
std::shared_ptr<Base> clone() const { \ std::shared_ptr<Base> clone() const override { \
return std::make_shared<Class>(*this); \ return std::make_shared<Class>(*this); \
} \ } \
public: public:
...@@ -37,7 +37,7 @@ public: ...@@ -37,7 +37,7 @@ public:
friend class Transport; friend class Transport;
Handler(); Handler();
~Handler(); virtual ~Handler();
virtual void onInput(const char *buffer, size_t len, const std::shared_ptr<Tcp::Peer>& peer) = 0; virtual void onInput(const char *buffer, size_t len, const std::shared_ptr<Tcp::Peer>& peer) = 0;
......
...@@ -66,7 +66,7 @@ public: ...@@ -66,7 +66,7 @@ public:
void disarmTimer(Fd fd); void disarmTimer(Fd fd);
std::shared_ptr<Aio::Handler> clone() const; std::shared_ptr<Aio::Handler> clone() const override;
private: private:
enum WriteStatus { enum WriteStatus {
...@@ -165,6 +165,7 @@ private: ...@@ -165,6 +165,7 @@ private:
: fd(fd_) : fd(fd_)
, value(value_) , value(value_)
, deferred(std::move(deferred_)) , deferred(std::move(deferred_))
, active()
{ {
active.store(true, std::memory_order_relaxed); active.store(true, std::memory_order_relaxed);
} }
......
...@@ -474,11 +474,13 @@ namespace Private { ...@@ -474,11 +474,13 @@ namespace Private {
Message::Message() Message::Message()
: version_(Version::Http11) : version_(Version::Http11)
, cookies_()
{ } { }
namespace Uri { namespace Uri {
Query::Query() Query::Query()
: params()
{ } { }
Query::Query(std::initializer_list<std::pair<const std::string, std::string>> params) Query::Query(std::initializer_list<std::pair<const std::string, std::string>> params)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment