Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
P
pistache
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
pistache
Commits
23ecc317
Commit
23ecc317
authored
Oct 20, 2018
by
Dennis Jenkins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
clang++ warning reduction (mostly missing 'override').
parent
08de5060
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
17 additions
and
15 deletions
+17
-15
examples/http_server.cc
examples/http_server.cc
+4
-2
tests/cookie_test_2.cc
tests/cookie_test_2.cc
+8
-8
tests/http_client_test.cc
tests/http_client_test.cc
+2
-2
tests/http_server_test.cc
tests/http_server_test.cc
+2
-2
tests/payload_test.cc
tests/payload_test.cc
+1
-1
No files found.
examples/http_server.cc
View file @
23ecc317
...
...
@@ -85,7 +85,7 @@ class MyHandler : public Http::Handler {
void
onRequest
(
const
Http
::
Request
&
req
,
Http
::
ResponseWriter
response
)
{
Http
::
ResponseWriter
response
)
override
{
if
(
req
.
resource
()
==
"/ping"
)
{
if
(
req
.
method
()
==
Http
::
Method
::
Get
)
{
...
...
@@ -149,7 +149,9 @@ class MyHandler : public Http::Handler {
}
void
onTimeout
(
const
Http
::
Request
&
req
,
Http
::
ResponseWriter
response
)
{
void
onTimeout
(
const
Http
::
Request
&
req
,
Http
::
ResponseWriter
response
)
override
{
UNUSED
(
req
);
response
.
send
(
Http
::
Code
::
Request_Timeout
,
"Timeout"
)
...
...
tests/cookie_test_2.cc
View file @
23ecc317
...
...
@@ -6,23 +6,23 @@
using
namespace
Pistache
;
using
namespace
Pistache
::
Http
;
void
addCookies
(
const
char
*
str
,
std
::
function
<
void
(
const
CookieJar
&
)
>
testFunc
)
{
void
addCookies
(
const
char
*
str
,
std
::
function
<
void
(
const
CookieJar
&
)
>
testFunc
)
{
CookieJar
jar
;
jar
.
addFromRaw
(
str
,
strlen
(
str
));
testFunc
(
jar
);
}
TEST
(
cookie_test_2
,
cookiejar_test_2
)
{
addCookies
(
"key=value1; key=value2; key2=; key2=foo=bar"
,
[](
const
CookieJar
&
jar
)
{
addCookies
(
"key=value1; key=value2; key2=; key2=foo=bar"
,
[](
const
CookieJar
&
jar
)
{
int
count
=
0
;
for
(
const
auto
&
c
:
jar
)
{
for
(
const
auto
&
c
:
jar
)
{
static_cast
<
void
>
(
c
);
// 'c' is unused
count
++
;
}
ASSERT_EQ
(
count
,
4
);
// number of cookies must be 4 in this case
});
}
tests/http_client_test.cc
View file @
23ecc317
...
...
@@ -11,7 +11,7 @@ using namespace Pistache;
struct
HelloHandler
:
public
Http
::
Handler
{
HTTP_PROTOTYPE
(
HelloHandler
)
void
onRequest
(
const
Http
::
Request
&
/*request*/
,
Http
::
ResponseWriter
writer
)
void
onRequest
(
const
Http
::
Request
&
/*request*/
,
Http
::
ResponseWriter
writer
)
override
{
writer
.
send
(
Http
::
Code
::
Ok
,
"Hello, World!"
);
}
...
...
tests/http_server_test.cc
View file @
23ecc317
...
...
@@ -15,7 +15,7 @@ struct HelloHandlerWithDelay : public Http::Handler {
explicit
HelloHandlerWithDelay
(
int
delay
=
0
)
:
delay_
(
delay
)
{
}
void
onRequest
(
const
Http
::
Request
&
/*request*/
,
Http
::
ResponseWriter
writer
)
void
onRequest
(
const
Http
::
Request
&
/*request*/
,
Http
::
ResponseWriter
writer
)
override
{
std
::
this_thread
::
sleep_for
(
std
::
chrono
::
seconds
(
delay_
));
writer
.
send
(
Http
::
Code
::
Ok
,
"Hello, World!"
);
...
...
@@ -32,7 +32,7 @@ struct SlowHandlerOnSpecialPage : public Http::Handler {
explicit
SlowHandlerOnSpecialPage
(
int
delay
=
0
)
:
delay_
(
delay
)
{
}
void
onRequest
(
const
Http
::
Request
&
request
,
Http
::
ResponseWriter
writer
)
void
onRequest
(
const
Http
::
Request
&
request
,
Http
::
ResponseWriter
writer
)
override
{
if
(
request
.
resource
()
==
SPECIAL_PAGE
)
{
...
...
tests/payload_test.cc
View file @
23ecc317
...
...
@@ -124,7 +124,7 @@ TEST(payload, manual_construction) {
void
onRequest
(
const
Http
::
Request
&
req
,
Http
::
ResponseWriter
response
)
Http
::
ResponseWriter
response
)
override
{
UNUSED
(
req
);
response
.
send
(
Http
::
Code
::
Ok
,
"All good"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment