Commit 96c7ed90 authored by Guido Casati's avatar Guido Casati

Minor comments

parent 2c8342c0
...@@ -75,6 +75,7 @@ int DU_handle_DL_RRC_MESSAGE_TRANSFER(instance_t instance, sctp_assoc_t assoc_id ...@@ -75,6 +75,7 @@ int DU_handle_DL_RRC_MESSAGE_TRANSFER(instance_t instance, sctp_assoc_t assoc_id
/* UL RRC Message Transfer */ /* UL RRC Message Transfer */
int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_initial_ul_rrc_message_t *msg) int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_initial_ul_rrc_message_t *msg)
{ {
/* encode Initial UL RRC Message Transfer */
F1AP_F1AP_PDU_t *pdu = encode_initial_ul_rrc_message_transfer(msg); F1AP_F1AP_PDU_t *pdu = encode_initial_ul_rrc_message_transfer(msg);
if (pdu == NULL) { if (pdu == NULL) {
LOG_E(F1AP, "cannot encode F1 INITIAL UL RRC MESSAGE TRANSFER, can't send message\n"); LOG_E(F1AP, "cannot encode F1 INITIAL UL RRC MESSAGE TRANSFER, can't send message\n");
...@@ -82,7 +83,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in ...@@ -82,7 +83,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in
return -1; return -1;
} }
/* encode */ /* encode F1AP PDU */
uint8_t *buffer = NULL; uint8_t *buffer = NULL;
uint32_t len = 0; uint32_t len = 0;
if (f1ap_encode_pdu(pdu, &buffer, &len) < 0) { if (f1ap_encode_pdu(pdu, &buffer, &len) < 0) {
...@@ -91,6 +92,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in ...@@ -91,6 +92,7 @@ int DU_send_INITIAL_UL_RRC_MESSAGE_TRANSFER(sctp_assoc_t assoc_id, const f1ap_in
} }
ASN_STRUCT_FREE(asn_DEF_F1AP_F1AP_PDU, pdu); ASN_STRUCT_FREE(asn_DEF_F1AP_F1AP_PDU, pdu);
/* Send to ITTI */
f1ap_itti_send_sctp_data_req(assoc_id, buffer, len); f1ap_itti_send_sctp_data_req(assoc_id, buffer, len);
return 0; return 0;
} }
......
...@@ -29,6 +29,13 @@ ...@@ -29,6 +29,13 @@
#include "openair3/UTILS/conversions.h" #include "openair3/UTILS/conversions.h"
#include "common/utils/oai_asn1.h" #include "common/utils/oai_asn1.h"
/* ====================================
* F1AP Initial UL RRC Message Transfer
* ==================================== */
/**
* @brief Initial UL RRC Message Transfer encoding
*/
F1AP_F1AP_PDU_t *encode_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *msg) F1AP_F1AP_PDU_t *encode_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *msg)
{ {
F1AP_F1AP_PDU_t *pdu = calloc(1, sizeof(*pdu)); F1AP_F1AP_PDU_t *pdu = calloc(1, sizeof(*pdu));
...@@ -98,6 +105,9 @@ F1AP_F1AP_PDU_t *encode_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rr ...@@ -98,6 +105,9 @@ F1AP_F1AP_PDU_t *encode_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rr
return pdu; return pdu;
} }
/**
* @brief Initial UL RRC Message Transfer decoding
*/
bool decode_initial_ul_rrc_message_transfer(const F1AP_F1AP_PDU_t *pdu, f1ap_initial_ul_rrc_message_t *out) bool decode_initial_ul_rrc_message_transfer(const F1AP_F1AP_PDU_t *pdu, f1ap_initial_ul_rrc_message_t *out)
{ {
DevAssert(out != NULL); DevAssert(out != NULL);
...@@ -129,6 +139,9 @@ bool decode_initial_ul_rrc_message_transfer(const F1AP_F1AP_PDU_t *pdu, f1ap_ini ...@@ -129,6 +139,9 @@ bool decode_initial_ul_rrc_message_transfer(const F1AP_F1AP_PDU_t *pdu, f1ap_ini
return true; return true;
} }
/**
* @brief Initial UL RRC Message Transfer deep copy
*/
f1ap_initial_ul_rrc_message_t cp_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *msg) f1ap_initial_ul_rrc_message_t cp_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *msg)
{ {
uint8_t *rrc_container = calloc(msg->rrc_container_length, sizeof(*rrc_container)); uint8_t *rrc_container = calloc(msg->rrc_container_length, sizeof(*rrc_container));
...@@ -155,6 +168,9 @@ f1ap_initial_ul_rrc_message_t cp_initial_ul_rrc_message_transfer(const f1ap_init ...@@ -155,6 +168,9 @@ f1ap_initial_ul_rrc_message_t cp_initial_ul_rrc_message_transfer(const f1ap_init
return cp; return cp;
} }
/**
* @brief Initial UL RRC Message Transfer equality check
*/
bool eq_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *a, const f1ap_initial_ul_rrc_message_t *b) bool eq_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *a, const f1ap_initial_ul_rrc_message_t *b)
{ {
if (a->gNB_DU_ue_id != b->gNB_DU_ue_id) if (a->gNB_DU_ue_id != b->gNB_DU_ue_id)
...@@ -178,6 +194,9 @@ bool eq_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *a, ...@@ -178,6 +194,9 @@ bool eq_initial_ul_rrc_message_transfer(const f1ap_initial_ul_rrc_message_t *a,
return true; return true;
} }
/**
* @brief Initial UL RRC Message Transfer memory management
*/
void free_initial_ul_rrc_message_transfer(f1ap_initial_ul_rrc_message_t *msg) void free_initial_ul_rrc_message_transfer(f1ap_initial_ul_rrc_message_t *msg)
{ {
DevAssert(msg != NULL); DevAssert(msg != NULL);
......
...@@ -43,6 +43,9 @@ static void f1ap_msg_free(F1AP_F1AP_PDU_t *pdu) ...@@ -43,6 +43,9 @@ static void f1ap_msg_free(F1AP_F1AP_PDU_t *pdu)
ASN_STRUCT_FREE(asn_DEF_F1AP_F1AP_PDU, pdu); ASN_STRUCT_FREE(asn_DEF_F1AP_F1AP_PDU, pdu);
} }
/**
* @brief Test Initial UL RRC Message Transfer encoding/decoding
*/
static void test_initial_ul_rrc_message_transfer(void) static void test_initial_ul_rrc_message_transfer(void)
{ {
f1ap_plmn_t plmn = { .mcc = 208, .mnc = 95, .mnc_digit_length = 2 }; f1ap_plmn_t plmn = { .mcc = 208, .mnc = 95, .mnc_digit_length = 2 };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment