• Cedric Roux's avatar
    bugfix: speedup integrity computation · d7931ea4
    Cedric Roux authored
    The main work of this commit is to rewrite cipher_aes_128_cbc_cmac()
    which was too slow and created issues when running the 4G eNB on some
    machines (LLL when using a b210).
    
    Instead of creating the security context, use it, and delete it, all in
    cipher_aes_128_cbc_cmac(), we introduce the function init_aes_128_cbc_cmac()
    to create it, and we change cipher_aes_128_cbc_cmac() to just use it,
    and we also adapt free_aes_128_cbc_cmac(). The function aes_128_cbc_cmac()
    is removed, it does not follow the new init/use/free API.
    
    Doing so, on the primary test machine used to do this work (a powerful
    and fast machine where it is possible to set the CPUs' frequencies)
    it was possible to limit the CPUs' frequencies to 500 MHz (it was not
    possible to go lower) without any LLL (using a b210, quectel UE in
    idle, no data traffic, only periodic measurement reports). Before this
    commit, it was necessary to set a frequency of at least 1.8 GHz
    otherwise some LLL would appear.
    
    Then we need to adapt the rest of the code to take into account those
    changes.
    
    A notion of security container (stream_security_container_t) containing
    ciphering and integrity contexts is introduced.
    
    And the code is harmonized for, hopefully, better readability.
    
    The (opaque) type stream_security_context_t is introduced, used by
    both integrity and ciphering contexts. The idea is to use a
    init()/use()/free() API for all the security procedures, identical for
    all the ciphering and integrity procedures.
    d7931ea4
pdcp_security.c 8.07 KB