From 707cf8088ac33dd63315c30bb0d3074375861d22 Mon Sep 17 00:00:00 2001 From: Vijay Chadachan <vijay.chadachan@firecell.io> Date: Fri, 11 Aug 2023 18:34:54 +0200 Subject: [PATCH] Addressed the review comments --- executables/softmodem-common.c | 2 +- openair2/LAYER2/NR_MAC_COMMON/nr_mac_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/executables/softmodem-common.c b/executables/softmodem-common.c index 1b1964f748..bdf942226f 100644 --- a/executables/softmodem-common.c +++ b/executables/softmodem-common.c @@ -109,7 +109,7 @@ void get_common_options(uint32_t execmask) { config_set_checkfunctions(cmdline_params, cmdline_CheckParams, numparams); config_get(cmdline_params, sizeof(cmdline_params) / sizeof(paramdef_t), NULL); nfapi_index = config_paramidx_fromname(cmdline_params, sizeof(cmdline_params) / sizeof(paramdef_t),"nfapi"); - AssertFatal(nfapi_index,"Index for nfapi config option not found!"); + AssertFatal(nfapi_index >= 0,"Index for nfapi config option not found!"); nfapi_mode = config_get_processedint(&cmdline_params[nfapi_index]); paramdef_t cmdline_logparams[] =CMDLINE_LOGPARAMS_DESC ; diff --git a/openair2/LAYER2/NR_MAC_COMMON/nr_mac_common.c b/openair2/LAYER2/NR_MAC_COMMON/nr_mac_common.c index c9a3009e9c..85b6988983 100644 --- a/openair2/LAYER2/NR_MAC_COMMON/nr_mac_common.c +++ b/openair2/LAYER2/NR_MAC_COMMON/nr_mac_common.c @@ -2899,7 +2899,7 @@ uint8_t compute_srs_resource_indicator(NR_PUSCH_ServingCellConfig_t *pusch_servi } if (count>0) { nbits = ceil(log2(count)); - if (val && srs_feedback && nbits > 0 && count > 2) { + if (val && srs_feedback && count > 1) { *val = table_7_3_1_1_2_32[count-2][srs_feedback->sri]; } } -- 2.26.2