Commit 4ebfe3cf authored by Joe Loser's avatar Joe Loser Committed by Facebook Github Bot

Enable IntToDouble test in ConvTest (#1112)

Summary:
- Most of `IntToDouble` test is commented out as it previously did not
  work with GCC 4.6.1.
- Enable the rest of this test as it works fine on GCC 5.1
Pull Request resolved: https://github.com/facebook/folly/pull/1112

Reviewed By: yfeldblum

Differential Revision: D15014999

Pulled By: Orvid

fbshipit-source-id: a26a0fcacc9a22c03d0d67c35cabf8ec0ca91813
parent c47ff43b
...@@ -676,14 +676,12 @@ TEST(Conv, EmptyStringToDouble) { ...@@ -676,14 +676,12 @@ TEST(Conv, EmptyStringToDouble) {
TEST(Conv, IntToDouble) { TEST(Conv, IntToDouble) {
auto d = to<double>(42); auto d = to<double>(42);
EXPECT_EQ(d, 42); EXPECT_EQ(d, 42);
/* This seems not work in ubuntu11.10, gcc 4.6.1
try { try {
auto f = to<float>(957837589847); (void)to<float>(957837589847);
ADD_FAILURE(); ADD_FAILURE();
} catch (std::range_error& e) { } catch (std::range_error& e) {
//LOG(INFO) << e.what(); //LOG(INFO) << e.what();
} }
*/
} }
TEST(Conv, DoubleToInt) { TEST(Conv, DoubleToInt) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment