Commit 6da515d7 authored by Robin Cheng's avatar Robin Cheng Committed by Facebook GitHub Bot

Disable some slow StlVectorTest cases under TSAN.

Summary: These tests time out under TSAN and there's not much value to run them under TSAN because the tests are single-threaded.

Reviewed By: yfeldblum

Differential Revision: D23302147

fbshipit-source-id: 6fc8bd3e29c9cde72bfa85a14fd7726850540285
parent adc391ea
...@@ -187,6 +187,7 @@ THOUGHTS: ...@@ -187,6 +187,7 @@ THOUGHTS:
#include <folly/lang/Pretty.h> #include <folly/lang/Pretty.h>
#include <folly/portability/GFlags.h> #include <folly/portability/GFlags.h>
#include <folly/portability/GTest.h> #include <folly/portability/GTest.h>
#include <folly/test/TestUtils.h>
// We use some pre-processor magic to auto-generate setup and destruct code, // We use some pre-processor magic to auto-generate setup and destruct code,
// but it also means we have some parameters that may not be used. // but it also means we have some parameters that may not be used.
...@@ -2380,6 +2381,12 @@ STL_TEST( ...@@ -2380,6 +2381,12 @@ STL_TEST(
a, a,
p, p,
t) { t) {
if (folly::kIsSanitizeThread) {
// This test is too slow when running under TSAN that it times out.
// There's little value of running under TSAN as this test is
// single-threaded.
SKIP();
}
DataState<Vector> dsa(a); DataState<Vector> dsa(a);
int idx = distance(a.begin(), p); int idx = distance(a.begin(), p);
int tval = convertToInt(t); int tval = convertToInt(t);
...@@ -2400,6 +2407,12 @@ STL_TEST( ...@@ -2400,6 +2407,12 @@ STL_TEST(
a, a,
p, p,
t) { t) {
if (folly::kIsSanitizeThread) {
// This test is too slow when running under TSAN that it times out.
// There's little value of running under TSAN as this test is
// single-threaded.
SKIP();
}
// rvalue-references cannot have their address checked for aliased inserts // rvalue-references cannot have their address checked for aliased inserts
if (a.data() <= addressof(t) && addressof(t) < a.data() + a.size()) { if (a.data() <= addressof(t) && addressof(t) < a.data() + a.size()) {
return; return;
...@@ -2425,6 +2438,12 @@ STL_TEST( ...@@ -2425,6 +2438,12 @@ STL_TEST(
p, p,
n, n,
t) { t) {
if (folly::kIsSanitizeThread) {
// This test is too slow when running under TSAN that it times out.
// There's little value of running under TSAN as this test is
// single-threaded.
SKIP();
}
DataState<Vector> dsa(a); DataState<Vector> dsa(a);
int idx = distance(a.begin(), p); int idx = distance(a.begin(), p);
int tval = convertToInt(t); int tval = convertToInt(t);
...@@ -2473,6 +2492,12 @@ STL_TEST( ...@@ -2473,6 +2492,12 @@ STL_TEST(
p, p,
i, i,
j) { j) {
if (folly::kIsSanitizeThread) {
// This test is too slow when running under TSAN that it times out.
// There's little value of running under TSAN as this test is
// single-threaded.
SKIP();
}
DataState<Vector> dsa(a); DataState<Vector> dsa(a);
int idx = distance(a.begin(), p); int idx = distance(a.begin(), p);
...@@ -2504,6 +2529,12 @@ STL_TEST( ...@@ -2504,6 +2529,12 @@ STL_TEST(
p, p,
i, i,
j) { j) {
if (folly::kIsSanitizeThread) {
// This test is too slow when running under TSAN that it times out.
// There's little value of running under TSAN as this test is
// single-threaded.
SKIP();
}
DataState<Vector> dsa(a); DataState<Vector> dsa(a);
int idx = distance(a.begin(), p); int idx = distance(a.begin(), p);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment