Commit 7e693d01 authored by Rosen Penev's avatar Rosen Penev Committed by Facebook Github Bot

Replace {} with default (#1291)

Summary:
Found with modernize-use-equals-default
Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Pull Request resolved: https://github.com/facebook/folly/pull/1291

Reviewed By: markisaa

Differential Revision: D19229643

Pulled By: yfeldblum

fbshipit-source-id: 69f0bd4f55ea5a3697ab176aab80683b99b4e11c
parent 6ea84a8e
...@@ -78,7 +78,7 @@ uint32_t IPAddressV4::toLongHBO(StringPiece ip) { ...@@ -78,7 +78,7 @@ uint32_t IPAddressV4::toLongHBO(StringPiece ip) {
} }
// public default constructor // public default constructor
IPAddressV4::IPAddressV4() {} IPAddressV4::IPAddressV4() = default;
// ByteArray4 constructor // ByteArray4 constructor
IPAddressV4::IPAddressV4(const ByteArray4& src) noexcept : addr_(src) {} IPAddressV4::IPAddressV4(const ByteArray4& src) noexcept : addr_(src) {}
......
...@@ -67,7 +67,7 @@ bool IPAddressV6::validate(StringPiece ip) noexcept { ...@@ -67,7 +67,7 @@ bool IPAddressV6::validate(StringPiece ip) noexcept {
} }
// public default constructor // public default constructor
IPAddressV6::IPAddressV6() {} IPAddressV6::IPAddressV6() = default;
// public string constructor // public string constructor
IPAddressV6::IPAddressV6(StringPiece addr) { IPAddressV6::IPAddressV6(StringPiece addr) {
......
...@@ -186,7 +186,7 @@ Subprocess::Options& Subprocess::Options::fd(int fd, int action) { ...@@ -186,7 +186,7 @@ Subprocess::Options& Subprocess::Options::fd(int fd, int action) {
return *this; return *this;
} }
Subprocess::Subprocess() {} Subprocess::Subprocess() = default;
Subprocess::Subprocess( Subprocess::Subprocess(
const std::vector<std::string>& argv, const std::vector<std::string>& argv,
......
...@@ -35,14 +35,14 @@ class ThreadListHook { ...@@ -35,14 +35,14 @@ class ThreadListHook {
~ThreadListHook(); ~ThreadListHook();
private: private:
ThreadListHook() {} ThreadListHook() = default;
ThreadPoolListHook* poolId_; ThreadPoolListHook* poolId_;
std::thread::id threadId_; std::thread::id threadId_;
}; };
class GlobalThreadPoolListImpl { class GlobalThreadPoolListImpl {
public: public:
GlobalThreadPoolListImpl() {} GlobalThreadPoolListImpl() = default;
void registerThreadPool(ThreadPoolListHook* threadPoolId, std::string name); void registerThreadPool(ThreadPoolListHook* threadPoolId, std::string name);
...@@ -89,7 +89,7 @@ class GlobalThreadPoolListImpl { ...@@ -89,7 +89,7 @@ class GlobalThreadPoolListImpl {
class GlobalThreadPoolList { class GlobalThreadPoolList {
public: public:
GlobalThreadPoolList() {} GlobalThreadPoolList() = default;
static GlobalThreadPoolList& instance(); static GlobalThreadPoolList& instance();
......
...@@ -113,7 +113,7 @@ struct UniformDistributionFunctor { ...@@ -113,7 +113,7 @@ struct UniformDistributionFunctor {
} // namespace } // namespace
FunctionScheduler::FunctionScheduler() {} FunctionScheduler::FunctionScheduler() = default;
FunctionScheduler::~FunctionScheduler() { FunctionScheduler::~FunctionScheduler() {
// make sure to stop the thread (if running) // make sure to stop the thread (if running)
......
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
namespace folly { namespace folly {
ThreadedRepeatingFunctionRunner::ThreadedRepeatingFunctionRunner() {} ThreadedRepeatingFunctionRunner::ThreadedRepeatingFunctionRunner() = default;
ThreadedRepeatingFunctionRunner::~ThreadedRepeatingFunctionRunner() { ThreadedRepeatingFunctionRunner::~ThreadedRepeatingFunctionRunner() {
if (stopImpl()) { if (stopImpl()) {
......
...@@ -34,7 +34,7 @@ class StackTraceStack::Node : public StackTrace { ...@@ -34,7 +34,7 @@ class StackTraceStack::Node : public StackTrace {
private: private:
Node() : next(nullptr) {} Node() : next(nullptr) {}
~Node() {} ~Node() = default;
}; };
auto StackTraceStack::Node::allocate() -> Node* { auto StackTraceStack::Node::allocate() -> Node* {
......
...@@ -96,8 +96,7 @@ void AsyncIOOp::reset(NotificationCallback cb) { ...@@ -96,8 +96,7 @@ void AsyncIOOp::reset(NotificationCallback cb) {
memset(&iocb_, 0, sizeof(iocb_)); memset(&iocb_, 0, sizeof(iocb_));
} }
AsyncIOOp::~AsyncIOOp() { AsyncIOOp::~AsyncIOOp() = default;
}
void AsyncIOOp::pread(int fd, void* buf, size_t size, off_t start) { void AsyncIOOp::pread(int fd, void* buf, size_t size, off_t start) {
init(); init();
......
...@@ -526,7 +526,7 @@ FastStackTracePrinter::FastStackTracePrinter( ...@@ -526,7 +526,7 @@ FastStackTracePrinter::FastStackTracePrinter(
LocationInfoMode::FULL, LocationInfoMode::FULL,
symbolCacheSize) {} symbolCacheSize) {}
FastStackTracePrinter::~FastStackTracePrinter() {} FastStackTracePrinter::~FastStackTracePrinter() = default;
void FastStackTracePrinter::printStackTrace(bool symbolize) { void FastStackTracePrinter::printStackTrace(bool symbolize) {
SCOPE_EXIT { SCOPE_EXIT {
......
...@@ -51,7 +51,7 @@ class GlobalCache { ...@@ -51,7 +51,7 @@ class GlobalCache {
} }
private: private:
GlobalCache() {} GlobalCache() = default;
// Leak this intentionally. During shutdown, we may call getFiberManager, // Leak this intentionally. During shutdown, we may call getFiberManager,
// and want access to the fiber managers during that time. // and want access to the fiber managers during that time.
...@@ -126,7 +126,7 @@ class ThreadLocalCache { ...@@ -126,7 +126,7 @@ class ThreadLocalCache {
} }
private: private:
ThreadLocalCache() {} ThreadLocalCache() = default;
struct ThreadLocalCacheTag {}; struct ThreadLocalCacheTag {};
using ThreadThreadLocalCache = using ThreadThreadLocalCache =
......
...@@ -394,7 +394,7 @@ IOBuf IOBuf::wrapBufferAsValue(const void* buf, std::size_t capacity) noexcept { ...@@ -394,7 +394,7 @@ IOBuf IOBuf::wrapBufferAsValue(const void* buf, std::size_t capacity) noexcept {
return IOBuf(WrapBufferOp::WRAP_BUFFER, buf, capacity); return IOBuf(WrapBufferOp::WRAP_BUFFER, buf, capacity);
} }
IOBuf::IOBuf() noexcept {} IOBuf::IOBuf() noexcept = default;
IOBuf::IOBuf(IOBuf&& other) noexcept IOBuf::IOBuf(IOBuf&& other) noexcept
: data_(other.data_), : data_(other.data_),
......
...@@ -91,7 +91,7 @@ class AsyncSSLSocketConnector : public AsyncSocket::ConnectCallback, ...@@ -91,7 +91,7 @@ class AsyncSSLSocketConnector : public AsyncSocket::ConnectCallback,
std::chrono::steady_clock::time_point startTime_; std::chrono::steady_clock::time_point startTime_;
protected: protected:
~AsyncSSLSocketConnector() override {} ~AsyncSSLSocketConnector() override = default;
public: public:
AsyncSSLSocketConnector( AsyncSSLSocketConnector(
......
...@@ -50,7 +50,7 @@ int HHWheelTimerBase<Duration>::DEFAULT_TICK_INTERVAL = ...@@ -50,7 +50,7 @@ int HHWheelTimerBase<Duration>::DEFAULT_TICK_INTERVAL =
detail::HHWheelTimerDurationConst<Duration>::DEFAULT_TICK_INTERVAL; detail::HHWheelTimerDurationConst<Duration>::DEFAULT_TICK_INTERVAL;
template <class Duration> template <class Duration>
HHWheelTimerBase<Duration>::Callback::Callback() {} HHWheelTimerBase<Duration>::Callback::Callback() = default;
template <class Duration> template <class Duration>
HHWheelTimerBase<Duration>::Callback::~Callback() { HHWheelTimerBase<Duration>::Callback::~Callback() {
......
...@@ -179,7 +179,7 @@ struct RequestContext::StateHazptr::Combined : hazptr_obj_base<Combined> { ...@@ -179,7 +179,7 @@ struct RequestContext::StateHazptr::Combined : hazptr_obj_base<Combined> {
} }
}; // Combined }; // Combined
RequestContext::StateHazptr::StateHazptr() {} RequestContext::StateHazptr::StateHazptr() = default;
RequestContext::StateHazptr::StateHazptr(const StateHazptr& o) { RequestContext::StateHazptr::StateHazptr(const StateHazptr& o) {
Combined* oc = o.combined(); Combined* oc = o.combined();
......
...@@ -16,4 +16,4 @@ ...@@ -16,4 +16,4 @@
#include <folly/lang/ColdClass.h> #include <folly/lang/ColdClass.h>
folly::cold_detail::ColdClass::ColdClass() noexcept {} folly::cold_detail::ColdClass::ColdClass() noexcept = default;
...@@ -22,7 +22,7 @@ using std::string; ...@@ -22,7 +22,7 @@ using std::string;
namespace folly { namespace folly {
LogHandlerConfig::LogHandlerConfig() {} LogHandlerConfig::LogHandlerConfig() = default;
LogHandlerConfig::LogHandlerConfig(StringPiece t) : type{t.str()} {} LogHandlerConfig::LogHandlerConfig(StringPiece t) : type{t.str()} {}
......
...@@ -52,5 +52,5 @@ LogStream::LogStream(LogStreamProcessor* processor) ...@@ -52,5 +52,5 @@ LogStream::LogStream(LogStreamProcessor* processor)
rdbuf(&buffer_); rdbuf(&buffer_);
} }
LogStream::~LogStream() {} LogStream::~LogStream() = default;
} // namespace folly } // namespace folly
...@@ -82,7 +82,7 @@ LoggerDB::LoggerDB() { ...@@ -82,7 +82,7 @@ LoggerDB::LoggerDB() {
LoggerDB::LoggerDB(TestConstructorArg) : LoggerDB() {} LoggerDB::LoggerDB(TestConstructorArg) : LoggerDB() {}
LoggerDB::~LoggerDB() {} LoggerDB::~LoggerDB() = default;
LogCategory* LoggerDB::getCategory(StringPiece name) { LogCategory* LoggerDB::getCategory(StringPiece name) {
return getOrCreateCategoryLocked(*loggersByName_.wlock(), name); return getOrCreateCategoryLocked(*loggersByName_.wlock(), name);
......
...@@ -32,7 +32,7 @@ StandardLogHandler::StandardLogHandler( ...@@ -32,7 +32,7 @@ StandardLogHandler::StandardLogHandler(
writer_{std::move(writer)}, writer_{std::move(writer)},
config_{config} {} config_{config} {}
StandardLogHandler::~StandardLogHandler() {} StandardLogHandler::~StandardLogHandler() = default;
void StandardLogHandler::handleMessage( void StandardLogHandler::handleMessage(
const LogMessage& message, const LogMessage& message,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment