Commit 929e93d4 authored by Nicholas Ormrod's avatar Nicholas Ormrod Committed by Dave Watson

IOBuf::moveToFbString legacy 4GiB limit

Summary:
IOBufs now support larger than 4GiB chunks. One of the checks
was not removed. Tracing through the capacity, its use if all 64-bit
compatible.

Test Plan: moveToFbString a 4GiB+ IOBuf element.

Reviewed By: maxim@fb.com

Subscribers: net-systems@, sdwilsh, njormrod, folly-diffs@

FB internal diff: D1705316

Tasks: 5648445

Signature: t1:1705316:1416965241:d9d064bbde53e033d32bfe872b3445ee59005f5e
parent eb9d7cd7
...@@ -590,9 +590,6 @@ void IOBuf::coalesceAndReallocate(size_t newHeadroom, ...@@ -590,9 +590,6 @@ void IOBuf::coalesceAndReallocate(size_t newHeadroom,
IOBuf* end, IOBuf* end,
size_t newTailroom) { size_t newTailroom) {
uint64_t newCapacity = newLength + newHeadroom + newTailroom; uint64_t newCapacity = newLength + newHeadroom + newTailroom;
if (newCapacity > UINT32_MAX) {
throw std::overflow_error("IOBuf chain too large to coalesce");
}
// Allocate space for the coalesced buffer. // Allocate space for the coalesced buffer.
// We always convert to an external buffer, even if we happened to be an // We always convert to an external buffer, even if we happened to be an
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment