fix -Wreturn-std-move errors
Summary:
This was exposed by the latest clang with -Wreturn-std-move enabled:
```lang=bash
folly/FBString.h:2487:12: error: local variable 'rhs' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
return rhs;
^~~
folly/test/FBStringTest.cpp:1294:23: note: in instantiation of function template specialization 'folly::operator+<char, std::char_traits<char>, std::allocator<char>, folly::fbstring_core<char> >' requested here
auto test1 = '\0' + std::move(s1);
^
folly/FBString.h:2487:12: note: call 'std::move' explicitly to avoid copying
return rhs;
^~~
std::move(rhs)
2 errors generated.
```
Reviewed By: Orvid
Differential Revision: D7776805
fbshipit-source-id: f11ae5a1fc416b8838b8ea74d7f6b488f07cab38
Showing
Please register or sign in to comment