Commit e2700485 authored by Lewis Baker's avatar Lewis Baker Committed by Facebook GitHub Bot

Remove unnecessary noexcept declaration on TaskPromise::await_transform()

Summary:
Declaring this method noexcept was incorrect and could unnecessarily lead to
program termination if one of the calls threw an exception.

Reviewed By: yfeldblum

Differential Revision: D21187354

fbshipit-source-id: 109a33d52659cdf42e5ced9e18be41ae4c3daf85
parent d8e90515
...@@ -91,7 +91,7 @@ class TaskPromiseBase { ...@@ -91,7 +91,7 @@ class TaskPromiseBase {
} }
template <typename Awaitable> template <typename Awaitable>
auto await_transform(Awaitable&& awaitable) noexcept { auto await_transform(Awaitable&& awaitable) {
return folly::coro::co_viaIfAsync( return folly::coro::co_viaIfAsync(
executor_.get_alias(), executor_.get_alias(),
folly::coro::co_withCancellation( folly::coro::co_withCancellation(
...@@ -106,7 +106,7 @@ class TaskPromiseBase { ...@@ -106,7 +106,7 @@ class TaskPromiseBase {
return AwaitableReady<const folly::CancellationToken&>{cancelToken_}; return AwaitableReady<const folly::CancellationToken&>{cancelToken_};
} }
void setCancelToken(const folly::CancellationToken& cancelToken) { void setCancelToken(const folly::CancellationToken& cancelToken) noexcept {
if (!hasCancelTokenOverride_) { if (!hasCancelTokenOverride_) {
cancelToken_ = cancelToken; cancelToken_ = cancelToken;
hasCancelTokenOverride_ = true; hasCancelTokenOverride_ = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment