Commit f2d5818b authored by Bryce Matsumori's avatar Bryce Matsumori Committed by Facebook Github Bot

Suppress "inherits via dominance" warning in IOThreadPoolExecutor.h

Summary: This is the expected design of the class, so suppress the warning using `FOLLY_MSVC_DISABLE_WARNING` instead of fixing the issue.

Reviewed By: Orvid

Differential Revision: D18733718

fbshipit-source-id: ff9368a9ce31ad11e5992d65f0b5b26b2859ff02
parent 857c6a5b
...@@ -18,12 +18,18 @@ ...@@ -18,12 +18,18 @@
#include <atomic> #include <atomic>
#include <folly/Portability.h>
#include <folly/executors/IOExecutor.h> #include <folly/executors/IOExecutor.h>
#include <folly/executors/ThreadPoolExecutor.h> #include <folly/executors/ThreadPoolExecutor.h>
#include <folly/io/async/EventBaseManager.h> #include <folly/io/async/EventBaseManager.h>
namespace folly { namespace folly {
FOLLY_PUSH_WARNING
// Suppress "IOThreadPoolExecutor inherits DefaultKeepAliveExecutor
// keepAliveAcquire/keepAliveRelease via dominance"
FOLLY_MSVC_DISABLE_WARNING(4250)
/** /**
* A Thread Pool for IO bound tasks * A Thread Pool for IO bound tasks
* *
...@@ -93,4 +99,6 @@ class IOThreadPoolExecutor : public ThreadPoolExecutor, public IOExecutor { ...@@ -93,4 +99,6 @@ class IOThreadPoolExecutor : public ThreadPoolExecutor, public IOExecutor {
folly::EventBaseManager* eventBaseManager_; folly::EventBaseManager* eventBaseManager_;
}; };
FOLLY_POP_WARNING
} // namespace folly } // namespace folly
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment