Commit 59e8d284 authored by Wim Lewis's avatar Wim Lewis

It's actually more efficient *not* to create a mutable static variable to hold...

It's actually more efficient *not* to create a mutable static variable to hold this constant string's address.
parent ca15fc65
...@@ -140,7 +140,7 @@ cb_failed: ...@@ -140,7 +140,7 @@ cb_failed:
int int
BIT_STRING_print(asn_TYPE_descriptor_t *td, const void *sptr, int ilevel, BIT_STRING_print(asn_TYPE_descriptor_t *td, const void *sptr, int ilevel,
asn_app_consume_bytes_f *cb, void *app_key) { asn_app_consume_bytes_f *cb, void *app_key) {
static const char *h2c = "0123456789ABCDEF"; const char * const h2c = "0123456789ABCDEF";
char scratch[64]; char scratch[64];
const BIT_STRING_t *st = (const BIT_STRING_t *)sptr; const BIT_STRING_t *st = (const BIT_STRING_t *)sptr;
uint8_t *buf; uint8_t *buf;
......
...@@ -166,7 +166,7 @@ INTEGER__dump(const asn_TYPE_descriptor_t *td, const INTEGER_t *st, asn_app_cons ...@@ -166,7 +166,7 @@ INTEGER__dump(const asn_TYPE_descriptor_t *td, const INTEGER_t *st, asn_app_cons
/* Output in the long xx:yy:zz... format */ /* Output in the long xx:yy:zz... format */
/* TODO: replace with generic algorithm (Knuth TAOCP Vol 2, 4.3.1) */ /* TODO: replace with generic algorithm (Knuth TAOCP Vol 2, 4.3.1) */
for(p = scratch; buf < buf_end; buf++) { for(p = scratch; buf < buf_end; buf++) {
static const char *h2c = "0123456789ABCDEF"; const char * const h2c = "0123456789ABCDEF";
if((p - scratch) >= (ssize_t)(sizeof(scratch) - 4)) { if((p - scratch) >= (ssize_t)(sizeof(scratch) - 4)) {
/* Flush buffer */ /* Flush buffer */
if(cb(scratch, p - scratch, app_key) < 0) if(cb(scratch, p - scratch, app_key) < 0)
......
...@@ -580,7 +580,7 @@ asn_enc_rval_t ...@@ -580,7 +580,7 @@ asn_enc_rval_t
OCTET_STRING_encode_xer(asn_TYPE_descriptor_t *td, void *sptr, OCTET_STRING_encode_xer(asn_TYPE_descriptor_t *td, void *sptr,
int ilevel, enum xer_encoder_flags_e flags, int ilevel, enum xer_encoder_flags_e flags,
asn_app_consume_bytes_f *cb, void *app_key) { asn_app_consume_bytes_f *cb, void *app_key) {
static const char *h2c = "0123456789ABCDEF"; const char * const h2c = "0123456789ABCDEF";
const OCTET_STRING_t *st = (const OCTET_STRING_t *)sptr; const OCTET_STRING_t *st = (const OCTET_STRING_t *)sptr;
asn_enc_rval_t er; asn_enc_rval_t er;
char scratch[16 * 3 + 4]; char scratch[16 * 3 + 4];
...@@ -1655,7 +1655,7 @@ OCTET_STRING_encode_uper(asn_TYPE_descriptor_t *td, ...@@ -1655,7 +1655,7 @@ OCTET_STRING_encode_uper(asn_TYPE_descriptor_t *td,
int int
OCTET_STRING_print(asn_TYPE_descriptor_t *td, const void *sptr, int ilevel, OCTET_STRING_print(asn_TYPE_descriptor_t *td, const void *sptr, int ilevel,
asn_app_consume_bytes_f *cb, void *app_key) { asn_app_consume_bytes_f *cb, void *app_key) {
static const char *h2c = "0123456789ABCDEF"; const char * const h2c = "0123456789ABCDEF";
const OCTET_STRING_t *st = (const OCTET_STRING_t *)sptr; const OCTET_STRING_t *st = (const OCTET_STRING_t *)sptr;
char scratch[16 * 3 + 4]; char scratch[16 * 3 + 4];
char *p = scratch; char *p = scratch;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment