Skip to content

F
fmt
Commit a79c7b4e authored by Victor Zverovich's avatar Victor Zverovich
Browse files
Options

Fix handling of unsigned char strings (#373)

parent 195d6a56
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
fmt/format.h
View file @ a79c7b4e
...@@ -1277,7 +1277,9 @@ class MakeValue : public Arg { ...@@ -1277,7 +1277,9 @@ class MakeValue : public Arg {
FMT_MAKE_VALUE(char *, string.value, CSTRING) FMT_MAKE_VALUE(char *, string.value, CSTRING)
FMT_MAKE_VALUE(const char *, string.value, CSTRING) FMT_MAKE_VALUE(const char *, string.value, CSTRING)
FMT_MAKE_VALUE(signed char *, sstring.value, CSTRING)
FMT_MAKE_VALUE(const signed char *, sstring.value, CSTRING) FMT_MAKE_VALUE(const signed char *, sstring.value, CSTRING)
FMT_MAKE_VALUE(unsigned char *, ustring.value, CSTRING)
FMT_MAKE_VALUE(const unsigned char *, ustring.value, CSTRING) FMT_MAKE_VALUE(const unsigned char *, ustring.value, CSTRING)
FMT_MAKE_STR_VALUE(const std::string &, STRING) FMT_MAKE_STR_VALUE(const std::string &, STRING)
FMT_MAKE_STR_VALUE(StringRef, STRING) FMT_MAKE_STR_VALUE(StringRef, STRING)
......
test/format-test.cc
View file @ a79c7b4e
...@@ -1343,6 +1343,8 @@ TEST(FormatterTest, FormatUCharString) { ...@@ -1343,6 +1343,8 @@ TEST(FormatterTest, FormatUCharString) {
EXPECT_EQ("test", format("{0:s}", str)); EXPECT_EQ("test", format("{0:s}", str));
const unsigned char *const_str = str; const unsigned char *const_str = str;
EXPECT_EQ("test", format("{0:s}", const_str)); EXPECT_EQ("test", format("{0:s}", const_str));
unsigned char *ptr = str;
EXPECT_EQ("test", format("{0:s}", ptr));
} }
TEST(FormatterTest, FormatPointer) { TEST(FormatterTest, FormatPointer) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment