Skip to content

J
json
Unverified Commit d6ff059a authored by Niels Lohmann's avatar Niels Lohmann
Browse files
Options

👌 addressed review comments

parent 33379684
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 6 deletions
include/nlohmann/detail/diagnostics_t.hpp
View file @ d6ff059a
...@@ -39,7 +39,7 @@ class diagnostics_t ...@@ -39,7 +39,7 @@ class diagnostics_t
if (current->m_parent->m_value.array->operator[](i) == *current) if (current->m_parent->m_value.array->operator[](i) == *current)
{ {
tokens.emplace_back(std::to_string(i)); tokens.emplace_back(std::to_string(i));
continue; break;
} }
} }
break; break;
...@@ -52,7 +52,7 @@ class diagnostics_t ...@@ -52,7 +52,7 @@ class diagnostics_t
if (element.second == *current) if (element.second == *current)
{ {
tokens.emplace_back(element.first.c_str()); tokens.emplace_back(element.first.c_str());
continue; break;
} }
} }
break; break;
...@@ -79,7 +79,7 @@ class diagnostics_t ...@@ -79,7 +79,7 @@ class diagnostics_t
} }
private: private:
const BasicJsonType* m_j = static_cast<const BasicJsonType*>(nullptr); const BasicJsonType* m_j = nullptr;
}; };
} // namespace detail } // namespace detail
......
single_include/nlohmann/json.hpp
View file @ d6ff059a
...@@ -2537,7 +2537,7 @@ class diagnostics_t ...@@ -2537,7 +2537,7 @@ class diagnostics_t
if (current->m_parent->m_value.array->operator[](i) == *current) if (current->m_parent->m_value.array->operator[](i) == *current)
{ {
tokens.emplace_back(std::to_string(i)); tokens.emplace_back(std::to_string(i));
continue; break;
} }
} }
break; break;
...@@ -2550,7 +2550,7 @@ class diagnostics_t ...@@ -2550,7 +2550,7 @@ class diagnostics_t
if (element.second == *current) if (element.second == *current)
{ {
tokens.emplace_back(element.first.c_str()); tokens.emplace_back(element.first.c_str());
continue; break;
} }
} }
break; break;
...@@ -2577,7 +2577,7 @@ class diagnostics_t ...@@ -2577,7 +2577,7 @@ class diagnostics_t
} }
private: private:
const BasicJsonType* m_j = static_cast<const BasicJsonType*>(nullptr); const BasicJsonType* m_j = nullptr;
}; };
} // namespace detail } // namespace detail
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment