Commit 08de5060 authored by Dennis Jenkins's avatar Dennis Jenkins

Compiler warning reduction (-Weffc++).

parent 48661c36
......@@ -262,6 +262,7 @@ private:
, transport(other.transport)
, armed(other.armed)
, timerFd(other.timerFd)
, peer()
{ }
Timeout(Tcp::Transport* transport_,
......@@ -272,8 +273,8 @@ private:
, transport(transport_)
, armed(false)
, timerFd(-1)
{
}
, peer()
{ }
template<typename Ptr>
void associatePeer(const Ptr& ptr) {
......@@ -569,6 +570,7 @@ public:
private:
ResponseWriter(Tcp::Transport* transport, Request request, Handler* handler)
: Response(request.version())
, peer_()
, buf_(DefaultStreamSize)
, transport_(transport)
, timeout_(transport, handler, std::move(request))
......@@ -691,7 +693,9 @@ namespace Private {
class ParserBase {
public:
ParserBase()
: cursor(&buffer)
: buffer()
, cursor(&buffer)
, allSteps()
, currentStep(0)
{ }
......@@ -724,6 +728,7 @@ namespace Private {
Parser()
: ParserBase()
, request()
{
allSteps[0].reset(new RequestLineStep(&request));
allSteps[1].reset(new HeadersStep(&request));
......@@ -732,6 +737,7 @@ namespace Private {
Parser(const char* data, size_t len)
: ParserBase()
, request()
{
allSteps[0].reset(new RequestLineStep(&request));
allSteps[1].reset(new HeadersStep(&request));
......@@ -756,6 +762,7 @@ namespace Private {
public:
Parser()
: ParserBase()
, response()
{
allSteps[0].reset(new ResponseLineStep(&response));
allSteps[1].reset(new HeadersStep(&response));
......@@ -764,6 +771,7 @@ namespace Private {
Parser(const char* data, size_t len)
: ParserBase()
, response()
{
allSteps[0].reset(new ResponseLineStep(&response));
allSteps[1].reset(new HeadersStep(&response));
......
......@@ -35,6 +35,10 @@ struct LowercaseEqual {
class Collection {
public:
Collection()
: headers()
, rawHeaders()
{ }
template<typename H>
typename std::enable_if<
......
......@@ -21,7 +21,7 @@ struct Prototype {
#define PROTOTYPE_OF(Base, Class) \
private: \
std::shared_ptr<Base> clone() const { \
std::shared_ptr<Base> clone() const override { \
return std::make_shared<Class>(*this); \
} \
public:
......@@ -37,7 +37,7 @@ public:
friend class Transport;
Handler();
~Handler();
virtual ~Handler();
virtual void onInput(const char *buffer, size_t len, const std::shared_ptr<Tcp::Peer>& peer) = 0;
......
......@@ -66,7 +66,7 @@ public:
void disarmTimer(Fd fd);
std::shared_ptr<Aio::Handler> clone() const;
std::shared_ptr<Aio::Handler> clone() const override;
private:
enum WriteStatus {
......@@ -165,6 +165,7 @@ private:
: fd(fd_)
, value(value_)
, deferred(std::move(deferred_))
, active()
{
active.store(true, std::memory_order_relaxed);
}
......
......@@ -474,11 +474,13 @@ namespace Private {
Message::Message()
: version_(Version::Http11)
, cookies_()
{ }
namespace Uri {
Query::Query()
: params()
{ }
Query::Query(std::initializer_list<std::pair<const std::string, std::string>> params)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment