Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
P
pistache
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
pistache
Commits
1d0330ed
Commit
1d0330ed
authored
Dec 12, 2015
by
Mathieu STEFANI
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Async: made whenAll compile with a range of void promises
parent
9c5b2175
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
146 additions
and
48 deletions
+146
-48
src/async.h
src/async.h
+135
-48
tests/async_test.cc
tests/async_test.cc
+11
-0
No files found.
src/async.h
View file @
1d0330ed
...
...
@@ -799,6 +799,133 @@ namespace Async {
Rejection
reject
;
};
template
<
typename
T
,
typename
Results
>
struct
WhenAllRange
{
WhenAllRange
(
Resolver
resolve
,
Rejection
reject
)
:
resolve
(
std
::
move
(
resolve
))
,
reject
(
std
::
move
(
reject
))
{
}
template
<
typename
Iterator
>
void
operator
()(
Iterator
first
,
Iterator
last
)
{
auto
data
=
std
::
make_shared
<
DataT
<
T
>>
(
static_cast
<
size_t
>
(
std
::
distance
(
first
,
last
)),
std
::
move
(
resolve
),
std
::
move
(
reject
)
);
size_t
index
=
0
;
for
(
auto
it
=
first
;
it
!=
last
;
++
it
)
{
WhenContinuation
<
T
>
cont
(
data
,
index
);
it
->
then
(
std
::
move
(
cont
),
[
=
](
std
::
exception_ptr
ptr
)
{
data
->
rejected
.
store
(
true
);
data
->
reject
(
std
::
move
(
ptr
));
});
++
index
;
}
}
private:
struct
Data
{
Data
(
size_t
total
,
Resolver
resolver
,
Rejection
rejection
)
:
total
(
total
)
,
resolved
(
0
)
,
rejected
(
false
)
,
resolve
(
std
::
move
(
resolver
))
,
reject
(
std
::
move
(
rejection
))
{
}
const
size_t
total
;
std
::
atomic
<
size_t
>
resolved
;
std
::
atomic
<
bool
>
rejected
;
Resolver
resolve
;
Rejection
reject
;
};
/* Ok so apparently I can not fully specialize a template structure
* here, so you know what, compiler ? Take that Dummy type and leave
* me alone
*/
template
<
typename
ValueType
,
typename
Dummy
=
void
>
struct
DataT
:
public
Data
{
DataT
(
size_t
total
,
Resolver
resolver
,
Rejection
rejection
)
:
Data
(
total
,
std
::
move
(
resolver
),
std
::
move
(
rejection
))
{
results
.
resize
(
total
);
}
Results
results
;
};
/* For a vector of void promises, we do not have any results, that's
* why we need a distinct specialization for the void case
*/
template
<
typename
Dummy
>
struct
DataT
<
void
,
Dummy
>
:
public
Data
{
DataT
(
size_t
total
,
Resolver
resolver
,
Rejection
rejection
)
:
Data
(
total
,
std
::
move
(
resolver
),
std
::
move
(
rejection
))
{
}
};
template
<
typename
ValueType
,
typename
Dummy
=
void
>
struct
WhenContinuation
{
typedef
std
::
shared_ptr
<
DataT
<
ValueType
>>
D
;
WhenContinuation
(
const
D
&
data
,
size_t
index
)
:
data
(
data
)
,
index
(
index
)
{
}
void
operator
()(
const
ValueType
&
val
)
const
{
if
(
data
->
rejected
)
return
;
data
->
results
[
index
]
=
val
;
data
->
resolved
.
fetch_add
(
1
);
if
(
data
->
resolved
==
data
->
total
)
{
data
->
resolve
(
data
->
results
);
}
}
D
data
;
size_t
index
;
};
template
<
typename
Dummy
>
struct
WhenContinuation
<
void
,
Dummy
>
{
typedef
std
::
shared_ptr
<
DataT
<
void
>>
D
;
WhenContinuation
(
const
D
&
data
,
size_t
)
:
data
(
data
)
{
}
void
operator
()()
const
{
if
(
data
->
rejected
)
return
;
data
->
resolved
.
fetch_add
(
1
);
if
(
data
->
resolved
==
data
->
total
)
{
data
->
resolve
();
}
}
D
data
;
};
Resolver
resolve
;
Rejection
reject
;
};
}
template
<
...
...
@@ -836,62 +963,22 @@ namespace Async {
=
typename
detail
::
RemovePromise
<
typename
std
::
iterator_traits
<
Iterator
>
::
value_type
>::
Type
,
typename
Results
=
std
::
vector
<
ValueType
>
typename
Results
=
typename
std
::
conditional
<
std
::
is_same
<
void
,
ValueType
>::
value
,
void
,
std
::
vector
<
ValueType
>
>::
type
>
Promise
<
Results
>
whenAll
(
Iterator
first
,
Iterator
last
)
{
/* @Security, assert that last >= first */
struct
Data
{
public:
Data
(
size_t
total
,
Resolver
resolver
,
Rejection
rejection
)
:
total
(
total
)
,
resolved
(
0
)
,
rejected
(
false
)
,
resolve
(
resolver
)
,
reject
(
rejection
)
{
results
.
resize
(
total
);
}
const
size_t
total
;
std
::
atomic
<
size_t
>
resolved
;
std
::
atomic
<
bool
>
rejected
;
Resolver
resolve
;
Rejection
reject
;
Results
results
;
};
return
Promise
<
Results
>
([
=
](
Resolver
&
resolve
,
Rejection
&
rejection
)
{
auto
data
=
std
::
make_shared
<
Data
>
(
static_cast
<
size_t
>
(
std
::
distance
(
first
,
last
)),
std
::
move
(
resolve
),
std
::
move
(
rejection
)
);
Impl
::
WhenAllRange
<
ValueType
,
Results
>
impl
(
std
::
move
(
resolve
),
std
::
move
(
rejection
));
size_t
index
=
0
;
for
(
auto
it
=
first
;
it
!=
last
;
++
it
)
{
it
->
then
([
=
](
const
ValueType
&
val
)
{
if
(
data
->
rejected
)
return
;
impl
(
first
,
last
);
data
->
results
[
index
]
=
val
;
data
->
resolved
.
fetch_add
(
1
);
if
(
data
->
resolved
==
data
->
total
)
{
data
->
resolve
(
data
->
results
);
}
},
[
=
](
std
::
exception_ptr
ptr
)
{
data
->
rejected
.
store
(
true
);
data
->
reject
(
std
::
move
(
ptr
));
});
++
index
;
}
});
}
...
...
tests/async_test.cc
View file @
1d0330ed
...
...
@@ -229,6 +229,17 @@ TEST(async_test, when_all) {
Async::whenAll(p3, p4).then([](const std::tuple<std::string, void>& results) {
}, Async::NoExcept);
#endif
std
::
vector
<
Async
::
Promise
<
void
>>
promises
;
promises
.
push_back
(
std
::
move
(
p4
));
promises
.
push_back
(
Async
::
Promise
<
void
>::
resolved
());
auto
p7
=
Async
::
whenAll
(
std
::
begin
(
promises
),
std
::
end
(
promises
));
resolved
=
false
;
p7
.
then
([
&
]()
{
resolved
=
true
;
},
Async
::
NoExcept
);
ASSERT_TRUE
(
resolved
);
}
TEST
(
async_test
,
rethrow_test
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment