Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
P
pistache
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
pistache
Commits
48661c36
Commit
48661c36
authored
Oct 20, 2018
by
Dennis Jenkins
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Cleaned up compiler warnings (comparison between signed and unsigned, ignored 'const'.
parent
ea24b955
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
16 deletions
+16
-16
include/pistache/string_view.h
include/pistache/string_view.h
+2
-2
tests/string_view_test.cc
tests/string_view_test.cc
+14
-14
No files found.
include/pistache/string_view.h
View file @
48661c36
...
@@ -65,7 +65,7 @@ namespace std {
...
@@ -65,7 +65,7 @@ namespace std {
}
}
constexpr
c
onst
c
har
operator
[](
size_type
pos
)
const
{
constexpr
char
operator
[](
size_type
pos
)
const
{
return
data_
[
pos
];
return
data_
[
pos
];
}
}
...
@@ -109,7 +109,7 @@ namespace std {
...
@@ -109,7 +109,7 @@ namespace std {
pos
=
size_
-
v
.
size_
;
pos
=
size_
-
v
.
size_
;
}
}
for
(;
pos
>=
0
&&
pos
!=
npos
;
pos
--
)
{
for
(;
pos
!=
npos
;
pos
--
)
{
string_view
compare
=
substr
(
pos
,
v
.
size_
);
string_view
compare
=
substr
(
pos
,
v
.
size_
);
if
(
v
==
compare
)
{
if
(
v
==
compare
)
{
return
pos
;
return
pos
;
...
...
tests/string_view_test.cc
100755 → 100644
View file @
48661c36
...
@@ -19,18 +19,18 @@ TEST(string_view_test, find_test) {
...
@@ -19,18 +19,18 @@ TEST(string_view_test, find_test) {
std
::
string_view
orig
(
"test"
);
std
::
string_view
orig
(
"test"
);
std
::
string_view
find
(
"est"
);
std
::
string_view
find
(
"est"
);
ASSERT_EQ
(
orig
.
find
(
find
),
1
);
ASSERT_EQ
(
orig
.
find
(
find
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
find
,
1
),
1
);
ASSERT_EQ
(
orig
.
find
(
find
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
find
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
find
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
'e'
),
1
);
ASSERT_EQ
(
orig
.
find
(
'e'
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
'e'
,
1
),
1
);
ASSERT_EQ
(
orig
.
find
(
'e'
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
'e'
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
'e'
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
'1'
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
'1'
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"est"
),
1
);
ASSERT_EQ
(
orig
.
find
(
"est"
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
"est"
,
1
),
1
);
ASSERT_EQ
(
orig
.
find
(
"est"
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
"est"
,
1
,
2
),
1
);
ASSERT_EQ
(
orig
.
find
(
"est"
,
1
,
2
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
find
(
"set"
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"set"
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"est"
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"est"
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"est"
,
2
,
2
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
find
(
"est"
,
2
,
2
),
std
::
size_t
(
-
1
));
...
@@ -40,16 +40,16 @@ TEST(string_view_test, rfind_test) {
...
@@ -40,16 +40,16 @@ TEST(string_view_test, rfind_test) {
std
::
string_view
orig
(
"test"
);
std
::
string_view
orig
(
"test"
);
std
::
string_view
find
(
"est"
);
std
::
string_view
find
(
"est"
);
ASSERT_EQ
(
orig
.
rfind
(
find
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
find
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
find
,
1
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
find
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
'e'
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
'e'
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
'e'
,
1
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
'e'
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
'q'
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
rfind
(
'q'
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
rfind
(
"est"
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
"est"
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
"est"
,
1
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
"est"
,
1
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
"est"
,
1
,
2
),
1
);
ASSERT_EQ
(
orig
.
rfind
(
"est"
,
1
,
2
),
std
::
size_t
(
1
)
);
ASSERT_EQ
(
orig
.
rfind
(
"set"
),
std
::
size_t
(
-
1
));
ASSERT_EQ
(
orig
.
rfind
(
"set"
),
std
::
size_t
(
-
1
));
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment