Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
P
pistache
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Libraries
pistache
Commits
7e3ff879
Commit
7e3ff879
authored
Feb 07, 2016
by
octal
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Added a safe poping interface to the wait-free queue that returns an unique_ptr
parent
b72ea357
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
6 deletions
+10
-6
include/mailbox.h
include/mailbox.h
+4
-0
src/client/client.cc
src/client/client.cc
+4
-4
src/common/transport.cc
src/common/transport.cc
+2
-2
No files found.
include/mailbox.h
View file @
7e3ff879
...
...
@@ -205,6 +205,10 @@ public:
return
nullptr
;
}
std
::
unique_ptr
<
Entry
>
popSafe
()
{
return
std
::
unique_ptr
<
Entry
>
(
pop
());
}
private:
std
::
atomic
<
Entry
*>
head
;
Entry
*
tail
;
...
...
src/client/client.cc
View file @
7e3ff879
...
...
@@ -213,7 +213,7 @@ void
Transport
::
handleRequestsQueue
()
{
// Let's drain the queue
for
(;;)
{
std
::
unique_ptr
<
PollableQueue
<
InflightRequest
>::
Entry
>
entry
(
requestsQueue
.
pop
()
);
auto
entry
=
requestsQueue
.
popSafe
(
);
if
(
!
entry
)
break
;
auto
&
req
=
entry
->
data
();
...
...
@@ -224,7 +224,7 @@ Transport::handleRequestsQueue() {
void
Transport
::
handleConnectionQueue
()
{
for
(;;)
{
std
::
unique_ptr
<
PollableQueue
<
PendingConnection
>::
Entry
>
entry
(
connectionsQueue
.
pop
()
);
auto
entry
=
connectionsQueue
.
popSafe
(
);
if
(
!
entry
)
break
;
auto
&
conn
=
entry
->
data
();
...
...
@@ -402,7 +402,7 @@ Connection::performImpl(
void
Connection
::
processRequestQueue
()
{
for
(;;)
{
std
::
unique_ptr
<
Queue
<
RequestData
>::
Entry
>
entry
(
requestsQueue
.
pop
()
);
auto
entry
=
requestsQueue
.
popSafe
(
);
if
(
!
entry
)
break
;
auto
&
req
=
entry
->
data
();
...
...
@@ -595,7 +595,7 @@ Client::processRequestQueue() {
auto
conn
=
pool
.
pickConnection
();
if
(
!
conn
)
break
;
std
::
unique_ptr
<
Queue
<
Connection
::
RequestData
>::
Entry
>
entry
(
requestsQueue
.
pop
()
);
auto
entry
=
requestsQueue
.
popSafe
(
);
if
(
!
entry
)
{
pool
.
releaseConnection
(
conn
);
break
;
...
...
src/common/transport.cc
View file @
7e3ff879
...
...
@@ -273,7 +273,7 @@ void
Transport
::
handleWriteQueue
()
{
// Let's drain the queue
for
(;;)
{
std
::
unique_ptr
<
PollableQueue
<
OnHoldWrite
>::
Entry
>
entry
(
writesQueue
.
pop
()
);
auto
entry
=
writesQueue
.
popSafe
(
);
if
(
!
entry
)
break
;
auto
&
write
=
entry
->
data
();
...
...
@@ -284,7 +284,7 @@ Transport::handleWriteQueue() {
void
Transport
::
handleTimerQueue
()
{
for
(;;)
{
std
::
unique_ptr
<
PollableQueue
<
TimerEntry
>::
Entry
>
entry
(
timersQueue
.
pop
()
);
auto
entry
=
timersQueue
.
popSafe
(
);
if
(
!
entry
)
break
;
auto
&
timer
=
entry
->
data
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment