- 07 Jul, 2020 1 commit
-
-
Mateusz Szychowski (Muttley) authored
* client, string_view: fix warnings Discarded qualifier and implicit fallthrough * common: http: fix ResponseStream flush
-
- 05 Jul, 2020 1 commit
-
-
Igor [hyperxor] authored
-
- 26 Jun, 2020 1 commit
-
-
chrisvroberts authored
An error existed in transport.cc where it incorrectly assumed that it would not receive epoll events relating to a closed peer connection. This is not the case because file descriptors can be shared between processes e.g. on exec. When they are, events could still be generated. The solution is to explicitly de-register our interest in the file descriptor before we close it using epoll_ctl(EPOLL_CTL_DEL). In addition the call to accept in listener.cc has been updated to set CLOEXEC on the peer file descriptors as these should not be shared with other processes anyway. Co-authored-by: Roberts, Chris (UK Gloucester) <chris.v.roberts@baesystems.com>
-
- 24 Jun, 2020 1 commit
-
-
Igor [hyperxor] authored
* Small improvements in Listener constructor * Trigger CI
-
- 23 Jun, 2020 1 commit
-
-
zhanb authored
* Update transport.cc fix throw but no catch bug * Update transport.cc disconnect peers for all other errors * adjust indent level Co-authored-by: zhanb <zhangbo@caict.ac.cn>
-
- 13 Jun, 2020 2 commits
-
-
Dennis Jenkins authored
Co-authored-by: Dennis Jenkins <dennisjenkins@google.com>
-
jiankyu authored
This commit partially resolves #24, which is a common requirement on many RESTful services. A vector of middleware handlers is added to Router, these handlers are executed before the URL match and handler invocation, in the order of registration. A middleware function has the signature: bool func(Pistache::Http::Request &request, Pistache::Http::ResponseWriter &response); The first parameter is a reference to Http::Request, not Rest::Request, at the moment middlewares are called, the request parameters are not yet filled. This allows some generic operation on the request, such as authentication or rate limiting. Parameters are passed as references, to allow the middlewares be able to modify them, such as injecting custom headers. If a function returns true, the next function is executed, until all middleware functions are called and all of them return true, the registered handler is called. If one of them returns false, this means there is no need to further call the subsequent functions and the handler, the handling of this request completes. Typical case is missing auth info or reaching limit. Basically, the middleware function that returns false is responsible to call response.send() to send the response to client. Like Route::bind, a new method, Route::middleware(), with different signatures, is added, to convert different callables into a middleware. There is also requirements on the "post-handling" handlers, such as logging response, measuring handler latency, and so on, in a centralized place. This commit doesn't implement it: The response is passed to handler using std::move, it's not retrievable again after handler processing. Signed-off-by: Jiankun Yu <yujiankun@hotmail.com>
-
- 04 Jun, 2020 1 commit
-
-
mplellison authored
The separation of the impl from the API means that it is more possible to independently test variations of the API by changing the macro definitions in log.h. The default StringLogger impl is now called StringToStreamLogger, and takes an optional ostream pointer on input - this makes it more testable. It is assumed that std::cerr will be used here nearly all of the time in practice.
-
- 03 Jun, 2020 1 commit
-
-
mplellison authored
* Travis fix to collect coredumps from build configuration subdirs - #720 Previously, Travis would only attempt to collect coredumps from the last directory the build script was in, or the home directory. This meant that most coredumps were missed, and debug information was lost. The new setup configures apport to watch for crashes on any executables (by default it watches for executables from Ubuntu packages). These crash dumps are picked up, extracted, and analysed using GDB to provide a backtrace (this needs the executable to be passed to GDB as well so that debug symbols are provided). * Restructured .travis.yml to avoid underspecified builds.
-
- 29 May, 2020 1 commit
-
-
mplellison authored
* Added a basic logger object and relevant macros. * Modify logging macros for more flexibility. Supplied logger types and sample values using macros for flexibility in recompiling the library against a different logging engine - the macros can be redefined to make calls to the relevant functions. * Updated endpoint and listener to use new logging structure. It remains to update the SSL portions of listener.cc to output SSL errors via the new loggers. * Add error logging for SSL errors in listener.cc. This needed an extension to the RAII setup for SSL objects to handle BIO objects. Also modified some exception types to ensure they get caught and logged by existing code. Moved anonymous function definitions to the top of listener.cc so that they are available in the entire file. These changes don't significantly change the behaviour of the Pistache library - it still logs errors and throws an exception for most errors that occur internally. It would likely be more sensible to only throw a descriptive exception and not log if the exception is expected to be handled by the library user - this gives them better control of the output of the software. Logging could be reserved for tracking events and debug; when the user is not expected to provide input. * Renamed macros and types to "string logger" and similar. This aligns the names of the types and macros, as well as leaving space for future logging APIs that handle different message types.
-
- 26 May, 2020 1 commit
-
-
mplellison authored
* Update test certificate generation to use explicit cert config. Previously, no configuration was supplied on certificate generation, so the certificates being used for testing were completely generic. This limited the effectiveness and transparency of testing. * Fix listener.cc to load a cert chain and provide it for server auth. Added test with a server cert signed by an intermediate CA. Previously, listener.cc would only load the first cert in a cert pack and use this to authenticate itself to clients. This meant that if the server held a cert signed by an intermediate CA, a client trusting only the root CA would be unable to authenticate the server's cert. See the OpenSSL docs here: https://www.openssl.org/docs/man1.0.2/man3/SSL_CTX_use_certificate_file.html for an overview of the SSL_CTX_use_certificate_file() and SSL_CTX_use_certificate_chain_file() functions.
-
- 21 May, 2020 1 commit
-
-
robertomdv authored
added GetSSLContext() at line 393 to prevent compilation with OpenSSL From fail (see issue #769)
-
- 12 May, 2020 4 commits
-
-
Johannes Schmitz authored
* Add third party dependencies to README.md * Add additional third party dependencies to README.md * Add CMake to third party dependency list in README.md
-
Johannes Schmitz authored
-
Johannes Schmitz authored
-
Simone Angeloni authored
-
- 11 May, 2020 1 commit
-
-
Simone Angeloni authored
-
- 03 May, 2020 1 commit
-
-
miketsts authored
* Fix -wConversion warning in async.h #748 Fix a warning about problematic conversion from 'long int' to 'int' appearing when compiling http.cc with -wConversion flag * Suppress -wConversion warnings in date.h #748 Suppress warnings originating in date.h. The similar suppression appears in the newer version of date.h appearing in its original repository https://github.com/HowardHinnant/dateCo-authored-by: Michael Tseitlin <michael.tseitlin@concertio.com>
-
- 02 May, 2020 1 commit
-
-
chrisvroberts authored
A race exists between the runThreaded and shutdown/dtor as follows: runThreaded - called shutdown - called shutdown - check for shutdownFd.isBound returns false (so no notify) runThreaded - thread executing 'run' starts runThreaded - thread calls shutdownFd.bind shutdown - blocks waiting for run thread runThreaded - continues to run as no notification received This deadlock avoided by ensuring the shutdownFd.bind is called before the thread is created rather than doing it at the start of the thread's execution.
-
- 29 Mar, 2020 1 commit
-
-
Igor [hyperxor] authored
-
- 22 Mar, 2020 1 commit
-
-
Igor [hyperxor] authored
* SSL usage improvements: using RAII for ssl context resource * Remove C style casts in listener
-
- 16 Mar, 2020 3 commits
-
-
Igor [hyperxor] authored
-
Igor [hyperxor] authored
* Code improvements in router * Trigger CI
-
Igor [hyperxor] authored
-
- 14 Mar, 2020 1 commit
-
-
miketsts authored
* CMakeLists.txt: add -Wconversion flag to CMAKE_CXX_CFLAGS * date.h: fix type conversion warnings Fix type conversion warnings occurring when using -Wconversion flag of gcc * base64.cc: fix type conversion warnings Fix type conversion warnings occurring when using -Wconversion flag of gcc. All the fixes actually convert std::byte to unsigned char for calculation purposes. Provided the number of such static_cast uses, I would reconsider using std::byte as a base data type, as std::byte is defined as "not a character type and is not an arithmetic type ... the only operators defined for it are the bitwise ones". At the same time, most of the fixes do deal with the arithmetics. Reference: https://en.cppreference.com/w/cpp/types/byte * Transport: fix type conversion warnings with Fd Fix type conversion warnings occurring when using -Wconversion flag of gcc. Most of the fixed locations deal with static cast from Polling::Tag to Fd. * stream.cc: fix type conversion warnings Fix type conversion warnings occurring when using -Wconversion flag of gcc. It appears that std::tolower has two different signatures: int tolower( int ch ); and template< class charT > charT tolower( charT ch, const locale& loc ); This commit doesn't replace the calls to tolower() but merely adds static_cast<char> in corresponding locations * listener.cc: fix type conversion warnings Fix type conversion warnings occurring when using -Wconversion flag of gcc. * Fix type conversion warnings Fix type conversion warnings in different files occurring when using -Wconversion flag of gcc * Fix type conversion warnings with OpenSSL with PISTACHE_USE_SSL Fix type conversion (size_t -> int) warnings occurring when using -Wconversion flag of gcc and PISTACHE_USE_SSL is defined OpenSSL 1.1.1 has new functions SSL_read_ex / SSL_write_ex which allow size_t parameter, but 1.0.2 has only SSL_read / SSL_write with int type parameter * Fix type conversion warnings in examples Fix type conversion warnings in examples occurring when using -Wconversion flag of gcc. The commit contains also tests/rest_server_test.cc with the similar fix. One of questionable change types was caused by Http::Endpoint::options()::threads(int val), and was invoked with size_t argument. Maybe it makes sense to modify the function argument type. After this commit, there still remain a lot of -Wconversion warnings in rapidjson library * Fix type conversion warnings in unit tests Fix type conversion warnings in unit tests occurring when using -Wconversion flag of gcc. Co-authored-by: Michael Tseitlin <michael.tseitlin@concertio.com>
-
- 10 Mar, 2020 1 commit
-
-
Ivan Oliveira Tarifa authored
* Bring the modifications to cxx14 * Correct cxx version comment Fixe->Pin
-
- 05 Mar, 2020 1 commit
-
-
Dennis Jenkins authored
-
- 03 Mar, 2020 1 commit
-
-
Igor [hyperxor] authored
-
- 02 Mar, 2020 3 commits
-
-
Kip authored
* {src/common/http_header.cc,include/pistache/http_header.h}: Implemented support for Authorization headers using basic method... include/pistache/base64.{cc,h}: Added utility classes and helper functions for base 64 encoding and decoding... tests/headers_test.cc: Added unit test authorization_basic_test... version.txt: Bumped versioning metadata... * Reformatted last commit with clang-format(1) per Dennis' request. Looks awful. * include/pistache/base64.h: No need to include standard filesystem library...
-
Kip authored
* {src/common/http_header.cc,include/pistache/http_header.h}: Implemented support for Authorization headers using basic method... include/pistache/base64.{cc,h}: Added utility classes and helper functions for base 64 encoding and decoding... tests/headers_test.cc: Added unit test authorization_basic_test... version.txt: Bumped versioning metadata... * Reformatted last commit with clang-format(1) per Dennis' request. Looks awful.
-
Igor [hyperxor] authored
-
- 29 Feb, 2020 2 commits
-
-
Igor [hyperxor] authored
-
Igor [hyperxor] authored
-
- 27 Feb, 2020 1 commit
-
-
Igor [hyperxor] authored
-
- 26 Feb, 2020 2 commits
-
-
Carlos Gomes Martinho authored
-
Mateusz Szychowski (Muttley) authored
* optional: reenable implicit constructors when using Some and None * CMake: suppress noExplicitConstructor for optional.h implicit constructors are intentional there
-
- 24 Feb, 2020 1 commit
-
-
Igor [hyperxor] authored
* Code improvements in HTTP Parsers * Trigger CI
-
- 23 Feb, 2020 1 commit
-
-
Igor [hyperxor] authored
* Exploring flaky tests: more logs and several improvements * Trigger CI * Trigger CI * Delete useless check in Listener
-
- 19 Feb, 2020 2 commits
-
-
Igor [hyperxor] authored
* Fix inssue #610 and refactoring * Fix ResponseWriter constructors
-
Igor [hyperxor] authored
-