1. 12 May, 2020 2 commits
  2. 11 May, 2020 1 commit
  3. 03 May, 2020 1 commit
  4. 02 May, 2020 1 commit
    • chrisvroberts's avatar
      Fix shutdown data race in listner.cc (#761) · a328d724
      chrisvroberts authored
      A race exists between the runThreaded and shutdown/dtor as follows:
      
       runThreaded - called
       shutdown - called
       shutdown - check for shutdownFd.isBound returns false (so no notify)
       runThreaded - thread executing 'run' starts
       runThreaded - thread calls shutdownFd.bind
       shutdown - blocks waiting for run thread
       runThreaded - continues to run as no notification received
      
      This deadlock avoided by ensuring the shutdownFd.bind is called before
      the thread is created rather than doing it at the start of the thread's
      execution.
      a328d724
  5. 29 Mar, 2020 1 commit
  6. 22 Mar, 2020 1 commit
  7. 16 Mar, 2020 3 commits
  8. 14 Mar, 2020 1 commit
    • miketsts's avatar
      Add -Wconversion compilation flag and fix related warnings (originated by #733) (#734) · 96ee08ec
      miketsts authored
      * CMakeLists.txt: add -Wconversion flag to CMAKE_CXX_CFLAGS
      
      * date.h: fix type conversion warnings
      
      Fix type conversion warnings occurring when using -Wconversion flag
      of gcc
      
      * base64.cc: fix type conversion warnings
      
      Fix type conversion warnings occurring when using -Wconversion flag
      of gcc.
      
      All the fixes actually convert std::byte to unsigned char for
      calculation purposes.
      
      Provided the number of such static_cast uses, I would reconsider using
      std::byte as a base data type, as std::byte is defined as "not a
      character type and is not an arithmetic type ... the only operators
      defined for it are the bitwise ones". At the same time, most of the
      fixes do deal with the arithmetics.
      
      Reference:
      https://en.cppreference.com/w/cpp/types/byte
      
      * Transport: fix type conversion warnings with Fd
      
      Fix type conversion warnings occurring when using -Wconversion flag
      of gcc.
      
      Most of the fixed locations deal with static cast from Polling::Tag
      to Fd.
      
      * stream.cc: fix type conversion warnings
      
      Fix type conversion warnings occurring when using -Wconversion flag
      of gcc.
      
      It appears that std::tolower has two different signatures:
      
      int tolower( int ch );
      and
      template< class charT >
      charT tolower( charT ch, const locale& loc );
      
      This commit doesn't replace the calls to tolower() but merely adds
      static_cast<char> in corresponding locations
      
      * listener.cc: fix type conversion warnings
      
      Fix type conversion warnings occurring when using -Wconversion flag
      of gcc.
      
      * Fix type conversion warnings
      
      Fix type conversion warnings in different files occurring when using
      -Wconversion flag of gcc
      
      * Fix type conversion warnings with OpenSSL
      
      with PISTACHE_USE_SSL
      
      Fix type conversion (size_t -> int) warnings occurring when using
      -Wconversion flag of gcc and PISTACHE_USE_SSL is defined
      
      OpenSSL 1.1.1 has new functions SSL_read_ex / SSL_write_ex which allow
      size_t parameter, but 1.0.2 has only SSL_read / SSL_write with int
      type parameter
      
      * Fix type conversion warnings in examples
      
      Fix type conversion warnings in examples occurring when using
      -Wconversion flag of gcc. The commit contains also
      tests/rest_server_test.cc with the similar fix.
      
      One of questionable change types was caused by
      Http::Endpoint::options()::threads(int val), and was invoked with size_t
      argument. Maybe it makes sense to modify the function argument type.
      
      After this commit, there still remain a lot of -Wconversion warnings in
      rapidjson library
      
      * Fix type conversion warnings in unit tests
      
      Fix type conversion warnings in unit tests occurring when using
      -Wconversion flag of gcc.
      Co-authored-by: default avatarMichael Tseitlin <michael.tseitlin@concertio.com>
      96ee08ec
  9. 10 Mar, 2020 1 commit
  10. 05 Mar, 2020 1 commit
  11. 03 Mar, 2020 1 commit
  12. 02 Mar, 2020 3 commits
    • Kip's avatar
      Removed unnecessary standard filesystem library. (#726) · 8b04ca8c
      Kip authored
      * {src/common/http_header.cc,include/pistache/http_header.h}: Implemented support for Authorization headers using basic method...
      include/pistache/base64.{cc,h}: Added utility classes and helper functions for base 64 encoding and decoding...
      tests/headers_test.cc: Added unit test authorization_basic_test...
      version.txt: Bumped versioning metadata...
      
      * Reformatted last commit with clang-format(1) per Dennis' request. Looks awful.
      
      * include/pistache/base64.h: No need to include standard filesystem library...
      8b04ca8c
    • Kip's avatar
      Implemented support for Authorization headers using basic method... (#725) · 53c08440
      Kip authored
      * {src/common/http_header.cc,include/pistache/http_header.h}: Implemented support for Authorization headers using basic method...
      include/pistache/base64.{cc,h}: Added utility classes and helper functions for base 64 encoding and decoding...
      tests/headers_test.cc: Added unit test authorization_basic_test...
      version.txt: Bumped versioning metadata...
      
      * Reformatted last commit with clang-format(1) per Dennis' request. Looks awful.
      53c08440
    • Igor [hyperxor]'s avatar
      7bb01321
  13. 29 Feb, 2020 2 commits
  14. 27 Feb, 2020 1 commit
  15. 26 Feb, 2020 2 commits
  16. 24 Feb, 2020 1 commit
  17. 23 Feb, 2020 1 commit
  18. 19 Feb, 2020 4 commits
  19. 16 Feb, 2020 1 commit
  20. 15 Feb, 2020 2 commits
  21. 14 Feb, 2020 3 commits
  22. 13 Feb, 2020 3 commits
  23. 12 Feb, 2020 2 commits
  24. 10 Feb, 2020 1 commit