- 15 Nov, 2025 5 commits
-
-
Guido Casati authored
RRC PDU Session Release: DRBs and PDU session teardown in NGAP PDU Session Release Response callback We need to keep PDU sessions and DRBs in list until the NGAP PDU Session Release Response is sent. * Introduced find_drb() and remove_drbs_by_pdu_session() helpers to locate and clean up DRBs linked to a specific PDU session * Targeted per-session DRB removal in rrc_gNB_send_NGAP_PDUSESSION_RELEASE_RESPONSE() * Ensures DRBs for unaffected PDU sessions remain intact * Remove unused PDU_SESSION_STATUS_RELEASED status: keeping this status is no longer relevant since the PDU sessions are effectively removed from the RRC lists Closes #867 Also, refactor rrc_gNB_process_NGAP_PDUSESSION_RELEASE_COMMAND 3GPP TS 38.413 8.2.2 PDU Session Resource Release says: > upon reception the NG-RAN node shall execute the release of the requested PDU sessions. > For each PDU session to be released the NG-RAN node shall release the corresponding > resources over Uu and over NG, if any. Therefore, any PDU session in the pdusession_release_params list that is also present in the RRC list can be set to release, regardless of its status. The function signature was also updated along with other minor changes.
-
Guido Casati authored
The partial-tunnel deletion API was buggy and redundant: * e.g. It erased entries from globGtp.te2ue_mapping but never erases the corresponding entries from inst->ue2te_mapping[ue].bearers All current use cases are already covered by: * newGtpuDeleteOneTunnel() for targeted deletion * newGtpuDeleteAllTunnels() for full cleanup Call sites should explicitly loop over newGtpuDeleteOneTunnel() if multiple tunnels need removal.
-
Guido Casati authored
This commit implements proper PDU Session Release handling across RRC, PDCP, F1AP, E1AP to ensure clean resource cleanup when a PDU session is terminated. Key changes: NGAP: In `rrc_gNB_process_NGAP_PDUSESSION_RELEASE_COMMAND()`: * Populates E1AP Bearer Modification for each released session * If a CU-UP is connected, triggers `bearer_context_mod()` for PDU teardown PDCP: * Added `nr_pdcp_release_drbs()` to remove all DRBs linked to a given PDU session * Called from `e1_bearer_context_modif()` for correct clean-up during session release F1AP UE Context Modification: Replace direct RRC message transfer with F1AP UE Context Modification Request to properly handle PDU session release according to 3GPP TS 38.331. 3GPP TS 38.331 `5.3.5.6.4 DRB release` says: whether or not the RLC and MAC entities associated with a PDCP entity are reset or released is determined by the CellGroupConfig. Thus, updated CellGroupConfig needs to be received by the UE. This has to be retrieved by CUCP from the DU. Therefore: After receiving an NGAP_PDUSESSION_RELEASE_COMMAND, the CUCP shall: 1) forward (store for later) the NAS PDU to the UE, if present as per 3GPP TS 38.413, and 2) send a UE Context Modification to the DU with the list of DRBs to release and the RRC container (RRCReconfiguration with NAS PDU) After reception of UE Context Modification Response, the list of drbs to release is prepared based on PDU session status PDU_SESSION_STATUS_TORELEASE in rrc_gNB_generate_dedicatedRRCReconfiguration and then encoded in drb_ToReleaseList for a new RRCReconfiguration with the new cellGroupConfig. Key changes: * rrc_gNB_generate_dedicatedRRCReconfiguration_release() now uses F1AP UE Context Modification Request instead of direct RRC transfer * Only DRBs to be released are now added to the list. * The ASN.1 memory allocation is entirely done in build_RRCReconfiguration_IEs * No longer needed to store ASN1 struct in UE context GTP-U: * Previous implementation had incomplete tunnel cleanup during PDU session release - Missing distinction between N3 (PDU session level) and F1-U (DRB level) tunnels - Lack of proper DRB identification for F1-U tunnel deletion Major Changes: * GTP tunnel teardown now handled in `e1_bearer_context_modif()` using the correct F1 or N3 GTP instance (`newGtpuDeleteOneTunnel()`) * Enhanced Tunnel Deletion Logic (cucp_cuup_handler.c): - Separate handling for N3 tunnels (1 per PDU session) and F1-U tunnels (1 per DRB) - Added proper DRB identification for F1-U tunnel cleanup - Improved error handling with detailed logging for each tunnel deletion - Enhanced logging to distinguish between N3 and F1-U tunnel operations * New PDCP API Function (nr_pdcp_oai_api.c/h): - Added nr_pdcp_get_drb_ids_for_pdusession() function - Enables retrieval of all DRB IDs associated with a specific PDU session - Supports proper F1-U tunnel cleanup by providing DRB identifiers in CUUP * Enhanced GTP Interface (gtp_itf.cpp/h): - Modified newGtpuDeleteOneTunnel() to accept tunnel_type parameter - Improved logging to distinguish between PDU session and DRB tunnel types - Better error messages for tunnel deletion failures - Enhanced debugging information for remaining tunnels Clean-up: * Ensured xid tracking works consistently between PDU Session Establishment (with NAS PDU) and dedicated RRCReconfiguration * Add function to release GTP-U tunnel in Bearer Context Modification Request handler * Do not send rrc_gNB_send_NGAP_PDUSESSION_RELEASE_RESPONSE when no PDU session are to be released: it is sent upon completion of the RRCReconfiguration and needs to contain released PDU Sessions (mandatory IE), therefore it is no necessary to send it in case there is no PDU session to release. Related to #867 Co-authored-by:rmagueta <rmagueta@allbesmart.pt>
-
Guido Casati authored
-
Guido Casati authored
-
- 14 Nov, 2025 3 commits
-
-
Guido Casati authored
Problem: - GTP-U logs showed negative TEID values (e.g., -1943516315) due to signed/unsigned conversion. Due to wrong conversion from uint32_t to int and overflow caused negative values. - TEID values were inconsistently formatted across different log statements, due to mixed use of %d, %u, %x formats for TEID logging. Made debugging and troubleshooting difficult Changes: 1. Fixed signed/unsigned conversion bug: use teid_t. Prevents overflow when TEID values exceed int range. 2. Standardized TEID logging format: all TEID values now use '0x%x' hexadecimal format. Consistent 'TEID' capitalization throughout
-
Guido Casati authored
The previously introduced function rrc_release_rlc_entity has been adopted to deactvate the RLC entities after release.
-
Guido Casati authored
-
- 13 Nov, 2025 2 commits
-
-
Guido Casati authored
Do not add PDU Session with status higher than PDU_SESSION_STATUS_TOMODIFY which means, do not add "failed" or "to release" PDU Sessions.
-
Guido Casati authored
According to TS 38.463 - clause 9.2.2.4 and 9.3.3.12. Also, fix response message by encoding choice IE only with presence of modified PDU sessions. Co-authored-by:rmagueta <rmagueta@allbesmart.pt>
-
- 06 Nov, 2025 8 commits
-
-
Jaroslava Fiedlerova authored
Integration `2025.w45` * !3736 fix bugs in scope for pdcch, and optimize cpu cost of pdcch decoding * !3743 NR UE: fix PDCCH LLR indexing for different search space RB sizes * !3739 Bugfix: save old tunnel info to remain the user plane connection while rolling back to source DU due to handover failure * !3742 Simplify node management in CI, handle SIGINT * !3670 PRS bug fix and CI Integration * !3746 Fix unsigned to signed decoding parameters to allow for 'no affinity'/'no pin' threads to CPUs * !3738 CI: Add new Jenkinsfiles Closes #984 and #1021 See merge request oai/openairinterface5g!3744
-
Jaroslava Fiedlerova authored
CI: Add unified Jenkinsfile for all test pipelines This MR introduces a single Jenkinsfile to cover all current CI test pipelines Improvements: - correct reporting of the start timestamp in the HTML report - harmonize log collection - always collect as test_logs_${env.BUILD_ID}.zip -
Jaroslava Fiedlerova authored
Combine Jenkinsfile and Jenkinsfile-oc from parrent commit into a single file.
-
Jaroslava Fiedlerova authored
Fix unsigned to signed decoding parameters to allow for 'no affinity'/'no pin' threads to CPUs By default, 'L1_rx_thread_core', 'L1_tx_thread_core', 'ru_thread_core' are set to '-1' but the values were decoded from config file as unsigned instead of signed types, thus, it was not allowing to set them with '-1' from config file.
-
Jaroslava Fiedlerova authored
Merge remote-tracking branch 'origin/prs_bug_fix_and_integrate_to_ci' into integration_2025_w45 (!3670) PRS bug fix and CI Integration - Fix the bug in PRS channel estimation while copying memory to compute the impulse response - Integrate PRS testing to CI
-
Jaroslava Fiedlerova authored
Simplify node management in CI, handle SIGINT - Make a single <node> XML step entry common to all XML steps to harmonize code - Handle SIGINT to make it possible to more easily stop the CI script.
-
Jaroslava Fiedlerova authored
Bugfix: save old tunnel info to remain the user plane connection while rolling back to source DU due to handover failure This MR closes issue #984 that UE lost the data plane connection while rolling back to the source DU due to handover failure.
-
Jaroslava Fiedlerova authored
NR UE: fix PDCCH LLR indexing for different search space RB sizes After !3603 (merged), when multiple search spaces have different CORESET configurations (different number of RBs), the LLR buffer stride must be calculated based on the maximum RB size across all search spaces, not the current search space's RB size. The LLR buffer is allocated with size based on get_pdcch_max_rbs(), but the demapping function was using coreset_nbr_rb (current search space) for symbol stride calculation, causing incorrect LLR extraction when search spaces have different RB configurations. This MR tries to fix it. Closes #1021
-
- 05 Nov, 2025 10 commits
-
-
luis_pereira87 authored
By default, 'L1_rx_thread_core', 'L1_tx_thread_core', 'ru_thread_core' are set to '-1' but the values were decoded from config file as unsigned instead of signed types, thus, it was not allowing to set them with '-1' from config file
-
Robert Schmidt authored
-
Jaroslava Fiedlerova authored
Use the bash script from a parent commit to verify PRS functionality.
-
Rakesh Mundlamuri authored
This commit inputs several distances at once and obtain the summary of successful and failed tests. We look for the number of successful tests that are geater than 0. We do that here since we sometimes dont receive a response for a telnet command from the rfsim although the command is applied. This is related to the queing telnet commands in the rfsim. The script for the distances 50, 100 and 150 are called as follows, ./set-and-verify-distance-prs.sh 50 100 150 The summary can be viewed as follows, ==================== SUMMARY ==================== Total tests run : 3 Successful tests: 3 Failed tests : 0 =================================================
-
Jaroslava Fiedlerova authored
-
rakesh mundlamuri authored
Set RFsim (DL) distance and use PRS to estimate the new distance. This is verified by comparing the distance set in RFsim with the distance reported through ToA estimation at the UE. Note that since RFsim telnet output is asynchronous (it uses a queue internally), we use grep --max-count 1 to wait for the matching line, together with ncat --idle 0.3 to keep ncat open for some time. The --max-count option will terminate grep after the first occurrence. For this to work reliably, we need to use grep <(echo | ncat) as opposod to simply echo | ncat | grep, as the latter does not seem to reliably make grep exit after the occurrence. Co-authored-by:Robert Schmidt <robert.schmidt@openairinterface.org>
-
Robert Schmidt authored
-
Robert Schmidt authored
Protect with mutex to allow reading from another thread.
-
Robert Schmidt authored
In a future commit, we will look up the maximum ToA over the last transmissions. Introduce a buffer in which we write the last 16 measurements.
-
Jaroslava Fiedlerova authored
fix bugs in scope for pdcch, and optimize cpu cost of pdcch decoding fix bugs in scope for pdcch, and optimize cpu cost of pdcch decoding by not processing useless samples in one symbol
-
- 04 Nov, 2025 2 commits
-
-
alexjiao authored
When multiple search spaces have different CORESET configurations (different number of RBs), the LLR buffer stride must be calculated based on the maximum RB size across all search spaces, not the current search space's RB size. The LLR buffer is allocated with size based on get_pdcch_max_rbs(), but the demapping function was using coreset_nbr_rb (current search space) for symbol stride calculation, causing incorrect LLR extraction when search spaces have different RB configurations.
-
Chieh-Chun Chen authored
Bugfix: save old tunnel info to remain the user plane connection while rolling back to source DU due to F1 handover failure
-
- 03 Nov, 2025 10 commits
-
-
Robert Schmidt authored
Handle SIGINT and mark any subsequent steps as failed. Receiving SIGINT a second time will abort the script immediately (as is the case before this commit). Note that Python seems to relay the signal to the "controlled" process (e.g., Ping), which would return immediately with an error. So some steps like Ping will abort immediately, others (e.g., IdleSleep) will finish their step, and then the present logic will mark subsequent steps as failed.
-
Laurent THOMAS authored
move all antennas comon code of begining of nr_pdcch_channel_estimation to prepare the future move of the antenna loop above the serial call of functions to decode pdcch
-
Laurent THOMAS authored
-
Laurent THOMAS authored
fix bugs in scope for pdcch, and optimize cpu cost of pdcch decoding by not processing useless samples in one symbol
-
Robert Schmidt authored
"or None" would assign if the first term is false-y. But not specifying it would already lead to the variable being set to None.
-
Robert Schmidt authored
All XML steps take a single node. We can thus "centralize" reading this parameter in the main loop and pass it to ExecuteActionWithParam().
-
Robert Schmidt authored
Some CI tasks/commands like Iperf(), Ping() get multiple nodes (via XML parameter "nodes") to potentially run UEs on different nodes (hosts) at the same time. However, I argue that this is not good: - we don't actually use this -- where we specify multiple UEs, it's always "localhost localhost..." - it is inconsistent, as we typically have a single "node", not nodes, and there is a possibility to harmonize (see also next commit) - if we needed it, there would be better ways to achieve the same. First, for hardware-based UEs, the ci_infra.yaml can specify different UEs. For simulated UEs, it would be feasible to have multiple XML steps run in parallel, e.g., in the XML <parallel> tag, which would clarify that multiple UEs on different hosts run in parallel - it reduces code. Hence, make a single <node> for these XML steps.
-
Robert Schmidt authored
-
Jaroslava Fiedlerova authored
Created Jenkinsfiles: - Jenkinsfile: for stadard test pipelines - Jenkinsfile-oc: for deployments with OC These 2 Jenkinsfiles covers all current test pipelines.
-
Robert Schmidt authored
-