Commit c86bb6f7 authored by Jaroslava Fiedlerova's avatar Jaroslava Fiedlerova

Merge remote-tracking branch 'origin/limit_dl_DataToUL_ACK' into integration_2026_w11 (!3971)

Limit dl_DataToUL_ACK values to 15 as per standard

If min feedback time is high enough otherwise we might fail to encode/decode
pucch-Config

Assertion (enc_rval.encoded > 0 && enc_rval.encoded <= max_buffer_size * 8) failed!
In encode_cellGroupConfig() /home/francesco/openairinterface5g/openair2/LAYER2/NR_MAC_gNB/nr_radio_config.c:4029
ASN1 message encoding failed (dl-DataToUL-ACK, 18446744073709551615)!
parents e73759e6 94a85735
...@@ -1207,10 +1207,16 @@ static void set_dl_DataToUL_ACK(NR_PUCCH_Config_t *pucch_Config, int min_feedbac ...@@ -1207,10 +1207,16 @@ static void set_dl_DataToUL_ACK(NR_PUCCH_Config_t *pucch_Config, int min_feedbac
long *delay[8]; long *delay[8];
for (int i = 0; i < 8; i++) { for (int i = 0; i < 8; i++) {
int curr_delay = i + min_feedback_time; int curr_delay = i + min_feedback_time;
// dl-DataToUL-ACK SEQUENCE (SIZE (1..8)) OF INTEGER (0..15)
if (curr_delay > 15)
break;
delay[i] = calloc(1,sizeof(*delay[i])); delay[i] = calloc(1,sizeof(*delay[i]));
*delay[i] = curr_delay; *delay[i] = curr_delay;
asn1cSeqAdd(&pucch_Config->dl_DataToUL_ACK->list,delay[i]); asn1cSeqAdd(&pucch_Config->dl_DataToUL_ACK->list,delay[i]);
} }
AssertFatal(pucch_Config->dl_DataToUL_ACK->list.count > 0,
"Minimum feedback time too high %d, cannot set any dl_DataToUL_ACK value\n",
min_feedback_time);
} }
// PUCCH resource set 0 for configuration with O_uci <= 2 bits and/or a positive or negative SR (section 9.2.1 of 38.213) // PUCCH resource set 0 for configuration with O_uci <= 2 bits and/or a positive or negative SR (section 9.2.1 of 38.213)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment