ci: ensure maintainer approval job is evaluated correctly on push events

  - The require-maintainer-approval job was being skipped on push event
    when upstream jobs (verify-signed-commits and check-labels) were skipped,
    even though detect-changes job successfully marked protected files as changed.
  - GitHub Actions may skip dependent jobs due to upstream skipped states before
    evaluating custom conditions.
  - Adding always() ensures the job condition is evaluated regardless of
    the status of upstream jobs, while still enforcing the rule that the job
    only runs when protected_files_changed == true.
Signed-off-by: default avatarShubhika Garg <shubhika.garg@openairinterface.org>
parent 328968ce
...@@ -109,8 +109,9 @@ jobs: ...@@ -109,8 +109,9 @@ jobs:
require-maintainer-approval: require-maintainer-approval:
needs: detect-changes needs: detect-changes
if: needs.detect-changes.outputs.protected_files_changed == 'true' if: |
always() &&
needs.detect-changes.outputs.protected_files_changed == 'true'
runs-on: ubuntu-24.04 runs-on: ubuntu-24.04
environment: environment:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment