- 08 Apr, 2024 2 commits
-
-
Robert Schmidt authored
-
Robert Schmidt authored
-
- 05 Apr, 2024 5 commits
-
-
Jaroslava Fiedlerova authored
- docker on CI machine avra was updated to version 26.0.0, which reports parameter "version" as obsolete - this additional log causes fail of the container undeployment to stage
-
Laurent authored
: error: '<unknown>' may be used uninitialized [-Werror=maybe-uninitialized] 180 | reverse_bits_u8(tmp, N/8, D2);
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Robert Schmidt authored
Closes: #775
-
- 04 Apr, 2024 6 commits
-
-
Robert Schmidt authored
We observe these asserts while running concurrent UL traffic on many UEs: Assertion (crc->rnti == rx->rnti) failed! In handle_nr_ulsch() ../../../openair2/NR_PHY_INTERFACE/NR_IF_Module.c:193 mis-match between CRC RNTI 7221 and RX RNTI 35cf CRC and RX indication need to be pairwise for one UE, when here we have each for different UE. However, investigation seemed to indicate that both arrays for CRC and RX indication contained only one PDU; it seemed the RNTI changed while writing the CRC/RX.indication messages in nr_fill_indication(). In this patch, we change the logic to mark a ULSCH free AFTER calling nr_fill_indication(). It is difficult to say if this makes the assertion disappear, but preliminary tests did not exhibit the same failure states. Closes #773
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Laurent THOMAS authored
Add an API to allow out-of-order writes to a radio interface, unlike the current interface. this function is called in UE in this commit, even if the tx might still be in order. Later, i plan to improve UE pulti-threading, that will lead to out of order tx. also, the gNB will benefit of this new function to replace several specific pieces of code that reorder tx with over complex and slow systems
-
- 03 Apr, 2024 16 commits
-
-
Laurent THOMAS authored
-
Laurent THOMAS authored
-
francescomani authored
-
francescomani authored
-
Cedric Roux authored
Reduces time with lock acquired.
-
Cedric Roux authored
Introduce the structure nr_pdcp_integrity_data_t and adapt code to use it. Note: in nr_pdcp_sdu_t we keep the 'count' variable (which is also present in nr_pdcp_integrity_data_t). They represent the same value, but 'count' in nr_pdcp_integrity_data_t is to be specifically used for integrity while the other one has other uses, so it's better to keep it.
-
Cedric Roux authored
-
Cedric Roux authored
-
Cedric Roux authored
We AssertFatal() if integrity fails. To be refined if needed.
-
Cedric Roux authored
-
Cedric Roux authored
The case securityModeFailure didn't seem to be implemented properly, so I just removed it entirely. The variable 'securityMode' did not make much sense, removed as well. Plus for integrity, there was: securityMode |= 1 << 5 for nea1 and << 6 for nea2, which does not seem correct (I would expect << 4 and << 5 respectively), so it was properly incorrect. 'securityModeCommand->criticalExtensions.choice.securityModeCommand' was accessed before checking that 'securityModeCommand->criticalExtensions.present' is 'NR_SecurityModeCommand__criticalExtensions_PR_securityModeCommand', which is wrong. The tests 'securityMode >= NO_SECURITY_MODE' and 'securityMode != 0xff' don't make sense/are unclear, so removed too. So let's simplify this function, wrong in several places. And put some AssertFatal() so that the code won't do weird things. The AssertFatal() can be removed later and the function improved later if needed. The case securityModeFailure can also be handled later, but I think there is more work to do than just encoding the message and send it to the gNB, so it's not bad to remove it for the moment.
-
Cedric Roux authored
Needed by some RRC procedures to validate the integrity of a message before accepting it.
-
Cedric Roux authored
-
Cedric Roux authored
The use of security_mode_completed in the PDCP entity was a hack. Plus it was not working at all with the deregistration request when nea2 is used, sent when doing ctrl+c in the nrUE. So let's remove it. And let's handle activation of integrity and ciphering more in accordance with what 38.331 says. SecurityModeComplete has to be sent integrity protected, but not ciphered. Only after should the ciphering be activated. (See 38.331 5.3.4.3.)
-
Cedric Roux authored
-
Robert Schmidt authored
Integration `2024.w13` Closes #696 and #762 See merge request oai/openairinterface5g!2653 * !1911 Preparatory work for NR DL 4-layer MIMO at gNB * !2610 fix ug on pilot 2 in nr_pbch_dmrs_correlation() that is lacking signal... * !2639 NR gNB PUCCH2 CQI workaround * !2642 NR UE demoting to LOG_D another log that cause flooding * !2644 NR UE prevent segfault at detach * !2645 add error code for pdu session reject in the ue * !2600 Handle Msg3 with SRB1 RRCReestablishmentComplete and MAC CE C-RNTI * trigger RF-sim E1+F1 test without asan * !2636 Fix various F1 problems * !2641 NR DL and UL channel estimation fix * !2652 Provide additional troubleshooting documentation for QtScope * !2646 NRUE fix asn_sequence_del to clear a list * !2504 CI: use iperf3, refactor Iperf_Module * !2617 use UE ID instead of RNTI internally in NR RLC * !2619 Minor PDCP fixes * !2648 Minor CI fixes, stack protection, fix E1+F1 Quectel test, L2sim5G test
-
- 02 Apr, 2024 11 commits
-
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
Merge remote-tracking branch 'origin/NR_UE_fix_wrong_use_asn_sequence_del' into integration_2024_w13
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
Merge remote-tracking branch 'origin/NR_fix_layer_port_confusion_channel_estimates' into integration_2024_w13
-
Jaroslava Fiedlerova authored
-
Robert Schmidt authored
-
Sagar Arora authored
-