1. 19 Jul, 2024 4 commits
  2. 18 Jul, 2024 7 commits
  3. 16 Jul, 2024 18 commits
    • Florian Kaltenberger's avatar
      documentation update · 612bbaec
      Florian Kaltenberger authored
      612bbaec
    • Florian Kaltenberger's avatar
      making nvIPC thread more configurable + cleanup · 2bee8edc
      Florian Kaltenberger authored
      making aerial shm prefix configurable (so we can use muliptle VNFs per PNF)
      making the nvipc thread affinity configurable and using threadCreate.
      removing aerial_vnf_nr_aerial_p7_start_thread
      2bee8edc
    • Florian Kaltenberger's avatar
      removing assert on RACH num_preambles>1. Instead we print an error and... · 2fa80efb
      Florian Kaltenberger authored
      removing assert on RACH num_preambles>1. Instead we print an error and continue RA with only the first preamble.
      2fa80efb
    • Fredrik Molander's avatar
      missing sudo in Aerial entrypoint · 7ccc7688
      Fredrik Molander authored
      7ccc7688
    • Robert Schmidt's avatar
      32c23892
    • Robert Schmidt's avatar
      Correct nr_clear_ra_proc() for SA+NSA case, fix memory leak · b12d3a4f
      Robert Schmidt authored
      In NSA, the RA process contains the RNTI of the UE to add. The previous
      implementation would not remove the RNTI in NSA/for CFRA, which is
      unclear (why should it stay? RA is over). Also, we did not clear all
      contents, which masked a bug, as we were reusing an RA process for a
      subsequent attach, leading to a segfault on reattach. That is fixed in
      this commit.
      
      Also, we were using the RA structure after having cleared it in
      _nr_rx_sdu(), which semantically makes no sense.
      
      To harmonize handling of the preambles: completely reset the RA
      processes inside nr_clear_ra_proc(). For SA, also add the initialization
      of allowed preambles.
      
      Finally, this commit fixes a memory leak: we always (also in SA) fill a
      list of preambles in a dynamically allocated preamble list. Since the
      total list is only up to 64 preambles of 1B each, put it directly into
      the struct instead of dynamically allocating it.
      b12d3a4f
    • Robert Schmidt's avatar
      Refactor: store secondaryCellGroup only at MAC · e77912a5
      Robert Schmidt authored
      Remove the secondaryCellGroup variable in RRC, as it is not used there.
      
      Note that in the case of F1, the secondaryCellGroup entirely belongs to
      the DU, i.e., MAC. Also, we don't do anything with it in RRC.
      e77912a5
    • Robert Schmidt's avatar
      Do not print all XnAP logs · 0a997ee0
      Robert Schmidt authored
      NSA is quite verbose, some messages are large and it is not very
      "interesting" for the average user. The logs can be enabled on demand,
      or directly seen in Wireshark instead.
      0a997ee0
    • Robert Schmidt's avatar
    • Robert Schmidt's avatar
      Use correct RRC UE ID for NSA UEs · 3d2bf72e
      Robert Schmidt authored
      The RRC UE context has the RRC UE ID. Use that instead of hardcoding
      something that might be wrong (because the RRC UE ID can be reused,
      whereas the counter just blindly increases).
      
      The next commit will use that RRC UE ID to free the PDCP context for the
      UE. It might be wrong on reattach otherwise, because the RRC UE ID could
      again be 1.
      3d2bf72e
    • Robert Schmidt's avatar
      get_default_secondaryCellGroup(): make servingCellConfig const · 09675f65
      Robert Schmidt authored
      We simply don't need to modify the servingCellConfig, so don't do it.
      09675f65
    • Robert Schmidt's avatar
      Remove "global" UE variable spCellConfig · 05aa348f
      Robert Schmidt authored
      Variable spCellConfig is only used in function rrc_add_nsa_user(). Make
      it local to this function to prevent possible bugs (limit the possible
      scope as much as possible).
      05aa348f
    • Robert Schmidt's avatar
      Remove "global" UE variable reconfig · 3a18c17d
      Robert Schmidt authored
      Variable reconfig is only used in function rrc_add_nsa_user(). Make it
      local to this function to prevent possible bugs (limit the possible
      scope as much as possible).
      3a18c17d
    • Robert Schmidt's avatar
      Refactor generate_CG_Config(): return CG_Config · 6b62c437
      Robert Schmidt authored
      Simplify code by returning an allocated object to a CG_Config.  It leads
      to less code and is easier to reason about, because each call will
      return a new CG_Config, which can be freed, irrespective of other calls
      to fill_default_reconfig().
      6b62c437
    • Robert Schmidt's avatar
      Refactor fill_default_reconfig(): return reconfig · c1668cd7
      Robert Schmidt authored
      Simplify code by returning an allocated object to an RRCReconfiguration.
      It leads to less code and is easier to reason about, because each call
      will return a new RRCReconfiguration, which can be freed, irrespective
      of other calls to fill_default_reconfig().
      c1668cd7
    • Robert Schmidt's avatar
      Clean up servingCellConfigDedicated once after reading config · 4cb0bd37
      Robert Schmidt authored
      get_default_secondaryCellGroup() would "sanitize" the servingCellConfig,
      i.e., remove BWP that are invalid. However, it is difficult to
      understand (we can do sanitization once at the beginning) and reason
      (why the servingCellConfig is modified in
      get_default_secondaryCellGroup(), because all we want is a new
      CellGroupConfig, without modifying other data structures).
      
      Instead, do sanitization once after reading the configuration in
      gnb_config.c. Also, modify physical simulators nr_dlsim and nr_ulsim to
      apply this sanitization before a call to
      get_default_secondaryCellGroup(), as the latter would have done the
      sanitization.
      4cb0bd37
    • Robert Schmidt's avatar
      Revert "Add assertion for known segfault during teardown of gNB." · 98ebd0d7
      Robert Schmidt authored
      This reverts commit 4c658cdd.
      
      This commit was introduce to signal a known segfault. The bug has been
      fixed in the last commit, so this commit can be reverted as the
      AssertFatal is not necessary anymore.
      98ebd0d7
    • Robert Schmidt's avatar
      Create deep copy of ServingCellConfigCommon for UE-specific parameter · 5bde2624
      Robert Schmidt authored
      Prior to this commit, upon a release of a UE at the gNB in NSA, the gNB
      fails with a segv. This is because the servingCellConfigCommon is used
      in the reconfigurationWithSync (through a simple pointer). At the
      release, the entire secondaryCellGroup is freed, leading to a free of
      the servingCellConfigCommon. The gNB then tries to use it (e.g., for
      looking up the numerology), and leading to a segv.
      
      To avoid this problem, make a "deep copy" of the ServingCellConfigCommon
      so that we can safely free the UEs secondaryCellGroup, without freeing
      the initial ServingCellConfigCommon.
      5bde2624
  4. 15 Jul, 2024 2 commits
    • luis_pereira87's avatar
      Switch to BWP where RA is configured when Msg3 contains MAC CE for C-RNTI · cbf84897
      luis_pereira87 authored
      Switch to BWP where RA is configured, typically in the InitialBWP
      At this point, MAC CE for C-RNTI received at gNB, UE already switched and triggered RA in that BWP, need to do BWP switching also at gNB for that C-RNTI
      cbf84897
    • Robert Schmidt's avatar
      Merge branch 'integration_2024_w28' into 'develop' · e8a08376
      Robert Schmidt authored
      Integration: `2024.w28`
      
      See merge request oai/openairinterface5g!2856
      
      * !2847 UE setting wrong frequency in 5G rfsimulator SA test
      * !2850 NR UE MAC DCI 00 BWP handling
      * !2852 \[E2 agent\] Move UE RRC_CONNECTED state signaling
      * !2851 Minor code cleanup and fixes
      * !2842 UE assertion for msg1_SubcarrierSpacing in RA
      * !2831 PUSCH power control state
      * !2838 NR UE UL FAPI PDU length fix
      * !2723 add initial NTN support for NR UE
      * !2764 Adding 7.2 containerfiles and docker-compose
      * !2827 Increase RX_DATA.indication PDU Length to 32 bits
      e8a08376
  5. 13 Jul, 2024 9 commits