1. 11 Feb, 2025 10 commits
    • Cedric Roux's avatar
      bugfix: use correct algorithm and derive keys accordingly · a1eb8f35
      Cedric Roux authored
      This was not a big problem, but we were advertising wrong
      algorithm and deriving keys using this wrong algorithm in case
      DRB ciphering and/or integrity was not active. (Say SRBs
      are configured with NIA2 but DRBs are configured without
      integrity, we would advertise NIA2 and send the integrity
      key derived for NIA2, instead of NIA0 for both.)
      
      It was not a problem because in the PDU Session Resource To Setup
      item, there is "securityIndication" which we use to effectively
      activate/deactivate the ciphering and/or integrity.
      
      But it did not look clean to see a SecurityInformation with
      incorrect data when inspecting the message in wireshark.
      
      So let's use the correct values.
      
      We could also not include the SecurityInformation if both ciphering
      and integrity are not used, and only include ciphering if integrity
      is not used (because integrity settings are optional).
      
      But then if only integrity is used, we still need to include
      ciphering, setting algorithm to NEA0 (no ciphering), because
      the ciphering settings are always included.
      
      This logic is too complex, let's use the simple one to always
      include SecurityInformation with NEA0 and/or NIA0 if ciphering
      and/or integrity is not activated.
      a1eb8f35
    • Guido Casati's avatar
      627f8171
    • Guido Casati's avatar
    • Guido Casati's avatar
      b061b576
    • Guido Casati's avatar
      f2b80ae3
    • Guido Casati's avatar
      Improvements to E1 Bearer Context Setup Request/Response · cd7218c9
      Guido Casati authored
      * Add enc/dec/cp/eq sub-functions to E1 library and adopt in stack
        * eq_drb_to_mod
        * encode_dl_up_parameters
        * decode_dl_up_parameters
        * e1_decode_snssai
        * e1_encode_snssai
        * eq_security_ind
      * Check result of enc/dec functions in Bearer Context Setup enc/dec libs
      cd7218c9
    • Guido Casati's avatar
      Add compile definitions E1AP_LOG_ERRORS · 1ef24796
      Guido Casati authored
      * this is necessary to enable the error logs in the E1 libs
      * also, updated the define name in the E1AP lib
      1ef24796
    • Guido Casati's avatar
      Refactor E1 Bearer Context Management structs · 2146f29c
      Guido Casati authored
      Bearer context setup request and modification request messages
      differ in various IEs according to 9.2.2 of 3GPP TS 38.463, e.g.
      the Bearer context setup request does not contain a list of
      DRBs to modify and does not contain an UP TL configuration.
      
      Thus, the goal of this commit is to split the setup request message
      and the modification request into two different structs:
      * adopt e1ap_bearer_mod_req_t where necessary (e.g. fill_e1_bearer_modif)
      
      Also, reorganized existing struct members according to specs:
      * remove irrelevant struct members from the setup request
      * group members from the same IEs into structs
      * set optional struct members IEs as pointers
      * add and adopt enc/dec/cp/eq lib functions for single IEs
      * add UP_TL_information_t struct with TEID and TL address info and adopt in stack
      * use int instead of long for count types
      * update the relevant copy/equality check utility functions
      
      Extra:
      * add a function to handle Security Information in RRC in the process
      * add create_up_tl_info and adopt in unit tests
      2146f29c
    • Guido Casati's avatar
      4f613ab2
    • Guido Casati's avatar
  2. 09 Feb, 2025 1 commit
  3. 28 Jan, 2025 4 commits
    • Guido Casati's avatar
      e9ff6288
    • Guido Casati's avatar
    • Guido Casati's avatar
      Fix missing line break in e1ap.c · bf3b8b19
      Guido Casati authored
      bf3b8b19
    • Robert Schmidt's avatar
      Merge branch 'integration_2025_w04' into 'develop' · 64a472ae
      Robert Schmidt authored
      Integration: `2025.w04`
      
      Closes #876, #896, #875, #893, and #878
      
      See merge request oai/openairinterface5g!3226
      
      * !3198 remove a set of compile options that don't work anyway
      * !3171 Refactor SCTP Association Response Handling and E1 connection loss at CU-UP
      * !3023 usrp constant and slow derive timestamp
      * !3215 Remove unused code
      * !3192 fix nr phy-test mode in ntn
      * !3214 fix(nrLDPC_coding_t2): Miscellaneous fixes related to T2
      * !3020 use ML receiver for 64 QAM UL-MIMO
      * Demote error logs to debug for "PUCCH not processed"
      * !3217 minor improvements in T hacks
      * !3199 Add a small FAPI Hex parser utility
      * !3209 Remove most of m64 type usage
      * !3211 Avoid huge calloc by alloc'ing TBs independently
      * !3212 F1AP IDs: Allow AddMod, fix concurrency bug
      * !3152 E1 Setup enc/dec library and unit test
      * !2999 Repair nFAPI in 5G
      * !3210 FHI72: FDD support
      * !3220 Improve RA logs
      64a472ae
  4. 27 Jan, 2025 25 commits