- 12 Feb, 2024 4 commits
-
-
Robert Schmidt authored
-
Raymond Knopp authored
This commit introduces a separate thread (l1_tx_thread) that processes gNB DL/TX slots. It receives a message from the ru_thread when a new slot started, and starts processing. The DL part of the scheduler is run in the l1_tx_thread. Therefore, only call UL indication (for scheduler) in UL slots. The UL indication previously triggered the DL scheduler -- hence, it had to be called in every slot. Now, since the DL scheduler is moved into the DL thread, we don't have to call the scheduler in every slot anymore. The reorder thread is removed, as reordering with this scheme is not necessary anymore. The main advantage of this version is that the TX can be scheduled earlier (sl_ahead). Further, there can no longer be race conditions in the TX path, since the scheduler/L2, TX L1 processing and the RU tx function are all execute in the same thread (L1_tX_thread). Also, the scheduler prepares PRACH/PUSCH/PUCCH FAPI PDUs. As of this commit, the scheduler runs in the TX processing chain, whereas these PDUs are destined for RX processing. Thus, too avoid data races, instead of triggering the RX processing at the same time as TX processing in the RU thread, this commit changes the code to trigger RX processing after the scheduler has been run in TX processing to avoid data races. Finally, we synchronize RU and L1 threads. This is important for rfsimulator, since unlike most radios, rfsimulator can run slower or faster, depending on I/O and CPU (it does not have a stable "tick"). Co-authored-by: kiran <saikiran@iitj.ac.in>
-
Robert Schmidt authored
The UL_INFO_mutex is used in only one place, and therefore useless. Also, the scheduler uses a lock internally to prevent concurrent access. Hence, the UL_INFO_mutex is not needed. Remove kill_gNB_proc(), as it is now dead code.
-
Robert Schmidt authored
The next commit introduces a separate gNB TX processing thread. To properly separate DL scheduler (for scheduling decisions) from UL indication handling (for UL packets), this commit introduces a slot indication "tick" to run the DL scheduler which will be put into the gNB TX processing chain instead of the UL indication.
-
- 06 Feb, 2024 5 commits
-
-
Raymond Knopp authored
-
Raymond Knopp authored
-
Raymond Knopp authored
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Robert Schmidt authored
Integration: 2024.w05 See merge request oai/openairinterface5g!2549 * !2537 Fix for UE PUSCH scheduler DURATION_RX_TO_TX assertion * !2538 Fix for UE MAC PDU LCID handling * !2542 Fix L1_SSB_CSI_RSRP table mapping and check validity * !2544 NR UE RRC timers improvement * !2546 Correcting the location of packages * !2493 Fix for computing SSB subcarrier offset * !2496 MCS for retransmission fix in case of dci failed detection at NR UE * !2503 Handle PDU Sessions in NG Initial UE context Setup and forward 5G-S-TMSI to core * enable caching in the docker build of the CI build steps * !2541 Fix RA bug, improve overall logging
-
- 05 Feb, 2024 6 commits
-
-
Raphael Defosseux authored
Signed-off-by: Raphael Defosseux <raphael.defosseux@eurecom.fr>
-
Jaroslava Fiedlerova authored
-
Robert Schmidt authored
-
Jaroslava Fiedlerova authored
-
Jaroslava Fiedlerova authored
Merge remote-tracking branch 'origin/NR_UE_fix_no_mcs_dci_failed_detection' into integration_2024_w05
-
Jaroslava Fiedlerova authored
-
- 03 Feb, 2024 25 commits
-
-
Robert Schmidt authored
We used to trigger the UECapabilityEnquiry right after SecurityModeComplete, and before the RRCReconfiguration (which we call "default" reconfiguration). However, 38.401 tells us that we should send the RRCReconfiguration right after the SecurityModeComplete. In fact, even though we get the UE capabilities, we cannot use them during this reconfiguration, as we would first need to update the DU with a UE Context Modification Request, which we cannot, as we just sent the UE Context Setup Request, and the DU relies on first getting the RRCReconfiguration. Since we rely on a subsequent reconfiguration anyway, we can safely trigger the UECapabilityEnquiry after RRCReconfigurationComplete. (38.331 also says we can send UECapabilityEnquiry at any point.) To cater for the possibility that there might not be any reconfiguration coming afterwards, we check if a DRB has been set up. If not, we assume a reconfiguration will come, and do not trigger one only for the UE capabilities (this is what we do before this commit). If we already have DRBs set up, they might have been set up during the "default" RRC Reconfiguration, and another reconfiguration might not follow soon; in this case, we trigger the reconfiguration by sending the UE capabilities to the DU right away.
-
Robert Schmidt authored
The next commit moves the UE Capability Enquiry after the first reconfiguration. This has the effect that for some UEs (e.g., iPhone), the Setup Requests come too close to each other, triggering RRC Reconfigurations while previous transactions are ongoing. I think the "true" solution would be to implement some tracking of transactions across RRC, F1AP, E1AP, but this might require many changes. For the moment, limit to delaying PDU session resource setups to prevent above problem. Delaying is done using ITTI timers (to be able to serve other UEs), waiting 10ms each time, up to 20 times (to not deadlock the transaction -- after all, if the UE is unhappy, it will drop the connection).
-
Robert Schmidt authored
- Put consistently transaction IDs - Remove transaction IDs when transaction finished, or in places that do not trigger an RRC transaction
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
This commit allows the gNB to handle PDU sessions that the core requests to setup during the NGAP Initial UE Context Setup. Previously, we only managed them as part of PDU Session Resource Setup Request. The RRC will, depending on whether a PDU session is in the NGAP Initial UE Context Setup, either directly trigger the Security Command, or first do a bearer setup at the CU-UP. Some asserts have been lifted, as now the PDU sessions might be present before the RRC Connection is fully established. Implement the correct forwarding of the bearers in an F1 UE Context Setup Request message. This solves bug #672.
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
Prior to this commit, the handling of DRBs is complex: first the RRC "guessed" a DRB ID when setting up DRBs via E1AP (in rrc_gNB_process_NGAP_PDUSESSION_SETUP_REQ()), and later chose one for real in fill_DRB_Configlist() (called in rrc_gNB_generate_dedicatedRRCReconfiguration()). To simplify, remove fill_DRB_Configlist(), and instead allocate the DRB using generateDRB() before sending the message via E1AP, in rrc_gNB_generate_dedicatedRRCReconfiguration(). The rest of the logic is the same. For PDU sessions, always mark PDU sessions as "done" to match pdu session state logic.
-
Robert Schmidt authored
-
Robert Schmidt authored
It might happen that a UE has no CU-UP (e.g., never requested a PDU session). When triggering a release, we previously and implicitly associated a CU-UP in that case. That is not good, and confusing. This commit adds a function to look up if the UE has an associated CU-UP. We only send a release if it is the case. The function get_existing_cuup_for_ue() now instead verifies that a CU-UP exist, and does not implicitly create an association (which might be unwanted, see above).
-
Robert Schmidt authored
-
Robert Schmidt authored
The number of tunnels corresponds to number of DRBs, so correctly compare tunnels and DRBs.
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
The function rrc_gNB_process_RRCReconfigurationComplete() does almost nothing, we can delete it. The variable name ue_reconfiguration_after_reestablishment_counter is misleading, as it counts all reconfigurations; rename to make it clear.
-
Robert Schmidt authored
The drb_active array keeps track of active DRBs. However, it only replicates some of the information in established_drbs, and could lead to a reuse of DRB IDs when two bearers are to be set up. Consider the following: 1. trigger first DRB creation at RRC 2. DRB ID chosen from free drb_active entry 3. trigger second DRB creation at RRC -> The first reconfiguration has not been acknowledged -> drb_active is not marked as DRB_ACTIVE 4. The second DRB ID is chosen from a free drb_active entry, which is the same as in 2. By reusing established_drbs everywhere, this cannot happen, as we 1. select the DRB to be used using next_available_drb() and then 2. use generateDRB(), which marks the DRB used all from within fill_DRB_configList, which gives a new DRB. The logic is still overly complex, though.
-
Robert Schmidt authored
-
Robert Schmidt authored
-
Robert Schmidt authored
If there are no active bearers, the function previously returned an empty list. Return NULL if there are no bearers, so it is safe to call this function even when no bearers are present. We can also pass it every time to do_RRCReconfiguration(), which will not add an empty list for DRBs.
-
Robert Schmidt authored
Create a single function to activate an SRB. This function derives the corresponding keys, triggers the setup in PDCP, and marks the SRB as set up, instead of doing all of this common functionality in individual steps. Use it at the corresponding places.
-
Luis Pereira authored
- show MAC bytes in one line - add MCS table idx - show ulsch errors before ulsch DTX (as in DL) - show if UE in-sync/out-of-sync - show CU UE ID next to RNTI to stats Since we modify the format of the statistics, fix the format in the retx checkers of the CI.
-
Robert Schmidt authored
Only fill the 5G-S-TMSI if if is present, and set the bit in the presenceMask.
-