1. 21 May, 2024 30 commits
  2. 16 May, 2024 1 commit
    • Robert Schmidt's avatar
      Correct buffer size for do_NR_DLInformationTransfer() · 9fd1b9ac
      Robert Schmidt authored
      uper_encode_to_buffer() of asn1c returns the number of BITS that have
      been encoded; if we use this, we need to calculate the resulting number
      of bytes (rounding up) to get the right buffer size.
      
      Note that do_NR_ULInformationTransfer() uses
      uper_encode_to_new_buffer() which returns the number of BYTES, hence, in
      this similar function, we should not modify the return value.
      9fd1b9ac
  3. 07 May, 2024 1 commit
    • Robert Schmidt's avatar
      Merge branch 'integration_2024_w18' into 'develop' · 82bd07eb
      Robert Schmidt authored
      Integration `2024.w18`
      
      See merge request oai/openairinterface5g!2713
      
      * !2705 Fix CRC check in UE DCI detection
      * !2708 Adding few more NR bands to the list of supported ones
      * !2701 gNB archi fixes
      * !2203 DL-MMSE
      * !2684 remove asserts on min RX/TX, set the RX/TX shift as 2 in the UE
      * !2594 F1AP refactoring to align with O-RAN.WG5.C.1-v11
      82bd07eb
  4. 06 May, 2024 8 commits
    • Jaroslava Fiedlerova's avatar
    • Jaroslava Fiedlerova's avatar
    • Robert Schmidt's avatar
      NGAP: Correct encoding of AMF Set ID and Pointer · 0fb0b055
      Robert Schmidt authored
      Taking the example of the AMF Set ID, the previous version of the macro
      used another macro to encode the number, then marked the last 6 bits in
      the bit string (of length 16/2 bytes) as unused. This is wrong, because,
      assuming AMF Set ID=3, it basically truncates the number by encoding all
      16 bits and cutting off the last 6, like this:
      
        ------------------- encode 16 bits
        0000 0000 0000 0011
        ------------        take these 10 bits
      
      So what remains is these bit positions of the number:
      (16,15,14,13,12,11,10,9,8,7) -- the last 6 bits are cut (and the first 6
      are either 0 or garbage, because they don't exist).
      
      Instead, manually encode bits (10,9,8,7,6,5,4,3) in the first byte, and
      (2,1) in the second byte of the bit string, like so:
      
        ------------        encode 10 bits
        0000 0000 1100 0000
        ------------        take these 10 bits
      
      Do the same with the pointer.
      
      The AMF Region ID above is correct, as it is exactly 8 bits.
      0fb0b055
    • Robert Schmidt's avatar
      NGAP Release Cplt: indicate release PDU sessions · 8d225a7e
      Robert Schmidt authored
      We can optionally indicate the PDU session IDs. At least with OAI 5GC,
      that should help it clean up.
      8d225a7e
    • Robert Schmidt's avatar
      Handle PDU sessions in NG UE context setup request · 3e2d5f88
      Robert Schmidt authored
      In the case of PDU sessions in the NG UE context setup request, we first
      have to set up security. Hence, in this commit, implement the "delayed"
      set up of theses PDU sessions, and acknowledge the setup request after
      reconfiguration, as requested by O-RAN.WG5.C.1-v11.
      3e2d5f88
    • Robert Schmidt's avatar
      Correctly trigger NGAP UE Context Setup Response · 1fc16077
      Robert Schmidt authored
      Trigger UE ctxt setup response for the case of "registration request"
      (no PDU sessions in UE Context setup response), as mandated by
      O-RAN.WG5.C.1-v11.
      1fc16077
    • Robert Schmidt's avatar
      Trigger UE context setup req after E1 bearer setup resp · cbf446e2
      Robert Schmidt authored
      As of this commit, since we now send the UE security command as a DL NAS
      message, there is no F1 UE Context setup request. Hence, instead of
      sending a UE context modif request, send the UE context setup request
      after the E1 bearer setup response (which logically also makes more
      sense, as the E1 setup procedure comes before the F1 setup procedure).
      cbf446e2
    • Robert Schmidt's avatar
      Revert "Delay PDU session resource setup request if necessary" · 179ecb8e
      Robert Schmidt authored
      This reverts commit 0f100a6e, which
      introduced a hack to possibly wait with a PDU session setup at the RRC
      in case a RRC UE capability transaction (requesting UE capabilities from
      a UE) was ongoing. This happened, as we delayed the UE capabilities to
      after the first RRC reconfiguration; in that case, certain UEs were
      requesting the next PDU session, and if RRC did not delay the new PDU
      session (as requested from the core), this procedure might occur while
      UE capability enquiry was ongoing, leading to failures in these
      transactions.
      179ecb8e