An error occurred fetching the project authors.
- 26 Oct, 2017 1 commit
-
-
lfarizav authored
-
- 24 Aug, 2017 1 commit
-
-
Cedric Roux authored
This commits contains several fixes to improve a multi-UE scenario. This is not the end of the story. Summary of work: ================ 1 - improve SR (scheduling requests): We configured n1pucch == 3 for scheduling requests, for all UEs. We now use 71 - UE_id/10. For it to work, it is vital that pucch_nRB_CQI in the configuration file is set to 0, otherwise the SR will go to an RB used for PUSCH and uplink decoding will fail whenever an UE does SR. Note that we will have problems with 20MHz when we use a CCE that let the UE send the ACK/NACK using a n1pucch allocated for SR, because when the PDCCH is of size 3, we can have 87 CCEs and it may lead to an n1pucch colliding with one for SR. The work done in this patch is a quick solution, seems to work with 10MHz. The real solution is to disable the use of those CCEs that would lead an UE to use a n1pucch colliding with an SR n1pucch. Then we can use whatever n1pucch we want for SR, as long as the scheduler protects them. Impacted files: configuration files openair2/RRC/LITE/MESSAGES/asn1_msg.c 2 - some fixes for uplink scheduling: - Do not use PRACH for PUSCH, that leads to too many false PRACH detection. Plus the PUSCH receiving may fail if one UE uses the PRACH at the same time. - Take care of retransmissions. That was not done at all, so we could allocate one RB to several UEs. The current design of the code makes it hard to do it properly, so we chose a quick and dirty solution, which is to increase "first_rb" to skip any RB used for retransmission. In this process we may skip a lot of free RBs. A proper solution is needed here. - Do not allocate the last RB. This one is used for PUCCH. It was sometimes allocated to PUSCH. - In the pre-processor we didn't pre-allocate RBs to UEs with an empty buffer status. We didn't check if the UE sent an SR. For example in a three UEs scenario, we could have the third UE never scheduled in the uplink. - rb_table_index was not decreased properly, so we allocated too much RBs to some UEs and thus not enough to others. Impacted files: openair2/LAYER2/MAC/eNB_scheduler_ulsch.c openair2/LAYER2/MAC/pre_processor.c openair1/SCHED/phy_procedures_lte_eNb.c 3 - some fixes for downlink scheduling: - The check on CCE allocation was not correct. We did something like: if (cce allocation is possible) { prepare } We should have done: save current cce allocation if (cce allocation is possible) { allocate cce prepare } reset current cce allocation Basically, when we scheduled several UEs, they were checked separately, and the totality of them was not checked. Impacted file: openair2/LAYER2/MAC/eNB_scheduler_dlsch.c - The retransmissions are probably not handled correctly. Check in openair2/LAYER2/MAC/pre_processor.c, near the comment "// control channel or retransmission", the case "round > 0" was added. It's probably not enough, even maybe not correct. - Change SF05_LIMIT with SF0_LIMIT. We accept to use central blocks in SF 5. The code was also not correct, vrb_map was not set properly because the loop on j was wrong for the last RBG (which can have one less RB than the others). This is not satisfying. The real solution is to use the central RBs and check that the MCS used is compatible with the numbers of resource elements allocated (we don't want to put too more data bits than what fits). 4 - some fixes in PUCCH decoding: See: openair1/PHY/LTE_TRANSPORT/pucch.c Probably not enough. Some more work and analysis is required for a proper use of the PUCCH. What we see is that the PUCCH constellation gets wrong when there are several UEs, meaning the received ACK/NACK is not properly decoded (this, or something else...). 5 - several fixes/checks added here and there: - The final allocate_CCEs in eNB_dlsch_ulsch_scheduler is checked and we brutally exit if it fails. - We exit in get_num_pdcch_symbols in case of failure (this should never happen anyway, no big deal normally). - Some logs added or changed to error/warning instead of debug. - In dlsch_scheduler_pre_processor an abort() was added. The code here looks suspicious. - In assign_max_mcs_min_rb, rb_table_index was not set to 2, the value 0 was used. This was not correct. What remains to be done: ======================== - Correct CCE allocation (take into account SR n1pucch, check that all the n1pucch that will be used are "compatible"). - Take into account the PHICH when scheduling uplink. As of today it is very possible to have two UEs use the same PHICH group and PHICH sequence index. We can use n_DMRS in the DCI to have uniqueness (see 36.213 table 9.1.2-2). We can drop an allocation if there is no free PHICH group/sequence index for a given UE. - When there is an uplink retransmission in the PRACH, we have to disable PRACH detection. It is possible that one UE does PRACH at the same time, but then what to do? We could use DCI0-based retransmission in this specific case maybe... - Handle free RBs in uplink in a much better way in case of a retransmission. We may have a lot of free unused RBs with the current code. - Check downlink retransmissions. Not much has been done there. - Surely more stuff not clear yet. In some situations we don't have a good behavior of the system. Hard to describe more precisely at this point.
-
- 27 Jul, 2017 1 commit
-
-
Cedric Roux authored
This bug happens when we detect uplink failure for one UE. In this case, a DCI format 1A is sent to the UE to ask it to do random acces. The way this DCI is generated was not compatible with how the software is organized. It was expected that the DCI are added (with add_ue_spec_dci and add_common_dci) in a very specific order: first all DCIs in common space are added (with add_common_dci) then all DCIs in UE specific space are added (with add_ue_spec_dci). The problem was that the DCI format 1A DCI sent to the UE for it to do random access is added (with add_ue_spec_dci) before the DCIs in common space. That totally messed up the logic in add_common_dci and add_ue_spec_dci. The solution is to get rid of Num_common_dci and Num_ue_spec_dci, replace those two counters by only one (Num_dci) and add "search_space" in the dci_alloc structure to be used later by the function "allocate_CCEs" when calling "get_nCCE_offset". The software had to be adapted to the new variables, everywhere. I am not sure that the simulators work. It seems that some of them didn't use Num_common_dci and Num_ue_spec_dci to decide on what space (common or UE specific) to put the DCI, but relied on the rnti (comparing with SI_RNTI). To be tested properly. The modified simulators are: - openair1/SIMULATION/LTE_PHY/dlsim.c - openair1/SIMULATION/LTE_PHY/dlsim_tm4.c - openair1/SIMULATION/LTE_PHY/dlsim_tm7.c - openair1/SIMULATION/LTE_PHY/framegen.c - openair1/SIMULATION/LTE_PHY/pdcchsim.c - openair1/SIMULATION/LTE_PHY/syncsim.c
-
- 06 Jun, 2017 1 commit
-
-
Florian Kaltenberger authored
re-adding the possibility in dlsim to bypass the DCI/PDCCH generation. This is necessary for accuracy of the dlsim-tests, which are working again now.
-
- 19 May, 2017 1 commit
-
-
Cedric Roux authored
-
- 12 May, 2017 1 commit
-
-
gabrielC authored
Note: not sure that the code is correct, to be checked (Cédric Roux). ---------------------------------------------------------- bug 22 Ttile: (subframe!=2)||(subframe!=7) is always TRUE. This coding is really intended? Operator || should be && instead? Bug Location: ((frame_parms->frame_type==TDD)&&(frame_parms->tdd_config==1)&&((subframe!=2)||(subframe!=7)))) { Note: Detected by CppCheck ----------------------------------------------------------
-
- 28 Mar, 2017 1 commit
-
-
Wilson Thong authored
-
- 23 Mar, 2017 1 commit
-
-
Cedric Roux authored
- import RRC ASN.1 defintions from the specifications (file openair2/RRC/LITE/MESSAGES/asn1c/ASN1_files/RRC-e10.asn) contrary to rel8/10, all modules have been imported, maybe it's too much to refine in case of problems - deal with rel14 in fix_asn1 - all code that was for Rel10 is now for Rel10/Rel14 - some incompatible changes (mostly in naming) were resolved in favor of rel14, see in openair2/RRC/LITE/defs.h - unsure about the rlc layer, some arrays have changed (values appended), I only changed the definition and in tests in the code, I changed the index limit, maybe it's not enough Rel14 is the default compilation mode.
-
- 21 Mar, 2017 2 commits
- 16 Mar, 2017 1 commit
-
-
Cedric Roux authored
-
- 15 Mar, 2017 2 commits
-
-
Florian Kaltenberger authored
-
Cedric Roux authored
768*8 is too small, in 20MHz, the phy-test mode (in default mode?) has a buffer of size 6378. Let's set the buffer size to the input's one plus 4 bytes (to accomodate for CRC, not sure about this).
-
- 14 Mar, 2017 1 commit
-
-
Calisson authored
-
- 10 Mar, 2017 3 commits
-
-
Florian Kaltenberger authored
-
Rohit Gupta authored
-
Florian Kaltenberger authored
-
- 17 Feb, 2017 1 commit
-
-
pyroclaste authored
-
- 13 Feb, 2017 1 commit
-
-
Cedric Roux authored
-
- 10 Feb, 2017 1 commit
-
-
Younes authored
-
- 07 Feb, 2017 1 commit
-
-
Florian Kaltenberger authored
Conflicts: openair1/PHY/INIT/lte_init.c openair1/PHY/LTE_TRANSPORT/dlsch_modulation.c openair1/PHY/LTE_TRANSPORT/power_control.c
-
- 05 Feb, 2017 1 commit
-
-
Raymond Knopp authored
-
- 02 Feb, 2017 1 commit
-
-
Xenofon Foukas authored
-
- 14 Jan, 2017 2 commits
-
-
Raymond Knopp authored
-
Raymond.Knopp authored
-
- 11 Jan, 2017 1 commit
-
-
Cedric Roux authored
Some of them might not be correctly handled. I put /* TODO: XXX */ where I didn't know if the fix was correct.
-
- 07 Jan, 2017 1 commit
-
-
Raymond.Knopp authored
fixes for precoding (turning off if nb_antennas_tx=1), configuration files, timing advance with 3/4 sampling on 20 MHz, logging in MAC
-
- 03 Jan, 2017 1 commit
-
-
Raymond Knopp authored
-
- 02 Jan, 2017 1 commit
-
-
Raymond.Knopp authored
-
- 14 Dec, 2016 1 commit
-
-
ROBERT Benoit authored
correct issue 147 : --phy-test mode : error msg " DL Received HarqReTx round=1 mcs=28 rballoc=8191 rv=0 "
-
- 05 Dec, 2016 2 commits
-
-
ROBERT Benoit authored
correct issue 147 : --phy-test mode : error msg " DL Received HarqReTx round=1 mcs=28 rballoc=8191 rv=0 "
-
Cedric Roux authored
-
- 04 Dec, 2016 1 commit
-
-
Raymond.Knopp authored
-
- 30 Nov, 2016 1 commit
-
-
Cedric Roux authored
- add mcs to ENB_PHY_DLSCH_UE_DCI - add mcs, round, first_rb, nb_rb, TBS to ENB_PHY_ULSCH_UE_DCI
-
- 25 Nov, 2016 1 commit
-
-
Florian Kaltenberger authored
-
- 24 Nov, 2016 2 commits
-
-
Cedric Roux authored
Something went wrong somewhere in the commit history, the function was not correct. The most obvious symptom was that way too much SR (scheduling requests) were given to the UE whenever it had some PUCCH to send. The case for TDD has not been tested.
-
Raymond Knopp authored
-
- 23 Nov, 2016 1 commit
-
-
Raymond Knopp authored
-
- 22 Nov, 2016 2 commits
-
-
Cedric Roux authored
The eNodeB may sometimes wrongly generate PHICH because somewhere 'phich_active' is not reset to 0, due to an unidentified reason. When adding this hack the problem seems to disappear completely. This is not the end of the story. The real underlying problem has to be understood and fixed correctly.
-
Cedric Roux authored
The Msg3 ressource blocks used by random access procedure were not correctly handled. The MAC scheduler could wrongly allocate a ressource block for both random access Msg3 and a regular UE. This hotfix hopefully fixes the problem. A new function "set_msg3_subframe" has been added in the interface between PHY and MAC.
-