An error occurred fetching the project authors.
  1. 07 May, 2020 1 commit
    • Cedric Roux's avatar
      rlc v2: some fixes for 'bugs' found by coverity scan · 21a2a8c6
      Cedric Roux authored
      Minor fixes, doesn't change anything. Not sure these are 'bugs' either,
      but let's be polite with coverity scan...
      
      One thing was not changed.
      Coverity scan says:
      *** CID 357991:  Memory - illegal accesses  (USE_AFTER_FREE)
      /home/carabe/raphael/openairinterface5g/openair2/LAYER2/rlc_v2/rlc_entity_am.c: 507 in tx_list_remove_sn()
      501         } else {
      502           prev = cur;
      503           cur = cur->next;
      504         }
      505       }
      506
      >>>     CID 357991:  Memory - illegal accesses  (USE_AFTER_FREE)
      >>>     Using freed pointer "head.next".
      507       return head.next;
      508     }
      509
      510     void cleanup_sdu_list(rlc_entity_am_t *entity)
      511     {
      512       rlc_sdu_t head;
      
      But as far as I understand, there is no problem. We don't access
      head.next at all if it has been freed. Or is there some aliasing
      going on there (pointer aliasing)? I doubt it. False positive?
      21a2a8c6
  2. 17 Apr, 2020 2 commits
    • Cedric Roux's avatar
      rlc v2: improve buffer status reporting · eebf2cb9
      Cedric Roux authored
      The old method was wrong.
      The new method is better, but not accurate, especially when the
      TX buffer contains SDU of size > 2047 bytes.
      
      Plus it's probably too slow.
      
      To be refined at some point.
      eebf2cb9
    • Cedric Roux's avatar
      alternative RLC implementation · 3310f5c6
      Cedric Roux authored
      This commit introduces an alternative RLC implementation
      based on 36.322 version 8. AM and UM done, TM not done.
      
      See openair2/LAYER2/rlc_v2/TODO for missing parts.
      3310f5c6