1. 15 Jan, 2018 5 commits
    • Cedric Roux's avatar
    • Cedric Roux's avatar
      Merge remote-tracking branch 'origin/hotfix-dci-clear-padding-bits' into... · 9c8b6e56
      Cedric Roux authored
      Merge remote-tracking branch 'origin/hotfix-dci-clear-padding-bits' into develop_integration_2018_w02
      9c8b6e56
    • Cedric Roux's avatar
    • Cedric Roux's avatar
      Fix NFAPI integration · 922b5b59
      Cedric Roux authored
      This commit fixes issues introduced by the previous commit.
      
      Summary of work:
      - cleanup:
        - fix LOG_XX to be less verbose
        - fix cmake_targets/CMakeLists.txt
        - fix oaienv
        - remove dead code
      - bug fixes:
        - in openair1/SCHED/fapi_l1.c we had:
            eNB->pdcch_vars[subframe&1].num_dci           = number_dci;
          should be:
            eNB->pdcch_vars[subframe&1].num_dci           = 0;
          This bug let the PHY send more DCIs than what should have been
          sent because num_dci is incremented later on in the code.
          This fix may be a problem for fapi mode, to be checked.
        - add new T VCD traces
        - revert openair1/PHY/TOOLS/file_output.c to 'develop' version
        - remove thread_id in logRecord/logRecord_mt
        - revert (and adapt) configuration files
        - be careful when doing frame++, we need to % 1024
        - revert target_rx_power in openair2/LAYER2/MAC/eNB_scheduler_ulsch.c
      - NFAPI:
        - the open-nFAPI code has been included in the repository. See nfapi/README.
          Maybe we should "git clone" the Cisco repository instead. We have to be
          careful of availability though.
      
      What has been tested:
      - monolithic eNB FDD 5/10MHz with one UE, iperf UDP/TCP uplink/downlink
      
      Anything else may fail to work, especially the FAPI mode, which has not
      been tested at all.
      922b5b59
    • Cedric Roux's avatar
      import NFAPI work from David Price from Cisco (non-working commit, do not use it) · 7757b9e7
      Cedric Roux authored
      It has been chosen to not include the full history of commits
      from David. He included a binary version of wireshark, probably
      a modified one that understands NFAPI. Wireshark is released under
      the GPL license, we cannot include it in the repository. We could
      have done a next commit to remove this binary. But then it would
      still be present in the history of commits, which may not be allowed.
      And it would take space on disk. We could edit the history to remove
      wireshark entirely. But this operation is too complicated.
      
      There was also a pcap capture file, which has nothing to do in
      the history of commits and would take space on disk. There again,
      it's too difficult to edit the history to remove it.
      
      There was a file .gitignore that was also removed.
      
      The original history can be found on David's repository:
      https://gitlab.eurecom.fr/daveprice/openairinterface5g/
      The branch is: nfapi-ru-rau-split.
      
      A copy of that branch has been included in the internal OAI
      repository, for those who have access to it.
      The branch is the same. The last commit ID is
      9106438239e0bc626ff1fa1d97d911caadd0fbb9.
      
      You can compare the current commit with the commit 9106...
      to see what differs.
      
      The current commit has to be considered non-working.
      The commit following the current commit will fix problems with
      the work in the current commit.
      
      If you use git bisect, don't spend time analyzing the current
      commit.
      7757b9e7
  2. 04 Jan, 2018 1 commit
    • Cedric Roux's avatar
      Add support for Ubuntu 17.04 and 17.10. · ec56a416
      Cedric Roux authored
      Basically, build_helper has been adapted so that:
        ./buil_oai -I -w USRP
      works for Ubuntu 17.04 and 17.10.
      
      Concerning those systems:
      - compilation with "--eNB --UE -w USRP" works
      - the enb softmodem runs on 17.04 (not tested on 17.10)
      - nothing else has been tested.
      
      Users should report any problem.
      ec56a416
  3. 03 Jan, 2018 1 commit
    • Cedric Roux's avatar
      hotfix: clear DCI padding bits · c5ca2bd8
      Cedric Roux authored
      The problem is the following (as reported by an user):
      
        "one UE is attached to OAI system. UE is near the antenna. Try to detach
        the UE and attach again. Repeat this procedure for 5-6 times. OAI system
        does not work and any the UE can not attach to this system. I use TEMS
        software and I can see MIB signaling on this UE but UE can not decode SIB1
        and SIB2."
      
      What happens is that the DCI for SIB1 and SIB2 is not cleared before
      use. That is the bits in the 'padding' field keep the values that were
      set before. If the structure has been used to transmit other DCIs
      (eg. for UEs) in the past, it may be reused with some of those bits set
      to 1. When receiving this DCI, the UE won't accept it because it
      gets some bits at 1 where it expects them to be 0.
      
      The short-term/quick solution is to clear the 'padding' field.
      A better solution would be to rewrite this part of the code,
      which is way too complicated for what it does. But this takes
      too much time.
      
      In dci.h the field 'dummy' of some structures was renamed to 'padding'.
      The fields 'padding32' and 'padding64' were also renamed to 'padding'
      for consistency.
      
      Some structures (DCI2B_1_5MHz_TDD, DCI2B_10MHz_FDD, DCI2D_1_5MHz_FDD,
      DCI2D_5MHz_FDD, DCI2D_10MHz_FDD) had a 'padding' field at the end, which
      was renamed to 'padding0'. I don't know if this field should be here at all.
      To me this field looks very suspicious. When we test DCIs 2B and 2D we
      should be careful.
      c5ca2bd8
  4. 01 Dec, 2017 7 commits
  5. 30 Nov, 2017 3 commits
  6. 28 Nov, 2017 1 commit
  7. 27 Nov, 2017 2 commits
  8. 23 Nov, 2017 1 commit
  9. 22 Nov, 2017 6 commits
  10. 20 Nov, 2017 1 commit
  11. 17 Nov, 2017 5 commits
  12. 14 Nov, 2017 2 commits
  13. 13 Nov, 2017 1 commit
  14. 04 Nov, 2017 2 commits
  15. 27 Oct, 2017 2 commits