build.yml: Try setting -DCMAKE_MSVC_RUNTIME_LIBRARY for abseil, protobuf, protobuf-c builds on Windows

Not sure why we want to cache and suppress the abseil/protobuf builds on
Windows since those are the things that break most often and we should
be alerted when they start breaking.

It looks like this got missed in 4cb63c20.

For MSVC:

- Updated abseil from 20230802.0 to 20240722.0.
- Updated protobuf from 24.3 to 29.3.
- Dropped utf8_range since this appears to have been incorporated into protobuf.

Clean CMake

Chase compatibility issues with Google protobuf >= 26.0

build.yml: Build on more pull request activity types

The default is to build on pull request activity types opened, reopened,
and synchronize. Also build on activity types edited, ready_for_review,
and review_requested.

As detailed in https://github.com/protobuf-c/protobuf-c/pull/711, the
protobuf compiler apparently polices the values reported by a code
generator's GetMinimumEdition() / GetMaximumEdition() methods, if
GetSupportedFeatures() reports that it reports editions.

Returning `FEATURE_SUPPORTS_EDITIONS` broke the legacy `protoc-c`
command-line binary because that binary "registers" the protobuf-c code
generator as a built-in code generator, whereas `protoc-gen-c` (aka
`protoc --c_out=`) is a code generator plugin and the policing performed
by protobuf's `CommandLineInterface::SetupFeatureResolution()` method
apparently doesn't apply to plugins.

This commit prevents our min/max editions from being policed when
invoked as `protoc-c`.

Tested with protobuf 29.3.

The Google protobuf project is currently experimenting with a new syntax
for .proto files called "editions". Since protobuf-c is a proto2/proto3
compiler, after the previous commit reimplementing `FieldSyntax()`, the
protobuf compiler will abort like this if presented with an "editions"
syntax .proto file due to the safety check in `FieldSyntax()`:

    $ protoc --experimental_editions --c_out=. test.proto
    protoc-gen-c: ./protoc-c/c_helpers.h:178: int google::protobuf::compiler::c::FieldSyntax(const google::protobuf::FieldDescriptor*): Assertion `syntax == "proto2" || syntax == "proto3"' failed.
    --c_out: protoc-gen-c: Plugin killed by signal 6.

On protobuf 26, our `CodeGenerator` can implement certain methods to
declare that we "support" editions, and then reject any other edition
except proto2 and proto3, which have apparently been retroactively
declared to be "editions". Of course this needs to be wrapped in a
version guard.

With this protection in place, the protobuf compiler cleanly exits with
a nice error message like this:

    $ protoc --experimental_editions --c_out=. test.proto
    WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
    E0000 00:00:1710988958.296200   20022 descriptor.cc:4620] Invalid proto descriptor for file "test.proto":
    E0000 00:00:1710988958.296239   20022 descriptor.cc:4623]   test.proto: Edition 2023 is later than the maximum supported edition PROTO3
    --c_out: protoc-gen-c: Plugin failed with status code 1.

Recent versions of Google protobuf have broken the interfaces for
determining the syntax version of a .proto file. The current protobuf-c
1.5.0 release does not compile with Google protobuf 26.0 due to the most
recentage breakage. There is a possible workaround involving the Google
protobuf `FileDescriptorLegacy` class, which is documented as:

// TODO Remove this deprecated API entirely.

So we probably shouldn't rely on it.

Instead, this commit obtains the `FileDescriptorProto` corresponding
to the passed in `FieldDescriptor` and interrogates the `syntax` field
directly. This is a single implementation with no version-specific
workarounds. Hopefully this won't break in the next Google protobuf
release.

I tested the `FieldSyntax()` implementation in this commit across a
number of different Google protobuf releases and found that it worked
(`make && make check`) on all of them:

- Google protobuf 3.6.1.3 (Ubuntu 20.04)
- Google protobuf 3.12.4 (Ubuntu 22.04)
- Google protobuf 3.21.12 (Debian 12 + Debian unstable)
- Google protobuf 3.25.2 (Debian experimental)
- Google protobuf 26.1-dev

Previously, we were conditionally trying to set `min_header_version` to
the lowest possible value, and relying on a "legacy" Google interface to
determine the file descriptor's syntax version as part of that
determination.

Instead, simply bump the minimum version to 1003000 (1.3.0). This
release was almost 7 years ago. In practice protobuf-c users should not
be shipping pre-compiled .pb-c.c/.pb-c.h files, anyway.

Miscellaneous CI updates

That gives us the entire weekend to investigate build failures.

Update actions

Simplify the CI steps command so in case we use another generator
than Make for example ninja or nmake we could also support it.
Signed-off-by: Clément Péron <peron.clem@gmail.com>

protoc-gen-c requires protobuf-c.

Properly set protobuf-c BUILD_INTERFACE.
To support both <protobuf-c/protobuf-c.h> and "protobuf-c.h"
Signed-off-by: Clément Péron <peron.clem@gmail.com>

Signed-off-by: Clément Péron <peron.clem@gmail.com>

Some endif are set, some are not.

Leave all the endif unset as it makes the code more readable.
Signed-off-by: Clément Péron <peron.clem@gmail.com>

One file has executable right whereas it should be 644.
Signed-off-by: Clément Péron <peron.clem@gmail.com>

Some executable and library add header files as source.
These should not be declared as source file, remove them.
Signed-off-by: Clément Péron <peron.clem@gmail.com>

CMake file is a bit a mess use:
cmake-format -i CMakeLists.txt

This will have a clean indent
Signed-off-by: Clément Péron <peron.clem@gmail.com>

The Google protobuf project is currently experimenting with a new syntax
for .proto files called "editions". Since protobuf-c is a proto2/proto3
compiler, after the previous commit reimplementing `FieldSyntax()`, the
protobuf compiler will abort like this if presented with an "editions"
syntax .proto file due to the safety check in `FieldSyntax()`:

    $ protoc --experimental_editions --c_out=. test.proto
    protoc-gen-c: ./protoc-c/c_helpers.h:178: int google::protobuf::compiler::c::FieldSyntax(const google::protobuf::FieldDescriptor*): Assertion `syntax == "proto2" || syntax == "proto3"' failed.
    --c_out: protoc-gen-c: Plugin killed by signal 6.

On protobuf 26, our `CodeGenerator` can implement certain methods to
declare that we "support" editions, and then reject any other edition
except proto2 and proto3, which have apparently been retroactively
declared to be "editions". Of course this needs to be wrapped in a
version guard.

With this protection in place, the protobuf compiler cleanly exits with
a nice error message like this:

    $ protoc --experimental_editions --c_out=. test.proto
    WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
    E0000 00:00:1710988958.296200   20022 descriptor.cc:4620] Invalid proto descriptor for file "test.proto":
    E0000 00:00:1710988958.296239   20022 descriptor.cc:4623]   test.proto: Edition 2023 is later than the maximum supported edition PROTO3
    --c_out: protoc-gen-c: Plugin failed with status code 1.

Recent versions of Google protobuf have broken the interfaces for
determining the syntax version of a .proto file. The current protobuf-c
1.5.0 release does not compile with Google protobuf 26.0 due to the most
recentage breakage. There is a possible workaround involving the Google
protobuf `FileDescriptorLegacy` class, which is documented as:

// TODO Remove this deprecated API entirely.

So we probably shouldn't rely on it.

Instead, this commit obtains the `FileDescriptorProto` corresponding
to the passed in `FieldDescriptor` and interrogates the `syntax` field
directly. This is a single implementation with no version-specific
workarounds. Hopefully this won't break in the next Google protobuf
release.

I tested the `FieldSyntax()` implementation in this commit across a
number of different Google protobuf releases and found that it worked
(`make && make check`) on all of them:

- Google protobuf 3.6.1.3 (Ubuntu 20.04)
- Google protobuf 3.12.4 (Ubuntu 22.04)
- Google protobuf 3.21.12 (Debian 12 + Debian unstable)
- Google protobuf 3.25.2 (Debian experimental)
- Google protobuf 26.1-dev

Previously, we were conditionally trying to set `min_header_version` to
the lowest possible value, and relying on a "legacy" Google interface to
determine the file descriptor's syntax version as part of that
determination.

Instead, simply bump the minimum version to 1003000 (1.3.0). This
release was almost 7 years ago. In practice protobuf-c users should not
be shipping pre-compiled .pb-c.c/.pb-c.h files, anyway.

build.yml: Set "fail-fast: false" so we can tell which jobs are failing

build.yml: Install libtool on OS X

This might fix the new CI build failure:

    → Run ./autogen.sh
    autoreconf: export WARNINGS=
    autoreconf: Entering directory '.'
    autoreconf: configure.ac: not using Gettext
    autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS}
    autoreconf: configure.ac: tracing
    autoreconf: configure.ac: creating directory build-aux
    autoreconf: configure.ac: not using Libtool
    autoreconf: configure.ac: not using Intltool
    autoreconf: configure.ac: not using Gtkdoc
    autoreconf: running: /opt/homebrew/Cellar/autoconf/2.72/bin/autoconf --force
    autoreconf: running: /opt/homebrew/Cellar/autoconf/2.72/bin/autoheader --force
    autoreconf: running: automake --add-missing --copy --force-missing
    configure.ac:14: installing 'build-aux/compile'
    configure.ac:13: installing 'build-aux/install-sh'
    configure.ac:13: installing 'build-aux/missing'
    Makefile.am:4: error: Libtool library used but 'LIBTOOL' is undefined
    Makefile.am:4:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
    Makefile.am:4:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
    Makefile.am:4:   If 'LT_INIT' is in 'configure.ac', make sure
    Makefile.am:4:   its definition is in aclocal's search path.
    Makefile.am: installing 'build-aux/depcomp'
    parallel-tests: installing 'build-aux/test-driver'
    autoreconf: error: automake failed with exit status: 1

Fix CI issues with CMake

cxx-generate-packed-data needs to link with protobuf library for the C++
source file.

Use the protobuf::libprotobuf to get both library and include directory.
Signed-off-by: Clément Péron <peron.clem@gmail.com>