packet-mac-lte.c 208 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
/* Routines for LTE MAC disassembly
 *
 * Martin Mathieson
 *
 * $Id: packet-mac-lte.c 42240 2012-04-25 20:02:12Z pascal $
 *
 * Wireshark - Network traffic analyzer
 * By Gerald Combs <gerald@wireshark.org>
 * Copyright 1998 Gerald Combs
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *

 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

#ifdef HAVE_CONFIG_H
# include "config.h"
#endif

#include <string.h>

#include <epan/packet.h>
#include <epan/expert.h>
#include <epan/prefs.h>
#include <epan/tap.h>
#include <epan/uat.h>

#include "packet-mac-lte.h"
#include "packet-rlc-lte.h"


/* Described in:
 * 3GPP TS 36.321 Evolved Universal Terrestrial Radio Access (E-UTRA)
 *                Medium Access Control (MAC) protocol specification (Release 10)
 */


/* Initialize the protocol and registered fields. */
int proto_mac_lte = -1;

static int mac_lte_tap = -1;

/* Decoding context */
static int hf_mac_lte_context = -1;
static int hf_mac_lte_context_radio_type = -1;
static int hf_mac_lte_context_direction = -1;
static int hf_mac_lte_context_rnti = -1;
static int hf_mac_lte_context_rnti_type = -1;
static int hf_mac_lte_context_ueid = -1;
static int hf_mac_lte_context_sysframe_number = -1;
static int hf_mac_lte_context_subframe_number = -1;
static int hf_mac_lte_context_grant_subframe_number = -1;
static int hf_mac_lte_context_predefined_frame = -1;
static int hf_mac_lte_context_length = -1;
static int hf_mac_lte_context_ul_grant_size = -1;
static int hf_mac_lte_context_bch_transport_channel = -1;
static int hf_mac_lte_context_retx_count = -1;
static int hf_mac_lte_context_retx_reason = -1;
static int hf_mac_lte_context_crc_status = -1;
static int hf_mac_lte_context_rapid = -1;
static int hf_mac_lte_context_rach_attempt_number = -1;

/* Inferred context */
static int hf_mac_lte_ues_ul_per_tti = -1;
static int hf_mac_lte_ues_dl_per_tti = -1;


/* Extra PHY context */
static int hf_mac_lte_context_phy_ul = -1;
static int hf_mac_lte_context_phy_ul_modulation_type = -1;
static int hf_mac_lte_context_phy_ul_tbs_index = -1;
static int hf_mac_lte_context_phy_ul_resource_block_length = -1;
static int hf_mac_lte_context_phy_ul_resource_block_start = -1;
static int hf_mac_lte_context_phy_ul_harq_id = -1;
static int hf_mac_lte_context_phy_ul_ndi = -1;

static int hf_mac_lte_context_phy_dl = -1;
static int hf_mac_lte_context_phy_dl_dci_format = -1;
static int hf_mac_lte_context_phy_dl_resource_allocation_type = -1;
static int hf_mac_lte_context_phy_dl_aggregation_level = -1;
static int hf_mac_lte_context_phy_dl_mcs_index = -1;
static int hf_mac_lte_context_phy_dl_redundancy_version_index = -1;
static int hf_mac_lte_context_phy_dl_retx = -1;
static int hf_mac_lte_context_phy_dl_resource_block_length = -1;
static int hf_mac_lte_context_phy_dl_crc_status = -1;
static int hf_mac_lte_context_phy_dl_harq_id = -1;
static int hf_mac_lte_context_phy_dl_ndi = -1;
static int hf_mac_lte_context_phy_dl_tb = -1;


/* Out-of-band events */
static int hf_mac_lte_oob_send_preamble = -1;
static int hf_mac_lte_oob_send_sr = -1;
static int hf_mac_lte_number_of_srs = -1;
static int hf_mac_lte_oob_sr_failure = -1;

/* MAC SCH/MCH header fields */
static int hf_mac_lte_ulsch = -1;
static int hf_mac_lte_ulsch_header = -1;
static int hf_mac_lte_dlsch = -1;
static int hf_mac_lte_dlsch_header = -1;
static int hf_mac_lte_sch_subheader = -1;
static int hf_mac_lte_mch = -1;
static int hf_mac_lte_mch_header = -1;
static int hf_mac_lte_mch_subheader = -1;

static int hf_mac_lte_sch_reserved = -1;
static int hf_mac_lte_dlsch_lcid = -1;
static int hf_mac_lte_ulsch_lcid = -1;
static int hf_mac_lte_sch_extended = -1;
static int hf_mac_lte_sch_format = -1;
static int hf_mac_lte_sch_length = -1;
static int hf_mac_lte_mch_reserved = -1;
static int hf_mac_lte_mch_lcid = -1;
static int hf_mac_lte_mch_extended = -1;
static int hf_mac_lte_mch_format = -1;
static int hf_mac_lte_mch_length = -1;

static int hf_mac_lte_sch_header_only = -1;
static int hf_mac_lte_mch_header_only = -1;

/* Data */
static int hf_mac_lte_sch_sdu = -1;
static int hf_mac_lte_mch_sdu = -1;
static int hf_mac_lte_bch_pdu = -1;
static int hf_mac_lte_pch_pdu = -1;
static int hf_mac_lte_predefined_pdu = -1;
static int hf_mac_lte_raw_pdu = -1;
static int hf_mac_lte_padding_data = -1;
static int hf_mac_lte_padding_length = -1;


/* RAR fields */
static int hf_mac_lte_rar = -1;
static int hf_mac_lte_rar_headers = -1;
static int hf_mac_lte_rar_header = -1;
static int hf_mac_lte_rar_extension = -1;
static int hf_mac_lte_rar_t = -1;
static int hf_mac_lte_rar_bi = -1;
static int hf_mac_lte_rar_rapid = -1;
static int hf_mac_lte_rar_reserved = -1;
static int hf_mac_lte_rar_body = -1;
static int hf_mac_lte_rar_reserved2 = -1;
static int hf_mac_lte_rar_ta = -1;
static int hf_mac_lte_rar_ul_grant = -1;
static int hf_mac_lte_rar_ul_grant_hopping = -1;
static int hf_mac_lte_rar_ul_grant_fsrba = -1;
static int hf_mac_lte_rar_ul_grant_tmcs = -1;
static int hf_mac_lte_rar_ul_grant_tcsp = -1;
static int hf_mac_lte_rar_ul_grant_ul_delay = -1;
static int hf_mac_lte_rar_ul_grant_cqi_request = -1;
static int hf_mac_lte_rar_temporary_crnti = -1;

/* Common channel control values */
static int hf_mac_lte_control_bsr = -1;
static int hf_mac_lte_control_bsr_lcg_id = -1;
static int hf_mac_lte_control_short_bsr_buffer_size = -1;
static int hf_mac_lte_control_long_bsr_buffer_size_0 = -1;
static int hf_mac_lte_control_long_bsr_buffer_size_1 = -1;
static int hf_mac_lte_control_long_bsr_buffer_size_2 = -1;
static int hf_mac_lte_control_long_bsr_buffer_size_3 = -1;
static int hf_mac_lte_control_short_ext_bsr_buffer_size = -1;
static int hf_mac_lte_control_long_ext_bsr_buffer_size_0 = -1;
static int hf_mac_lte_control_long_ext_bsr_buffer_size_1 = -1;
static int hf_mac_lte_control_long_ext_bsr_buffer_size_2 = -1;
static int hf_mac_lte_control_long_ext_bsr_buffer_size_3 = -1;
static int hf_mac_lte_control_crnti = -1;
static int hf_mac_lte_control_timing_advance = -1;
static int hf_mac_lte_control_timing_advance_reserved = -1;
static int hf_mac_lte_control_ue_contention_resolution = -1;
static int hf_mac_lte_control_ue_contention_resolution_identity = -1;
static int hf_mac_lte_control_ue_contention_resolution_msg3 = -1;
static int hf_mac_lte_control_ue_contention_resolution_msg3_matched = -1;
static int hf_mac_lte_control_ue_contention_resolution_time_since_msg3 = -1;
static int hf_mac_lte_control_power_headroom = -1;
static int hf_mac_lte_control_power_headroom_reserved = -1;
static int hf_mac_lte_control_power_headroom_level = -1;
static int hf_mac_lte_control_ext_power_headroom = -1;
static int hf_mac_lte_control_ext_power_headroom_c7 = -1;
static int hf_mac_lte_control_ext_power_headroom_c6 = -1;
static int hf_mac_lte_control_ext_power_headroom_c5 = -1;
static int hf_mac_lte_control_ext_power_headroom_c4 = -1;
static int hf_mac_lte_control_ext_power_headroom_c3 = -1;
static int hf_mac_lte_control_ext_power_headroom_c2 = -1;
static int hf_mac_lte_control_ext_power_headroom_c1 = -1;
static int hf_mac_lte_control_ext_power_headroom_reserved = -1;
static int hf_mac_lte_control_ext_power_headroom_power_backoff = -1;
static int hf_mac_lte_control_ext_power_headroom_value = -1;
static int hf_mac_lte_control_ext_power_headroom_level = -1;
static int hf_mac_lte_control_ext_power_headroom_reserved2 = -1;
static int hf_mac_lte_control_ext_power_headroom_pcmaxc = -1;
static int hf_mac_lte_control_activation_deactivation = -1;
static int hf_mac_lte_control_activation_deactivation_c7 = -1;
static int hf_mac_lte_control_activation_deactivation_c6 = -1;
static int hf_mac_lte_control_activation_deactivation_c5 = -1;
static int hf_mac_lte_control_activation_deactivation_c4 = -1;
static int hf_mac_lte_control_activation_deactivation_c3 = -1;
static int hf_mac_lte_control_activation_deactivation_c2 = -1;
static int hf_mac_lte_control_activation_deactivation_c1 = -1;
static int hf_mac_lte_control_activation_deactivation_reserved = -1;
static int hf_mac_lte_control_mch_scheduling_info = -1;
static int hf_mac_lte_control_mch_scheduling_info_lcid = -1;
static int hf_mac_lte_control_mch_scheduling_info_stop_mtch = -1;

static int hf_mac_lte_dl_harq_resend_original_frame = -1;
static int hf_mac_lte_dl_harq_resend_time_since_previous_frame = -1;
static int hf_mac_lte_dl_harq_resend_next_frame = -1;
static int hf_mac_lte_dl_harq_resend_time_until_next_frame = -1;

static int hf_mac_lte_ul_harq_resend_original_frame = -1;
static int hf_mac_lte_ul_harq_resend_time_since_previous_frame = -1;
static int hf_mac_lte_ul_harq_resend_next_frame = -1;
static int hf_mac_lte_ul_harq_resend_time_until_next_frame = -1;


static int hf_mac_lte_grant_answering_sr = -1;
static int hf_mac_lte_failure_answering_sr = -1;
static int hf_mac_lte_sr_leading_to_failure = -1;
static int hf_mac_lte_sr_leading_to_grant = -1;
static int hf_mac_lte_sr_invalid_event = -1;
static int hf_mac_lte_sr_time_since_request = -1;
static int hf_mac_lte_sr_time_until_answer = -1;


/* Subtrees. */
static int ett_mac_lte = -1;
static int ett_mac_lte_context = -1;
static int ett_mac_lte_phy_context = -1;
static int ett_mac_lte_ulsch_header = -1;
static int ett_mac_lte_dlsch_header = -1;
static int ett_mac_lte_mch_header = -1;
static int ett_mac_lte_sch_subheader = -1;
static int ett_mac_lte_mch_subheader = -1;
static int ett_mac_lte_rar_headers = -1;
static int ett_mac_lte_rar_header = -1;
static int ett_mac_lte_rar_body = -1;
static int ett_mac_lte_rar_ul_grant = -1;
static int ett_mac_lte_bsr = -1;
static int ett_mac_lte_bch = -1;
static int ett_mac_lte_pch = -1;
static int ett_mac_lte_activation_deactivation = -1;
static int ett_mac_lte_contention_resolution = -1;
static int ett_mac_lte_power_headroom = -1;
static int ett_mac_lte_extended_power_headroom = -1;
static int ett_mac_lte_extended_power_headroom_cell = -1;
static int ett_mac_lte_mch_scheduling_info = -1;
static int ett_mac_lte_oob = -1;



/* Constants and value strings */

259 260 261 262
static const value_string radio_type_vals[] = {
  { FDD_RADIO,      "FDD"},
  { TDD_RADIO,      "TDD"},
  { 0, NULL }
263 264 265
};


266 267 268 269
static const value_string direction_vals[] = {
  { DIRECTION_UPLINK,      "Uplink"},
  { DIRECTION_DOWNLINK,    "Downlink"},
  { 0, NULL }
270 271 272
};


273 274 275 276 277 278 279 280 281
static const value_string rnti_type_vals[] = {
  { NO_RNTI,     "NO-RNTI"},
  { P_RNTI,      "P-RNTI"},
  { RA_RNTI,     "RA-RNTI"},
  { C_RNTI,      "C-RNTI"},
  { SI_RNTI,     "SI-RNTI"},
  { SPS_RNTI,    "SPS-RNTI"},
  { M_RNTI,      "M-RNTI"},
  { 0, NULL }
282 283
};

284 285 286 287
static const value_string bch_transport_channel_vals[] = {
  { SI_RNTI,      "DL-SCH"},
  { NO_RNTI,      "BCH"},
  { 0, NULL }
288 289
};

290 291 292 293 294 295 296
static const value_string crc_status_vals[] = {
  { crc_success,                "OK"},
  { crc_fail,                   "Failed"},
  { crc_high_code_rate,         "High Code Rate"},
  { crc_pdsch_lost,             "PDSCH Lost"},
  { crc_duplicate_nonzero_rv,   "Duplicate_nonzero_rv"},
  { 0, NULL }
297 298 299
};


300 301 302 303 304 305 306 307 308 309 310
static const value_string dci_format_vals[] = {
  { 0, "0"},
  { 1, "1"},
  { 2, "1A"},
  { 3, "1B"},
  { 4, "1C"},
  { 5, "1D"},
  { 6, "2"},
  { 7, "2A"},
  { 8, "3/3A"},
  { 0, NULL }
311 312
};

313 314 315 316 317 318
static const value_string aggregation_level_vals[] = {
  { 0, "1"},
  { 1, "2"},
  { 2, "4"},
  { 3, "8"},
  { 0, NULL }
319 320
};

321 322 323 324 325
static const value_string modulation_type_vals[] = {
  { 2, "QPSK"},
  { 4, "QAM16"},
  { 6, "QAM64"},
  { 0, NULL }
326 327 328
};

static const true_false_string mac_lte_scell_ph_vals = {
329 330
  "Reported",
  "Not reported"
331 332 333
};

static const true_false_string mac_lte_power_backoff_vals = {
334 335
  "Applied",
  "Not applied"
336 337 338
};

static const true_false_string mac_lte_ph_value_vals = {
339 340
  "Based on reference format",
  "Based on real transmission"
341 342 343
};

static const true_false_string mac_lte_scell_status_vals = {
344 345
  "Activated",
  "Deactivated"
346 347 348 349 350 351 352 353
};

#define ACTIVATION_DEACTIVATION_LCID           0x1b
#define UE_CONTENTION_RESOLUTION_IDENTITY_LCID 0x1c
#define TIMING_ADVANCE_LCID                    0x1d
#define DRX_COMMAND_LCID                       0x1e
#define PADDING_LCID                           0x1f

354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
static const value_string dlsch_lcid_vals[] = {
  { 0,                                        "CCCH"},
  { 1,                                        "1"},
  { 2,                                        "2"},
  { 3,                                        "3"},
  { 4,                                        "4"},
  { 5,                                        "5"},
  { 6,                                        "6"},
  { 7,                                        "7"},
  { 8,                                        "8"},
  { 9,                                        "9"},
  { 10,                                       "10"},
  { ACTIVATION_DEACTIVATION_LCID          ,   "Activation/Deactivation"},
  { UE_CONTENTION_RESOLUTION_IDENTITY_LCID,   "UE Contention Resolution Identity"},
  { TIMING_ADVANCE_LCID                   ,   "Timing Advance"},
  { DRX_COMMAND_LCID                      ,   "DRX Command"},
  { PADDING_LCID                          ,   "Padding" },
  { 0, NULL }
372 373 374 375 376 377 378 379 380
};

#define EXTENDED_POWER_HEADROOM_REPORT_LCID 0x19
#define POWER_HEADROOM_REPORT_LCID          0x1a
#define CRNTI_LCID                          0x1b
#define TRUNCATED_BSR_LCID                  0x1c
#define SHORT_BSR_LCID                      0x1d
#define LONG_BSR_LCID                       0x1e

381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400
static const value_string ulsch_lcid_vals[] = {
  { 0,                                   "CCCH"},
  { 1,                                   "1"},
  { 2,                                   "2"},
  { 3,                                   "3"},
  { 4,                                   "4"},
  { 5,                                   "5"},
  { 6,                                   "6"},
  { 7,                                   "7"},
  { 8,                                   "8"},
  { 9,                                   "9"},
  { 10,                                  "10"},
  { EXTENDED_POWER_HEADROOM_REPORT_LCID, "Extended Power Headroom Report"},
  { POWER_HEADROOM_REPORT_LCID,          "Power Headroom Report"},
  { CRNTI_LCID,                          "C-RNTI"},
  { TRUNCATED_BSR_LCID,                  "Truncated BSR"},
  { SHORT_BSR_LCID,                      "Short BSR"},
  { LONG_BSR_LCID,                       "Long BSR"},
  { PADDING_LCID,                        "Padding" },
  { 0, NULL }
401 402 403 404
};

#define MCH_SCHEDULING_INFO_LCID 0x1e

405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437
static const value_string mch_lcid_vals[] = {
  { 0,                            "MCCH"},
  { 1,                            "1"},
  { 2,                            "2"},
  { 3,                            "3"},
  { 4,                            "4"},
  { 5,                            "5"},
  { 6,                            "6"},
  { 7,                            "7"},
  { 8,                            "8"},
  { 9,                            "9"},
  { 10,                           "10"},
  { 11,                           "11"},
  { 12,                           "12"},
  { 13,                           "13"},
  { 14,                           "14"},
  { 15,                           "15"},
  { 16,                           "16"},
  { 17,                           "17"},
  { 18,                           "18"},
  { 19,                           "19"},
  { 20,                           "20"},
  { 21,                           "21"},
  { 22,                           "22"},
  { 23,                           "23"},
  { 24,                           "24"},
  { 25,                           "25"},
  { 26,                           "26"},
  { 27,                           "27"},
  { 28,                           "28"},
  { MCH_SCHEDULING_INFO_LCID,     "MCH Scheduling Information"},
  { PADDING_LCID,                 "Padding" },
  { 0, NULL }
438 439
};

440 441 442 443
static const value_string format_vals[] = {
  { 0,      "Data length is < 128 bytes"},
  { 1,      "Data length is >= 128 bytes"},
  { 0, NULL }
444 445 446
};


447 448 449 450
static const value_string rar_type_vals[] = {
  { 0,      "Backoff Indicator present"},
  { 1,      "RAPID present"},
  { 0, NULL }
451 452 453
};


454 455 456 457 458 459 460 461 462 463 464 465 466 467 468
static const value_string rar_bi_vals[] = {
  { 0,      "0"},
  { 1,      "10"},
  { 2,      "20"},
  { 3,      "30"},
  { 4,      "40"},
  { 5,      "60"},
  { 6,      "80"},
  { 7,      "120"},
  { 8,      "160"},
  { 9,      "240"},
  { 10,     "320"},
  { 11,     "480"},
  { 12,     "960"},
  { 0, NULL }
469 470 471
};


472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537
static const value_string buffer_size_vals[] = {
  { 0,      "BS = 0"},
  { 1,      "0 < BS <= 10"},
  { 2,      "10 < BS <= 12"},
  { 3,      "12 < BS <= 14"},
  { 4,      "14 < BS <= 17"},
  { 5,      "17 < BS <= 19"},
  { 6,      "19 < BS <= 22"},
  { 7,      "22 < BS <= 26"},
  { 8,      "26 < BS <= 31"},
  { 9,      "31 < BS <= 36"},
  { 10,     "36 < BS <= 42"},
  { 11,     "42 < BS <= 49"},
  { 12,     "49 < BS <= 57"},
  { 13,     "47 < BS <= 67"},
  { 14,     "67 < BS <= 78"},
  { 15,     "78 < BS <= 91"},
  { 16,     "91 < BS <= 107"},
  { 17,     "107 < BS <= 125"},
  { 18,     "125 < BS <= 146"},
  { 19,     "146 < BS <= 171"},
  { 20,     "171 < BS <= 200"},
  { 21,     "200 < BS <= 234"},
  { 22,     "234 < BS <= 274"},
  { 23,     "274 < BS <= 321"},
  { 24,     "321 < BS <= 376"},
  { 25,     "376 < BS <= 440"},
  { 26,     "440 < BS <= 515"},
  { 27,     "515 < BS <= 603"},
  { 28,     "603 < BS <= 706"},
  { 29,     "706 < BS <= 826"},
  { 30,     "826 < BS <= 967"},
  { 31,     "967 < BS <= 1132"},
  { 32,     "1132 < BS <= 1326"},
  { 33,     "1326 < BS <= 1552"},
  { 34,     "1552 < BS <= 1817"},
  { 35,     "1817 < BS <= 2127"},
  { 36,     "2127 < BS <= 2490"},
  { 37,     "2490 < BS <= 2915"},
  { 38,     "2915 < BS <= 3413"},
  { 39,     "3413 < BS <= 3995"},
  { 40,     "3995 < BS <= 4677"},
  { 41,     "4677 < BS <= 5476"},
  { 42,     "5476 < BS <= 6411"},
  { 43,     "6411 < BS <= 7505"},
  { 44,     "7505 < BS <= 8787"},
  { 45,     "8787 < BS <= 10276"},
  { 46,     "10287 < BS <= 12043"},
  { 47,     "12043 < BS <= 14099"},
  { 48,     "14099 < BS <= 16507"},
  { 49,     "16507 < BS <= 19325"},
  { 50,     "19325 < BS <= 22624"},
  { 51,     "22624 < BS <= 26487"},
  { 52,     "26487 < BS <= 31009"},
  { 53,     "31009 < BS <= 36304"},
  { 54,     "36304 < BS <= 42502"},
  { 55,     "42502 < BS <= 49759"},
  { 56,     "49759 < BS <= 58255"},
  { 57,     "58255 < BS <= 68201"},
  { 58,     "68201 < BS <= 79846"},
  { 59,     "79846 < BS <= 93479"},
  { 60,     "93479 < BS <= 109439"},
  { 61,     "109439 < BS <= 128125"},
  { 62,     "128125 < BS <= 150000"},
  { 63,     "BS > 150000"},
  { 0, NULL }
538 539 540
};
static value_string_ext buffer_size_vals_ext = VALUE_STRING_EXT_INIT(buffer_size_vals);

541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606
static const value_string ext_buffer_size_vals[] = {
  { 0,      "BS = 0"},
  { 1,      "0 < BS <= 10"},
  { 2,      "10 < BS <= 13"},
  { 3,      "13 < BS <= 16"},
  { 4,      "16 < BS <= 19"},
  { 5,      "19 < BS <= 23"},
  { 6,      "23 < BS <= 29"},
  { 7,      "29 < BS <= 35"},
  { 8,      "35 < BS <= 43"},
  { 9,      "43 < BS <= 53"},
  { 10,     "53 < BS <= 65"},
  { 11,     "65 < BS <= 80"},
  { 12,     "80 < BS <= 98"},
  { 13,     "98 < BS <= 120"},
  { 14,     "120 < BS <= 147"},
  { 15,     "147 < BS <= 181"},
  { 16,     "181 < BS <= 223"},
  { 17,     "223 < BS <= 274"},
  { 18,     "274 < BS <= 337"},
  { 19,     "337 < BS <= 414"},
  { 20,     "414 < BS <= 509"},
  { 21,     "509 < BS <= 625"},
  { 22,     "625 < BS <= 769"},
  { 23,     "769 < BS <= 945"},
  { 24,     "945 < BS <= 1162"},
  { 25,     "1162 < BS <= 1429"},
  { 26,     "1429 < BS <= 1757"},
  { 27,     "1757 < BS <= 2161"},
  { 28,     "2161 < BS <= 2657"},
  { 29,     "2657 < BS <= 3267"},
  { 30,     "3267 < BS <= 4017"},
  { 31,     "4017 < BS <= 4940"},
  { 32,     "4940 < BS <= 6074"},
  { 33,     "6074 < BS <= 7469"},
  { 34,     "7469 < BS <= 9185"},
  { 35,     "9185 < BS <= 11294"},
  { 36,     "11294 < BS <= 13888"},
  { 37,     "13888 < BS <= 17077"},
  { 38,     "17077 < BS <= 20999"},
  { 39,     "20999 < BS <= 25822"},
  { 40,     "25822 < BS <= 31752"},
  { 41,     "31752 < BS <= 39045"},
  { 42,     "39045 < BS <= 48012"},
  { 43,     "48012 < BS <= 59039"},
  { 44,     "59039 < BS <= 72598"},
  { 45,     "72598 < BS <= 89272"},
  { 46,     "89272 < BS <= 109774"},
  { 47,     "109774 < BS <= 134986"},
  { 48,     "134986 < BS <= 165989"},
  { 49,     "165989 < BS <= 204111"},
  { 50,     "204111 < BS <= 250990"},
  { 51,     "250990 < BS <= 308634"},
  { 52,     "308634 < BS <= 379519"},
  { 53,     "379519 < BS <= 466683"},
  { 54,     "466683 < BS <= 573866"},
  { 55,     "573866 < BS <= 705666"},
  { 56,     "705666 < BS <= 867737"},
  { 57,     "867737 < BS <= 1067031"},
  { 58,     "1067031 < BS <= 1312097"},
  { 59,     "1312097 < BS <= 1613447"},
  { 60,     "1613447 < BS <= 1984009"},
  { 61,     "1984009 < BS <= 2439678"},
  { 62,     "2439678 < BS <= 3000000"},
  { 63,     "BS > 3000000"},
  { 0, NULL }
607 608 609
};
static value_string_ext ext_buffer_size_vals_ext = VALUE_STRING_EXT_INIT(ext_buffer_size_vals);

610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675
static const value_string power_headroom_vals[] = {
  { 0,      "-23 <= PH < -22"},
  { 1,      "-22 <= PH < -21"},
  { 2,      "-21 <= PH < -20"},
  { 3,      "-20 <= PH < -19"},
  { 4,      "-19 <= PH < -18"},
  { 5,      "-18 <= PH < -17"},
  { 6,      "-17 <= PH < -16"},
  { 7,      "-16 <= PH < -15"},
  { 8,      "-15 <= PH < -14"},
  { 9,      "-14 <= PH < -13"},
  { 10,     "-13 <= PH < -12"},
  { 11,     "-12 <= PH < -11"},
  { 12,     "-11 <= PH < -10"},
  { 13,     "-10 <= PH < -9"},
  { 14,     "-9 <= PH < -8"},
  { 15,     "-8 <= PH < -7"},
  { 16,     "-7 <= PH < -6"},
  { 17,     "-6 <= PH < -5"},
  { 18,     "-5 <= PH < -4"},
  { 19,     "-4 <= PH < -3"},
  { 20,     "-3 <= PH < -2"},
  { 21,     "-2 <= PH < -1"},
  { 22,     "-1 <= PH < 0"},
  { 23,     "0 <= PH < 1"},
  { 24,     "1 <= PH < 2"},
  { 25,     "2 <= PH < 3"},
  { 26,     "3 <= PH < 4"},
  { 27,     "4 <= PH < 5"},
  { 28,     "5 <= PH < 6"},
  { 29,     "6 <= PH < 7"},
  { 30,     "7 <= PH < 8"},
  { 31,     "8 <= PH < 9"},
  { 32,     "9 <= PH < 10"},
  { 33,     "10 <= PH < 11"},
  { 34,     "11 <= PH < 12"},
  { 35,     "12 <= PH < 13"},
  { 36,     "13 <= PH < 14"},
  { 37,     "14 <= PH < 15"},
  { 38,     "15 <= PH < 16"},
  { 39,     "16 <= PH < 17"},
  { 40,     "17 <= PH < 18"},
  { 41,     "18 <= PH < 19"},
  { 42,     "19 <= PH < 20"},
  { 43,     "20 <= PH < 21"},
  { 44,     "21 <= PH < 22"},
  { 45,     "22 <= PH < 23"},
  { 46,     "23 <= PH < 24"},
  { 47,     "24 <= PH < 25"},
  { 48,     "25 <= PH < 26"},
  { 49,     "26 <= PH < 27"},
  { 50,     "27 <= PH < 28"},
  { 51,     "28 <= PH < 29"},
  { 52,     "29 <= PH < 30"},
  { 53,     "30 <= PH < 31"},
  { 54,     "31 <= PH < 32"},
  { 55,     "32 <= PH < 33"},
  { 56,     "33 <= PH < 34"},
  { 57,     "34 <= PH < 35"},
  { 58,     "34 <= PH < 36"},
  { 59,     "36 <= PH < 37"},
  { 60,     "37 <= PH < 38"},
  { 61,     "38 <= PH < 39"},
  { 62,     "39 <= PH < 40"},
  { 63,     "PH >= 40"},
  { 0, NULL }
676 677 678
};
static value_string_ext power_headroom_vals_ext = VALUE_STRING_EXT_INIT(power_headroom_vals);

679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744
static const value_string pcmaxc_vals[] = {
  { 0,      "Pcmax,c < -29"},
  { 1,      "-29 <= Pcmax,c < -28"},
  { 2,      "-28 <= Pcmax,c < -27"},
  { 3,      "-27 <= Pcmax,c < -26"},
  { 4,      "-26 <= Pcmax,c < -25"},
  { 5,      "-25 <= Pcmax,c < -24"},
  { 6,      "-24 <= Pcmax,c < -23"},
  { 7,      "-23 <= Pcmax,c < -22"},
  { 8,      "-22 <= Pcmax,c < -21"},
  { 9,      "-21 <= Pcmax,c < -20"},
  { 10,     "-20 <= Pcmax,c < -19"},
  { 11,     "-19 <= Pcmax,c < -18"},
  { 12,     "-18 <= Pcmax,c < -17"},
  { 13,     "-17 <= Pcmax,c < -16"},
  { 14,     "-16 <= Pcmax,c < -15"},
  { 15,     "-15 <= Pcmax,c < -14"},
  { 16,     "-14 <= Pcmax,c < -13"},
  { 17,     "-13 <= Pcmax,c < -12"},
  { 18,     "-12 <= Pcmax,c < -11"},
  { 19,     "-11 <= Pcmax,c < -10"},
  { 20,     "-10 <= Pcmax,c < -9"},
  { 21,     "-9 <= Pcmax,c < -8"},
  { 22,     "-8 <= Pcmax,c < -7"},
  { 23,     "-7 <= Pcmax,c < -6"},
  { 24,     "-6 <= Pcmax,c < -5"},
  { 25,     "-5 <= Pcmax,c < -4"},
  { 26,     "-4 <= Pcmax,c < -3"},
  { 27,     "-3 <= Pcmax,c < -2"},
  { 28,     "-2 <= Pcmax,c < -1"},
  { 29,     "-1 <= Pcmax,c < 0"},
  { 30,     "0 <= Pcmax,c < 1"},
  { 31,     "1 <= Pcmax,c < 2"},
  { 32,     "2 <= Pcmax,c < 3"},
  { 33,     "3 <= Pcmax,c < 4"},
  { 34,     "4 <= Pcmax,c < 5"},
  { 35,     "5 <= Pcmax,c < 6"},
  { 36,     "6 <= Pcmax,c < 7"},
  { 37,     "7 <= Pcmax,c < 8"},
  { 38,     "8 <= Pcmax,c < 9"},
  { 39,     "9 <= Pcmax,c < 10"},
  { 40,     "10 <= Pcmax,c < 11"},
  { 41,     "11 <= Pcmax,c < 12"},
  { 42,     "12 <= Pcmax,c < 13"},
  { 43,     "13 <= Pcmax,c < 14"},
  { 44,     "14 <= Pcmax,c < 15"},
  { 45,     "15 <= Pcmax,c < 16"},
  { 46,     "16 <= Pcmax,c < 17"},
  { 47,     "17 <= Pcmax,c < 18"},
  { 48,     "18 <= Pcmax,c < 19"},
  { 49,     "19 <= Pcmax,c < 20"},
  { 50,     "20 <= Pcmax,c < 21"},
  { 51,     "21 <= Pcmax,c < 22"},
  { 52,     "22 <= Pcmax,c < 23"},
  { 53,     "23 <= Pcmax,c < 24"},
  { 54,     "24 <= Pcmax,c < 25"},
  { 55,     "25 <= Pcmax,c < 26"},
  { 56,     "26 <= Pcmax,c < 27"},
  { 57,     "27 <= Pcmax,c < 28"},
  { 58,     "28 <= Pcmax,c < 29"},
  { 59,     "29 <= Pcmax,c < 30"},
  { 60,     "30 <= Pcmax,c < 31"},
  { 61,     "31 <= Pcmax,c < 32"},
  { 62,     "32 <= Pcmax,c < 33"},
  { 63,     "33 <= Pcmax,c"},
  { 0, NULL }
745 746 747
};
static value_string_ext pcmaxc_vals_ext = VALUE_STRING_EXT_INIT(pcmaxc_vals);

748 749 750 751
static const value_string header_only_vals[] = {
  { 0,      "MAC PDU Headers and body present"},
  { 1,      "MAC PDU Headers only"},
  { 0, NULL }
752 753
};

754 755 756 757
static const value_string predefined_frame_vals[] = {
  { 0,      "Real MAC PDU present - will dissect"},
  { 1,      "Predefined frame present - will not dissect"},
  { 0, NULL }
758 759
};

760 761 762 763
static const value_string ul_retx_grant_vals[] = {
  { 0,      "PDCCH ReTx"},
  { 1,      "PHICH NACK"},
  { 0, NULL }
764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784
};

/**************************************************************************/
/* Preferences state                                                      */
/**************************************************************************/

/* If this PDU has been NACK'd (by HARQ) more than a certain number of times,
   we trigger an expert warning. */
static gint global_mac_lte_retx_counter_trigger = 3;

/* By default try to decode transparent data (BCH, PCH and CCCH) data using LTE RRC dissector */
static gboolean global_mac_lte_attempt_rrc_decode = TRUE;

/* Whether should attempt to dissect frames failing CRC check */
static gboolean global_mac_lte_dissect_crc_failures = FALSE;

/* Whether should attempt to decode lcid 1&2 SDUs as srb1/2 (i.e. AM RLC) */
static gboolean global_mac_lte_attempt_srb_decode = TRUE;

/* Where to take LCID -> DRB mappings from */
enum lcid_drb_source {
785
  FromStaticTable, FromConfigurationProtocol
786 787 788 789 790 791 792 793 794 795 796
};
static gint global_mac_lte_lcid_drb_source = (gint)FromStaticTable;

/* Threshold for warning in expert info about high BSR values */
static gint global_mac_lte_bsr_warn_threshold = 50; /* default is 19325 -> 22624 */

/* Whether or not to track SRs and related frames */
static gboolean global_mac_lte_track_sr = TRUE;

/* Which layer info to show in the info column */
enum layer_to_show {
797
  ShowPHYLayer, ShowMACLayer, ShowRLCLayer
798 799 800 801 802 803 804 805 806 807 808 809
};

/* Which layer's details to show in Info column */
static gint     global_mac_lte_layer_to_show = (gint)ShowRLCLayer;

/* When showing RLC info, count PDUs so can append info column properly */
static guint8   s_number_of_rlc_pdus_shown = 0;

/***********************************************************************/
/* How to dissect lcid 3-10 (presume drb logical channels)             */

static const value_string drb_lcid_vals[] = {
810 811 812 813 814 815 816 817 818
  { 3,  "LCID 3"},
  { 4,  "LCID 4"},
  { 5,  "LCID 5"},
  { 6,  "LCID 6"},
  { 7,  "LCID 7"},
  { 8,  "LCID 8"},
  { 9,  "LCID 9"},
  { 10, "LCID 10"},
  { 0, NULL }
819 820 821
};

typedef enum rlc_channel_type_t {
822 823 824 825 826
  rlcRaw,
  rlcTM,
  rlcUM5,
  rlcUM10,
  rlcAM
827 828 829
} rlc_channel_type_t;

static const value_string rlc_channel_type_vals[] = {
830 831 832 833 834
  { rlcTM,    "TM"},
  { rlcUM5 ,  "UM, SN Len=5"},
  { rlcUM10,  "UM, SN Len=10"},
  { rlcAM  ,  "AM"},
  { 0, NULL }
835 836 837 838 839
};


/* Mapping type */
typedef struct lcid_drb_mapping_t {
840 841 842
  guint16 lcid;
  gint    drbid;
  rlc_channel_type_t channel_type;
843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858
} lcid_drb_mapping_t;

/* Mapping entity */
static lcid_drb_mapping_t *lcid_drb_mappings = NULL;
static guint num_lcid_drb_mappings = 0;

UAT_VS_DEF(lcid_drb_mappings, lcid, lcid_drb_mapping_t, 3, "LCID 3")
UAT_DEC_CB_DEF(lcid_drb_mappings, drbid, lcid_drb_mapping_t)
UAT_VS_DEF(lcid_drb_mappings, channel_type, lcid_drb_mapping_t, 2, "AM")

/* UAT object */
static uat_t* lcid_drb_mappings_uat;

/* Dynamic mappings (set by configuration protocol)
   LCID is the index into the array of these */
typedef struct dynamic_lcid_drb_mapping_t {
859 860 861 862
  gboolean valid;
  gint     drbid;
  rlc_channel_type_t channel_type;
  guint8   ul_priority;
863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878
} dynamic_lcid_drb_mapping_t;

static dynamic_lcid_drb_mapping_t dynamic_lcid_drb_mapping[11];


extern int proto_rlc_lte;

/***************************************************************/



/***************************************************************/
/* Keeping track of Msg3 bodies so they can be compared with   */
/* Contention Resolution bodies.                               */

typedef struct Msg3Data {
879 880 881
  guint8   data[6];
  nstime_t msg3Time;
  guint32  framenum;
882 883 884 885 886 887 888 889 890 891
} Msg3Data;


/* This table stores (RNTI -> Msg3Data*).  Will be populated when
   Msg3 frames are first read.  */
static GHashTable *mac_lte_msg3_hash = NULL;

/* Hash table functions for mac_lte_msg3_hash.  Hash is just the (RNTI) key */
static gint mac_lte_rnti_hash_equal(gconstpointer v, gconstpointer v2)
{
892
  return (v == v2);
893 894 895 896
}

static guint mac_lte_rnti_hash_func(gconstpointer v)
{
897
  return GPOINTER_TO_UINT(v);
898 899 900 901
}


typedef enum ContentionResolutionStatus {
902 903 904
  NoMsg3,
  Msg3Match,
  Msg3NoMatch
905 906 907
} ContentionResolutionStatus;

typedef struct ContentionResolutionResult {
908 909 910
  ContentionResolutionStatus status;
  guint                      msg3FrameNum;
  guint                      msSinceMsg3;
911 912 913 914 915 916 917 918 919 920
} ContentionResolutionResult;


/* This table stores (CRFrameNum -> CRResult).  It is assigned during the first
   pass and used thereafter */
static GHashTable *mac_lte_cr_result_hash = NULL;

/* Hash table functions for mac_lte_cr_result_hash.  Hash is just the (framenum) key */
static gint mac_lte_framenum_hash_equal(gconstpointer v, gconstpointer v2)
{
921
  return (v == v2);
922 923 924 925
}

static guint mac_lte_framenum_hash_func(gconstpointer v)
{
926
  return GPOINTER_TO_UINT(v);
927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942
}

/**************************************************************************/



/****************************************************************/
/* Keeping track of last DL frames per C-RNTI so can guess when */
/* there has been a HARQ retransmission                         */
/* TODO: this should be simplified now that harq-id & ndi are   */
/* being logged!                                                */

/* Could be bigger, but more than enough to flag suspected resends */
#define MAX_EXPECTED_PDU_LENGTH 2048

typedef struct LastFrameData {
943 944 945 946 947 948
  gboolean inUse;
  guint32  framenum;
  gboolean ndi;
  nstime_t received_time;
  gint     length;
  guint8   data[MAX_EXPECTED_PDU_LENGTH];
949 950 951
} LastFrameData;

typedef struct DLHarqBuffers {
952
  LastFrameData harqid[2][15];  /* 2 blocks (1 for each antenna) needed for DL */
953 954 955 956 957 958 959 960
} DLHarqBuffers;


/* This table stores (RNTI -> DLHARQBuffers*).  Will be populated when
   DL frames are first read.  */
static GHashTable *mac_lte_dl_harq_hash = NULL;

typedef struct DLHARQResult {
961 962 963 964 965
  gboolean    previousSet, nextSet;
  guint       previousFrameNum;
  guint       timeSincePreviousFrame;
  guint       nextFrameNum;
  guint       timeToNextFrame;
966 967 968 969 970 971 972 973 974 975 976 977 978 979 980
} DLHARQResult;


/* This table stores (FrameNumber -> *DLHARQResult).  It is assigned during the first
   pass and used thereafter */
static GHashTable *mac_lte_dl_harq_result_hash = NULL;

/**************************************************************************/


/*****************************************************************/
/* Keeping track of last UL frames per C-RNTI so can verify when */
/* told that a frame is a retx                                   */

typedef struct ULHarqBuffers {
981
  LastFrameData harqid[8];
982 983 984 985 986 987 988 989
} ULHarqBuffers;


/* This table stores (RNTI -> ULHarqBuffers*).  Will be populated when
   UL frames are first read.  */
static GHashTable *mac_lte_ul_harq_hash = NULL;

typedef struct ULHARQResult {
990 991 992 993 994
  gboolean    previousSet, nextSet;
  guint       previousFrameNum;
  guint       timeSincePreviousFrame;
  guint       nextFrameNum;
  guint       timeToNextFrame;
995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
} ULHARQResult;


/* This table stores (FrameNum -> ULHARQResult).  It is assigned during the first
   pass and used thereafter */
static GHashTable *mac_lte_ul_harq_result_hash = NULL;

/**************************************************************************/


/**************************************************************************/
/* Tracking of Scheduling Requests (SRs).                                 */
/* Keep track of:                                                         */
/* - last grant before SR                                                 */
/* - SR failures following request                                        */
/* - grant following SR                                                   */

typedef enum SREvent {
1013 1014 1015
  SR_Grant,
  SR_Request,
  SR_Failure
1016 1017
} SREvent;

1018 1019 1020 1021 1022
static const value_string sr_event_vals[] = {
  { SR_Grant,        "Grant"},
  { SR_Request,      "SR Request"},
  { SR_Failure,      "SR Failure"},
  { 0,               NULL}
1023 1024 1025
};

typedef enum SRStatus {
1026 1027 1028
  None,
  SR_Outstanding,
  SR_Failed
1029 1030
} SRStatus;

1031 1032 1033 1034 1035
static const value_string sr_status_vals[] = {
  { None,                "Receiving grants"},
  { SR_Outstanding,      "SR Request outstanding"},
  { SR_Failed,           "SR has Failed"},
  { 0,                   NULL}
1036 1037 1038 1039
};


typedef struct SRState {
1040 1041 1042 1043
  SRStatus status;
  guint32  lastSRFramenum;
  guint32  lastGrantFramenum;
  nstime_t requestTime;
1044 1045 1046 1047 1048 1049 1050 1051 1052
} SRState;


/* This table keeps track of the SR state for each UE.
   (RNTI -> SRState) */
static GHashTable *mac_lte_ue_sr_state = NULL;


typedef enum SRResultType {
1053 1054 1055 1056 1057
  GrantAnsweringSR,
  FailureAnsweringSR,
  SRLeadingToGrant,
  SRLeadingToFailure,
  InvalidSREvent
1058 1059 1060 1061
} SRResultType;


typedef struct SRResult {
1062 1063 1064
  SRResultType type;
  guint32      frameNum;
  guint32      timeDifference;
1065

1066 1067 1068
  /* These 2 are only used with InvalidSREvent */
  SRStatus     status;
  SREvent      event;
1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084
} SRResult;

/* Entries in this table are created during the first pass
   It maps (SRFrameNum -> SRResult) */
static GHashTable *mac_lte_sr_request_hash = NULL;


/**************************************************************************/



/* Forward declarations */
void proto_reg_handoff_mac_lte(void);
void dissect_mac_lte(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree);

static guint8 get_mac_lte_channel_priority(guint16 ueid _U_, guint8 lcid,
1085
    guint8 direction);
1086 1087 1088 1089 1090 1091 1092


/* Heuristic dissection */
static gboolean global_mac_lte_heur = FALSE;

static void call_with_catch_all(dissector_handle_t handle, tvbuff_t* tvb, packet_info *pinfo, proto_tree *tree)
{
1093 1094 1095 1096 1097 1098 1099
  /* Call it (catch exceptions so that stats will be updated) */
  TRY {
    call_dissector_only(handle, tvb, pinfo, tree);
  }
  CATCH_ALL {
  }
  ENDTRY
1100 1101 1102 1103 1104 1105 1106
}

/* Dissect context fields in the format described in packet-mac-lte.h.
   Return TRUE if the necessary information was successfully found */
gboolean dissect_mac_lte_context_fields(struct mac_lte_info  *p_mac_lte_info, tvbuff_t *tvb,
                                        gint *p_offset)
{
1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206
  gint    offset = *p_offset;
  guint8  tag = 0;

  /* Read fixed fields */
  p_mac_lte_info->radioType = tvb_get_guint8(tvb, offset++);
  p_mac_lte_info->direction = tvb_get_guint8(tvb, offset++);

  /* TODO: currently no support for detailed PHY info... */
  if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
    p_mac_lte_info->detailed_phy_info.ul_info.present = FALSE;
  } else {
    p_mac_lte_info->detailed_phy_info.dl_info.present = FALSE;
  }

  p_mac_lte_info->rntiType = tvb_get_guint8(tvb, offset++);

  /* Initialize RNTI with a default value in case optional field is not present */
  switch (p_mac_lte_info->rntiType) {
  case M_RNTI:
    p_mac_lte_info->rnti = 0xFFFD;
    break;

  case P_RNTI:
    p_mac_lte_info->rnti = 0xFFFE;
    break;

  case SI_RNTI:
    p_mac_lte_info->rnti = 0xFFFF;
    break;

  case RA_RNTI:
  case C_RNTI:
  case SPS_RNTI:
    p_mac_lte_info->rnti = 0x0001;
    break;

  default:
    break;
  }

  /* Read optional fields */
  while (tag != MAC_LTE_PAYLOAD_TAG) {
    /* Process next tag */
    tag = tvb_get_guint8(tvb, offset++);

    switch (tag) {
    case MAC_LTE_RNTI_TAG:
      p_mac_lte_info->rnti = tvb_get_ntohs(tvb, offset);
      offset += 2;
      break;

    case MAC_LTE_UEID_TAG:
      p_mac_lte_info->ueid = tvb_get_ntohs(tvb, offset);
      offset += 2;
      break;

    case MAC_LTE_SUBFRAME_TAG:
      p_mac_lte_info->sysframeNumber = tvb_get_ntohs(tvb, offset);
      offset += 2;
      p_mac_lte_info->subframeNumber = tvb_get_ntohs(tvb, offset);
      offset += 2;
      break;

    case MAC_LTE_PREDEFINED_DATA_TAG:
      p_mac_lte_info->isPredefinedData = tvb_get_guint8(tvb, offset);
      offset++;
      break;

    case MAC_LTE_RETX_TAG:
      p_mac_lte_info->reTxCount = tvb_get_guint8(tvb, offset);
      offset++;
      break;

    case MAC_LTE_CRC_STATUS_TAG:
      p_mac_lte_info->crcStatusValid = TRUE;
      p_mac_lte_info->detailed_phy_info.dl_info.crc_status = tvb_get_guint8(tvb, offset);
      offset++;
      break;

    case MAC_LTE_EXT_BSR_SIZES_TAG:
      p_mac_lte_info->isExtendedBSRSizes = TRUE;
      break;

    case MAC_LTE_OOB_EVENT_TAG:
      p_mac_lte_info->oob_event = tvb_get_guint8(tvb, offset);
      offset++;
      p_mac_lte_info->rapid = tvb_get_guint8(tvb, offset);
      offset++;
      p_mac_lte_info->rach_attempt_number = tvb_get_guint8(tvb, offset);
      offset++;
      break;

    case MAC_LTE_PAYLOAD_TAG:
      /* Have reached data, so set payload length and get out of loop */
      p_mac_lte_info->length= tvb_length_remaining(tvb, offset);
      continue;

    default:
      /* It must be a recognised tag */
      return FALSE;
1207
    }
1208
  }
1209

1210 1211
  /* Pass out where offset is now */
  *p_offset = offset;
1212

1213
  return TRUE;
1214 1215 1216 1217 1218 1219
}

/* Heuristic dissector looks for supported framing protocol (see wiki page)  */
static gboolean dissect_mac_lte_heur(tvbuff_t *tvb, packet_info *pinfo,
                                     proto_tree *tree)
{
1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272
  gint                 offset = 0;
  struct mac_lte_info  *p_mac_lte_info;
  tvbuff_t             *mac_tvb;
  gboolean             infoAlreadySet = FALSE;

  /* This is a heuristic dissector, which means we get all the UDP
   * traffic not sent to a known dissector and not claimed by
   * a heuristic dissector called before us!
   */

  if (!global_mac_lte_heur) {
    return FALSE;
  }

  /* Do this again on re-dissection to re-discover offset of actual PDU */

  /* Needs to be at least as long as:
     - the signature string
     - fixed header bytes
     - tag for data
     - at least one byte of MAC PDU payload */
  if ((size_t)tvb_length_remaining(tvb, offset) < (strlen(MAC_LTE_START_STRING)+3+2)) {
    return FALSE;
  }

  /* OK, compare with signature string */
  if (tvb_strneql(tvb, offset, MAC_LTE_START_STRING, strlen(MAC_LTE_START_STRING)) != 0) {
    return FALSE;
  }

  offset += (gint)strlen(MAC_LTE_START_STRING);

  /* If redissecting, use previous info struct (if available) */
  p_mac_lte_info = p_get_proto_data(pinfo->fd, proto_mac_lte);

  if (p_mac_lte_info == NULL) {
    /* Allocate new info struct for this frame */
    p_mac_lte_info = se_alloc0(sizeof(struct mac_lte_info));
    infoAlreadySet = FALSE;
  } else {
    infoAlreadySet = TRUE;
  }

  /* Dissect the fields to populate p_mac_lte */
  if (!dissect_mac_lte_context_fields(p_mac_lte_info, tvb, &offset)) {
    return FALSE;
  }


  if (!infoAlreadySet) {
    /* Store info in packet */
    p_add_proto_data(pinfo->fd, proto_mac_lte, p_mac_lte_info);
  }
1273

1274 1275
  /**************************************/
  /* OK, now dissect as MAC LTE         */
1276

1277 1278 1279
  /* Create tvb that starts at actual MAC PDU */
  mac_tvb = tvb_new_subset(tvb, offset, -1, tvb_reported_length(tvb)-offset);
  dissect_mac_lte(mac_tvb, pinfo, tree);
1280

1281
  return TRUE;
1282 1283 1284 1285 1286 1287 1288 1289 1290 1291
}


/* Write the given formatted text to:
   - the info column (if pinfo != NULL)
   - 1 or 2 other labels (optional)
*/
static void write_pdu_label_and_info(proto_item *ti1, proto_item *ti2,
                                     packet_info *pinfo, const char *format, ...)
{
1292 1293
#define MAX_INFO_BUFFER 256
  static char info_buffer[MAX_INFO_BUFFER];
1294

1295
  va_list ap;
1296

1297 1298 1299
  va_start(ap, format);
  g_vsnprintf(info_buffer, MAX_INFO_BUFFER, format, ap);
  va_end(ap);
1300

1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312
  /* Add to indicated places */
  if (pinfo != NULL) {
    col_append_str(pinfo->cinfo, COL_INFO, info_buffer);
  }

  if (ti1 != NULL) {
    proto_item_append_text(ti1, "%s", info_buffer);
  }

  if (ti2 != NULL) {
    proto_item_append_text(ti2, "%s", info_buffer);
  }
1313 1314 1315 1316 1317 1318
}

/* Show extra PHY parameters (if present) */
static void show_extra_phy_parameters(packet_info *pinfo, tvbuff_t *tvb, proto_tree *tree,
                                      struct mac_lte_info *p_mac_lte_info)
{
1319 1320 1321
  proto_item *phy_ti;
  proto_tree *phy_tree;
  proto_item *ti;
1322

1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387
  if (global_mac_lte_layer_to_show == ShowPHYLayer) {
    /* Clear the info column */
    col_clear(pinfo->cinfo, COL_INFO);
  }

  if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
    if (p_mac_lte_info->detailed_phy_info.ul_info.present) {

      /* Create root */
      phy_ti = proto_tree_add_string_format(tree, hf_mac_lte_context_phy_ul,
                                            tvb, 0, 0, "", "UL PHY Context");
      phy_tree = proto_item_add_subtree(phy_ti, ett_mac_lte_phy_context);
      PROTO_ITEM_SET_GENERATED(phy_ti);

      /* Add items */
      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_modulation_type,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.modulation_type);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_tbs_index,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.tbs_index);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_resource_block_length,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.resource_block_length);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_resource_block_start,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.resource_block_start);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_harq_id,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.harq_id);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_ul_ndi,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.ul_info.ndi);
      PROTO_ITEM_SET_GENERATED(ti);


      proto_item_append_text(phy_ti, " (");

      write_pdu_label_and_info(phy_ti, NULL,
                               (global_mac_lte_layer_to_show == ShowPHYLayer) ? pinfo : NULL,
                               "UL: UEId=%u RNTI=%u %s Tbs_Index=%u RB_len=%u RB_start=%u",
                               p_mac_lte_info->ueid,
                               p_mac_lte_info->rnti,
                               val_to_str_const(p_mac_lte_info->detailed_phy_info.ul_info.modulation_type,
                                   modulation_type_vals, "Unknown"),
                               p_mac_lte_info->detailed_phy_info.ul_info.tbs_index,
                               p_mac_lte_info->detailed_phy_info.ul_info.resource_block_length,
                               p_mac_lte_info->detailed_phy_info.ul_info.resource_block_start);

      proto_item_append_text(phy_ti, ")");

      /* Don't want columns to be replaced now */
      if (global_mac_lte_layer_to_show == ShowPHYLayer) {
        col_set_writable(pinfo->cinfo, FALSE);
      }
1388
    }
1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480
  } else {
    if (p_mac_lte_info->detailed_phy_info.dl_info.present) {

      /* Create root */
      phy_ti = proto_tree_add_string_format(tree, hf_mac_lte_context_phy_dl,
                                            tvb, 0, 0, "", "DL PHY Context");
      phy_tree = proto_item_add_subtree(phy_ti, ett_mac_lte_phy_context);
      PROTO_ITEM_SET_GENERATED(phy_ti);

      /* Add items */
      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_dci_format,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.dci_format);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_resource_allocation_type,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.resource_allocation_type);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_aggregation_level,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.aggregation_level);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_mcs_index,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.mcs_index);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_redundancy_version_index,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.redundancy_version_index);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_boolean(phy_tree, hf_mac_lte_context_phy_dl_retx,
                                  tvb, 0, 0,
                                  p_mac_lte_info->dl_retx);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_resource_block_length,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.resource_block_length);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_crc_status,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.crc_status);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_harq_id,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.harq_id);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_ndi,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.ndi);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(phy_tree, hf_mac_lte_context_phy_dl_tb,
                               tvb, 0, 0,
                               p_mac_lte_info->detailed_phy_info.dl_info.transport_block);
      PROTO_ITEM_SET_GENERATED(ti);


      proto_item_append_text(phy_ti, " (");

      write_pdu_label_and_info(phy_ti, NULL,
                               (global_mac_lte_layer_to_show == ShowPHYLayer) ? pinfo : NULL,
                               "DL: UEId=%u RNTI=%u DCI_Format=%s Res_Alloc=%u Aggr_Level=%s MCS=%u RV=%u "
                               "Res_Block_len=%u CRC_status=%s HARQ_id=%u NDI=%u",
                               p_mac_lte_info->ueid,
                               p_mac_lte_info->rnti,
                               val_to_str_const(p_mac_lte_info->detailed_phy_info.dl_info.dci_format,
                                   dci_format_vals, "Unknown"),
                               p_mac_lte_info->detailed_phy_info.dl_info.resource_allocation_type,
                               val_to_str_const(p_mac_lte_info->detailed_phy_info.dl_info.aggregation_level,
                                   aggregation_level_vals, "Unknown"),
                               p_mac_lte_info->detailed_phy_info.dl_info.mcs_index,
                               p_mac_lte_info->detailed_phy_info.dl_info.redundancy_version_index,
                               p_mac_lte_info->detailed_phy_info.dl_info.resource_block_length,
                               val_to_str_const(p_mac_lte_info->detailed_phy_info.dl_info.crc_status,
                                   crc_status_vals, "Unknown"),
                               p_mac_lte_info->detailed_phy_info.dl_info.harq_id,
                               p_mac_lte_info->detailed_phy_info.dl_info.ndi);
      proto_item_append_text(phy_ti, ")");

      /* Don't want columns to be replaced now */
      if (global_mac_lte_layer_to_show == ShowPHYLayer) {
        col_set_writable(pinfo->cinfo, FALSE);
      }
1481
    }
1482
  }
1483 1484 1485 1486 1487 1488 1489 1490
}


/* Dissect a single Random Access Reponse body */
static gint dissect_rar_entry(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                              proto_item *pdu_ti,
                              gint offset, guint8 rapid)
{
1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575
  guint8      reserved;
  guint       start_body_offset = offset;
  proto_item *ti;
  proto_item *rar_body_ti;
  proto_tree *rar_body_tree;
  proto_tree *ul_grant_tree;
  proto_item *ul_grant_ti;
  guint16     timing_advance;
  guint32     ul_grant;
  guint16     temp_crnti;

  /* Create tree for this Body */
  rar_body_ti = proto_tree_add_item(tree,
                                    hf_mac_lte_rar_body,
                                    tvb, offset, 0, ENC_ASCII|ENC_NA);
  rar_body_tree = proto_item_add_subtree(rar_body_ti, ett_mac_lte_rar_body);

  /* Dissect an RAR entry */

  /* Check reserved bit */
  reserved = (tvb_get_guint8(tvb, offset) & 0x80) >> 7;
  ti = proto_tree_add_item(rar_body_tree, hf_mac_lte_rar_reserved2, tvb, offset, 1, ENC_BIG_ENDIAN);

  if (reserved != 0) {
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "RAR body Reserved bit not zero (found 0x%x)", reserved);
  }

  /* Timing Advance */
  timing_advance = (tvb_get_ntohs(tvb, offset) & 0x7ff0) >> 4;
  ti = proto_tree_add_item(rar_body_tree, hf_mac_lte_rar_ta, tvb, offset, 2, ENC_BIG_ENDIAN);

  if (timing_advance != 0) {
    expert_add_info_format(pinfo, ti, PI_SEQUENCE, (timing_advance <= 31) ? PI_NOTE : PI_WARN,
                           "RAR Timing advance not zero (%u)", timing_advance);
  }

  offset++;

  /* UL Grant */
  ul_grant = (tvb_get_ntohl(tvb, offset) & 0x0fffff00) >> 8;
  ul_grant_ti = proto_tree_add_item(rar_body_tree, hf_mac_lte_rar_ul_grant, tvb, offset, 3, ENC_BIG_ENDIAN);

  /* Break these 20 bits down as described in 36.213, section 6.2 */
  /* Create subtree for UL grant break-down */
  ul_grant_tree = proto_item_add_subtree(ul_grant_ti, ett_mac_lte_rar_ul_grant);

  /* Hopping flag (1 bit) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_hopping,
                      tvb, offset, 1, ENC_BIG_ENDIAN);

  /* Fixed sized resource block assignment (10 bits) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_fsrba,
                      tvb, offset, 2, ENC_BIG_ENDIAN);

  /* Truncated Modulation and coding scheme (4 bits) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_tmcs,
                      tvb, offset+1, 2, ENC_BIG_ENDIAN);

  /* TPC command for scheduled PUSCH (3 bits) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_tcsp,
                      tvb, offset+2, 1, ENC_BIG_ENDIAN);

  /* UL delay (1 bit) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_ul_delay,
                      tvb, offset+2, 1, ENC_BIG_ENDIAN);

  /* CQI request (1 bit) */
  proto_tree_add_item(ul_grant_tree, hf_mac_lte_rar_ul_grant_cqi_request,
                      tvb, offset+2, 1, ENC_BIG_ENDIAN);

  offset += 3;

  /* Temporary C-RNTI */
  temp_crnti = tvb_get_ntohs(tvb, offset);
  proto_tree_add_item(rar_body_tree, hf_mac_lte_rar_temporary_crnti, tvb, offset, 2, ENC_BIG_ENDIAN);
  offset += 2;

  write_pdu_label_and_info(pdu_ti, rar_body_ti, pinfo,
                           "(RAPID=%u: TA=%u, UL-Grant=%u, Temp C-RNTI=%u) ",
                           rapid, timing_advance, ul_grant, temp_crnti);

  proto_item_set_len(rar_body_ti, offset-start_body_offset);

  return offset;
1576 1577 1578 1579 1580 1581 1582 1583
}


#define MAX_RAR_PDUS 64
/* Dissect Random Access Reponse (RAR) PDU */
static void dissect_rar(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, proto_item *pdu_ti,
                        gint offset, mac_lte_info *p_mac_lte_info, mac_lte_tap_info *tap_info)
{
1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664
  gint        number_of_rars         = 0; /* No of RAR bodies expected following headers */
  guint8     *rapids                 = ep_alloc(MAX_RAR_PDUS * sizeof(guint8));
  gboolean    backoff_indicator_seen = FALSE;
  guint8      backoff_indicator      = 0;
  guint8      extension;
  gint        n;
  proto_tree *rar_headers_tree;
  proto_item *ti;
  proto_item *rar_headers_ti;
  proto_item *padding_length_ti;
  int         start_headers_offset   = offset;

  write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                           "RAR (RA-RNTI=%u, SF=%u) ",
                           p_mac_lte_info->rnti, p_mac_lte_info->subframeNumber);

  /* Create hidden 'virtual root' so can filter on mac-lte.rar */
  ti = proto_tree_add_item(tree, hf_mac_lte_rar, tvb, offset, -1, ENC_NA);
  PROTO_ITEM_SET_HIDDEN(ti);

  /* Create headers tree */
  rar_headers_ti = proto_tree_add_item(tree,
                                       hf_mac_lte_rar_headers,
                                       tvb, offset, 0, ENC_ASCII|ENC_NA);
  rar_headers_tree = proto_item_add_subtree(rar_headers_ti, ett_mac_lte_rar_headers);


  /***************************/
  /* Read the header entries */
  do {
    int start_header_offset = offset;
    proto_tree *rar_header_tree;
    proto_item *rar_header_ti;
    guint8 type_value;
    guint8 first_byte = tvb_get_guint8(tvb, offset);

    /* Create tree for this header */
    rar_header_ti = proto_tree_add_item(rar_headers_tree,
                                        hf_mac_lte_rar_header,
                                        tvb, offset, 0, ENC_ASCII|ENC_NA);
    rar_header_tree = proto_item_add_subtree(rar_header_ti, ett_mac_lte_rar_header);

    /* Extension */
    extension = (first_byte & 0x80) >> 7;
    proto_tree_add_item(rar_header_tree, hf_mac_lte_rar_extension, tvb, offset, 1, ENC_BIG_ENDIAN);

    /* Type */
    type_value = (first_byte & 0x40) >> 6;
    proto_tree_add_item(rar_header_tree, hf_mac_lte_rar_t, tvb, offset, 1, ENC_BIG_ENDIAN);

    if (type_value == 0) {
      /* Backoff Indicator (BI) case */

      guint8 reserved;
      proto_item *tii;
      proto_item *bi_ti;

      /* 2 Reserved bits */
      reserved = (tvb_get_guint8(tvb, offset) & 0x30) >> 4;
      tii = proto_tree_add_item(rar_header_tree, hf_mac_lte_rar_reserved, tvb, offset, 1, ENC_BIG_ENDIAN);

      if (reserved != 0) {
        expert_add_info_format(pinfo, tii, PI_MALFORMED, PI_ERROR,
                               "RAR header Reserved bits not zero (found 0x%x)", reserved);
      }

      /* Backoff Indicator */
      backoff_indicator = tvb_get_guint8(tvb, offset) & 0x0f;
      bi_ti = proto_tree_add_item(rar_header_tree, hf_mac_lte_rar_bi, tvb, offset, 1, ENC_BIG_ENDIAN);

      /* As of March 2009 spec, it must be first, and may only appear once */
      if (backoff_indicator_seen) {
        expert_add_info_format(pinfo, bi_ti, PI_MALFORMED, PI_ERROR,
                               "MAC RAR PDU has > 1 Backoff Indicator subheader present");
      }

      backoff_indicator_seen = TRUE;

      write_pdu_label_and_info(pdu_ti, rar_header_ti, pinfo,
                               "(Backoff Indicator=%sms)",
                               val_to_str_const(backoff_indicator, rar_bi_vals, "Illegal-value "));
1665

1666 1667 1668 1669 1670
      /* If present, it must be the first subheader */
      if (number_of_rars > 0) {
        expert_add_info_format(pinfo, bi_ti, PI_MALFORMED, PI_WARN,
                               "Backoff Indicator must appear as first subheader");
      }
1671

1672 1673 1674 1675 1676
    } else {
      /* RAPID case */
      /* TODO: complain if the same RAPID appears twice in same frame? */
      rapids[number_of_rars] = tvb_get_guint8(tvb, offset) & 0x3f;
      proto_tree_add_item(rar_header_tree, hf_mac_lte_rar_rapid, tvb, offset, 1, ENC_BIG_ENDIAN);
1677

1678
      proto_item_append_text(rar_header_ti, "(RAPID=%u)", rapids[number_of_rars]);
1679

1680 1681
      number_of_rars++;
    }
1682

1683
    offset++;
1684

1685 1686
    /* Finalise length of header tree selection */
    proto_item_set_len(rar_header_ti, offset - start_header_offset);
1687

1688
  } while (extension && number_of_rars < MAX_RAR_PDUS);
1689

1690 1691
  /* Append summary to headers root */
  proto_item_append_text(rar_headers_ti, " (%u RARs", number_of_rars);
1692

1693 1694 1695 1696 1697 1698
  if (backoff_indicator_seen) {
    proto_item_append_text(rar_headers_ti, ", BI=%sms)",
                           val_to_str_const(backoff_indicator, rar_bi_vals, "Illegal-value "));
  } else {
    proto_item_append_text(rar_headers_ti, ")");
  }
1699

1700 1701
  /* Set length for headers root */
  proto_item_set_len(rar_headers_ti, offset-start_headers_offset);
1702 1703


1704 1705 1706 1707 1708
  /***************************/
  /* Read any indicated RARs */
  for (n=0; n < number_of_rars; n++) {
    offset = dissect_rar_entry(tvb, pinfo, tree, pdu_ti, offset, rapids[n]);
  }
1709

1710 1711
  /* Update TAP info */
  tap_info->number_of_rars += number_of_rars;
1712

1713 1714 1715 1716 1717
  /* Padding may follow */
  if (tvb_length_remaining(tvb, offset) > 0) {
    proto_tree_add_item(tree, hf_mac_lte_padding_data,
                        tvb, offset, -1, ENC_NA);
  }
1718

1719 1720 1721 1722
  padding_length_ti = proto_tree_add_int(tree, hf_mac_lte_padding_length,
                                         tvb, offset, 0,
                                         p_mac_lte_info->length - offset);
  PROTO_ITEM_SET_GENERATED(padding_length_ti);
1723

1724 1725
  /* Update padding bytes in stats */
  tap_info->padding_bytes += (p_mac_lte_info->length - offset);
1726 1727 1728 1729 1730 1731 1732 1733
}


/* Dissect BCH PDU */
static void dissect_bch(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        proto_item *pdu_ti,
                        int offset, mac_lte_info *p_mac_lte_info)
{
1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766
  proto_item *ti;

  write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                           "BCH PDU (%u bytes, on %s transport)  ",
                           tvb_length_remaining(tvb, offset),
                           val_to_str_const(p_mac_lte_info->rntiType,
                               bch_transport_channel_vals,
                               "Unknown"));

  /* Show which transport layer it came in on (inferred from RNTI type) */
  ti = proto_tree_add_uint(tree, hf_mac_lte_context_bch_transport_channel,
                           tvb, offset, 0, p_mac_lte_info->rntiType);
  PROTO_ITEM_SET_GENERATED(ti);

  /****************************************/
  /* Whole frame is BCH data              */

  /* Raw data */
  ti = proto_tree_add_item(tree, hf_mac_lte_bch_pdu,
                           tvb, offset, -1, ENC_NA);

  if (global_mac_lte_attempt_rrc_decode) {
    /* Attempt to decode payload using LTE RRC dissector */
    tvbuff_t *rrc_tvb = tvb_new_subset(tvb, offset, -1, tvb_length_remaining(tvb, offset));

    /* Get appropriate dissector handle */
    dissector_handle_t protocol_handle = 0;

    if (p_mac_lte_info->rntiType == SI_RNTI) {
      protocol_handle = find_dissector("lte_rrc.bcch_dl_sch");
    } else {
      protocol_handle = find_dissector("lte_rrc.bcch_bch");
    }
1767

1768 1769
    /* Hide raw view of bytes */
    PROTO_ITEM_SET_HIDDEN(ti);
1770

1771 1772
    call_with_catch_all(protocol_handle, rrc_tvb, pinfo, tree);
  }
1773

1774 1775 1776 1777 1778
  /* Check that this *is* downlink! */
  if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "BCH data should not be received in Uplink!");
  }
1779 1780 1781 1782 1783 1784 1785
}


/* Dissect PCH PDU */
static void dissect_pch(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                        proto_item *pdu_ti, int offset, guint8 direction)
{
1786
  proto_item *ti;
1787

1788 1789 1790
  write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                           "PCH PDU (%u bytes)  ",
                           tvb_length_remaining(tvb, offset));
1791

1792 1793
  /****************************************/
  /* Whole frame is PCH data              */
1794

1795 1796 1797
  /* Always show as raw data */
  ti = proto_tree_add_item(tree, hf_mac_lte_pch_pdu,
                           tvb, offset, -1, ENC_NA);
1798

1799
  if (global_mac_lte_attempt_rrc_decode) {
1800

1801 1802
    /* Attempt to decode payload using LTE RRC dissector */
    tvbuff_t *rrc_tvb = tvb_new_subset(tvb, offset, -1, tvb_length_remaining(tvb, offset));
1803

1804 1805
    /* Get appropriate dissector handle */
    dissector_handle_t protocol_handle = find_dissector("lte-rrc.pcch");
1806

1807 1808
    /* Hide raw view of bytes */
    PROTO_ITEM_SET_HIDDEN(ti);
1809

1810 1811 1812
    /* Call it (catch exceptions so that stats will be updated) */
    TRY {
      call_dissector_only(protocol_handle, rrc_tvb, pinfo, tree);
1813
    }
1814
    CATCH_ALL {
1815
    }
1816 1817 1818 1819 1820 1821 1822 1823
    ENDTRY
  }

  /* Check that this *is* downlink! */
  if (direction == DIRECTION_UPLINK) {
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "PCH data should not be received in Uplink!");
  }
1824 1825 1826 1827 1828 1829
}


/* Does this header entry correspond to a fixed-sized control element? */
static int is_fixed_sized_control_element(guint8 lcid, guint8 direction)
{
1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841
  if (direction == DIRECTION_UPLINK) {
    /* Uplink */
    switch (lcid) {
    case POWER_HEADROOM_REPORT_LCID:
    case CRNTI_LCID:
    case TRUNCATED_BSR_LCID:
    case SHORT_BSR_LCID:
    case LONG_BSR_LCID:
      return TRUE;

    default:
      return FALSE;
1842
    }
1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853
  } else {
    /* Assume Downlink */
    switch (lcid) {
    case ACTIVATION_DEACTIVATION_LCID:
    case UE_CONTENTION_RESOLUTION_IDENTITY_LCID:
    case TIMING_ADVANCE_LCID:
    case DRX_COMMAND_LCID:
      return TRUE;

    default:
      return FALSE;
1854
    }
1855
  }
1856 1857 1858 1859 1860 1861
}


/* Is this a BSR report header? */
static int is_bsr_lcid(guint8 lcid)
{
1862 1863 1864
  return ((lcid == TRUNCATED_BSR_LCID) ||
          (lcid == SHORT_BSR_LCID) ||
          (lcid == LONG_BSR_LCID));
1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876
}


/* Helper function to call RLC dissector for SDUs (where channel params are known) */
static void call_rlc_dissector(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                               proto_item *pdu_ti,
                               int offset, guint16 data_length,
                               guint8 mode, guint8 direction, guint16 ueid,
                               guint16 channelType, guint16 channelId,
                               guint8 UMSequenceNumberLength,
                               guint8 priority)
{
1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913
  tvbuff_t            *srb_tvb = tvb_new_subset(tvb, offset, data_length, data_length);
  struct rlc_lte_info *p_rlc_lte_info;

  /* Get RLC dissector handle */
  volatile dissector_handle_t protocol_handle = find_dissector("rlc-lte");

  /* Resuse or create RLC info */
  p_rlc_lte_info = p_get_proto_data(pinfo->fd, proto_rlc_lte);

  if (p_rlc_lte_info == NULL) {
    p_rlc_lte_info = se_alloc0(sizeof(struct rlc_lte_info));
  }

  /* Fill in struct details for srb channels */
  p_rlc_lte_info->rlcMode = mode;
  p_rlc_lte_info->direction = direction;
  p_rlc_lte_info->priority = priority;
  p_rlc_lte_info->ueid = ueid;
  p_rlc_lte_info->channelType = channelType;
  p_rlc_lte_info->channelId = channelId;
  p_rlc_lte_info->pduLength = data_length;
  p_rlc_lte_info->UMSequenceNumberLength = UMSequenceNumberLength;

  /* Store info in packet */
  p_add_proto_data(pinfo->fd, proto_rlc_lte, p_rlc_lte_info);

  if (global_mac_lte_layer_to_show != ShowRLCLayer) {
    /* Don't want these columns replaced */
    col_set_writable(pinfo->cinfo, FALSE);
  } else {
    /* Clear info column before first RLC PDU */
    if (s_number_of_rlc_pdus_shown == 0) {
      col_clear(pinfo->cinfo, COL_INFO);
    } else {
      /* Add a separator and protect column contents here */
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, "   ||   ");
      col_set_fence(pinfo->cinfo, COL_INFO);
1914
    }
1915
  }
1916

1917
  s_number_of_rlc_pdus_shown++;
1918

1919 1920 1921 1922 1923 1924 1925
  /* Call it (catch exceptions so that stats will be updated) */
  TRY {
    call_dissector_only(protocol_handle, srb_tvb, pinfo, tree);
  }
  CATCH_ALL {
  }
  ENDTRY
1926

1927 1928
  /* Let columns be written to again */
  col_set_writable(pinfo->cinfo, TRUE);
1929 1930 1931 1932 1933 1934 1935
}


/* For DL frames, look for previous Tx. Add link back if found */
static void TrackReportedDLHARQResend(packet_info *pinfo, tvbuff_t *tvb, volatile int length,
                                      proto_tree *tree, mac_lte_info *p_mac_lte_info)
{
1936 1937
  DLHARQResult *result = NULL;
  DLHARQResult *original_result = NULL;
1938

1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959
  /* If don't have detailed DL PHy info, just give up */
  if (!p_mac_lte_info->detailed_phy_info.dl_info.present) {
    return;
  }

  /* TDD may not work... */

  if (!pinfo->fd->flags.visited) {
    /* First time, so set result and update DL harq table */
    LastFrameData *lastData = NULL;
    LastFrameData *thisData = NULL;

    DLHarqBuffers *ueData;

    /* Read these for convenience */
    guint8 harq_id = p_mac_lte_info->detailed_phy_info.dl_info.harq_id;
    guint8 transport_block = p_mac_lte_info->detailed_phy_info.dl_info.transport_block;

    /* Check harq-id bounds, give up if invalid */
    if ((harq_id >= 15) || (transport_block+1 > 2)) {
      return;
1960 1961
    }

1962 1963
    /* Look up entry for this UE/RNTI */
    ueData = g_hash_table_lookup(mac_lte_dl_harq_hash, GUINT_TO_POINTER((guint)p_mac_lte_info->rnti));
1964

1965 1966 1967
    if (ueData != NULL) {
      /* Get previous info for this harq-id */
      lastData = &(ueData->harqid[transport_block][harq_id]);
1968

1969 1970 1971 1972 1973
      if (lastData->inUse) {
        /* Compare time difference, ndi, data to see if this looks like a retx */
        if ((length == lastData->length) &&
            (p_mac_lte_info->detailed_phy_info.dl_info.ndi == lastData->ndi) &&
            tvb_memeql(tvb, 0, lastData->data, MIN(lastData->length, MAX_EXPECTED_PDU_LENGTH)) == 0) {
1974

1975 1976 1977 1978 1979
          /* Work out gap between frames */
          gint seconds_between_packets = (gint)
                                         (pinfo->fd->abs_ts.secs - lastData->received_time.secs);
          gint nseconds_between_packets =
            pinfo->fd->abs_ts.nsecs - lastData->received_time.nsecs;
1980

1981 1982 1983
          /* Round difference to nearest millisecond */
          gint total_gap = (seconds_between_packets*1000) +
                           ((nseconds_between_packets+500000) / 1000000);
1984

1985 1986
          /* Expect to be within (say) 8-13 subframes since previous */
          if ((total_gap >= 8) && (total_gap <= 13)) {
1987

1988 1989 1990 1991 1992 1993
            /* Resend detected! Store result pointing back. */
            result = se_alloc0(sizeof(DLHARQResult));
            result->previousSet = TRUE;
            result->previousFrameNum = lastData->framenum;
            result->timeSincePreviousFrame = total_gap;
            g_hash_table_insert(mac_lte_dl_harq_result_hash, GUINT_TO_POINTER(pinfo->fd->num), result);
1994

1995 1996
            /* Now make previous frame point forward to here */
            original_result = g_hash_table_lookup(mac_lte_dl_harq_result_hash, GUINT_TO_POINTER(lastData->framenum));
1997

1998 1999 2000 2001 2002 2003 2004 2005 2006
            if (original_result == NULL) {
              original_result = se_alloc0(sizeof(ULHARQResult));
              g_hash_table_insert(mac_lte_dl_harq_result_hash, GUINT_TO_POINTER(lastData->framenum), original_result);
            }

            original_result->nextSet = TRUE;
            original_result->nextFrameNum = pinfo->fd->num;
            original_result->timeToNextFrame = total_gap;
          }
2007
        }
2008 2009 2010 2011 2012 2013
      }
    } else {
      /* Allocate entry in table for this UE/RNTI */
      ueData = se_alloc0(sizeof(DLHarqBuffers));
      g_hash_table_insert(mac_lte_dl_harq_hash, GUINT_TO_POINTER((guint)p_mac_lte_info->rnti), ueData);
    }
2014

2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041
    /* Store this frame's details in table */
    thisData = &(ueData->harqid[transport_block][harq_id]);
    thisData->inUse = TRUE;
    thisData->length = length;
    tvb_memcpy(tvb, thisData->data, 0, MIN(thisData->length, MAX_EXPECTED_PDU_LENGTH));
    thisData->ndi = p_mac_lte_info->detailed_phy_info.dl_info.ndi;
    thisData->framenum = pinfo->fd->num;
    thisData->received_time = pinfo->fd->abs_ts;
  } else {
    /* Not first time, so just set whats already stored in result */
    result = g_hash_table_lookup(mac_lte_dl_harq_result_hash, GUINT_TO_POINTER(pinfo->fd->num));
  }


  /***************************************************/
  /* Show link back to original frame (if available) */
  if (result != NULL) {
    if (result->previousSet) {
      proto_item *gap_ti;
      proto_item *original_ti = proto_tree_add_uint(tree, hf_mac_lte_dl_harq_resend_original_frame,
                                tvb, 0, 0, result->previousFrameNum);
      PROTO_ITEM_SET_GENERATED(original_ti);

      gap_ti = proto_tree_add_uint(tree, hf_mac_lte_dl_harq_resend_time_since_previous_frame,
                                   tvb, 0, 0, result->timeSincePreviousFrame);
      PROTO_ITEM_SET_GENERATED(gap_ti);
    }
2042

2043 2044 2045 2046 2047
    if (result->nextSet) {
      proto_item *gap_ti;
      proto_item *next_ti = proto_tree_add_uint(tree, hf_mac_lte_dl_harq_resend_next_frame,
                            tvb, 0, 0, result->nextFrameNum);
      PROTO_ITEM_SET_GENERATED(next_ti);
2048

2049 2050 2051
      gap_ti = proto_tree_add_uint(tree, hf_mac_lte_dl_harq_resend_time_until_next_frame,
                                   tvb, 0, 0, result->timeToNextFrame);
      PROTO_ITEM_SET_GENERATED(gap_ti);
2052
    }
2053 2054

  }
2055 2056 2057 2058 2059 2060
}


/* Return TRUE if the given packet is thought to be a retx */
int is_mac_lte_frame_retx(packet_info *pinfo, guint8 direction)
{
2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073
  struct mac_lte_info *p_mac_lte_info = p_get_proto_data(pinfo->fd, proto_mac_lte);

  if (direction == DIRECTION_UPLINK) {
    /* For UL, retx count is stored in per-packet struct */
    return ((p_mac_lte_info != NULL) && (p_mac_lte_info->reTxCount > 0));
  } else {
    /* Use answer if told directly */
    if (p_mac_lte_info->dl_retx == dl_retx_yes) {
      return TRUE;
    } else {
      /* Otherwise look up in table */
      DLHARQResult *result = g_hash_table_lookup(mac_lte_dl_harq_result_hash, GUINT_TO_POINTER(pinfo->fd->num));
      return ((result != NULL) && result->previousSet);
2074
    }
2075
  }
2076 2077 2078 2079 2080 2081 2082 2083 2084 2085
}


/* Track UL frames, so that when a retx is indicated, we can search for
   the original tx.  We will either find it, and provide a link back to it,
   or flag that we couldn't find as an expert error */
static void TrackReportedULHARQResend(packet_info *pinfo, tvbuff_t *tvb, volatile int offset,
                                      proto_tree *tree, mac_lte_info *p_mac_lte_info,
                                      proto_item *retx_ti)
{
2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152
  ULHARQResult *result = NULL;

  /* If don't have detailed DL PHY info, just give up */
  if (!p_mac_lte_info->detailed_phy_info.ul_info.present) {
    return;
  }

  /* Give up if harqid is out of range */
  if (p_mac_lte_info->detailed_phy_info.ul_info.harq_id >= 8) {
    return;
  }

  if (!pinfo->fd->flags.visited) {
    /* First time, so set result and update UL harq table */
    LastFrameData *lastData = NULL;
    LastFrameData *thisData = NULL;

    /* Look up entry for this UE/RNTI */
    ULHarqBuffers *ueData =
      g_hash_table_lookup(mac_lte_ul_harq_hash, GUINT_TO_POINTER((guint)p_mac_lte_info->rnti));

    if (ueData != NULL) {
      if (p_mac_lte_info->reTxCount >= 1) {
        /* Looking for frame previously on this harq-id */
        lastData = &(ueData->harqid[p_mac_lte_info->detailed_phy_info.ul_info.harq_id]);

        if (lastData->inUse) {
          /* Compare time, sf, data to see if this looks like a retx */
          if ((tvb_length_remaining(tvb, offset) == lastData->length) &&
              (p_mac_lte_info->detailed_phy_info.ul_info.ndi == lastData->ndi) &&
              tvb_memeql(tvb, offset, lastData->data, MIN(lastData->length, MAX_EXPECTED_PDU_LENGTH)) == 0) {

            /* Work out gap between frames */
            gint seconds_between_packets = (gint)
                                           (pinfo->fd->abs_ts.secs - lastData->received_time.secs);
            gint nseconds_between_packets =
              pinfo->fd->abs_ts.nsecs - lastData->received_time.nsecs;

            /* Round to nearest ms */
            gint total_gap = (seconds_between_packets*1000) +
                             ((nseconds_between_packets+500000) / 1000000);

            /* Could be as many as max-tx (which we don't know) * 8ms ago.
               32 is the most I've seen... */
            if (total_gap <= 33) {
              ULHARQResult *original_result = NULL;

              /* Original detected!!! Store result pointing back */
              result = se_alloc0(sizeof(ULHARQResult));
              result->previousSet = TRUE;
              result->previousFrameNum = lastData->framenum;
              result->timeSincePreviousFrame = total_gap;
              g_hash_table_insert(mac_lte_ul_harq_result_hash, GUINT_TO_POINTER(pinfo->fd->num), result);

              /* Now make previous frame point forward to here */
              original_result = g_hash_table_lookup(mac_lte_ul_harq_result_hash, GUINT_TO_POINTER(lastData->framenum));

              if (original_result == NULL) {
                original_result = se_alloc0(sizeof(ULHARQResult));
                g_hash_table_insert(mac_lte_ul_harq_result_hash, GUINT_TO_POINTER(lastData->framenum), original_result);
              }

              original_result->nextSet = TRUE;
              original_result->nextFrameNum = pinfo->fd->num;
              original_result->timeToNextFrame = total_gap;
            }
          }
2153
        }
2154 2155 2156 2157 2158
      }
    } else {
      /* Allocate entry in table for this UE/RNTI */
      ueData = se_alloc0(sizeof(ULHarqBuffers));
      g_hash_table_insert(mac_lte_ul_harq_hash, GUINT_TO_POINTER((guint)p_mac_lte_info->rnti), ueData);
2159 2160
    }

2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178
    /* Store this frame's details in table */
    thisData = &(ueData->harqid[p_mac_lte_info->detailed_phy_info.ul_info.harq_id]);
    thisData->inUse = TRUE;
    thisData->length = tvb_length_remaining(tvb, offset);
    tvb_memcpy(tvb, thisData->data, offset, MIN(thisData->length, MAX_EXPECTED_PDU_LENGTH));
    thisData->ndi = p_mac_lte_info->detailed_phy_info.ul_info.ndi;
    thisData->framenum = pinfo->fd->num;
    thisData->received_time = pinfo->fd->abs_ts;
  } else {
    /* Not first time, so just get whats already stored in result */
    result = g_hash_table_lookup(mac_lte_ul_harq_result_hash, GUINT_TO_POINTER(pinfo->fd->num));
  }

  /* Show any link back to previous Tx */
  if (retx_ti != NULL) {
    if (result != NULL) {
      if (result->previousSet) {
        proto_item *original_ti, *gap_ti;
2179

2180 2181 2182
        original_ti = proto_tree_add_uint(tree, hf_mac_lte_ul_harq_resend_original_frame,
                                          tvb, 0, 0, result->previousFrameNum);
        PROTO_ITEM_SET_GENERATED(original_ti);
2183

2184 2185 2186 2187 2188 2189 2190
        gap_ti = proto_tree_add_uint(tree, hf_mac_lte_ul_harq_resend_time_since_previous_frame,
                                     tvb, 0, 0, result->timeSincePreviousFrame);
        PROTO_ITEM_SET_GENERATED(gap_ti);
      }
    } else {
      expert_add_info_format(pinfo, retx_ti, PI_SEQUENCE, PI_ERROR,
                             "Original Tx of UL frame not found (UE %u) !!", p_mac_lte_info->ueid);
2191
    }
2192
  }
2193

2194 2195 2196
  /* Show link forward to any known next Tx */
  if ((result != NULL) && result->nextSet) {
    proto_item *next_ti, *gap_ti;
2197

2198 2199 2200 2201
    next_ti = proto_tree_add_uint(tree, hf_mac_lte_ul_harq_resend_next_frame,
                                  tvb, 0, 0, result->nextFrameNum);
    expert_add_info_format(pinfo, next_ti, PI_SEQUENCE, PI_WARN,
                           "UL MAC PDU (UE %u) needed to be retransmitted", p_mac_lte_info->ueid);
2202

2203
    PROTO_ITEM_SET_GENERATED(next_ti);
2204

2205 2206 2207 2208
    gap_ti = proto_tree_add_uint(tree, hf_mac_lte_ul_harq_resend_time_until_next_frame,
                                 tvb, 0, 0, result->timeToNextFrame);
    PROTO_ITEM_SET_GENERATED(gap_ti);
  }
2209 2210 2211 2212 2213 2214 2215
}


/* Look up SRResult associated with a given frame. Will create one if necessary
   if can_create is set */
static SRResult *GetSRResult(guint32 frameNum, gboolean can_create)
{
2216 2217
  SRResult *result;
  result = g_hash_table_lookup(mac_lte_sr_request_hash, GUINT_TO_POINTER(frameNum));
2218

2219 2220 2221 2222 2223 2224
  if ((result == NULL) && can_create) {
    result = se_alloc0(sizeof(SRResult));
    g_hash_table_insert(mac_lte_sr_request_hash, GUINT_TO_POINTER((guint)frameNum), result);
  }

  return result;
2225 2226 2227 2228 2229 2230 2231 2232
}


/* Keep track of SR requests, failures and related grants, in order to show them
   as generated fields in these frames */
static void TrackSRInfo(SREvent event, packet_info *pinfo, proto_tree *tree,
                        tvbuff_t *tvb, mac_lte_info *p_mac_lte_info, gint idx, proto_item *event_ti)
{
2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264
  SRResult   *result           = NULL;
  SRState    *state;
  SRResult   *resultForSRFrame = NULL;

  guint16     rnti;
  guint16     ueid;
  proto_item *ti;

  /* Get appropriate identifiers */
  if (event == SR_Request) {
    rnti = p_mac_lte_info->oob_rnti[idx];
    ueid = p_mac_lte_info->oob_ueid[idx];
  } else {
    rnti = p_mac_lte_info->rnti;
    ueid = p_mac_lte_info->ueid;
  }

  /* Create state for this RNTI if necessary */
  state = g_hash_table_lookup(mac_lte_ue_sr_state, GUINT_TO_POINTER((guint)rnti));

  if (state == NULL) {
    /* Allocate status for this RNTI */
    state = se_alloc(sizeof(SRState));
    state->status = None;
    g_hash_table_insert(mac_lte_ue_sr_state, GUINT_TO_POINTER((guint)rnti), state);
  }

  /* First time through - update state with new info */
  if (!pinfo->fd->flags.visited) {
    guint32 timeSinceRequest;

    /* Store time of request */
2265
    if (event == SR_Request) {
2266
      state->requestTime = pinfo->fd->abs_ts;
2267 2268
    }

2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306
    switch (state->status) {
    case None:
      switch (event) {
      case SR_Grant:
        /* Got another grant - fine */

        /* update state */
        state->lastGrantFramenum = pinfo->fd->num;
        break;

      case SR_Request:
        /* Sent an SR - fine */

        /* Update state */
        state->status = SR_Outstanding;
        state->lastSRFramenum = pinfo->fd->num;
        break;

      case SR_Failure:
        /* This is an error, since we hadn't send an SR... */
        result = GetSRResult(pinfo->fd->num, TRUE);
        result->type = InvalidSREvent;
        result->status = None;
        result->event = SR_Failure;
        break;
      }

      break;

    case SR_Outstanding:
      timeSinceRequest = (guint32)(((pinfo->fd->abs_ts.secs - state->requestTime.secs) * 1000) +
                                   ((pinfo->fd->abs_ts.nsecs - state->requestTime.nsecs) / 1000000));

      switch (event) {
      case SR_Grant:
        /* Got grant we were waiting for, so state goes to None */

        /* Update state */
2307 2308
        state->status = None;

2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359
        /* Set result info */
        result = GetSRResult(pinfo->fd->num, TRUE);
        result->type = GrantAnsweringSR;
        result->frameNum = state->lastSRFramenum;
        result->timeDifference = timeSinceRequest;

        /* Also set forward link for SR */
        resultForSRFrame = GetSRResult(state->lastSRFramenum, TRUE);
        resultForSRFrame->type = SRLeadingToGrant;
        resultForSRFrame->frameNum = pinfo->fd->num;
        resultForSRFrame->timeDifference = timeSinceRequest;
        break;

      case SR_Request:
        /* Another request when already have one pending */
        result = GetSRResult(pinfo->fd->num, TRUE);
        result->type = InvalidSREvent;
        result->status = SR_Outstanding;
        result->event = SR_Request;
        break;

      case SR_Failure:
        /* We sent an SR but it failed */

        /* Update state */
        state->status = SR_Failed;

        /* Set result info for failure frame */
        result = GetSRResult(pinfo->fd->num, TRUE);
        result->type = FailureAnsweringSR;
        result->frameNum = state->lastSRFramenum;
        result->timeDifference = timeSinceRequest;

        /* Also set forward link for SR */
        resultForSRFrame = GetSRResult(state->lastSRFramenum, TRUE);
        resultForSRFrame->type = SRLeadingToFailure;
        resultForSRFrame->frameNum = pinfo->fd->num;
        resultForSRFrame->timeDifference = timeSinceRequest;
        break;
      }

      break;

    case SR_Failed:
      switch (event) {
      case SR_Grant:
        /* Got a grant, presumably after a subsequent RACH - fine */

        /* Update state */
        state->status = None;
        break;
2360

2361 2362 2363
      case SR_Request:
        /* Tried another SR after previous one failed.
           Presumably a subsequent RACH was tried in-between... */
2364

2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381
        state->status = SR_Outstanding;

        result = GetSRResult(pinfo->fd->num, TRUE);
        result->status = SR_Outstanding;
        result->event = SR_Request;
        break;

      case SR_Failure:
        /* 2 failures in a row.... */
        result = GetSRResult(pinfo->fd->num, TRUE);
        result->type = InvalidSREvent;
        result->status = SR_Failed;
        result->event = SR_Failure;
        break;
      }

      break;
2382
    }
2383
  }
2384

2385 2386 2387 2388 2389 2390 2391 2392 2393 2394
  /* Get stored result for this frame */
  result = GetSRResult(pinfo->fd->num, FALSE);

  if (result == NULL) {
    /* For an SR frame, there should always be either a PDCCH grant or indication
       that the SR has failed */
    if (event == SR_Request) {
      expert_add_info_format(pinfo, event_ti, PI_SEQUENCE, PI_ERROR,
                             "UE %u: SR results in neither a grant nor a failure indication",
                             ueid);
2395 2396
    }

2397 2398
    return;
  }
2399 2400


2401 2402 2403 2404 2405 2406 2407 2408 2409 2410
  /* Show result info */
  switch (result->type) {
  case GrantAnsweringSR:
    ti = proto_tree_add_uint(tree, hf_mac_lte_grant_answering_sr,
                             tvb, 0, 0, result->frameNum);
    PROTO_ITEM_SET_GENERATED(ti);
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_time_since_request,
                             tvb, 0, 0, result->timeDifference);
    PROTO_ITEM_SET_GENERATED(ti);
    break;
2411

2412 2413 2414 2415 2416 2417 2418 2419
  case FailureAnsweringSR:
    ti = proto_tree_add_uint(tree, hf_mac_lte_failure_answering_sr,
                             tvb, 0, 0, result->frameNum);
    PROTO_ITEM_SET_GENERATED(ti);
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_time_since_request,
                             tvb, 0, 0, result->timeDifference);
    PROTO_ITEM_SET_GENERATED(ti);
    break;
2420

2421 2422 2423 2424 2425 2426 2427
  case SRLeadingToGrant:
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_leading_to_grant,
                             tvb, 0, 0, result->frameNum);
    PROTO_ITEM_SET_GENERATED(ti);
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_time_until_answer,
                             tvb, 0, 0, result->timeDifference);
    PROTO_ITEM_SET_GENERATED(ti);
2428

2429
    break;
2430

2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453
  case SRLeadingToFailure:
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_leading_to_failure,
                             tvb, 0, 0, result->frameNum);
    PROTO_ITEM_SET_GENERATED(ti);
    ti = proto_tree_add_uint(tree, hf_mac_lte_sr_time_until_answer,
                             tvb, 0, 0, result->timeDifference);
    PROTO_ITEM_SET_GENERATED(ti);
    break;

  case InvalidSREvent:
    ti = proto_tree_add_none_format(tree, hf_mac_lte_sr_invalid_event,
                                    tvb, 0, 0, "UE %u: Invalid SR event - state=%s, event=%s",
                                    ueid,
                                    val_to_str_const(result->status, sr_status_vals, "Unknown"),
                                    val_to_str_const(result->event,  sr_event_vals,  "Unknown"));
    PROTO_ITEM_SET_GENERATED(ti);
    expert_add_info_format(pinfo, ti, PI_SEQUENCE, PI_ERROR,
                           "Invalid SR event for UE %u (C-RNTI %u) - state=%s, event=%s",
                           ueid, rnti,
                           val_to_str_const(result->status, sr_status_vals, "Unknown"),
                           val_to_str_const(result->event,  sr_event_vals,  "Unknown"));
    break;
  }
2454 2455 2456 2457 2458 2459 2460 2461 2462
}


/********************************************************/
/* Count number of UEs/TTI (in both directions)         */
/********************************************************/

/* For keeping track during first pass */
typedef struct tti_info_t {
2463 2464 2465
  guint16 subframe;
  nstime_t ttiStartTime;
  guint ues_in_tti;
2466 2467 2468 2469 2470 2471 2472
} tti_info_t;

static tti_info_t UL_tti_info;
static tti_info_t DL_tti_info;

/* For associating with frame and displaying */
typedef struct TTIInfoResult_t {
2473
  guint ues_in_tti;
2474 2475 2476 2477 2478 2479 2480 2481 2482 2483
} TTIInfoResult_t;

/* This table stores (FrameNumber -> *TTIInfoResult_t).  It is assigned during the first
   pass and used thereafter */
static GHashTable *mac_lte_tti_info_result_hash = NULL;


/* Work out which UE this is within TTI (within direction). Return answer */
static guint16 count_ues_tti(mac_lte_info *p_mac_lte_info, packet_info *pinfo)
{
2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513
  gboolean same_tti = FALSE;
  tti_info_t *tti_info;

  /* Just return any previous result */
  TTIInfoResult_t *result = g_hash_table_lookup(mac_lte_tti_info_result_hash, GUINT_TO_POINTER(pinfo->fd->num));

  if (result != NULL) {
    return result->ues_in_tti;
  }

  /* Set tti_info based upon direction */
  if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
    tti_info = &UL_tti_info;
  } else {
    tti_info = &DL_tti_info;
  }

  /* Work out if we are still in the same tti as before */
  if (tti_info->subframe == p_mac_lte_info->subframeNumber) {
    gint seconds_between_packets = (gint)
                                   (pinfo->fd->abs_ts.secs - tti_info->ttiStartTime.secs);
    gint nseconds_between_packets =
      pinfo->fd->abs_ts.nsecs -  tti_info->ttiStartTime.nsecs;

    /* Round difference to nearest microsecond */
    gint total_us_gap = (seconds_between_packets*1000000) +
                        ((nseconds_between_packets+500) / 1000);

    if (total_us_gap < 1000) {
      same_tti = TRUE;
2514
    }
2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533
  }

  /* Update global state */
  if (!same_tti) {
    tti_info->subframe = p_mac_lte_info->subframeNumber;
    tti_info->ttiStartTime = pinfo->fd->abs_ts;
    tti_info->ues_in_tti = 1;
  } else {
    tti_info->ues_in_tti++;
  }

  /* Set result state for this frame */
  result = se_alloc(sizeof(TTIInfoResult_t));
  result->ues_in_tti = tti_info->ues_in_tti;
  g_hash_table_insert(mac_lte_tti_info_result_hash,
                      GUINT_TO_POINTER(pinfo->fd->num), result);

  return tti_info->ues_in_tti;
}
2534 2535 2536 2537 2538


/* Show which UE this is (within direction) for this TTI */
static void show_ues_tti(packet_info *pinfo, mac_lte_info *p_mac_lte_info, tvbuff_t *tvb, proto_tree *context_tree)
{
2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549
  /* Look up result */
  TTIInfoResult_t *result = g_hash_table_lookup(mac_lte_tti_info_result_hash, GUINT_TO_POINTER(pinfo->fd->num));

  if (result != NULL) {
    proto_item *ti =  proto_tree_add_uint(context_tree,
                                          (p_mac_lte_info->direction == DIRECTION_UPLINK) ?
                                          hf_mac_lte_ues_ul_per_tti :
                                          hf_mac_lte_ues_dl_per_tti,
                                          tvb, 0, 0, result->ues_in_tti);
    PROTO_ITEM_SET_GENERATED(ti);
  }
2550 2551 2552 2553 2554 2555
}



/* Lookup channel details for lcid */
static void lookup_rlc_channel_from_lcid(guint8 lcid,
2556 2557 2558
    rlc_channel_type_t *rlc_channel_type,
    guint8 *UM_seqnum_length,
    gint *drb_id)
2559
{
2560 2561 2562 2563 2564 2565 2566 2567 2568
  /* Zero params (in case no match is found) */
  *rlc_channel_type = rlcRaw;
  *UM_seqnum_length = 0;
  *drb_id           = 0;

  if (global_mac_lte_lcid_drb_source == (int)FromStaticTable) {

    /* Look up in static (UAT) table */
    guint m;
2569

2570 2571 2572 2573
    for (m=0; m < num_lcid_drb_mappings; m++) {
      if (lcid == lcid_drb_mappings[m].lcid) {

        *rlc_channel_type = lcid_drb_mappings[m].channel_type;
2574 2575 2576

        /* Set UM_seqnum_length */
        switch (*rlc_channel_type) {
2577 2578 2579 2580 2581 2582 2583 2584 2585 2586
        case rlcUM5:
          *UM_seqnum_length = 5;
          break;

        case rlcUM10:
          *UM_seqnum_length = 10;
          break;

        default:
          break;
2587 2588 2589
        }

        /* Set drb_id */
2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613
        *drb_id = lcid_drb_mappings[m].drbid;
        break;
      }
    }
  } else {
    /* Look up setting gleaned from configuration protocol */
    if (!dynamic_lcid_drb_mapping[lcid].valid) {
      return;
    }

    *rlc_channel_type = dynamic_lcid_drb_mapping[lcid].channel_type;

    /* Set UM_seqnum_length */
    switch (*rlc_channel_type) {
    case rlcUM5:
      *UM_seqnum_length = 5;
      break;

    case rlcUM10:
      *UM_seqnum_length = 10;
      break;

    default:
      break;
2614
    }
2615 2616 2617 2618

    /* Set drb_id */
    *drb_id = dynamic_lcid_drb_mapping[lcid].drbid;
  }
2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633
}



#define MAX_HEADERS_IN_PDU 1024

/* UL-SCH and DL-SCH formats have much in common, so handle them in a common
   function */
static void dissect_ulsch_or_dlsch(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
                                   proto_item *pdu_ti,
                                   volatile guint32 offset, guint8 direction,
                                   mac_lte_info *p_mac_lte_info, mac_lte_tap_info *tap_info,
                                   proto_item *retx_ti,
                                   proto_tree *context_tree)
{
2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728
  guint8            extension;
  volatile guint16  n;
  proto_item       *truncated_ti;
  proto_item       *padding_length_ti;
  proto_item       *hidden_root_ti;

  /* Keep track of LCIDs and lengths as we dissect the header */
  volatile guint16 number_of_headers = 0;
  guint8           lcids[MAX_HEADERS_IN_PDU];
  gint16           pdu_lengths[MAX_HEADERS_IN_PDU];

  proto_item *pdu_header_ti;
  proto_tree *pdu_header_tree;

  gboolean   have_seen_data_header = FALSE;
  guint8     number_of_padding_subheaders = 0;
  gboolean   have_seen_non_padding_control = FALSE;
  gboolean   have_seen_bsr = FALSE;
  gboolean   expecting_body_data = FALSE;
  volatile   guint32    is_truncated = FALSE;

  /* Maintain/show UEs/TTI count */
  tap_info->ueInTTI = count_ues_tti(p_mac_lte_info, pinfo);
  show_ues_tti(pinfo, p_mac_lte_info, tvb, context_tree);

  write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                           "%s: (SF=%u) UEId=%-3u ",
                           (direction == DIRECTION_UPLINK) ? "UL-SCH" : "DL-SCH",
                           p_mac_lte_info->subframeNumber,
                           p_mac_lte_info->ueid);

  tap_info->raw_length = p_mac_lte_info->length;

  /* For uplink frames, if this is logged as a resend, look for original tx */
  if (direction == DIRECTION_UPLINK) {
    TrackReportedULHARQResend(pinfo, tvb, offset, tree, p_mac_lte_info, retx_ti);
  }

  /* For uplink grants, update SR status.  N.B. only newTx grant should stop SR */
  if ((direction == DIRECTION_UPLINK) && (p_mac_lte_info->reTxCount == 0) &&
      global_mac_lte_track_sr) {

    TrackSRInfo(SR_Grant, pinfo, tree, tvb, p_mac_lte_info, 0, NULL);
  }

  /* Add hidden item to filter on */
  hidden_root_ti = proto_tree_add_string_format(tree,
                   (direction == DIRECTION_UPLINK) ?
                   hf_mac_lte_ulsch :
                   hf_mac_lte_dlsch,
                   tvb, offset, 0,
                   "",
                   "Hidden header");
  PROTO_ITEM_SET_HIDDEN(hidden_root_ti);

  /* Add PDU block header subtree */
  pdu_header_ti = proto_tree_add_string_format(tree,
                  (direction == DIRECTION_UPLINK) ?
                  hf_mac_lte_ulsch_header :
                  hf_mac_lte_dlsch_header,
                  tvb, offset, 0,
                  "",
                  "MAC PDU Header");
  pdu_header_tree = proto_item_add_subtree(pdu_header_ti,
                    (direction == DIRECTION_UPLINK) ?
                    ett_mac_lte_ulsch_header :
                    ett_mac_lte_dlsch_header);


  /************************************************************************/
  /* Dissect each sub-header.                                             */
  do {
    guint8 reserved;
    guint64 length = 0;
    proto_item *pdu_subheader_ti;
    proto_tree *pdu_subheader_tree;
    proto_item *lcid_ti;
    proto_item *ti;
    gint       offset_start_subheader = offset;
    guint8 first_byte = tvb_get_guint8(tvb, offset);

    /* Add PDU block header subtree.
       Default with length of 1 byte. */
    pdu_subheader_ti = proto_tree_add_string_format(pdu_header_tree,
                       hf_mac_lte_sch_subheader,
                       tvb, offset, 1,
                       "",
                       "Sub-header");
    pdu_subheader_tree = proto_item_add_subtree(pdu_subheader_ti,
                         ett_mac_lte_sch_subheader);

    /* Check 1st 2 reserved bits */
    reserved = (first_byte & 0xc0) >> 6;
    ti = proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_sch_reserved,
                             tvb, offset, 1, ENC_BIG_ENDIAN);
2729

2730 2731 2732 2733 2734 2735 2736 2737 2738 2739
    if (reserved != 0) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "%cL-SCH header Reserved bits not zero",
                             (p_mac_lte_info->direction == DIRECTION_UPLINK) ? 'U' : 'D');
    }

    /* Extended bit */
    extension = (first_byte & 0x20) >> 5;
    proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_sch_extended,
                        tvb, offset, 1, ENC_BIG_ENDIAN);
2740

2741 2742
    /* LCID.  Has different meaning depending upon direction. */
    lcids[number_of_headers] = first_byte & 0x1f;
2743 2744

    if (direction == DIRECTION_UPLINK) {
2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765

      lcid_ti = proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_ulsch_lcid,
                                    tvb, offset, 1, ENC_BIG_ENDIAN);
      write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                               "(%s",
                               val_to_str_const(lcids[number_of_headers],
                                   ulsch_lcid_vals, "(Unknown LCID)"));
    } else {
      /* Downlink */
      lcid_ti = proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_dlsch_lcid,
                                    tvb, offset, 1, ENC_BIG_ENDIAN);
      write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                               "(%s",
                               val_to_str_const(lcids[number_of_headers],
                                   dlsch_lcid_vals, "(Unknown LCID)"));

      if (lcids[number_of_headers] == DRX_COMMAND_LCID) {
        expert_add_info_format(pinfo, lcid_ti, PI_SEQUENCE, PI_NOTE,
                               "DRX command received for UE %u (RNTI %u)",
                               p_mac_lte_info->ueid, p_mac_lte_info->rnti);
      }
2766 2767
    }

2768
    offset++;
2769

2770 2771 2772 2773
    /* Remember if we've seen a data subheader */
    if (lcids[number_of_headers] <= 10) {
      have_seen_data_header = TRUE;
      expecting_body_data = TRUE;
2774 2775
    }

2776 2777 2778 2779 2780 2781 2782 2783 2784
    /* Show an expert item if a contol subheader (except Padding) appears
       *after* a data PDU */
    if (have_seen_data_header &&
        (lcids[number_of_headers] > 10) && (lcids[number_of_headers] != PADDING_LCID)) {
      expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_ERROR,
                             "%cL-SCH Control subheaders should not appear after data subheaders",
                             (p_mac_lte_info->direction == DIRECTION_UPLINK) ? 'U' : 'D');
      return;
    }
2785

2786 2787 2788 2789 2790 2791 2792
    /* Show an expert item if we're seeing more then one BSR in a frame */
    if ((direction == DIRECTION_UPLINK) && is_bsr_lcid(lcids[number_of_headers])) {
      if (have_seen_bsr) {
        expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_ERROR,
                               "There shouldn't be > 1 BSR in a frame");
        return;
      }
2793

2794 2795
      have_seen_bsr = TRUE;
    }
2796

2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812
    /* Should not see padding after non-padding control... */
    if ((lcids[number_of_headers] > 10) &&
        (lcids[number_of_headers] == PADDING_LCID) &&
        extension) {
      number_of_padding_subheaders++;

      if (number_of_padding_subheaders > 2) {
        expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_WARN,
                               "Should not see more than 2 padding subheaders in one frame");
      }

      if (have_seen_non_padding_control) {
        expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_ERROR,
                               "Padding should come before other control subheaders!");
      }
    }
2813

2814 2815 2816 2817 2818
    /* Remember that we've seen non-padding control */
    if ((lcids[number_of_headers] > 10) &&
        (lcids[number_of_headers] != PADDING_LCID)) {
      have_seen_non_padding_control = TRUE;
    }
2819 2820 2821



2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835
    /********************************************************************/
    /* Length field follows if not the last header or for a fixed-sized
       control element */
    if (!extension) {
      /* Last one... */
      if (is_fixed_sized_control_element(lcids[number_of_headers], direction)) {
        pdu_lengths[number_of_headers] = 0;
      } else {
        pdu_lengths[number_of_headers] = -1;
      }
    } else {
      /* Not the last one */
      if (!is_fixed_sized_control_element(lcids[number_of_headers], direction) &&
          (lcids[number_of_headers] != PADDING_LCID)) {
2836

2837
        guint8  format;
2838

2839 2840 2841 2842
        /* F(ormat) bit tells us how long the length field is */
        format = (tvb_get_guint8(tvb, offset) & 0x80) >> 7;
        proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_sch_format,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
2843

2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855
        /* Now read length field itself */
        if (format) {
          /* >= 128 - use 15 bits */
          proto_tree_add_bits_ret_val(pdu_subheader_tree, hf_mac_lte_sch_length,
                                      tvb, offset*8 + 1, 15, &length, ENC_BIG_ENDIAN);

          offset += 2;
        } else {
          /* Less than 128 - only 7 bits */
          proto_tree_add_bits_ret_val(pdu_subheader_tree, hf_mac_lte_sch_length,
                                      tvb, offset*8 + 1, 7, &length, ENC_BIG_ENDIAN);
          offset++;
2856 2857
        }

2858 2859 2860 2861 2862
        pdu_lengths[number_of_headers] = (gint16)length;
      } else {
        pdu_lengths[number_of_headers] = 0;
      }
    }
2863 2864


2865 2866 2867 2868 2869
    /* Close off description in info column */
    switch (pdu_lengths[number_of_headers]) {
    case 0:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ") ");
      break;
2870

2871 2872 2873
    case -1:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ":remainder) ");
      break;
2874

2875 2876 2877 2878 2879
    default:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ":%u bytes) ",
                               pdu_lengths[number_of_headers]);
      break;
    }
2880

2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896
    /* Append summary to subheader root */
    proto_item_append_text(pdu_subheader_ti, " (lcid=%s",
                           val_to_str_const(lcids[number_of_headers],
                                            (direction == DIRECTION_UPLINK) ?
                                            ulsch_lcid_vals :
                                            dlsch_lcid_vals,
                                            "Unknown"));

    switch (pdu_lengths[number_of_headers]) {
    case -1:
      proto_item_append_text(pdu_subheader_ti, ", length is remainder)");
      proto_item_append_text(pdu_header_ti, " (%s:remainder)",
                             val_to_str_const(lcids[number_of_headers],
                                              (direction == DIRECTION_UPLINK) ? ulsch_lcid_vals : dlsch_lcid_vals,
                                              "Unknown"));
      break;
2897

2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915
    case 0:
      proto_item_append_text(pdu_subheader_ti, ")");
      proto_item_append_text(pdu_header_ti, " (%s)",
                             val_to_str_const(lcids[number_of_headers],
                                              (direction == DIRECTION_UPLINK) ? ulsch_lcid_vals : dlsch_lcid_vals,
                                              "Unknown"));
      break;

    default:
      proto_item_append_text(pdu_subheader_ti, ", length=%u)",
                             pdu_lengths[number_of_headers]);
      proto_item_append_text(pdu_header_ti, " (%s:%u)",
                             val_to_str_const(lcids[number_of_headers],
                                              (direction == DIRECTION_UPLINK) ? ulsch_lcid_vals : dlsch_lcid_vals,
                                              "Unknown"),
                             pdu_lengths[number_of_headers]);
      break;
    }
2916 2917


2918 2919 2920 2921 2922 2923 2924 2925
    /* Flag unknown lcid values in expert info */
    if (match_strval(lcids[number_of_headers],
                     (direction == DIRECTION_UPLINK) ? ulsch_lcid_vals : dlsch_lcid_vals) == NULL) {
      expert_add_info_format(pinfo, pdu_subheader_ti, PI_MALFORMED, PI_ERROR,
                             "%cL-SCH: Unexpected LCID received (%u)",
                             (p_mac_lte_info->direction == DIRECTION_UPLINK) ? 'U' : 'D',
                             lcids[number_of_headers]);
    }
2926

2927 2928
    /* Set length of this subheader */
    proto_item_set_len(pdu_subheader_ti, offset - offset_start_subheader);
2929

2930 2931
    number_of_headers++;
  } while ((number_of_headers < MAX_HEADERS_IN_PDU) && extension);
2932

2933 2934 2935 2936 2937 2938 2939 2940 2941 2942
  /* Check that we didn't reach the end of the subheader array... */
  if (number_of_headers >= MAX_HEADERS_IN_PDU) {
    proto_item *ti = proto_tree_add_text(tree, tvb, offset, 1,
                                         "Reached %u subheaders - frame obviously malformed",
                                         MAX_HEADERS_IN_PDU);
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "Reached %u subheaders - frame obviously malformed",
                           MAX_HEADERS_IN_PDU);
    return;
  }
2943 2944


2945 2946 2947
  /* Append summary to overall PDU header root */
  proto_item_append_text(pdu_header_ti, "  [%u subheaders]",
                         number_of_headers);
2948

2949 2950
  /* And set its length to offset */
  proto_item_set_len(pdu_header_ti, offset);
2951 2952


2953 2954 2955 2956
  /* For DL, see if this is a retx.  Use whole PDU present (i.e. ignore padding if not logged) */
  if (direction == DIRECTION_DOWNLINK) {
    /* Result will be added to context tree */
    TrackReportedDLHARQResend(pinfo, tvb, tvb_length_remaining(tvb, 0), context_tree, p_mac_lte_info);
2957

2958 2959
    tap_info->isPHYRetx = (p_mac_lte_info->dl_retx == dl_retx_yes);
  }
2960 2961


2962 2963 2964
  /************************************************************************/
  /* Dissect SDUs / control elements / padding.                           */
  /************************************************************************/
2965

2966 2967 2968 2969 2970 2971
  /* Dissect control element bodies first */

  for (n=0; n < number_of_headers; n++) {
    /* Get out of loop once see any data SDU subheaders */
    if (lcids[n] <= 10) {
      break;
2972 2973
    }

2974 2975
    /* Process what should be a valid control PDU type */
    if (direction == DIRECTION_DOWNLINK) {
2976

2977 2978 2979 2980 2981 2982 2983 2984
      /****************************/
      /* DL-SCH Control PDUs      */
      switch (lcids[n]) {
      case ACTIVATION_DEACTIVATION_LCID: {
        proto_item *ad_ti;
        proto_tree *ad_tree;
        proto_item *ti;
        guint8 reserved;
2985

2986 2987 2988 2989 2990 2991 2992
        /* Create AD root */
        ad_ti = proto_tree_add_string_format(tree,
                                             hf_mac_lte_control_activation_deactivation,
                                             tvb, offset, 1,
                                             "",
                                             "Activation/Deactivation");
        ad_tree = proto_item_add_subtree(ad_ti, ett_mac_lte_activation_deactivation);
2993

2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c7,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c6,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c5,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c4,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c3,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c2,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_c1,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        ti = proto_tree_add_item(ad_tree, hf_mac_lte_control_activation_deactivation_reserved,
                                 tvb, offset, 1, ENC_BIG_ENDIAN);
        reserved = tvb_get_guint8(tvb, offset) & 0x01;
3011

3012 3013 3014
        if (reserved != 0) {
          expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                                 "Activation/Deactivation Reserved bit not zero");
3015 3016
        }

3017 3018 3019
        offset++;
      }
      break;
3020

3021 3022 3023 3024 3025
      case UE_CONTENTION_RESOLUTION_IDENTITY_LCID: {
        proto_item *cr_ti;
        proto_tree *cr_tree;
        proto_item *ti;
        ContentionResolutionResult *crResult;
3026

3027 3028 3029 3030 3031 3032 3033
        /* Create CR root */
        cr_ti = proto_tree_add_string_format(tree,
                                             hf_mac_lte_control_ue_contention_resolution,
                                             tvb, offset, 6,
                                             "",
                                             "Contention Resolution");
        cr_tree = proto_item_add_subtree(cr_ti, ett_mac_lte_contention_resolution);
3034 3035


3036 3037
        proto_tree_add_item(cr_tree, hf_mac_lte_control_ue_contention_resolution_identity,
                            tvb, offset, 6, ENC_NA);
3038

3039 3040
        /* Get pointer to result struct for this frame */
        crResult =  g_hash_table_lookup(mac_lte_cr_result_hash, GUINT_TO_POINTER(pinfo->fd->num));
3041

3042
        if (crResult == NULL) {
3043

3044 3045 3046
          /* Need to set result by looking for and comparing with Msg3 */
          Msg3Data *msg3Data;
          guint msg3Key = p_mac_lte_info->rnti;
3047

3048 3049 3050
          /* Allocate result and add it to the table */
          crResult = se_alloc(sizeof(ContentionResolutionResult));
          g_hash_table_insert(mac_lte_cr_result_hash, GUINT_TO_POINTER(pinfo->fd->num), crResult);
3051

3052 3053
          /* Look for Msg3 */
          msg3Data = g_hash_table_lookup(mac_lte_msg3_hash, GUINT_TO_POINTER(msg3Key));
3054

3055 3056 3057 3058 3059
          /* Compare CCCH bytes */
          if (msg3Data != NULL) {
            crResult->msSinceMsg3 = (guint32)(((pinfo->fd->abs_ts.secs - msg3Data->msg3Time.secs) * 1000) +
                                              ((pinfo->fd->abs_ts.nsecs - msg3Data->msg3Time.nsecs) / 1000000));
            crResult->msg3FrameNum = msg3Data->framenum;
3060

3061 3062 3063 3064 3065
            /* Compare the 6 bytes */
            if (tvb_memeql(tvb, offset, msg3Data->data, 6) == 0) {
              crResult->status = Msg3Match;
            } else {
              crResult->status = Msg3NoMatch;
3066
            }
3067 3068 3069 3070
          } else {
            crResult->status = NoMsg3;
          }
        }
3071

3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124
        /* Now show CR result in tree */
        switch (crResult->status) {
        case NoMsg3:
          proto_item_append_text(cr_ti, " (no corresponding Msg3 found!)");
          break;

        case Msg3Match:
          ti = proto_tree_add_uint(cr_tree, hf_mac_lte_control_ue_contention_resolution_msg3,
                                   tvb, 0, 0, crResult->msg3FrameNum);
          PROTO_ITEM_SET_GENERATED(ti);
          ti = proto_tree_add_uint(cr_tree, hf_mac_lte_control_ue_contention_resolution_time_since_msg3,
                                   tvb, 0, 0, crResult->msSinceMsg3);
          PROTO_ITEM_SET_GENERATED(ti);

          ti = proto_tree_add_boolean(cr_tree, hf_mac_lte_control_ue_contention_resolution_msg3_matched,
                                      tvb, 0, 0, TRUE);
          PROTO_ITEM_SET_GENERATED(ti);
          proto_item_append_text(cr_ti, " (matches Msg3 from frame %u, %ums ago)",
                                 crResult->msg3FrameNum, crResult->msSinceMsg3);
          break;

        case Msg3NoMatch:
          ti = proto_tree_add_uint(cr_tree, hf_mac_lte_control_ue_contention_resolution_msg3,
                                   tvb, 0, 0, crResult->msg3FrameNum);
          PROTO_ITEM_SET_GENERATED(ti);
          ti = proto_tree_add_uint(cr_tree, hf_mac_lte_control_ue_contention_resolution_time_since_msg3,
                                   tvb, 0, 0, crResult->msSinceMsg3);
          PROTO_ITEM_SET_GENERATED(ti);

          ti = proto_tree_add_boolean(cr_tree, hf_mac_lte_control_ue_contention_resolution_msg3_matched,
                                      tvb, 0, 0, FALSE);
          expert_add_info_format(pinfo, ti, PI_SEQUENCE, PI_WARN,
                                 "CR body in Msg4 doesn't match Msg3 CCCH in frame %u",
                                 crResult->msg3FrameNum);
          PROTO_ITEM_SET_GENERATED(ti);
          proto_item_append_text(cr_ti, " (doesn't match Msg3 from frame %u, %u ago)",
                                 crResult->msg3FrameNum, crResult->msSinceMsg3);
          break;
        };

        offset += 6;
      }
      break;

      case TIMING_ADVANCE_LCID: {
        proto_item *ta_ti;
        proto_item *reserved_ti;
        guint8      reserved;
        guint8      ta_value;

        /* Check 2 reserved bits */
        reserved = (tvb_get_guint8(tvb, offset) & 0xc0) >> 6;
        reserved_ti = proto_tree_add_item(tree, hf_mac_lte_control_timing_advance_reserved, tvb, offset, 1, ENC_BIG_ENDIAN);
3125

3126 3127 3128
        if (reserved != 0) {
          expert_add_info_format(pinfo, reserved_ti, PI_MALFORMED, PI_ERROR,
                                 "Timing Advance Reserved bits not zero (found 0x%x)", reserved);
3129 3130
        }

3131 3132 3133 3134
        /* TA value */
        ta_value = tvb_get_guint8(tvb, offset) & 0x3f;
        ta_ti = proto_tree_add_item(tree, hf_mac_lte_control_timing_advance,
                                    tvb, offset, 1, ENC_BIG_ENDIAN);
3135

3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146
        if (ta_value == 31) {
          expert_add_info_format(pinfo, ta_ti, PI_SEQUENCE,
                                 PI_NOTE,
                                 "Timing Advance control element received (no correction needed)");
        } else {
          expert_add_info_format(pinfo, ta_ti, PI_SEQUENCE,
                                 PI_WARN,
                                 "Timing Advance control element received (%u) %s correction needed",
                                 ta_value,
                                 (ta_value < 31) ? "-ve" : "+ve");
        }
3147

3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184
        offset++;
      }
      break;

      case DRX_COMMAND_LCID:
        /* No payload */
        break;

      case PADDING_LCID:
        /* No payload (in this position) */
        tap_info->padding_bytes++;
        break;

      default:
        break;
      }
    } else {

      /**********************************/
      /* UL-SCH Control PDUs            */
      switch (lcids[n]) {
      case EXTENDED_POWER_HEADROOM_REPORT_LCID: {
        proto_item *ephr_ti;
        proto_tree *ephr_tree;
        proto_item *ti;
        proto_tree *ephr_cell_tree;
        proto_item *ephr_cell_ti;
        guint8 scell_bitmap;
        guint8 scell_count;
        guint8 byte;
        guint i;
        guint32 curr_offset = offset;
        guint32 computed_header_offset;

        if (pdu_lengths[n] == -1) {
          /* Control Element size is the remaining PDU */
          pdu_lengths[n] = (gint16)tvb_length_remaining(tvb, curr_offset);
3185
        }
3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216

        /* Create EPHR root */
        ephr_ti = proto_tree_add_string_format(tree,
                                               hf_mac_lte_control_ext_power_headroom,
                                               tvb, curr_offset, pdu_lengths[n],
                                               "",
                                               "Extended Power Headroom");
        ephr_tree = proto_item_add_subtree(ephr_ti, ett_mac_lte_extended_power_headroom);

        scell_bitmap = tvb_get_guint8(tvb, curr_offset);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c7,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c6,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c5,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c4,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c3,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c2,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_c1,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        /* Check Reserved bit */
        ti = proto_tree_add_item(ephr_tree, hf_mac_lte_control_ext_power_headroom_reserved,
                                 tvb, curr_offset, 1, ENC_BIG_ENDIAN);

        if (scell_bitmap & 0x01) {
          expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                                 "Extended Power Headroom Reserved bit not zero");
3217
        }
3218 3219 3220 3221 3222 3223 3224 3225 3226

        curr_offset++;

        /* Compute expected header size to deduce if PH Type 2 report is present or not */
        /* First count the number of SCells */
        for (i = 0, scell_count = 0; i < 7; i++) {
          if (scell_bitmap & (0x80>>i)) {
            scell_count++;
          }
3227 3228
        }

3229 3230 3231 3232 3233 3234 3235 3236 3237
        /* Now quickly parse the header */
        computed_header_offset = curr_offset;

        for (i = 0; i < scell_count; i++) {
          if (tvb_get_guint8(tvb, computed_header_offset) & 0x80) {
            computed_header_offset++;
          }

          computed_header_offset++;
3238 3239
        }

3240 3241 3242 3243 3244
        if ((gint16)(computed_header_offset + 1 - curr_offset) != pdu_lengths[n]) {
          /* PH Type 2 is present */
          if (tvb_get_guint8(tvb, computed_header_offset) & 0x80) {
            computed_header_offset++;
          }
3245

3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296
          computed_header_offset++;

          if ((gint16)(computed_header_offset + 1 - curr_offset) != pdu_lengths[n]) {
            expert_add_info_format(pinfo, ephr_ti, PI_MALFORMED, PI_ERROR,
                                   "Control Element has an unexpected size (computed=%d, actual=%d)",
                                   computed_header_offset + 1 - curr_offset, pdu_lengths[n]);
            offset += pdu_lengths[n];
            break;
          }

          byte = tvb_get_guint8(tvb, curr_offset);
          ephr_cell_ti = proto_tree_add_text(ephr_tree, tvb, curr_offset, ((byte&0x80)?2:1), "PCell");
          ephr_cell_tree = proto_item_add_subtree(ephr_cell_ti, ett_mac_lte_extended_power_headroom_cell);
          proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_power_backoff,
                              tvb, curr_offset, 1, ENC_BIG_ENDIAN);
          proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_value,
                              tvb, curr_offset, 1, ENC_BIG_ENDIAN);
          proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_level,
                              tvb, curr_offset, 1, ENC_BIG_ENDIAN);
          proto_item_append_text(ephr_cell_ti, " (%s)",
                                 val_to_str_ext_const((byte&0x3f), &power_headroom_vals_ext, "Unknown"));
          curr_offset++;

          if (byte & 0x80) {
            /* Pcmax,c field is present */
            byte = tvb_get_guint8(tvb, curr_offset);
            /* Check 2 Reserved bits */
            ti = proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_reserved2,
                                     tvb, curr_offset, 1, ENC_BIG_ENDIAN);

            if (byte & 0xc0) {
              expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                                     "Extended Power Headroom Reserved bits not zero (found 0x%x)",
                                     (byte & 0xc0) >> 6);
            }

            proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_pcmaxc,
                                tvb, curr_offset, 1, ENC_BIG_ENDIAN);
            proto_item_append_text(ephr_cell_ti, " (%s)",
                                   val_to_str_ext_const((byte&0x3f), &pcmaxc_vals_ext, "Unknown"));
            curr_offset++;
          }
        } else {
          if ((gint16)(computed_header_offset + 1 - curr_offset) != pdu_lengths[n]) {
            expert_add_info_format(pinfo, ephr_ti, PI_MALFORMED, PI_ERROR,
                                   "Control Element has an unexpected size (computed=%d, actual=%d)",
                                   computed_header_offset + 1 - curr_offset, pdu_lengths[n]);
            offset += pdu_lengths[n];
            break;
          }
        }
3297

3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324
        for (i = 1, scell_bitmap>>=1; i <= 7; i++, scell_bitmap>>=1) {
          if (scell_bitmap & 0x01) {
            byte = tvb_get_guint8(tvb, curr_offset);
            ephr_cell_ti = proto_tree_add_text(ephr_tree, tvb, curr_offset, ((byte&0x80)?2:1), "SCell Index %u", i);
            ephr_cell_tree = proto_item_add_subtree(ephr_cell_ti, ett_mac_lte_extended_power_headroom_cell);
            proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_power_backoff,
                                tvb, curr_offset, 1, ENC_BIG_ENDIAN);
            proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_value,
                                tvb, curr_offset, 1, ENC_BIG_ENDIAN);
            proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_level,
                                tvb, curr_offset, 1, ENC_BIG_ENDIAN);
            proto_item_append_text(ephr_cell_ti, " (%s)",
                                   val_to_str_ext_const((byte&0x3f), &power_headroom_vals_ext, "Unknown"));
            curr_offset++;

            if (byte & 0x80) {
              /* Pcmax,c field is present */
              byte = tvb_get_guint8(tvb, curr_offset);
              /* Check 2 Reserved bits */
              ti = proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_reserved2,
                                       tvb, curr_offset, 1, ENC_BIG_ENDIAN);

              if (byte & 0xc0) {
                expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                                       "Extended Power Headroom Reserved bits not zero (found 0x%x)",
                                       (byte & 0xc0) >> 6);
              }
3325

3326 3327 3328 3329 3330 3331 3332 3333
              proto_tree_add_item(ephr_cell_tree, hf_mac_lte_control_ext_power_headroom_pcmaxc,
                                  tvb, curr_offset, 1, ENC_BIG_ENDIAN);
              proto_item_append_text(ephr_cell_ti, " (%s)",
                                     val_to_str_ext_const((byte&0x3f), &pcmaxc_vals_ext, "Unknown"));
              curr_offset++;
            }
          }
        }
3334

3335 3336 3337
        offset += pdu_lengths[n];
      }
      break;
3338

3339 3340 3341
      case POWER_HEADROOM_REPORT_LCID: {
        proto_item *phr_ti;
        proto_tree *phr_tree;
3342
        proto_item *ti;
3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356
        guint8 reserved;
        guint8 level;

        /* Create PHR root */
        phr_ti = proto_tree_add_string_format(tree,
                                              hf_mac_lte_control_power_headroom,
                                              tvb, offset, 1,
                                              "",
                                              "Power Headroom");
        phr_tree = proto_item_add_subtree(phr_ti, ett_mac_lte_power_headroom);

        /* Check 2 Reserved bits */
        reserved = (tvb_get_guint8(tvb, offset) & 0xc0) >> 6;
        ti = proto_tree_add_item(phr_tree, hf_mac_lte_control_power_headroom_reserved,
3357
                                 tvb, offset, 1, ENC_BIG_ENDIAN);
3358

3359
        if (reserved != 0) {
3360 3361
          expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                                 "Power Headroom Reserved bits not zero (found 0x%x)", reserved);
3362 3363
        }

3364 3365 3366
        /* Level */
        level = tvb_get_guint8(tvb, offset) & 0x3f;
        proto_tree_add_item(phr_tree, hf_mac_lte_control_power_headroom_level,
3367 3368
                            tvb, offset, 1, ENC_BIG_ENDIAN);

3369 3370 3371
        /* Show value in root label */
        proto_item_append_text(phr_ti, " (%s)",
                               val_to_str_ext_const(level, &power_headroom_vals_ext, "Unknown"));
3372
        offset++;
3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399
      }


      break;

      case CRNTI_LCID:
        proto_tree_add_item(tree, hf_mac_lte_control_crnti,
                            tvb, offset, 2, ENC_BIG_ENDIAN);
        offset += 2;
        break;

      case TRUNCATED_BSR_LCID:
      case SHORT_BSR_LCID: {
        proto_tree *bsr_tree;
        proto_item *bsr_ti;
        proto_item *buffer_size_ti;
        guint8 lcgid;
        guint8 buffer_size;
        int hfindex;
        value_string_ext *p_vs_ext;

        if (p_mac_lte_info->isExtendedBSRSizes) {
          hfindex = hf_mac_lte_control_short_ext_bsr_buffer_size;
          p_vs_ext = &ext_buffer_size_vals_ext;
        } else {
          hfindex = hf_mac_lte_control_short_bsr_buffer_size;
          p_vs_ext = &buffer_size_vals_ext;
3400 3401
        }

3402 3403 3404 3405 3406 3407
        bsr_ti = proto_tree_add_string_format(tree,
                                              hf_mac_lte_control_bsr,
                                              tvb, offset, 1,
                                              "",
                                              "Short BSR");
        bsr_tree = proto_item_add_subtree(bsr_ti, ett_mac_lte_bsr);
3408

3409 3410 3411 3412 3413 3414 3415 3416 3417
        /* LCG ID */
        lcgid = (tvb_get_guint8(tvb, offset) & 0xc0) >> 6;
        proto_tree_add_item(bsr_tree, hf_mac_lte_control_bsr_lcg_id,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
        /* Buffer Size */
        buffer_size = tvb_get_guint8(tvb, offset) & 0x3f;
        buffer_size_ti = proto_tree_add_item(bsr_tree, hfindex,
                                             tvb, offset, 1, ENC_BIG_ENDIAN);
        offset++;
3418

3419 3420 3421 3422 3423 3424 3425
        if (buffer_size >= global_mac_lte_bsr_warn_threshold) {
          expert_add_info_format(pinfo, buffer_size_ti, PI_SEQUENCE, PI_WARN,
                                 "UE %u - BSR for LCG %u exceeds threshold: %u (%s)",
                                 p_mac_lte_info->ueid,
                                 lcgid,
                                 buffer_size,
                                 val_to_str_ext_const(buffer_size, p_vs_ext, "Unknown"));
3426 3427
        }

3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454

        proto_item_append_text(bsr_ti, " (lcgid=%u  %s)",
                               lcgid,
                               val_to_str_ext_const(buffer_size, &buffer_size_vals_ext, "Unknown"));
      }
      break;

      case LONG_BSR_LCID: {
        proto_tree *bsr_tree;
        proto_item *bsr_ti;
        proto_item *buffer_size_ti;
        guint8     buffer_size[4];
        int hfindex[4];
        value_string_ext *p_vs_ext;

        if (p_mac_lte_info->isExtendedBSRSizes) {
          hfindex[0] = hf_mac_lte_control_long_ext_bsr_buffer_size_0;
          hfindex[1] = hf_mac_lte_control_long_ext_bsr_buffer_size_1;
          hfindex[2] = hf_mac_lte_control_long_ext_bsr_buffer_size_2;
          hfindex[3] = hf_mac_lte_control_long_ext_bsr_buffer_size_3;
          p_vs_ext = &ext_buffer_size_vals_ext;
        } else {
          hfindex[0] = hf_mac_lte_control_long_bsr_buffer_size_0;
          hfindex[1] = hf_mac_lte_control_long_bsr_buffer_size_1;
          hfindex[2] = hf_mac_lte_control_long_bsr_buffer_size_2;
          hfindex[3] = hf_mac_lte_control_long_bsr_buffer_size_3;
          p_vs_ext = &buffer_size_vals_ext;
3455 3456
        }

3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475
        bsr_ti = proto_tree_add_string_format(tree,
                                              hf_mac_lte_control_bsr,
                                              tvb, offset, 3,
                                              "",
                                              "Long BSR");
        bsr_tree = proto_item_add_subtree(bsr_ti, ett_mac_lte_bsr);

        /* LCID Group 0 */
        buffer_size_ti = proto_tree_add_item(bsr_tree, hfindex[0],
                                             tvb, offset, 1, ENC_BIG_ENDIAN);
        buffer_size[0] = (tvb_get_guint8(tvb, offset) & 0xfc) >> 2;

        if (buffer_size[0] >= global_mac_lte_bsr_warn_threshold) {
          expert_add_info_format(pinfo, buffer_size_ti, PI_SEQUENCE, PI_WARN,
                                 "UE %u - BSR for LCG 0 exceeds threshold: %u (%s)",
                                 p_mac_lte_info->ueid,
                                 buffer_size[0],
                                 val_to_str_ext_const(buffer_size[0], p_vs_ext, "Unknown"));
        }
3476

3477 3478 3479 3480 3481
        /* LCID Group 1 */
        buffer_size_ti = proto_tree_add_item(bsr_tree, hfindex[1],
                                             tvb, offset, 2, ENC_BIG_ENDIAN);
        buffer_size[1] = ((tvb_get_guint8(tvb, offset) & 0x03) << 4) | ((tvb_get_guint8(tvb, offset+1) & 0xf0) >> 4);
        offset++;
3482

3483 3484 3485 3486 3487 3488
        if (buffer_size[1] >= global_mac_lte_bsr_warn_threshold) {
          expert_add_info_format(pinfo, buffer_size_ti, PI_SEQUENCE, PI_WARN,
                                 "UE %u - BSR for LCG 1 exceeds threshold: %u (%s)",
                                 p_mac_lte_info->ueid,
                                 buffer_size[1],
                                 val_to_str_ext_const(buffer_size[1], p_vs_ext, "Unknown"));
3489 3490
        }

3491 3492 3493
        /* LCID Group 2 */
        buffer_size_ti = proto_tree_add_item(bsr_tree, hfindex[2],
                                             tvb, offset, 2, ENC_BIG_ENDIAN);
3494

3495 3496
        buffer_size[2] = ((tvb_get_guint8(tvb, offset) & 0x0f) << 2) | ((tvb_get_guint8(tvb, offset+1) & 0xc0) >> 6);
        offset++;
3497

3498 3499 3500 3501 3502 3503
        if (buffer_size[2] >= global_mac_lte_bsr_warn_threshold) {
          expert_add_info_format(pinfo, buffer_size_ti, PI_SEQUENCE, PI_WARN,
                                 "UE %u - BSR for LCG 2 exceeds threshold: %u (%s)",
                                 p_mac_lte_info->ueid,
                                 buffer_size[2],
                                 val_to_str_ext_const(buffer_size[2], p_vs_ext, "Unknown"));
3504 3505
        }

3506 3507 3508 3509 3510
        /* LCID Group 3 */
        buffer_size_ti = proto_tree_add_item(bsr_tree, hfindex[3],
                                             tvb, offset, 1, ENC_BIG_ENDIAN);
        buffer_size[3] = tvb_get_guint8(tvb, offset) & 0x3f;
        offset++;
3511

3512 3513 3514 3515 3516 3517
        if (buffer_size[3] >= global_mac_lte_bsr_warn_threshold) {
          expert_add_info_format(pinfo, buffer_size_ti, PI_SEQUENCE, PI_WARN,
                                 "UE %u - BSR for LCG 3 exceeds threshold: %u (%s)",
                                 p_mac_lte_info->ueid,
                                 buffer_size[3],
                                 val_to_str_ext_const(buffer_size[3], p_vs_ext, "Unknown"));
3518 3519
        }

3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597
        /* Append summary to parent */
        proto_item_append_text(bsr_ti, "   0:(%s)  1:(%s)  2:(%s)  3:(%s)",
                               val_to_str_ext_const(buffer_size[0], p_vs_ext, "Unknown"),
                               val_to_str_ext_const(buffer_size[1], p_vs_ext, "Unknown"),
                               val_to_str_ext_const(buffer_size[2], p_vs_ext, "Unknown"),
                               val_to_str_ext_const(buffer_size[3], p_vs_ext, "Unknown"));
      }
      break;

      case PADDING_LCID:
        /* No payload, in this position */
        tap_info->padding_bytes++;
        break;

      default:
        break;
      }
    }
  }

  /* There might not be any data, if only headers (plus control data) were logged */
  is_truncated = ((tvb_length_remaining(tvb, offset) == 0) && expecting_body_data);
  truncated_ti = proto_tree_add_uint(tree, hf_mac_lte_sch_header_only, tvb, 0, 0,
                                     is_truncated);

  if (is_truncated) {
    PROTO_ITEM_SET_GENERATED(truncated_ti);
    expert_add_info_format(pinfo, truncated_ti, PI_SEQUENCE, PI_NOTE,
                           "MAC PDU SDUs have been omitted");
    return;
  } else {
    PROTO_ITEM_SET_HIDDEN(truncated_ti);
  }


  /* Now process remaining bodies, which should all be data */
  for (; n < number_of_headers; n++) {

    /* Data SDUs treated identically for Uplink or downlink channels */
    proto_item *sdu_ti;
    const guint8 *pdu_data;
    volatile guint16 data_length;
    int i;
    char buff[64];

    /* Break out if meet padding */
    if (lcids[n] == PADDING_LCID) {
      break;
    }

    /* Work out length */
    data_length = (pdu_lengths[n] == -1) ?
                  tvb_length_remaining(tvb, offset) :
                  pdu_lengths[n];

    /* Dissect SDU as raw bytes */
    sdu_ti = proto_tree_add_bytes_format(tree, hf_mac_lte_sch_sdu, tvb, offset, pdu_lengths[n],
                                         NULL, "SDU (%s, length=%u bytes): ",
                                         val_to_str_const(lcids[n],
                                             (direction == DIRECTION_UPLINK) ?
                                             ulsch_lcid_vals :
                                             dlsch_lcid_vals,
                                             "Unknown"),
                                         data_length);
    /* Show bytes too.  There must be a nicer way of doing this! */
    pdu_data = tvb_get_ptr(tvb, offset, pdu_lengths[n]);

    for (i=0; i < data_length; i++) {
      g_snprintf(buff+(i*2), 3, "%02x",  pdu_data[i]);

      if (i >= 30) {
        g_snprintf(buff+(i*2), 4, "...");
        break;
      }
    }

    proto_item_append_text(sdu_ti, "%s", buff);

3598

3599 3600 3601 3602 3603 3604
    /* Look for Msg3 data so that it may be compared with later
       Contention Resolution body */
    if ((lcids[n] == 0) && (direction == DIRECTION_UPLINK) && (data_length == 6)) {
      if (!pinfo->fd->flags.visited) {
        guint key = p_mac_lte_info->rnti;
        Msg3Data *data = g_hash_table_lookup(mac_lte_msg3_hash, GUINT_TO_POINTER(key));
3605

3606 3607 3608 3609 3610
        /* Look for previous entry for this UE */
        if (data == NULL) {
          /* Allocate space for data and add to table */
          data = se_alloc(sizeof(Msg3Data));
          g_hash_table_insert(mac_lte_msg3_hash, GUINT_TO_POINTER(key), data);
3611 3612
        }

3613 3614 3615 3616 3617 3618
        /* Fill in data details */
        data->framenum = pinfo->fd->num;
        tvb_memcpy(tvb, data->data, offset, data_length);
        data->msg3Time = pinfo->fd->abs_ts;
      }
    }
3619

3620 3621 3622
    /* CCCH frames can be dissected directly by LTE RRC... */
    if ((lcids[n] == 0) && global_mac_lte_attempt_rrc_decode) {
      tvbuff_t *rrc_tvb = tvb_new_subset(tvb, offset, data_length, data_length);
3623

3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636
      /* Get appropriate dissector handle */
      volatile dissector_handle_t protocol_handle = 0;

      if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
        protocol_handle = find_dissector("lte_rrc.ul_ccch");
      } else {
        protocol_handle = find_dissector("lte_rrc.dl_ccch");
      }

      /* Hide raw view of bytes */
      PROTO_ITEM_SET_HIDDEN(sdu_ti);

      call_with_catch_all(protocol_handle, rrc_tvb, pinfo, tree);
3637 3638
    }

3639 3640 3641 3642 3643 3644 3645 3646 3647
    /* LCID 1 and 2 can be assumed to be srb1&2, so can dissect as RLC AM */
    else if ((lcids[n] == 1) || (lcids[n] == 2)) {
      if (global_mac_lte_attempt_srb_decode) {
        /* Call RLC dissector */
        call_rlc_dissector(tvb, pinfo, tree, pdu_ti, offset, data_length,
                           RLC_AM_MODE, direction, p_mac_lte_info->ueid,
                           CHANNEL_TYPE_SRB, lcids[n], 0,
                           get_mac_lte_channel_priority(p_mac_lte_info->ueid,
                               lcids[n], direction));
3648

3649 3650 3651 3652
        /* Hide raw view of bytes */
        PROTO_ITEM_SET_HIDDEN(sdu_ti);
      }
    }
3653

3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706
    else if ((lcids[n] >= 2) && (lcids[n] <= 10)) {

      /* Look for mapping for this LCID to drb channel set by UAT table */
      rlc_channel_type_t rlc_channel_type;
      guint8 UM_seqnum_length;
      gint drb_id;
      guint8 priority = get_mac_lte_channel_priority(p_mac_lte_info->ueid,
                        lcids[n], direction);

      lookup_rlc_channel_from_lcid(lcids[n],
                                   &rlc_channel_type,
                                   &UM_seqnum_length,
                                   &drb_id);

      /* Dissect according to channel type */
      switch (rlc_channel_type) {
      case rlcUM5:
        call_rlc_dissector(tvb, pinfo, tree, pdu_ti, offset, data_length,
                           RLC_UM_MODE, direction, p_mac_lte_info->ueid,
                           CHANNEL_TYPE_DRB, (guint16)drb_id, UM_seqnum_length,
                           priority);
        break;

      case rlcUM10:
        call_rlc_dissector(tvb, pinfo, tree, pdu_ti, offset, data_length,
                           RLC_UM_MODE, direction, p_mac_lte_info->ueid,
                           CHANNEL_TYPE_DRB, (guint16)drb_id, UM_seqnum_length,
                           priority);
        break;

      case rlcAM:
        call_rlc_dissector(tvb, pinfo, tree, pdu_ti, offset, data_length,
                           RLC_AM_MODE, direction, p_mac_lte_info->ueid,
                           CHANNEL_TYPE_DRB, (guint16)drb_id, 0,
                           priority);
        break;

      case rlcTM:
        call_rlc_dissector(tvb, pinfo, tree, pdu_ti, offset, data_length,
                           RLC_TM_MODE, direction, p_mac_lte_info->ueid,
                           CHANNEL_TYPE_DRB, (guint16)drb_id, 0,
                           priority);
        break;

      case rlcRaw:
        /* Nothing to do! */
        break;
      }

      if (rlc_channel_type != rlcRaw) {
        /* Hide raw view of bytes */
        PROTO_ITEM_SET_HIDDEN(sdu_ti);
      }
3707

3708
    }
3709

3710
    offset += data_length;
3711

3712 3713 3714 3715
    /* Update tap byte count for this channel */
    tap_info->bytes_for_lcid[lcids[n]] += data_length;
    tap_info->sdus_for_lcid[lcids[n]]++;
  }
3716 3717


3718 3719 3720 3721 3722
  /* Now padding, if present, extends to the end of the PDU */
  if (lcids[number_of_headers-1] == PADDING_LCID) {
    if (tvb_length_remaining(tvb, offset) > 0) {
      proto_tree_add_item(tree, hf_mac_lte_padding_data,
                          tvb, offset, -1, ENC_NA);
3723 3724
    }

3725 3726 3727 3728 3729 3730 3731
    padding_length_ti = proto_tree_add_int(tree, hf_mac_lte_padding_length,
                                           tvb, offset, 0,
                                           p_mac_lte_info->length - offset);
    PROTO_ITEM_SET_GENERATED(padding_length_ti);

    /* Update padding bytes in stats */
    tap_info->padding_bytes += (p_mac_lte_info->length - offset);
3732

3733 3734 3735 3736 3737 3738
    /* Make sure the PDU isn't bigger than reported! */
    if (offset > p_mac_lte_info->length) {
      expert_add_info_format(pinfo, padding_length_ti, PI_MALFORMED, PI_ERROR,
                             "%s MAC PDU is longer than reported length (reported=%u, actual=%u)",
                             (direction == DIRECTION_UPLINK) ? "UL-SCH" : "DL-SCH",
                             p_mac_lte_info->length, offset);
3739
    }
3740 3741 3742 3743 3744 3745 3746 3747
  } else {
    /* There is no padding at the end of the frame */
    if (!is_truncated && (offset < p_mac_lte_info->length)) {
      /* There is a problem if we haven't used all of the PDU */
      expert_add_info_format(pinfo, pdu_ti, PI_MALFORMED, PI_ERROR,
                             "%s PDU for UE %u is shorter than reported length (reported=%u, actual=%u)",
                             (direction == DIRECTION_UPLINK) ? "UL-SCH" : "DL-SCH",
                             p_mac_lte_info->ueid, p_mac_lte_info->length, offset);
3748 3749
    }

3750 3751 3752 3753 3754 3755 3756 3757 3758
    if (!is_truncated && (offset > p_mac_lte_info->length)) {
      /* There is a problem if the PDU is longer than rpeported */
      expert_add_info_format(pinfo, pdu_ti, PI_MALFORMED, PI_ERROR,
                             "%s PDU for UE %u is longer than reported length (reported=%u, actual=%u)",
                             (direction == DIRECTION_UPLINK) ? "UL-SCH" : "DL-SCH",
                             p_mac_lte_info->ueid, p_mac_lte_info->length, offset);
    }
  }
}
3759

3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825
static void dissect_mch(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, proto_item *pdu_ti,
                        volatile guint32 offset, mac_lte_info *p_mac_lte_info)
{
  guint8            extension;
  volatile guint16  n;
  proto_item       *truncated_ti;
  proto_item       *padding_length_ti;
  proto_item       *hidden_root_ti;

  /* Keep track of LCIDs and lengths as we dissect the header */
  volatile guint16 number_of_headers = 0;
  guint8  lcids[MAX_HEADERS_IN_PDU];
  gint16  pdu_lengths[MAX_HEADERS_IN_PDU];

  proto_item *pdu_header_ti;
  proto_tree *pdu_header_tree;

  gboolean   have_seen_data_header = FALSE;
  guint8     number_of_padding_subheaders = 0;
  gboolean   have_seen_non_padding_control = FALSE;
  gboolean   expecting_body_data = FALSE;
  volatile   guint32    is_truncated = FALSE;

  write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                           "MCH: ",
                           p_mac_lte_info->subframeNumber);

  /* Add hidden item to filter on */
  hidden_root_ti = proto_tree_add_string_format(tree, hf_mac_lte_mch, tvb,
                   offset, 0, "", "Hidden header");
  PROTO_ITEM_SET_HIDDEN(hidden_root_ti);

  /* Add PDU block header subtree */
  pdu_header_ti = proto_tree_add_string_format(tree, hf_mac_lte_mch_header,
                  tvb, offset, 0,
                  "",
                  "MAC PDU Header");
  pdu_header_tree = proto_item_add_subtree(pdu_header_ti, ett_mac_lte_mch_header);


  /************************************************************************/
  /* Dissect each sub-header.                                             */
  do {
    guint8 reserved;
    guint64 length = 0;
    proto_item *pdu_subheader_ti;
    proto_tree *pdu_subheader_tree;
    proto_item *lcid_ti;
    proto_item *ti;
    gint       offset_start_subheader = offset;
    guint8 first_byte = tvb_get_guint8(tvb, offset);

    /* Add PDU block header subtree.
       Default with length of 1 byte. */
    pdu_subheader_ti = proto_tree_add_string_format(pdu_header_tree,
                       hf_mac_lte_mch_subheader,
                       tvb, offset, 1,
                       "",
                       "Sub-header");
    pdu_subheader_tree = proto_item_add_subtree(pdu_subheader_ti,
                         ett_mac_lte_mch_subheader);

    /* Check 1st 2 reserved bits */
    reserved = (first_byte & 0xc0) >> 6;
    ti = proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_mch_reserved,
                             tvb, offset, 1, ENC_BIG_ENDIAN);
3826

3827 3828 3829 3830
    if (reserved != 0) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "MCH header Reserved bits not zero");
    }
3831

3832 3833 3834 3835
    /* Extended bit */
    extension = (first_byte & 0x20) >> 5;
    proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_mch_extended,
                        tvb, offset, 1, ENC_BIG_ENDIAN);
3836

3837 3838 3839 3840 3841 3842 3843 3844 3845
    /* LCID */
    lcids[number_of_headers] = first_byte & 0x1f;
    lcid_ti = proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_mch_lcid,
                                  tvb, offset, 1, ENC_BIG_ENDIAN);
    write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                             "(%s",
                             val_to_str_const(lcids[number_of_headers],
                                 mch_lcid_vals, "(Unknown LCID)"));
    offset++;
3846

3847 3848 3849 3850
    /* Remember if we've seen a data subheader */
    if (lcids[number_of_headers] <= 28) {
      have_seen_data_header = TRUE;
      expecting_body_data = TRUE;
3851 3852
    }

3853 3854 3855 3856 3857 3858 3859
    /* Show an expert item if a contol subheader (except Padding) appears
       *after* a data PDU */
    if (have_seen_data_header &&
        (lcids[number_of_headers] > 28) && (lcids[number_of_headers] != PADDING_LCID)) {
      expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_ERROR,
                             "MCH Control subheaders should not appear after data subheaders");
      return;
3860 3861
    }

3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876
    /* Should not see padding after non-padding control... */
    if ((lcids[number_of_headers] > 28) &&
        (lcids[number_of_headers] == PADDING_LCID) &&
        extension) {
      number_of_padding_subheaders++;

      if (number_of_padding_subheaders > 2) {
        expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_WARN,
                               "Should not see more than 2 padding subheaders in one frame");
      }

      if (have_seen_non_padding_control) {
        expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_ERROR,
                               "Padding should come before other control subheaders!");
      }
3877 3878
    }

3879 3880 3881 3882
    /* Remember that we've seen non-padding control */
    if ((lcids[number_of_headers] > 28) &&
        (lcids[number_of_headers] != PADDING_LCID)) {
      have_seen_non_padding_control = TRUE;
3883 3884 3885 3886
    }



3887 3888 3889 3890 3891 3892 3893 3894 3895
    /********************************************************************/
    /* Length field follows if not the last header or for a fixed-sized
       control element */
    if (!extension) {
      /* Last one... */
      pdu_lengths[number_of_headers] = -1;
    } else {
      /* Not the last one */
      if (lcids[number_of_headers] != PADDING_LCID) {
3896

3897
        guint8  format;
3898

3899 3900 3901 3902
        /* F(ormat) bit tells us how long the length field is */
        format = (tvb_get_guint8(tvb, offset) & 0x80) >> 7;
        proto_tree_add_item(pdu_subheader_tree, hf_mac_lte_mch_format,
                            tvb, offset, 1, ENC_BIG_ENDIAN);
3903

3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916
        /* Now read length field itself */
        if (format) {
          /* >= 128 - use 15 bits */
          proto_tree_add_bits_ret_val(pdu_subheader_tree, hf_mac_lte_mch_length,
                                      tvb, offset*8 + 1, 15, &length, ENC_BIG_ENDIAN);

          offset += 2;
        } else {
          /* Less than 128 - only 7 bits */
          proto_tree_add_bits_ret_val(pdu_subheader_tree, hf_mac_lte_mch_length,
                                      tvb, offset*8 + 1, 7, &length, ENC_BIG_ENDIAN);
          offset++;
        }
3917

3918 3919 3920
        if ((lcids[number_of_headers] == MCH_SCHEDULING_INFO_LCID) && (length & 0x01)) {
          expert_add_info_format(pinfo, lcid_ti, PI_MALFORMED, PI_WARN,
                                 "MCH Scheduling Information MAC Control Element should have an even size");
3921 3922
        }

3923 3924 3925 3926
        pdu_lengths[number_of_headers] = (gint16)length;
      } else {
        pdu_lengths[number_of_headers] = 0;
      }
3927 3928 3929
    }


3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943
    /* Close off description in info column */
    switch (pdu_lengths[number_of_headers]) {
    case 0:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ") ");
      break;

    case -1:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ":remainder) ");
      break;

    default:
      write_pdu_label_and_info(pdu_ti, NULL, pinfo, ":%u bytes) ",
                               pdu_lengths[number_of_headers]);
      break;
3944 3945
    }

3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976
    /* Append summary to subheader root */
    proto_item_append_text(pdu_subheader_ti, " (lcid=%s",
                           val_to_str_const(lcids[number_of_headers],
                                            mch_lcid_vals, "Unknown"));

    switch (pdu_lengths[number_of_headers]) {
    case -1:
      proto_item_append_text(pdu_subheader_ti, ", length is remainder)");
      proto_item_append_text(pdu_header_ti, " (%s:remainder)",
                             val_to_str_const(lcids[number_of_headers],
                                              mch_lcid_vals,
                                              "Unknown"));
      break;

    case 0:
      proto_item_append_text(pdu_subheader_ti, ")");
      proto_item_append_text(pdu_header_ti, " (%s)",
                             val_to_str_const(lcids[number_of_headers],
                                              mch_lcid_vals,
                                              "Unknown"));
      break;

    default:
      proto_item_append_text(pdu_subheader_ti, ", length=%u)",
                             pdu_lengths[number_of_headers]);
      proto_item_append_text(pdu_header_ti, " (%s:%u)",
                             val_to_str_const(lcids[number_of_headers],
                                              mch_lcid_vals,
                                              "Unknown"),
                             pdu_lengths[number_of_headers]);
      break;
3977 3978
    }

3979 3980 3981 3982 3983 3984

    /* Flag unknown lcid values in expert info */
    if (match_strval(lcids[number_of_headers],mch_lcid_vals) == NULL) {
      expert_add_info_format(pinfo, pdu_subheader_ti, PI_MALFORMED, PI_ERROR,
                             "MCH: Unexpected LCID received (%u)",
                             lcids[number_of_headers]);
3985 3986
    }

3987 3988
    /* Set length of this subheader */
    proto_item_set_len(pdu_subheader_ti, offset - offset_start_subheader);
3989

3990 3991
    number_of_headers++;
  } while ((number_of_headers < MAX_HEADERS_IN_PDU) && extension);
3992

3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022
  /* Check that we didn't reach the end of the subheader array... */
  if (number_of_headers >= MAX_HEADERS_IN_PDU) {
    proto_item *ti = proto_tree_add_text(tree, tvb, offset, 1,
                                         "Reached %u subheaders - frame obviously malformed",
                                         MAX_HEADERS_IN_PDU);
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "Reached %u subheaders - frame obviously malformed",
                           MAX_HEADERS_IN_PDU);
    return;
  }


  /* Append summary to overall PDU header root */
  proto_item_append_text(pdu_header_ti, " (%u subheaders)",
                         number_of_headers);

  /* And set its length to offset */
  proto_item_set_len(pdu_header_ti, offset);


  /************************************************************************/
  /* Dissect SDUs / control elements / padding.                           */
  /************************************************************************/

  /* Dissect control element bodies first */

  for (n=0; n < number_of_headers; n++) {
    /* Get out of loop once see any data SDU subheaders */
    if (lcids[n] <= 28) {
      break;
4023 4024
    }

4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057
    /* Process what should be a valid control PDU type */
    switch (lcids[n]) {
    case MCH_SCHEDULING_INFO_LCID: {
      guint32 curr_offset = offset;
      gint16 i;
      guint16 stop_mtch_val;
      proto_item *mch_sched_info_ti, *ti;
      proto_tree *mch_sched_info_tree;

      mch_sched_info_ti = proto_tree_add_string_format(tree,
                          hf_mac_lte_control_mch_scheduling_info,
                          tvb, curr_offset, pdu_lengths[n],
                          "",
                          "MCH Scheduling Information");
      mch_sched_info_tree = proto_item_add_subtree(mch_sched_info_ti, ett_mac_lte_mch_scheduling_info);

      for (i=0; i<(pdu_lengths[n]/2); i++) {
        proto_tree_add_item(mch_sched_info_tree, hf_mac_lte_control_mch_scheduling_info_lcid,
                            tvb, curr_offset, 1, ENC_BIG_ENDIAN);
        stop_mtch_val = tvb_get_ntohs(tvb, curr_offset) & 0x7ff;
        ti = proto_tree_add_item(mch_sched_info_tree, hf_mac_lte_control_mch_scheduling_info_stop_mtch,
                                 tvb, curr_offset, 2, ENC_BIG_ENDIAN);

        if ((stop_mtch_val >= 2043) && (stop_mtch_val <= 2046)) {
          proto_item_append_text(ti, " (reserved)");
        } else if (stop_mtch_val == 2047) {
          proto_item_append_text(ti, " (MTCH is not scheduled)");
        }

        curr_offset += 2;
      }

      offset += pdu_lengths[n];
4058
    }
4059 4060 4061 4062 4063 4064 4065 4066
    break;

    case PADDING_LCID:
      /* No payload (in this position) */
      break;

    default:
      break;
4067
    }
4068
  }
4069

4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097

  /* There might not be any data, if only headers (plus control data) were logged */
  is_truncated = ((tvb_length_remaining(tvb, offset) == 0) && expecting_body_data);
  truncated_ti = proto_tree_add_uint(tree, hf_mac_lte_mch_header_only, tvb, 0, 0,
                                     is_truncated);

  if (is_truncated) {
    PROTO_ITEM_SET_GENERATED(truncated_ti);
    expert_add_info_format(pinfo, truncated_ti, PI_SEQUENCE, PI_NOTE,
                           "MAC PDU SDUs have been omitted");
    return;
  } else {
    PROTO_ITEM_SET_HIDDEN(truncated_ti);
  }


  /* Now process remaining bodies, which should all be data */
  for (; n < number_of_headers; n++) {

    proto_item *sdu_ti;
    const guint8 *pdu_data;
    volatile guint16 data_length;
    int i;
    char buff[64];

    /* Break out if meet padding */
    if (lcids[n] == PADDING_LCID) {
      break;
4098 4099
    }

4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122
    /* Work out length */
    data_length = (pdu_lengths[n] == -1) ?
                  tvb_length_remaining(tvb, offset) :
                  pdu_lengths[n];

    /* Dissect SDU as raw bytes */
    sdu_ti = proto_tree_add_bytes_format(tree, hf_mac_lte_mch_sdu, tvb, offset, pdu_lengths[n],
                                         NULL, "SDU (%s, length=%u bytes): ",
                                         val_to_str_const(lcids[n], mch_lcid_vals, "Unknown"),
                                         data_length);
    /* Show bytes too.  There must be a nicer way of doing this! */
    pdu_data = tvb_get_ptr(tvb, offset, pdu_lengths[n]);

    for (i=0; i < data_length; i++) {
      g_snprintf(buff+(i*2), 3, "%02x",  pdu_data[i]);

      if (i >= 30) {
        g_snprintf(buff+(i*2), 4, "...");
        break;
      }
    }

    proto_item_append_text(sdu_ti, "%s", buff);
4123

4124 4125 4126 4127 4128 4129 4130 4131
    offset += data_length;
  }

  /* Now padding, if present, extends to the end of the PDU */
  if (lcids[number_of_headers-1] == PADDING_LCID) {
    if (tvb_length_remaining(tvb, offset) > 0) {
      proto_tree_add_item(tree, hf_mac_lte_padding_data,
                          tvb, offset, -1, ENC_NA);
4132 4133
    }

4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288
    padding_length_ti = proto_tree_add_int(tree, hf_mac_lte_padding_length,
                                           tvb, offset, 0,
                                           p_mac_lte_info->length - offset);
    PROTO_ITEM_SET_GENERATED(padding_length_ti);

    /* Make sure the PDU isn't bigger than reported! */
    if (offset > p_mac_lte_info->length) {
      expert_add_info_format(pinfo, padding_length_ti, PI_MALFORMED, PI_ERROR,
                             "MAC PDU is longer than reported length (reported=%u, actual=%u)",
                             p_mac_lte_info->length, offset);
    }
  } else {
    /* There is no padding at the end of the frame */
    if (!is_truncated && (offset < p_mac_lte_info->length)) {
      /* There is a problem if we haven't used all of the PDU */
      expert_add_info_format(pinfo, pdu_ti, PI_MALFORMED, PI_ERROR,
                             "PDU is shorter than reported length (reported=%u, actual=%u)",
                             p_mac_lte_info->length, offset);
    }

    if (!is_truncated && (offset > p_mac_lte_info->length)) {
      /* There is a problem if the PDU is longer than rpeported */
      expert_add_info_format(pinfo, pdu_ti, PI_MALFORMED, PI_ERROR,
                             "PDU is longer than reported length (reported=%u, actual=%u)",
                             p_mac_lte_info->length, offset);
    }
  }
}


/*****************************/
/* Main dissection function. */
void dissect_mac_lte(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
{
  proto_tree          *mac_lte_tree;
  proto_item          *pdu_ti;
  proto_tree          *context_tree;
  proto_item          *context_ti;
  proto_item          *retx_ti        = NULL;
  proto_item          *ti;
  gint                 offset         = 0;
  struct mac_lte_info *p_mac_lte_info = NULL;
  gint                 n;

  /* Allocate and zero tap struct */
  mac_lte_tap_info *tap_info = ep_alloc0(sizeof(mac_lte_tap_info));

  /* Set protocol name */
  col_set_str(pinfo->cinfo, COL_PROTOCOL, "MAC-LTE");

  /* Create protocol tree. */
  pdu_ti = proto_tree_add_item(tree, proto_mac_lte, tvb, offset, -1, ENC_NA);
  proto_item_append_text(pdu_ti, " ");
  mac_lte_tree = proto_item_add_subtree(pdu_ti, ett_mac_lte);


  /* Look for packet info! */
  p_mac_lte_info = p_get_proto_data(pinfo->fd, proto_mac_lte);

  /* Can't dissect anything without it... */
  if (p_mac_lte_info == NULL) {
    proto_item *tii =
      proto_tree_add_text(mac_lte_tree, tvb, offset, -1,
                          "Can't dissect LTE MAC frame because no per-frame info was attached!");
    PROTO_ITEM_SET_GENERATED(tii);
    return;
  }

  /* Clear info column */
  col_clear(pinfo->cinfo, COL_INFO);


  /*****************************************/
  /* Show context information              */

  /* Create context root */
  context_ti = proto_tree_add_string_format(mac_lte_tree, hf_mac_lte_context,
               tvb, offset, 0, "", "Context");
  context_tree = proto_item_add_subtree(context_ti, ett_mac_lte_context);
  PROTO_ITEM_SET_GENERATED(context_ti);

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_radio_type,
                           tvb, 0, 0, p_mac_lte_info->radioType);
  PROTO_ITEM_SET_GENERATED(ti);

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_direction,
                           tvb, 0, 0, p_mac_lte_info->direction);
  PROTO_ITEM_SET_GENERATED(ti);

  if (p_mac_lte_info->ueid != 0) {
    ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_ueid,
                             tvb, 0, 0, p_mac_lte_info->ueid);
    PROTO_ITEM_SET_GENERATED(ti);
  }

  /* There are several out-of-band MAC events that may be indicated in the context info. */
  /* Handle them here */
  if (p_mac_lte_info->length == 0) {
    proto_item *preamble_ti;
    proto_tree *preamble_tree;

    switch (p_mac_lte_info->oob_event) {
    case ltemac_send_preamble:
      preamble_ti = proto_tree_add_item(mac_lte_tree, hf_mac_lte_oob_send_preamble,
                                        tvb, 0, 0, ENC_ASCII|ENC_NA);
      preamble_tree = proto_item_add_subtree(preamble_ti, ett_mac_lte_oob);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(preamble_tree, hf_mac_lte_context_rapid,
                               tvb, 0, 0, p_mac_lte_info->rapid);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_uint(preamble_tree, hf_mac_lte_context_rach_attempt_number,
                               tvb, 0, 0, p_mac_lte_info->rach_attempt_number);
      PROTO_ITEM_SET_GENERATED(ti);

      /* Info column */
      write_pdu_label_and_info(pdu_ti, preamble_ti, pinfo,
                               "RACH Preamble sent for UE %u (RAPID=%u, attempt=%u)",
                               p_mac_lte_info->ueid, p_mac_lte_info->rapid, p_mac_lte_info->rach_attempt_number);

      /* Add expert info (a note, unless attempt > 1) */
      expert_add_info_format(pinfo, ti, PI_SEQUENCE,
                             (p_mac_lte_info->rach_attempt_number > 1) ? PI_WARN : PI_NOTE,
                             "RACH Preamble sent for UE %u (RAPID=%u, attempt=%u)",
                             p_mac_lte_info->ueid, p_mac_lte_info->rapid,
                             p_mac_lte_info->rach_attempt_number);
      break;

    case ltemac_send_sr:
      /* Count of SRs */
      ti = proto_tree_add_uint(mac_lte_tree, hf_mac_lte_number_of_srs,
                               tvb, 0, 0, p_mac_lte_info->number_of_srs);
      PROTO_ITEM_SET_GENERATED(ti);


      for (n=0; n < p_mac_lte_info->number_of_srs; n++) {
        proto_item *sr_ti;
        proto_tree *sr_tree;

        /* SR event is subtree */
        sr_ti = proto_tree_add_item(mac_lte_tree, hf_mac_lte_oob_send_sr,
                                    tvb, 0, 0, ENC_NA);
        sr_tree = proto_item_add_subtree(sr_ti, ett_mac_lte_oob);
        PROTO_ITEM_SET_GENERATED(sr_ti);


        /* RNTI */
        ti = proto_tree_add_uint(sr_tree, hf_mac_lte_context_rnti,
                                 tvb, 0, 0, p_mac_lte_info->oob_rnti[n]);
        PROTO_ITEM_SET_GENERATED(ti);

        /* UEID */
        ti = proto_tree_add_uint(sr_tree, hf_mac_lte_context_ueid,
                                 tvb, 0, 0, p_mac_lte_info->oob_ueid[n]);
4289 4290
        PROTO_ITEM_SET_GENERATED(ti);

4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307
        /* Add summary to root. */
        proto_item_append_text(sr_ti, " (UE=%u C-RNTI=%u)",
                               p_mac_lte_info->oob_ueid[n],
                               p_mac_lte_info->oob_rnti[n]);

        /* Info column */
        if (n == 0) {
          write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                                   "Scheduling Requests (%u) sent: (UE=%u C-RNTI=%u)",
                                   p_mac_lte_info->number_of_srs,
                                   p_mac_lte_info->oob_ueid[n],
                                   p_mac_lte_info->oob_rnti[n]);
        } else {
          write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                                   " (UE=%u C-RNTI=%u)",
                                   p_mac_lte_info->oob_ueid[n],
                                   p_mac_lte_info->oob_rnti[n]);
4308 4309
        }

4310 4311 4312 4313 4314 4315 4316 4317 4318
        /* Add expert info (a note) */
        expert_add_info_format(pinfo, sr_ti, PI_SEQUENCE, PI_NOTE,
                               "Scheduling Request sent for UE %u (RNTI %u)",
                               p_mac_lte_info->oob_ueid[n],
                               p_mac_lte_info->oob_rnti[n]);

        /* Update SR status for this UE */
        if (global_mac_lte_track_sr) {
          TrackSRInfo(SR_Request, pinfo, mac_lte_tree, tvb, p_mac_lte_info, n, sr_ti);
4319
        }
4320
      }
4321

4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350
      break;

    case ltemac_sr_failure:
      ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_rnti,
                               tvb, 0, 0, p_mac_lte_info->rnti);
      PROTO_ITEM_SET_GENERATED(ti);

      ti = proto_tree_add_item(mac_lte_tree, hf_mac_lte_oob_sr_failure,
                               tvb, 0, 0, ENC_NA);
      PROTO_ITEM_SET_GENERATED(ti);

      /* Info column */
      write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                               "Scheduling Request FAILED for UE %u (C-RNTI=%u)",
                               p_mac_lte_info->ueid,
                               p_mac_lte_info->rnti);

      /* Add expert info (an error) */
      expert_add_info_format(pinfo, ti, PI_SEQUENCE, PI_ERROR,
                             "Scheduling Request failed for UE %u (RNTI %u)",
                             p_mac_lte_info->ueid,
                             p_mac_lte_info->rnti);

      /* Update SR status */
      if (global_mac_lte_track_sr) {
        TrackSRInfo(SR_Failure, pinfo, mac_lte_tree, tvb, p_mac_lte_info, 0, ti);
      }

      break;
4351 4352
    }

4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377
    /* Our work here is done */
    return;
  }

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_sysframe_number,
                           tvb, 0, 0, p_mac_lte_info->sysframeNumber);
  PROTO_ITEM_SET_GENERATED(ti);

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_subframe_number,
                           tvb, 0, 0, p_mac_lte_info->subframeNumber);
  PROTO_ITEM_SET_GENERATED(ti);

  if (p_mac_lte_info->subframeNumber > 9) {
    /* N.B. if we set it to valid value, it won't trigger when we rescan
       (at least with DCT2000 files where the context struct isn't re-read). */
    expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                           "Subframe number (%u) was out of range - valid range is 0-9",
                           p_mac_lte_info->subframeNumber);
  }

  if (p_mac_lte_info->subframeNumberOfGrantPresent) {
    ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_grant_subframe_number,
                             tvb, 0, 0, p_mac_lte_info->subframeNumberOfGrant);
    PROTO_ITEM_SET_GENERATED(ti);
  }
4378

4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397
  if (p_mac_lte_info->rntiType != NO_RNTI) {
    ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_rnti,
                             tvb, 0, 0, p_mac_lte_info->rnti);
    PROTO_ITEM_SET_GENERATED(ti);
  }

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_rnti_type,
                           tvb, 0, 0, p_mac_lte_info->rntiType);
  PROTO_ITEM_SET_GENERATED(ti);

  /* Check that RNTI value is consistent with given RNTI type */
  switch (p_mac_lte_info->rntiType) {
  case M_RNTI:
    if (p_mac_lte_info->rnti != 0xFFFD) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "M-RNTI indicated, but value is %u (0x%x) (must be 0x%x)",
                             p_mac_lte_info->rnti, p_mac_lte_info->rnti, 0xFFFD);
      return;
    }
4398

4399
    break;
4400

4401 4402 4403 4404 4405 4406
  case P_RNTI:
    if (p_mac_lte_info->rnti != 0xFFFE) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "P-RNTI indicated, but value is %u (0x%x) (must be 0x%x)",
                             p_mac_lte_info->rnti, p_mac_lte_info->rnti, 0xFFFE);
      return;
4407 4408
    }

4409
    break;
4410

4411 4412 4413 4414 4415 4416 4417
  case SI_RNTI:
    if (p_mac_lte_info->rnti != 0xFFFF) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "SI-RNTI indicated, but value is %u (0x%x) (must be 0x%x)",
                             p_mac_lte_info->rnti, p_mac_lte_info->rnti, 0xFFFE);
      return;
    }
4418

4419
    break;
4420

4421 4422 4423 4424 4425 4426 4427
  case RA_RNTI:
    if ((p_mac_lte_info->rnti < 0x0001) || (p_mac_lte_info->rnti > 0x003C)) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "RA_RNTI indicated, but given value %u (0x%x)is out of range",
                             p_mac_lte_info->rnti, p_mac_lte_info->rnti);
      return;
    }
4428

4429
    break;
4430

4431 4432 4433 4434 4435 4436 4437 4438 4439
  case C_RNTI:
  case SPS_RNTI:
    if ((p_mac_lte_info->rnti < 0x0001) || (p_mac_lte_info->rnti > 0xFFF3)) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "%s indicated, but given value %u (0x%x)is out of range",
                             val_to_str_const(p_mac_lte_info->rntiType,  rnti_type_vals, "Unknown"),
                             p_mac_lte_info->rnti, p_mac_lte_info->rnti);
      return;
    }
4440

4441
    break;
4442

4443 4444 4445
  default:
    break;
  }
4446

4447 4448
  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_predefined_frame,
                           tvb, 0, 0, p_mac_lte_info->isPredefinedData);
4449

4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477
  if (p_mac_lte_info->isPredefinedData) {
    PROTO_ITEM_SET_GENERATED(ti);
  } else {
    PROTO_ITEM_SET_HIDDEN(ti);
  }

  ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_length,
                           tvb, 0, 0, p_mac_lte_info->length);
  PROTO_ITEM_SET_GENERATED(ti);

  /* Infer uplink grant size */
  if (p_mac_lte_info->direction == DIRECTION_UPLINK) {
    ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_ul_grant_size,
                             tvb, 0, 0, p_mac_lte_info->length);
    PROTO_ITEM_SET_GENERATED(ti);
  }

  /* Retx count goes in top-level tree to make it more visible */
  if (p_mac_lte_info->reTxCount) {
    proto_item *retx_reason_ti;
    retx_ti = proto_tree_add_uint(mac_lte_tree, hf_mac_lte_context_retx_count,
                                  tvb, 0, 0, p_mac_lte_info->reTxCount);
    PROTO_ITEM_SET_GENERATED(retx_ti);

    if (p_mac_lte_info->reTxCount >= global_mac_lte_retx_counter_trigger) {
      expert_add_info_format(pinfo, retx_ti, PI_SEQUENCE, PI_WARN,
                             "UE %u: UL MAC frame ReTX no. %u",
                             p_mac_lte_info->ueid, p_mac_lte_info->reTxCount);
4478 4479
    }

4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539
    retx_reason_ti = proto_tree_add_uint(mac_lte_tree, hf_mac_lte_context_retx_reason,
                                         tvb, 0, 0, p_mac_lte_info->isPHICHNACK);
    PROTO_ITEM_SET_GENERATED(retx_reason_ti);
  }

  if (p_mac_lte_info->crcStatusValid) {
    /* Set status */
    ti = proto_tree_add_uint(context_tree, hf_mac_lte_context_crc_status,
                             tvb, 0, 0, p_mac_lte_info->detailed_phy_info.dl_info.crc_status);
    PROTO_ITEM_SET_GENERATED(ti);

    /* Report non-success */
    if (p_mac_lte_info->detailed_phy_info.dl_info.crc_status != crc_success) {
      expert_add_info_format(pinfo, ti, PI_MALFORMED, PI_ERROR,
                             "%s Frame has CRC error problem (%s)",
                             (p_mac_lte_info->direction == DIRECTION_UPLINK) ? "UL" : "DL",
                             val_to_str_const(p_mac_lte_info->detailed_phy_info.dl_info.crc_status,
                                              crc_status_vals,
                                              "Unknown"));
      write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                               "%s: <CRC %s> UEId=%u %s=%u ",
                               (p_mac_lte_info->direction == DIRECTION_UPLINK) ? "UL" : "DL",
                               val_to_str_const(p_mac_lte_info->detailed_phy_info.dl_info.crc_status,
                                   crc_status_vals,
                                   "Unknown"),
                               p_mac_lte_info->ueid,
                               val_to_str_const(p_mac_lte_info->rntiType, rnti_type_vals,
                                   "Unknown RNTI type"),
                               p_mac_lte_info->rnti);
    }
  }

  /* May also have extra Physical layer attributes set for this frame */
  show_extra_phy_parameters(pinfo, tvb, mac_lte_tree, p_mac_lte_info);

  /* Set context-info parts of tap struct */
  tap_info->rnti = p_mac_lte_info->rnti;
  tap_info->ueid = p_mac_lte_info->ueid;
  tap_info->rntiType = p_mac_lte_info->rntiType;
  tap_info->isPredefinedData = p_mac_lte_info->isPredefinedData;
  tap_info->isPHYRetx = (p_mac_lte_info->reTxCount >= 1);
  tap_info->crcStatusValid = p_mac_lte_info->crcStatusValid;
  tap_info->crcStatus = p_mac_lte_info->detailed_phy_info.dl_info.crc_status;
  tap_info->direction = p_mac_lte_info->direction;

  tap_info->time = pinfo->fd->abs_ts;

  /* Also set total number of bytes (won't be used for UL/DL-SCH) */
  tap_info->single_number_of_bytes = tvb_length_remaining(tvb, offset);

  /* If we know its predefined data, don't try to decode any further */
  if (p_mac_lte_info->isPredefinedData) {
    proto_tree_add_item(mac_lte_tree, hf_mac_lte_predefined_pdu, tvb, offset, -1, ENC_NA);
    write_pdu_label_and_info(pdu_ti, NULL, pinfo,
                             "Predefined data (%u bytes%s)",
                             p_mac_lte_info->length,
                             (p_mac_lte_info->length > tvb_length_remaining(tvb, offset) ?
                              " - truncated" :
                              ""));

4540
    /* Queue tap info */
4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610
    if (!pinfo->flags.in_error_pkt) {
      tap_queue_packet(mac_lte_tap, pinfo, tap_info);
    }

    return;
  }

  /* IF CRC status failed, just do decode as raw bytes */
  if (!global_mac_lte_dissect_crc_failures &&
      (p_mac_lte_info->crcStatusValid &&
       (p_mac_lte_info->detailed_phy_info.dl_info.crc_status != crc_success))) {

    proto_tree_add_item(mac_lte_tree, hf_mac_lte_raw_pdu, tvb, offset, -1, ENC_NA);
    write_pdu_label_and_info(pdu_ti, NULL, pinfo, "Raw data (%u bytes)", tvb_length_remaining(tvb, offset));

    /* Queue tap info.
       TODO: unfortunately DL retx detection won't get done if we return here... */
    if (!pinfo->flags.in_error_pkt) {
      tap_queue_packet(mac_lte_tap, pinfo, tap_info);
    }

    return;
  }

  /* Reset this counter */
  s_number_of_rlc_pdus_shown = 0;

  /* Dissect the MAC PDU itself. Format depends upon RNTI type. */
  switch (p_mac_lte_info->rntiType) {

  case P_RNTI:
    /* PCH PDU */
    dissect_pch(tvb, pinfo, mac_lte_tree, pdu_ti, offset, p_mac_lte_info->direction);
    break;

  case RA_RNTI:
    /* RAR PDU */
    dissect_rar(tvb, pinfo, mac_lte_tree, pdu_ti, offset, p_mac_lte_info, tap_info);
    break;

  case C_RNTI:
  case SPS_RNTI:
    /* Can be UL-SCH or DL-SCH */
    dissect_ulsch_or_dlsch(tvb, pinfo, mac_lte_tree, pdu_ti, offset,
                           p_mac_lte_info->direction, p_mac_lte_info, tap_info,
                           retx_ti, context_tree);
    break;

  case SI_RNTI:
    /* BCH over DL-SCH */
    dissect_bch(tvb, pinfo, mac_lte_tree, pdu_ti, offset, p_mac_lte_info);
    break;

  case M_RNTI:
    /* MCH PDU */
    dissect_mch(tvb, pinfo, mac_lte_tree, pdu_ti, offset, p_mac_lte_info);
    break;

  case NO_RNTI:
    /* Must be BCH over BCH... */
    dissect_bch(tvb, pinfo, mac_lte_tree, pdu_ti, offset, p_mac_lte_info);
    break;


  default:
    break;
  }

  /* Queue tap info */
  tap_queue_packet(mac_lte_tap, pinfo, tap_info);
4611 4612 4613 4614 4615 4616 4617 4618 4619
}




/* Initializes the hash tables each time a new
 * file is loaded or re-loaded in wireshark */
static void mac_lte_init_protocol(void)
{
4620 4621 4622 4623
  /* Destroy any existing tables. */
  if (mac_lte_msg3_hash) {
    g_hash_table_destroy(mac_lte_msg3_hash);
  }
4624

4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635
  if (mac_lte_cr_result_hash) {
    g_hash_table_destroy(mac_lte_cr_result_hash);
  }

  if (mac_lte_dl_harq_hash) {
    g_hash_table_destroy(mac_lte_dl_harq_hash);
  }

  if (mac_lte_dl_harq_result_hash) {
    g_hash_table_destroy(mac_lte_dl_harq_result_hash);
  }
4636

4637 4638 4639
  if (mac_lte_ul_harq_hash) {
    g_hash_table_destroy(mac_lte_ul_harq_hash);
  }
4640

4641 4642 4643
  if (mac_lte_ul_harq_result_hash) {
    g_hash_table_destroy(mac_lte_ul_harq_result_hash);
  }
4644

4645 4646 4647
  if (mac_lte_ue_sr_state) {
    g_hash_table_destroy(mac_lte_ue_sr_state);
  }
4648

4649 4650 4651
  if (mac_lte_sr_request_hash) {
    g_hash_table_destroy(mac_lte_sr_request_hash);
  }
4652

4653 4654 4655
  if (mac_lte_tti_info_result_hash) {
    g_hash_table_destroy(mac_lte_tti_info_result_hash);
  }
4656

4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676
  /* Reset structs */
  memset(&UL_tti_info, 0, sizeof(UL_tti_info));
  UL_tti_info.subframe = 0xff;  /* Invalid value */
  memset(&DL_tti_info, 0, sizeof(DL_tti_info));
  DL_tti_info.subframe = 0xff;  /* Invalid value */

  /* Now create them over */
  mac_lte_msg3_hash = g_hash_table_new(mac_lte_rnti_hash_func, mac_lte_rnti_hash_equal);
  mac_lte_cr_result_hash = g_hash_table_new(mac_lte_framenum_hash_func, mac_lte_framenum_hash_equal);

  mac_lte_dl_harq_hash = g_hash_table_new(mac_lte_rnti_hash_func, mac_lte_rnti_hash_equal);
  mac_lte_dl_harq_result_hash = g_hash_table_new(mac_lte_framenum_hash_func, mac_lte_framenum_hash_equal);

  mac_lte_ul_harq_hash = g_hash_table_new(mac_lte_rnti_hash_func, mac_lte_rnti_hash_equal);
  mac_lte_ul_harq_result_hash = g_hash_table_new(mac_lte_framenum_hash_func, mac_lte_framenum_hash_equal);

  mac_lte_ue_sr_state = g_hash_table_new(mac_lte_rnti_hash_func, mac_lte_rnti_hash_equal);
  mac_lte_sr_request_hash = g_hash_table_new(mac_lte_framenum_hash_func, mac_lte_framenum_hash_equal);

  mac_lte_tti_info_result_hash = g_hash_table_new(mac_lte_framenum_hash_func, mac_lte_framenum_hash_equal);
4677 4678 4679 4680 4681
}


static void* lcid_drb_mapping_copy_cb(void* dest, const void* orig, size_t len _U_)
{
4682 4683
  const lcid_drb_mapping_t *o = orig;
  lcid_drb_mapping_t       *d = dest;
4684

4685 4686 4687 4688
  /* Copy all items over */
  d->lcid = o->lcid;
  d->drbid = o->drbid;
  d->channel_type = o->channel_type;
4689

4690
  return d;
4691 4692 4693 4694 4695 4696
}



void proto_register_mac_lte(void)
{
4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843
  static hf_register_info hf[] = {
    /**********************************/
    /* Items for decoding context     */
    {
      &hf_mac_lte_context,
      {
        "Context",
        "mac-lte.context", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_radio_type,
      {
        "Radio Type",
        "mac-lte.radio-type", FT_UINT8, BASE_DEC, VALS(radio_type_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_direction,
      {
        "Direction",
        "mac-lte.direction", FT_UINT8, BASE_DEC, VALS(direction_vals), 0x0,
        "Direction of message", HFILL
      }
    },
    {
      &hf_mac_lte_context_rnti,
      {
        "RNTI",
        "mac-lte.rnti", FT_UINT16, BASE_DEC, 0, 0x0,
        "RNTI associated with message", HFILL
      }
    },
    {
      &hf_mac_lte_context_rnti_type,
      {
        "RNTI Type",
        "mac-lte.rnti-type", FT_UINT8, BASE_DEC, VALS(rnti_type_vals), 0x0,
        "Type of RNTI associated with message", HFILL
      }
    },
    {
      &hf_mac_lte_context_ueid,
      {
        "UEId",
        "mac-lte.ueid", FT_UINT16, BASE_DEC, 0, 0x0,
        "User Equipment Identifier associated with message", HFILL
      }
    },
    {
      &hf_mac_lte_context_sysframe_number,
      {
        "System Frame Number",
        "mac-lte.sfn", FT_UINT16, BASE_DEC, 0, 0x0,
        "System Frame Number associated with message", HFILL
      }
    },
    {
      &hf_mac_lte_context_subframe_number,
      {
        "Subframe",
        "mac-lte.subframe", FT_UINT16, BASE_DEC, 0, 0x0,
        "Subframe number associated with message", HFILL
      }
    },
    {
      &hf_mac_lte_context_grant_subframe_number,
      {
        "Grant Subframe",
        "mac-lte.grant-subframe", FT_UINT16, BASE_DEC, 0, 0x0,
        "Subframe when grant for this PDU was received", HFILL
      }
    },
    {
      &hf_mac_lte_context_predefined_frame,
      {
        "Predefined frame",
        "mac-lte.is-predefined-frame", FT_UINT8, BASE_DEC, VALS(predefined_frame_vals), 0x0,
        "Predefined test frame (or real MAC PDU)", HFILL
      }
    },
    {
      &hf_mac_lte_context_length,
      {
        "Length of frame",
        "mac-lte.length", FT_UINT8, BASE_DEC, 0, 0x0,
        "Original length of frame (including SDUs and padding)", HFILL
      }
    },
    {
      &hf_mac_lte_context_ul_grant_size,
      {
        "Uplink grant size",
        "mac-lte.ul-grant-size", FT_UINT8, BASE_DEC, 0, 0x0,
        "Uplink grant size (in bytes)", HFILL
      }
    },
    {
      &hf_mac_lte_context_bch_transport_channel,
      {
        "Transport channel",
        "mac-lte.bch-transport-channel", FT_UINT8, BASE_DEC, VALS(bch_transport_channel_vals), 0x0,
        "Transport channel BCH data was carried on", HFILL
      }
    },
    {
      &hf_mac_lte_context_retx_count,
      {
        "ReTX count",
        "mac-lte.retx-count", FT_UINT8, BASE_DEC, 0, 0x0,
        "Number of times this PDU has been retransmitted", HFILL
      }
    },
    {
      &hf_mac_lte_context_retx_reason,
      {
        "ReTX reason",
        "mac-lte.retx-reason", FT_UINT8, BASE_DEC, VALS(ul_retx_grant_vals), 0x0,
        "Type of UL ReTx grant", HFILL
      }
    },
    {
      &hf_mac_lte_context_crc_status,
      {
        "CRC Status",
        "mac-lte.crc-status", FT_UINT8, BASE_DEC, VALS(crc_status_vals), 0x0,
        "CRC Status as reported by PHY", HFILL
      }
    },
    {
      &hf_mac_lte_context_rapid,
      {
        "RAPID",
        "mac-lte.preamble-sent.rapid", FT_UINT8, BASE_DEC, 0, 0x0,
        "RAPID sent in RACH preamble", HFILL
      }
    },
    {
      &hf_mac_lte_context_rach_attempt_number,
      {
        "RACH Attempt Number",
        "mac-lte.preamble-sent.attempt", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
4844

4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860
    {
      &hf_mac_lte_ues_ul_per_tti,
      {
        "UL UE in TTI",
        "mac-lte.ul-tti-count", FT_UINT8, BASE_DEC, 0, 0x0,
        "In this TTI, this is the nth UL grant", HFILL
      }
    },
    {
      &hf_mac_lte_ues_dl_per_tti,
      {
        "DL UE in TTI",
        "mac-lte.dl-tti-count", FT_UINT8, BASE_DEC, 0, 0x0,
        "In this TTI, this is the nth DL PDU", HFILL
      }
    },
4861 4862


4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919
    /* Extra PHY context */
    {
      &hf_mac_lte_context_phy_ul,
      {
        "UL PHY attributes",
        "mac-lte.ul-phy", FT_STRING, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_modulation_type,
      {
        "Modulation type",
        "mac-lte.ul-phy.modulation-type", FT_UINT8, BASE_DEC, VALS(modulation_type_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_tbs_index,
      {
        "TBs Index",
        "mac-lte.ul-phy.tbs-index", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_resource_block_length,
      {
        "Resource Block Length",
        "mac-lte.ul-phy.resource-block-length", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_resource_block_start,
      {
        "Resource Block Start",
        "mac-lte.ul-phy.resource-block-start", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_harq_id,
      {
        "HARQ Id",
        "mac-lte.ul-phy.harq-id", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_ul_ndi,
      {
        "NDI",
        "mac-lte.ul-phy.ndi", FT_UINT8, BASE_DEC, 0, 0x0,
        "UL New Data Indicator", HFILL
      }
    },
4920

4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288
    {
      &hf_mac_lte_context_phy_dl,
      {
        "DL PHY attributes",
        "mac-lte.dl-phy", FT_STRING, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_dci_format,
      {
        "DCI format",
        "mac-lte.dl-phy.dci-format", FT_UINT8, BASE_DEC, VALS(dci_format_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_resource_allocation_type,
      {
        "Resource Allocation Type",
        "mac-lte.dl-phy.resource-allocation-type", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_aggregation_level,
      {
        "Aggregation Level",
        "mac-lte.dl-phy.aggregation-level", FT_UINT8, BASE_DEC, VALS(aggregation_level_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_mcs_index,
      {
        "MCS Index",
        "mac-lte.dl-phy.mcs-index", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_redundancy_version_index,
      {
        "RV Index",
        "mac-lte.dl-phy.rv-index", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_retx,
      {
        "DL Retx",
        "mac-lte.dl-phy.dl-retx", FT_BOOLEAN, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_resource_block_length,
      {
        "RB Length",
        "mac-lte.dl-phy.rb-length", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_crc_status,
      {
        "CRC Status",
        "mac-lte.dl-phy.crc-status", FT_UINT8, BASE_DEC, VALS(crc_status_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_harq_id,
      {
        "HARQ Id",
        "mac-lte.dl-phy.harq-id", FT_UINT8, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_ndi,
      {
        "NDI",
        "mac-lte.dl-phy.ndi", FT_UINT8, BASE_DEC, 0, 0x0,
        "New Data Indicator", HFILL
      }
    },
    {
      &hf_mac_lte_context_phy_dl_tb,
      {
        "TB",
        "mac-lte.dl-phy.tb", FT_UINT8, BASE_DEC, 0, 0x0,
        "Transport Block (antenna #)", HFILL
      }
    },

    /* Out-of-band events */
    {
      &hf_mac_lte_oob_send_preamble,
      {
        "PRACH",
        "mac-lte.preamble-sent", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_oob_send_sr,
      {
        "Scheduling Request sent",
        "mac-lte.sr-req", FT_NONE, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_number_of_srs,
      {
        "Number of SRs",
        "mac-lte.sr-req.count", FT_UINT32, BASE_DEC, 0, 0x0,
        "Number of UEs doing SR in this frame", HFILL
      }
    },
    {
      &hf_mac_lte_oob_sr_failure,
      {
        "Scheduling Request failure",
        "mac-lte.sr-failure", FT_NONE, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },

    /*******************************************/
    /* MAC shared channel header fields        */
    {
      &hf_mac_lte_ulsch,
      {
        "UL-SCH",
        "mac-lte.ulsch", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_ulsch_header,
      {
        "UL-SCH Header",
        "mac-lte.ulsch.header", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_dlsch_header,
      {
        "DL-SCH Header",
        "mac-lte.dlsch.header", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_dlsch,
      {
        "DL-SCH",
        "mac-lte.dlsch", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sch_subheader,
      {
        "SCH sub-header",
        "mac-lte.sch.subheader", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch,
      {
        "MCH",
        "mac-lte.mch", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch_header,
      {
        "MCH Header",
        "mac-lte.mch.header", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch_subheader,
      {
        "MCH sub-header",
        "mac-lte.mch.subheader", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sch_reserved,
      {
        "SCH reserved bits",
        "mac-lte.sch.reserved", FT_UINT8, BASE_HEX, NULL, 0xc0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sch_extended,
      {
        "Extension",
        "mac-lte.sch.extended", FT_UINT8, BASE_HEX, 0, 0x20,
        "Extension - i.e. further headers after this one", HFILL
      }
    },
    {
      &hf_mac_lte_dlsch_lcid,
      {
        "LCID",
        "mac-lte.dlsch.lcid", FT_UINT8, BASE_HEX, VALS(dlsch_lcid_vals), 0x1f,
        "DL-SCH Logical Channel Identifier", HFILL
      }
    },
    {
      &hf_mac_lte_ulsch_lcid,
      {
        "LCID",
        "mac-lte.ulsch.lcid", FT_UINT8, BASE_HEX, VALS(ulsch_lcid_vals), 0x1f,
        "UL-SCH Logical Channel Identifier", HFILL
      }
    },
    {
      &hf_mac_lte_sch_format,
      {
        "Format",
        "mac-lte.sch.format", FT_UINT8, BASE_HEX, VALS(format_vals), 0x80,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sch_length,
      {
        "Length",
        "mac-lte.sch.length", FT_UINT16, BASE_DEC, 0, 0x0,
        "Length of MAC SDU or MAC control element", HFILL
      }
    },
    {
      &hf_mac_lte_mch_reserved,
      {
        "MCH reserved bits",
        "mac-lte.mch.reserved", FT_UINT8, BASE_HEX, NULL, 0xc0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch_extended,
      {
        "Extension",
        "mac-lte.mch.extended", FT_UINT8, BASE_HEX, 0, 0x20,
        "Extension - i.e. further headers after this one", HFILL
      }
    },
    {
      &hf_mac_lte_mch_lcid,
      {
        "LCID",
        "mac-lte.mch.lcid", FT_UINT8, BASE_HEX, VALS(mch_lcid_vals), 0x1f,
        "MCH Logical Channel Identifier", HFILL
      }
    },
    {
      &hf_mac_lte_mch_format,
      {
        "Format",
        "mac-lte.mch.format", FT_UINT8, BASE_HEX, VALS(format_vals), 0x80,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch_length,
      {
        "Length",
        "mac-lte.mch.length", FT_UINT16, BASE_DEC, 0, 0x0,
        "Length of MAC SDU or MAC control element", HFILL
      }
    },
    {
      &hf_mac_lte_sch_header_only,
      {
        "MAC PDU Header only",
        "mac-lte.sch.header-only", FT_UINT8, BASE_DEC, VALS(header_only_vals), 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_mch_header_only,
      {
        "MAC PDU Header only",
        "mac-lte.mch.header-only", FT_UINT8, BASE_DEC, VALS(header_only_vals), 0x0,
        NULL, HFILL
      }
    },

    /********************************/
    /* Data                         */
    {
      &hf_mac_lte_sch_sdu,
      {
        "SDU",
        "mac-lte.sch.sdu", FT_BYTES, BASE_NONE, 0, 0x0,
        "Shared channel SDU", HFILL
      }
    },
    {
      &hf_mac_lte_mch_sdu,
      {
        "SDU",
        "mac-lte.mch.sdu", FT_BYTES, BASE_NONE, 0, 0x0,
        "Multicast channel SDU", HFILL
      }
    },
    {
      &hf_mac_lte_bch_pdu,
      {
        "BCH PDU",
        "mac-lte.bch.pdu", FT_BYTES, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_pch_pdu,
      {
        "PCH PDU",
        "mac-lte.pch.pdu", FT_BYTES, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_predefined_pdu,
      {
        "Predefined data",
        "mac-lte.predefined-data", FT_BYTES, BASE_NONE, 0, 0x0,
        "Predefined test data", HFILL
      }
    },
    {
      &hf_mac_lte_raw_pdu,
      {
        "Raw data",
        "mac-lte.raw-data", FT_BYTES, BASE_NONE, 0, 0x0,
        "Raw bytes of PDU (e.g. if CRC error)", HFILL
      }
    },
    {
      &hf_mac_lte_padding_data,
      {
        "Padding data",
        "mac-lte.padding-data", FT_BYTES, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_padding_length,
      {
        "Padding length",
        "mac-lte.padding-length", FT_INT32, BASE_DEC, 0, 0x0,
        "Length of padding data not included at end of frame", HFILL
      }
    },
5289 5290 5291



5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357
    /*********************************/
    /* RAR fields                    */
    {
      &hf_mac_lte_rar,
      {
        "RAR",
        "mac-lte.rar", FT_NONE, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_headers,
      {
        "RAR Headers",
        "mac-lte.rar.headers", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_header,
      {
        "RAR Header",
        "mac-lte.rar.header", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_extension,
      {
        "Extension",
        "mac-lte.rar.e", FT_UINT8, BASE_HEX, 0, 0x80,
        "Extension - i.e. further RAR headers after this one", HFILL
      }
    },
    {
      &hf_mac_lte_rar_t,
      {
        "Type",
        "mac-lte.rar.t", FT_UINT8, BASE_HEX, VALS(rar_type_vals), 0x40,
        "Type field indicating whether the payload is RAPID or BI", HFILL
      }
    },
    {
      &hf_mac_lte_rar_bi,
      {
        "BI",
        "mac-lte.rar.bi", FT_UINT8, BASE_HEX, VALS(rar_bi_vals), 0x0f,
        "Backoff Indicator (ms)", HFILL
      }
    },
    {
      &hf_mac_lte_rar_rapid,
      {
        "RAPID",
        "mac-lte.rar.rapid", FT_UINT8, BASE_HEX_DEC, 0, 0x3f,
        "Random Access Preamble IDentifier", HFILL
      }
    },
    {
      &hf_mac_lte_rar_reserved,
      {
        "Reserved",
        "mac-lte.rar.reserved", FT_UINT8, BASE_HEX, 0, 0x30,
        "Reserved bits in RAR header - should be 0", HFILL
      }
    },
5358

5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609
    {
      &hf_mac_lte_rar_body,
      {
        "RAR Body",
        "mac-lte.rar.body", FT_STRING, BASE_NONE, NULL, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_reserved2,
      {
        "Reserved",
        "mac-lte.rar.reserved2", FT_UINT8, BASE_HEX, 0, 0x80,
        "Reserved bit in RAR body - should be 0", HFILL
      }
    },
    {
      &hf_mac_lte_rar_ta,
      {
        "Timing Advance",
        "mac-lte.rar.ta", FT_UINT16, BASE_DEC, 0, 0x7ff0,
        "Required adjustment to uplink transmission timing", HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant,
      {
        "UL Grant",
        "mac-lte.rar.ul-grant", FT_UINT24, BASE_DEC, 0, 0x0fffff,
        "Size of UL Grant", HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_hopping,
      {
        "Hopping Flag",
        "mac-lte.rar.ul-grant.hopping", FT_UINT8, BASE_DEC, 0, 0x08,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_fsrba,
      {
        "Fixed sized resource block assignment",
        "mac-lte.rar.ul-grant.fsrba", FT_UINT16, BASE_DEC, 0, 0x07fe,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_tmcs,
      {
        "Truncated Modulation and coding scheme",
        "mac-lte.rar.ul-grant.tmcs", FT_UINT16, BASE_DEC, 0, 0x01e0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_tcsp,
      {
        "TPC command for scheduled PUSCH",
        "mac-lte.rar.ul-grant.tcsp", FT_UINT8, BASE_DEC, 0, 0x01c,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_ul_delay,
      {
        "UL Delay",
        "mac-lte.rar.ul-grant.ul-delay", FT_UINT8, BASE_DEC, 0, 0x02,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_ul_grant_cqi_request,
      {
        "CQI Request",
        "mac-lte.rar.ul-grant.cqi-request", FT_UINT8, BASE_DEC, 0, 0x01,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_rar_temporary_crnti,
      {
        "Temporary C-RNTI",
        "mac-lte.rar.temporary-crnti", FT_UINT16, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },

    /**********************/
    /* Control PDU fields */
    {
      &hf_mac_lte_control_bsr,
      {
        "BSR",
        "mac-lte.control.bsr", FT_STRING, BASE_NONE, 0, 0x0,
        "Buffer Status Report", HFILL
      }
    },
    {
      &hf_mac_lte_control_bsr_lcg_id,
      {
        "Logical Channel Group ID",
        "mac-lte.control.bsr.lcg-id", FT_UINT8, BASE_DEC, 0, 0xc0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_short_bsr_buffer_size,
      {
        "Buffer Size",
        "mac-lte.control.bsr.buffer-size", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &buffer_size_vals_ext, 0x3f,
        "Buffer Size available in all channels in group", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_bsr_buffer_size_0,
      {
        "Buffer Size 0",
        "mac-lte.control.bsr.buffer-size-0", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &buffer_size_vals_ext, 0xfc,
        "Buffer Size available in logical channel group 0", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_bsr_buffer_size_1,
      {
        "Buffer Size 1",
        "mac-lte.control.bsr.buffer-size-1", FT_UINT16, BASE_DEC|BASE_EXT_STRING, &buffer_size_vals_ext, 0x03f0,
        "Buffer Size available in logical channel group 1", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_bsr_buffer_size_2,
      {
        "Buffer Size 2",
        "mac-lte.control.bsr.buffer-size-2", FT_UINT16, BASE_DEC|BASE_EXT_STRING, &buffer_size_vals_ext, 0x0fc0,
        "Buffer Size available in logical channel group 2", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_bsr_buffer_size_3,
      {
        "Buffer Size 3",
        "mac-lte.control.bsr.buffer-size-3", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &buffer_size_vals_ext, 0x3f,
        "Buffer Size available in logical channel group 3", HFILL
      }
    },
    {
      &hf_mac_lte_control_short_ext_bsr_buffer_size,
      {
        "Buffer Size",
        "mac-lte.control.bsr.buffer-size", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &ext_buffer_size_vals_ext, 0x3f,
        "Buffer Size available in all channels in group", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_ext_bsr_buffer_size_0,
      {
        "Buffer Size 0",
        "mac-lte.control.bsr.buffer-size-0", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &ext_buffer_size_vals_ext, 0xfc,
        "Buffer Size available in logical channel group 0", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_ext_bsr_buffer_size_1,
      {
        "Buffer Size 1",
        "mac-lte.control.bsr.buffer-size-1", FT_UINT16, BASE_DEC|BASE_EXT_STRING, &ext_buffer_size_vals_ext, 0x03f0,
        "Buffer Size available in logical channel group 1", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_ext_bsr_buffer_size_2,
      {
        "Buffer Size 2",
        "mac-lte.control.bsr.buffer-size-2", FT_UINT16, BASE_DEC|BASE_EXT_STRING, &ext_buffer_size_vals_ext, 0x0fc0,
        "Buffer Size available in logical channel group 2", HFILL
      }
    },
    {
      &hf_mac_lte_control_long_ext_bsr_buffer_size_3,
      {
        "Buffer Size 3",
        "mac-lte.control.bsr.buffer-size-3", FT_UINT8, BASE_DEC|BASE_EXT_STRING, &ext_buffer_size_vals_ext, 0x3f,
        "Buffer Size available in logical channel group 3", HFILL
      }
    },
    {
      &hf_mac_lte_control_crnti,
      {
        "C-RNTI",
        "mac-lte.control.crnti", FT_UINT16, BASE_DEC, 0, 0x0,
        "C-RNTI for the UE", HFILL
      }
    },
    {
      &hf_mac_lte_control_timing_advance,
      {
        "Timing Advance",
        "mac-lte.control.timing-advance", FT_UINT8, BASE_DEC, 0, 0x3f,
        "Timing Advance (0-1282 - see 36.213, 4.2.3)", HFILL
      }
    },
    {
      &hf_mac_lte_control_timing_advance_reserved,
      {
        "Reserved",
        "mac-lte.control.timing-advance.reserved", FT_UINT8, BASE_HEX, 0, 0xc0,
        "Reserved bits", HFILL
      }
    },
    {
      &hf_mac_lte_control_ue_contention_resolution,
      {
        "UE Contention Resolution",
        "mac-lte.control.ue-contention-resolution", FT_STRING, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ue_contention_resolution_identity,
      {
        "UE Contention Resolution Identity",
        "mac-lte.control.ue-contention-resolution.identity", FT_BYTES, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ue_contention_resolution_msg3,
      {
        "Msg3",
        "mac-lte.control.ue-contention-resolution.msg3", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ue_contention_resolution_msg3_matched,
      {
        "UE Contention Resolution Matches Msg3",
        "mac-lte.control.ue-contention-resolution.matches-msg3", FT_BOOLEAN, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ue_contention_resolution_time_since_msg3,
      {
        "Time since Msg3",
        "mac-lte.control.ue-contention-resolution.time-since-msg3", FT_UINT32, BASE_DEC, 0, 0x0,
        "Time in ms since corresponding Msg3", HFILL
      }
    },
5610

5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634
    {
      &hf_mac_lte_control_power_headroom,
      {
        "Power Headroom",
        "mac-lte.control.power-headroom", FT_STRING, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_power_headroom_reserved,
      {
        "Reserved",
        "mac-lte.control.power-headroom.reserved", FT_UINT8, BASE_DEC, 0, 0xc0,
        "Reserved bits, should be 0", HFILL
      }
    },
    {
      &hf_mac_lte_control_power_headroom_level,
      {
        "Power Headroom Level",
        "mac-lte.control.power-headroom.level", FT_UINT8, BASE_DEC|BASE_EXT_STRING,
        &power_headroom_vals_ext, 0x3f, "Power Headroom Level in dB", HFILL
      }
    },
5635

5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747
    {
      &hf_mac_lte_control_ext_power_headroom,
      {
        "Extended Power Headroom",
        "mac-lte.control.ext-power-headroom", FT_STRING, BASE_NONE,
        0, 0x0, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c7,
      {
        "SCell Index 7 Power Headroom",
        "mac-lte.control.ext-power-headroom.c7", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x80, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c6,
      {
        "SCell Index 6 Power Headroom",
        "mac-lte.control.ext-power-headroom.c6", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x40, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c5,
      {
        "SCell Index 5 Power Headroom",
        "mac-lte.control.ext-power-headroom.c5", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x20, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c4,
      {
        "SCell Index 4 Power Headroom",
        "mac-lte.control.ext-power-headroom.c4", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x10, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c3,
      {
        "SCell Index 3 Power Headroom",
        "mac-lte.control.ext-power-headroom.c3", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x08, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c2,
      {
        "SCell Index 2 Power Headroom",
        "mac-lte.control.ext-power-headroom.c2", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x04, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_c1,
      {
        "SCell Index 1 Power Headroom",
        "mac-lte.control.ext-power-headroom.c1", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_ph_vals), 0x02, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_reserved,
      {
        "Reserved",
        "mac-lte.control.ext-power-headroom.reserved", FT_UINT8, BASE_DEC,
        0, 0x01, "Reserved bit, should be 0", HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_power_backoff,
      {
        "Power Backoff",
        "mac-lte.control.ext-power-headroom.power-backoff", FT_BOOLEAN, 8,
        TFS(&mac_lte_power_backoff_vals), 0x80, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_value,
      {
        "Power Headroom Value",
        "mac-lte.control.ext-power-headroom.power-headroom-value", FT_BOOLEAN, 8,
        TFS(&mac_lte_ph_value_vals), 0x40, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_level,
      {
        "Power Headroom Level",
        "mac-lte.control.ext-power-headroom.level", FT_UINT8, BASE_DEC|BASE_EXT_STRING,
        &power_headroom_vals_ext, 0x3f, "Power Headroom Level in dB", HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_reserved2,
      {
        "Reserved",
        "mac-lte.control.ext-power-headroom.reserved2", FT_UINT8, BASE_DEC,
        0, 0xc0, "Reserved bits, should be 0", HFILL
      }
    },
    {
      &hf_mac_lte_control_ext_power_headroom_pcmaxc,
      {
        "Configured UE Transmit Power",
        "mac-lte.control.ext-power-headroom.pcmaxc", FT_UINT8, BASE_DEC|BASE_EXT_STRING,
        &pcmaxc_vals_ext, 0x3f, "Pcmax,c in dBm", HFILL
      }
    },
5748

5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820
    {
      &hf_mac_lte_control_activation_deactivation,
      {
        "Activation/Deactivation",
        "mac-lte.control.activation-deactivation", FT_STRING, BASE_NONE,
        0, 0x0, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c7,
      {
        "SCell Index 7 Status",
        "mac-lte.control.activation-deactivation.c7", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x80, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c6,
      {
        "SCell Index 6 Status",
        "mac-lte.control.activation-deactivation.c6", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x40, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c5,
      {
        "SCell Index 5 Status",
        "mac-lte.control.activation-deactivation.c5", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x20, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c4,
      {
        "SCell Index 4 Status",
        "mac-lte.control.activation-deactivation.c4", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x10, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c3,
      {
        "SCell Index 3 Status",
        "mac-lte.control.activation-deactivation.c3", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x08, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c2,
      {
        "SCell Index 2 Status",
        "mac-lte.control.activation-deactivation.c2", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x04, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_c1,
      {
        "SCell Index 1 Status",
        "mac-lte.control.activation-deactivation.c1", FT_BOOLEAN, 8,
        TFS(&mac_lte_scell_status_vals), 0x02, NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_activation_deactivation_reserved,
      {
        "Reserved",
        "mac-lte.control.activation-deactivation.reserved", FT_UINT8, BASE_DEC,
        0, 0x01, "Reserved bit, should be 0", HFILL
      }
    },
5821

5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879
    {
      &hf_mac_lte_control_mch_scheduling_info,
      {
        "MCH Scheduling Information",
        "mac-lte.control.mch_scheduling_info", FT_STRING, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_control_mch_scheduling_info_lcid,
      {
        "LCID",
        "mac-lte.control.mch_scheduling_info.lcid", FT_UINT8, BASE_HEX, VALS(mch_lcid_vals), 0xf8,
        "Logical Channel ID of the MTCH", HFILL
      }
    },
    {
      &hf_mac_lte_control_mch_scheduling_info_stop_mtch,
      {
        "Stop MTCH",
        "mac-lte.control.mch_scheduling_info.stop_mtch", FT_UINT16, BASE_DEC, 0, 0x07ff,
        "Ordinal number of the subframe where the corresponding MTCH stops", HFILL
      }
    },

    /* Generated fields */
    {
      &hf_mac_lte_dl_harq_resend_original_frame,
      {
        "Frame with previous tx",
        "mac-lte.dlsch.retx.original-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_dl_harq_resend_time_since_previous_frame,
      {
        "Time since previous tx (ms)",
        "mac-lte.dlsch.retx.time-since-previous", FT_UINT16, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_dl_harq_resend_next_frame,
      {
        "Frame with next tx",
        "mac-lte.dlsch.retx.next-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_dl_harq_resend_time_until_next_frame,
      {
        "Time until next tx (ms)",
        "mac-lte.dlsch.retx.time-until-next", FT_UINT16, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
5880

5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912
    {
      &hf_mac_lte_ul_harq_resend_original_frame,
      {
        "Frame with previous tx",
        "mac-lte.ulsch.retx.original-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_ul_harq_resend_time_since_previous_frame,
      {
        "Time since previous tx (ms)",
        "mac-lte.ulsch.retx.time-since-previous", FT_UINT16, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_ul_harq_resend_next_frame,
      {
        "Frame with next tx",
        "mac-lte.ulsch.retx.next-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_ul_harq_resend_time_until_next_frame,
      {
        "Time until next tx (ms)",
        "mac-lte.ulsch.retx.time-until-next", FT_UINT16, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
5913

5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110
    {
      &hf_mac_lte_grant_answering_sr,
      {
        "First Grant Following SR from",
        "mac-lte.ulsch.grant-answering-sr", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_failure_answering_sr,
      {
        "SR which failed",
        "mac-lte.ulsch.failure-answering-sr", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sr_leading_to_failure,
      {
        "This SR fails",
        "mac-lte.ulsch.failure-answering-sr-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sr_leading_to_grant,
      {
        "This SR results in a grant here",
        "mac-lte.ulsch.grant-answering-sr-frame", FT_FRAMENUM, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sr_invalid_event,
      {
        "Invalid event",
        "mac-lte.ulsch.sr-invalid-event", FT_NONE, BASE_NONE, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sr_time_since_request,
      {
        "Time since SR (ms)",
        "mac-lte.ulsch.time-since-sr", FT_UINT32, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },
    {
      &hf_mac_lte_sr_time_until_answer,
      {
        "Time until answer (ms)",
        "mac-lte.ulsch.time-until-sr-answer", FT_UINT32, BASE_DEC, 0, 0x0,
        NULL, HFILL
      }
    },

  };

  static gint *ett[] = {
    &ett_mac_lte,
    &ett_mac_lte_context,
    &ett_mac_lte_phy_context,
    &ett_mac_lte_rar_headers,
    &ett_mac_lte_rar_header,
    &ett_mac_lte_rar_body,
    &ett_mac_lte_rar_ul_grant,
    &ett_mac_lte_ulsch_header,
    &ett_mac_lte_dlsch_header,
    &ett_mac_lte_mch_header,
    &ett_mac_lte_sch_subheader,
    &ett_mac_lte_mch_subheader,
    &ett_mac_lte_bch,
    &ett_mac_lte_bsr,
    &ett_mac_lte_pch,
    &ett_mac_lte_activation_deactivation,
    &ett_mac_lte_contention_resolution,
    &ett_mac_lte_power_headroom,
    &ett_mac_lte_extended_power_headroom,
    &ett_mac_lte_extended_power_headroom_cell,
    &ett_mac_lte_mch_scheduling_info,
    &ett_mac_lte_oob
  };

  static enum_val_t show_info_col_vals[] = {
    {"show-phy", "PHY Info", ShowPHYLayer},
    {"show-mac", "MAC Info", ShowMACLayer},
    {"show-rlc", "RLC Info", ShowRLCLayer},
    {NULL, NULL, -1}
  };

  static enum_val_t lcid_drb_source_vals[] = {
    {"from-static-stable",          "From static table",           FromStaticTable},
    {"from-configuration-protocol", "From configuration protocol", FromConfigurationProtocol},
    {NULL, NULL, -1}
  };


  module_t *mac_lte_module;

  static uat_field_t lcid_drb_mapping_flds[] = {
    UAT_FLD_VS(lcid_drb_mappings, lcid, "lcid", drb_lcid_vals, "The MAC LCID"),
    UAT_FLD_DEC(lcid_drb_mappings, drbid,"drb id (1-32)", "Identifier of logical data channel"),
    UAT_FLD_VS(lcid_drb_mappings, channel_type, "RLC Channel Type", rlc_channel_type_vals, "The MAC LCID"),
    UAT_END_FIELDS
  };

  /* Register protocol. */
  proto_mac_lte = proto_register_protocol("MAC-LTE", "MAC-LTE", "mac-lte");
  proto_register_field_array(proto_mac_lte, hf, array_length(hf));
  proto_register_subtree_array(ett, array_length(ett));

  /* Allow other dissectors to find this one by name. */
  register_dissector("mac-lte", dissect_mac_lte, proto_mac_lte);

  /* Register the tap name */
  mac_lte_tap = register_tap("mac-lte");

  /* Preferences */
  mac_lte_module = prefs_register_protocol(proto_mac_lte, NULL);

  /* Obsolete preferences */
  prefs_register_obsolete_preference(mac_lte_module, "single_rar");
  prefs_register_obsolete_preference(mac_lte_module, "check_reserved_bits");
  prefs_register_obsolete_preference(mac_lte_module, "decode_rar_ul_grant");
  prefs_register_obsolete_preference(mac_lte_module, "show_rlc_info_column");
  prefs_register_obsolete_preference(mac_lte_module, "attempt_to_detect_dl_harq_resend");
  prefs_register_obsolete_preference(mac_lte_module, "attempt_to_track_ul_harq_resend");

  prefs_register_uint_preference(mac_lte_module, "retx_count_warn",
                                 "Number of Re-Transmits before expert warning triggered",
                                 "Number of Re-Transmits before expert warning triggered",
                                 10, &global_mac_lte_retx_counter_trigger);

  prefs_register_bool_preference(mac_lte_module, "attempt_rrc_decode",
                                 "Attempt to decode BCH, PCH and CCCH data using LTE RRC dissector",
                                 "Attempt to decode BCH, PCH and CCCH data using LTE RRC dissector",
                                 &global_mac_lte_attempt_rrc_decode);

  prefs_register_bool_preference(mac_lte_module, "attempt_to_dissect_crc_failures",
                                 "Dissect frames that have failed CRC check",
                                 "Attempt to dissect frames that have failed CRC check",
                                 &global_mac_lte_dissect_crc_failures);

  prefs_register_bool_preference(mac_lte_module, "heuristic_mac_lte_over_udp",
                                 "Try Heuristic LTE-MAC over UDP framing",
                                 "When enabled, use heuristic dissector to find MAC-LTE frames sent with "
                                 "UDP framing",
                                 &global_mac_lte_heur);

  prefs_register_bool_preference(mac_lte_module, "attempt_to_dissect_srb_sdus",
                                 "Attempt to dissect LCID 1&2 as srb1&2",
                                 "Will call LTE RLC dissector with standard settings as per RRC spec",
                                 &global_mac_lte_attempt_srb_decode);

  prefs_register_enum_preference(mac_lte_module, "lcid_to_drb_mapping_source",
                                 "Source of LCID -> drb channel settings",
                                 "Set whether LCID -> drb Table is taken from static table (below) or from "
                                 "info learned from control protocol (e.g. RRC)",
                                 &global_mac_lte_lcid_drb_source, lcid_drb_source_vals, FALSE);

  lcid_drb_mappings_uat = uat_new("Static LCID -> drb Table",
                                  sizeof(lcid_drb_mapping_t),
                                  "drb_logchans",
                                  TRUE,
                                  (void*) &lcid_drb_mappings,
                                  &num_lcid_drb_mappings,
                                  UAT_CAT_FFMT,
                                  "",  /* TODO: is this ref to help manual? */
                                  lcid_drb_mapping_copy_cb,
                                  NULL,
                                  NULL,
                                  NULL,
                                  lcid_drb_mapping_flds );

  prefs_register_uat_preference(mac_lte_module,
                                "drb_table",
                                "LCID -> DRB Mappings Table",
                                "A table that maps from configurable lcids -> RLC logical channels",
                                lcid_drb_mappings_uat);

  prefs_register_uint_preference(mac_lte_module, "bsr_warn_threshold",
                                 "BSR size when warning should be issued (0 - 63)",
                                 "If any BSR report is >= this number, an expert warning will be added",
                                 10, &global_mac_lte_bsr_warn_threshold);

  prefs_register_bool_preference(mac_lte_module, "track_sr",
                                 "Track status of SRs within UEs",
                                 "Track status of SRs, providing links between requests, failure indications and grants",
                                 &global_mac_lte_track_sr);

  prefs_register_enum_preference(mac_lte_module, "layer_to_show",
                                 "Which layer info to show in Info column",
                                 "Can show PHY, MAC or RLC layer info in Info column",
                                 &global_mac_lte_layer_to_show, show_info_col_vals, FALSE);

  register_init_routine(&mac_lte_init_protocol);
6111 6112 6113 6114 6115 6116 6117 6118 6119 6120
}


/* Set LCID -> RLC channel mappings from signalling protocol (i.e. RRC or similar).
   TODO: not using UEID yet - assume all UEs configured identically... */
void set_mac_lte_channel_mapping(guint16 ueid _U_, guint8 lcid,
                                 guint8  srbid, guint8 drbid,
                                 guint8  rlcMode, guint8 um_sn_length,
                                 guint8  ul_priority)
{
6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145
  /* Don't bother setting srb details - we just assume AM */
  if (srbid != 0) {
    return;
  }

  /* Ignore if LCID is out of range */
  if ((lcid < 3) || (lcid > 10)) {
    return;
  }

  /* Set array entry */
  dynamic_lcid_drb_mapping[lcid].valid = TRUE;
  dynamic_lcid_drb_mapping[lcid].drbid = drbid;
  dynamic_lcid_drb_mapping[lcid].ul_priority = ul_priority;

  switch (rlcMode) {
  case RLC_AM_MODE:
    dynamic_lcid_drb_mapping[lcid].channel_type = rlcAM;
    break;

  case RLC_UM_MODE:
    if (um_sn_length == 5) {
      dynamic_lcid_drb_mapping[lcid].channel_type = rlcUM5;
    } else {
      dynamic_lcid_drb_mapping[lcid].channel_type = rlcUM10;
6146 6147
    }

6148
    break;
6149

6150 6151 6152
  default:
    break;
  }
6153 6154 6155 6156
}

/* Return the configured UL priority for the channel */
static guint8 get_mac_lte_channel_priority(guint16 ueid _U_, guint8 lcid,
6157
    guint8 direction)
6158
{
6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169
  /* Priority only affects UL */
  if (direction == DIRECTION_DOWNLINK) {
    return 0;
  }

  /* Won't report value if channel not configured */
  if (!dynamic_lcid_drb_mapping[lcid].valid) {
    return 0;
  } else {
    return dynamic_lcid_drb_mapping[lcid].ul_priority;
  }
6170 6171 6172 6173 6174
}

/* Function to be called from outside this module (e.g. in a plugin) to get per-packet data */
mac_lte_info *get_mac_lte_proto_data(packet_info *pinfo)
{
6175
  return p_get_proto_data(pinfo->fd, proto_mac_lte);
6176 6177 6178 6179 6180
}

/* Function to be called from outside this module (e.g. in a plugin) to set per-packet data */
void set_mac_lte_proto_data(packet_info *pinfo, mac_lte_info *p_mac_lte_info)
{
6181
  p_add_proto_data(pinfo->fd, proto_mac_lte, p_mac_lte_info);
6182 6183 6184 6185
}

void proto_reg_handoff_mac_lte(void)
{
6186
  static dissector_handle_t mac_lte_handle;
6187

6188 6189 6190 6191 6192 6193
  if (!mac_lte_handle) {
    mac_lte_handle = find_dissector("mac-lte");

    /* Add as a heuristic UDP dissector */
    heur_dissector_add("udp", dissect_mac_lte_heur, proto_mac_lte);
  }
6194 6195
}