• Owen Yamauchi's avatar
    Compile out GroupVarint on non-Intel · 5d43d2ab
    Owen Yamauchi authored
    Summary:
    Compile out instead of erroring.
    
    In an ideal world, we'd have a fallback that would work across platforms
    (i.e. no SSE, no unaligned 32-bit writes etc.) and compile some version
    of GroupVarint in all environments. I actually tried this; the SSE stuff
    is all behind #if __SSSE3__ already, so I thought it could work (modulo
    the unaligned-writes problem). I ran into problems with the
    SSSE3-vs.-not distinction that @simpkins alluded to in D652764, and
    decided I'd rather not open that can of worms at the moment.
    
    Test Plan:
    fbmake runtests. Manually force the #ifs to false and make
    sure fbmake runtests still passes (although GroupVarintTest is empty).
    
    Reviewed By: delong.j@fb.com
    
    FB internal diff: D747150
    5d43d2ab
GroupVarint.h 17.4 KB