• Alexey Spiridonov's avatar
    Fix gmock handling in rsocket opensource build · eba20f4d
    Alexey Spiridonov authored
    Summary:
    Simply linking `GMOCK_LIBS` into a binary was not telling CMake that the binary depends on `gmock` being built. So, let's add that dependency explicitly.
    
    This wasn't breaking in production because we typically build with `-j 4`, and `gmock` was getting built before the first dependent binary would attempt to link.
    
    Also, since `rsocket` bundles its own `gmock`, it is just a waste of time to compile a system-level gmock. It's not a real dependency.
    
    NB: The change in `fbcode_builder.py` is needed because now that `rsocket` no longer depends on anything on Github, driver programs that were unconditionally setting `projects_dir` started to fail to build `rsocket`.
    
    Reviewed By: simpkins
    
    Differential Revision: D16461572
    
    fbshipit-source-id: 1e95654e96256e7ed37d42e702b5433bf2fe5328
    eba20f4d
rsocket.py 518 Bytes