Fix Clang 8 -Wdefaulted-function-deleted errors (#1082)
Summary: - Clang 8 introduces a new compiler option which is turned on by default: `-Wdefaulted-function-deleted`. - This flags some code which has special member functions which we declare as defaulted, but are implicitly deleted. As such, it is a bit misleading to mark them as defaulted. So, mark them as deleted. We could also remove them and they would be implicitly deleted, but then the internal linter would not like that we define a user defined type but are not explicit about deleting or defaulting all special member functions. Note: - This fixes some Clang 8 compilation issues, but https://github.com/facebook/folly/issues/1081 contains details about the remaining issues. Pull Request resolved: https://github.com/facebook/folly/pull/1082 Reviewed By: Orvid Differential Revision: D14613574 Pulled By: yfeldblum fbshipit-source-id: 8011b3bc456bf92bbaf374c045fffb130e26d38b
Showing
Please register or sign in to comment