Commit 09a81a96 authored by Joel Marcey's avatar Joel Marcey Committed by Nicholas Ormrod

Be explicit about what we're passing to Endian::big

Summary:
This prevents a linker error on OSX:
```
Undefined symbols for architecture x86_64:
"folly::detail::EndianIntBase::swap(unsigned long)",
referenced from:
__GLOBAL__sub_I_MacAddress.cpp in libfolly.a(MacAddress.cpp.o)
ld: symbol(s) not found for architecture x86_64
```

We need folly and third-party changes in order to land a pull request for HHVM
that starts to get FastCGI running on OSX.

See the checklist of the HHVM pull request here: https://github.com/facebook/hhvm/pull/2944#issuecomment-47281003

Closes #68

GitHub Author: Daniel Sloof <goapsychadelic@gmail.com>

@override-unit-failures

Test Plan: fbmake runtests 100%

Reviewed By: pt@fb.com, njormrod@fb.com

FB internal diff: D1407426
parent 75f93a66
...@@ -24,7 +24,7 @@ using std::string; ...@@ -24,7 +24,7 @@ using std::string;
namespace folly { namespace folly {
const MacAddress MacAddress::BROADCAST{Endian::big(0xffffffffffffU)}; const MacAddress MacAddress::BROADCAST{Endian::big(uint64_t(0xffffffffffffU))};
const MacAddress MacAddress::ZERO; const MacAddress MacAddress::ZERO;
MacAddress::MacAddress(StringPiece str) { MacAddress::MacAddress(StringPiece str) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment