Commit 11ce85ed authored by Orvid King's avatar Orvid King Committed by Facebook Github Bot

Remove the fd overload of EventHandler::changeHandlerFD

Summary: This will probably break things.

Reviewed By: yfeldblum

Differential Revision: D13461653

fbshipit-source-id: bd678ad9ac810bfec7be9411d290071358c66781
parent 3980dd0f
......@@ -43,7 +43,7 @@ void AsyncPipeReader::failRead(const AsyncSocketException& ex) {
void AsyncPipeReader::close() {
unregisterHandler();
if (fd_ >= 0) {
changeHandlerFD(folly::NetworkSocket::fromFd(-1));
changeHandlerFD(NetworkSocket());
if (closeCb_) {
closeCb_(fd_);
......@@ -192,7 +192,7 @@ void AsyncPipeWriter::closeNow() {
}
if (fd_ >= 0) {
unregisterHandler();
changeHandlerFD(folly::NetworkSocket::fromFd(-1));
changeHandlerFD(NetworkSocket());
if (closeCb_) {
closeCb_(fd_);
} else {
......
......@@ -394,7 +394,7 @@ int AsyncSocket::detachFd() {
closeNow();
// Update the EventHandler to stop using this fd.
// This can only be done after closeNow() unregisters the handler.
ioHandler_.changeHandlerFD(folly::NetworkSocket::fromFd(-1));
ioHandler_.changeHandlerFD(NetworkSocket());
return fd.toFd();
}
......
......@@ -140,10 +140,6 @@ class EventHandler : private boost::noncopyable {
*
* This may only be called when the handler is not currently registered.
*/
void changeHandlerFD(int fd) {
changeHandlerFD(NetworkSocket::fromFd(fd));
}
void changeHandlerFD(NetworkSocket fd);
/**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment