Commit 18f713a6 authored by Jim Meyering's avatar Jim Meyering Committed by Facebook Github Bot

change EXPECT_EQ(false, ... to EXPECT_FALSE(...; ditto for ASSERT_EQ

Summary:
Change every instance of EXPECT_EQ(false, ... to the simpler/shorter EXPECT_FALSE(...
Do the same for ASSERT_EQ, for consistency, and for true/TRUE.

Reviewed By: Orvid

Differential Revision: D4751397

fbshipit-source-id: 045293dbf8be1167f0cb1b85a2f9cd59a6a30f73
parent 85361b0c
...@@ -1651,7 +1651,7 @@ TEST(EventBaseTest, EventBaseThreadLoop) { ...@@ -1651,7 +1651,7 @@ TEST(EventBaseTest, EventBaseThreadLoop) {
}); });
base.loop(); base.loop();
ASSERT_EQ(true, ran); ASSERT_TRUE(ran);
} }
TEST(EventBaseTest, EventBaseThreadName) { TEST(EventBaseTest, EventBaseThreadName) {
......
...@@ -142,7 +142,7 @@ TEST(IOBuf, Cursor) { ...@@ -142,7 +142,7 @@ TEST(IOBuf, Cursor) {
c.write((uint8_t)40); // OK c.write((uint8_t)40); // OK
try { try {
c.write((uint8_t)10); // Bad write, checked should except. c.write((uint8_t)10); // Bad write, checked should except.
EXPECT_EQ(true, false); EXPECT_TRUE(false);
} catch (...) { } catch (...) {
} }
} }
......
...@@ -296,11 +296,11 @@ TEST(DynamicConverter, consts) { ...@@ -296,11 +296,11 @@ TEST(DynamicConverter, consts) {
dynamic d3 = true; dynamic d3 = true;
auto i3 = convertTo<const bool>(d3); auto i3 = convertTo<const bool>(d3);
EXPECT_EQ(true, i3); EXPECT_TRUE(i3);
dynamic d4 = "true"; dynamic d4 = "true";
auto i4 = convertTo<const bool>(d4); auto i4 = convertTo<const bool>(d4);
EXPECT_EQ(true, i4); EXPECT_TRUE(i4);
dynamic d5 = dynamic::array(1, 2); dynamic d5 = dynamic::array(1, 2);
auto i5 = convertTo<const std::pair<const int, const int>>(d5); auto i5 = convertTo<const std::pair<const int, const int>>(d5);
......
...@@ -440,10 +440,10 @@ TEST(Dynamic, GetSmallThings) { ...@@ -440,10 +440,10 @@ TEST(Dynamic, GetSmallThings) {
EXPECT_EQ(6.0, ddouble.getDouble()); EXPECT_EQ(6.0, ddouble.getDouble());
EXPECT_EQ(5.0, std::move(mdouble).getDouble()); EXPECT_EQ(5.0, std::move(mdouble).getDouble());
EXPECT_EQ(true, cbool.getBool()); EXPECT_TRUE(cbool.getBool());
dbool.getBool() = false; dbool.getBool() = false;
EXPECT_FALSE(dbool.getBool()); EXPECT_FALSE(dbool.getBool());
EXPECT_EQ(true, std::move(mbool).getBool()); EXPECT_TRUE(std::move(mbool).getBool());
} }
TEST(Dynamic, At) { TEST(Dynamic, At) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment