fix tautological comparisons in Conv.h
Summary: We have an off-by-one in our enable_if/sfinae logic here. We do not want to actually do the comparison in `less_than` when the rhs is exactly the minimum possible lhs. This results in a tautological comparison. I added a unit test for these traits that test all the various sfinae cases. Test Plan: See the clang tautological warnings go away. Under gcc, rerun all tests. All pass. Reviewed By: marcelo.juchem@fb.com FB internal diff: D856869
Showing
Please register or sign in to comment