avoid throwing in thenValue
Summary: AFAIK, thenValue should effectively NOP if the future has an exception. Instead, it throws. C++ throw is expensive, as the stack_unwind process acquires a futex. If the service is seeing lots of exceptions (for example if it's overloaded and trying to shed load) throwing results in high lock contention. Reviewed By: yfeldblum Differential Revision: D13088019 fbshipit-source-id: a4bd39d8196d8691ca3a2c21a4860024b366fdac
Showing
Please register or sign in to comment