Commit 5313ad0d authored by Adam Simpkins's avatar Adam Simpkins Committed by Facebook Github Bot

remove duplicate definition of dynamic::print_as_pseudo_json

Summary:
`folly/test/DynamicTest.cpp` contained a duplicate definition of
`dynamic::print_as_pseudo_json()`.  This caused link errors due if this test
was linked against `json.cpp`.

Part of the problem here is that the `//folly:dynamic` library is somewhat of
a lie: the `dynamic::print_as_pseudo_json()` method is provided by the
`//folly:json` library rather than by `//folly:dynamic`.  This violates
assumptions made by autodeps.  Ultimately the right thing to do might be to
combine `//folly:json` and `//folly:dynamic` into a single rule.

Reviewed By: yangchi

Differential Revision: D8020841

fbshipit-source-id: e563611309c122680a5fc69c3f0da1ad5d4337b0
parent 99661f09
......@@ -16,6 +16,7 @@
#include <folly/dynamic.h>
#include <folly/json.h>
#include <folly/portability/GTest.h>
#include <boost/next_prior.hpp>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment