Commit 592dcbca authored by Andrew Gallagher's avatar Andrew Gallagher Committed by Facebook Github Bot

folly/logging: workaround clang modules bug with unnamed namespaces

Summary:
Named namespaces inside unnamed namespaces conflict when they cross module
boundaries (https://bugs.llvm.org/show_bug.cgi?id=39644).

Reviewed By: yfeldblum

Differential Revision: D13056637

fbshipit-source-id: 2ecf2360bbb3b6e7a3cf72ca20e38d7b940e694a
parent 09408821
...@@ -308,8 +308,8 @@ ...@@ -308,8 +308,8 @@
#endif #endif
#define XLOG_SET_CATEGORY_NAME(category) \ #define XLOG_SET_CATEGORY_NAME(category) \
namespace { \
namespace xlog_detail { \ namespace xlog_detail { \
namespace { \
XLOG_SET_CATEGORY_CHECK \ XLOG_SET_CATEGORY_CHECK \
constexpr inline folly::StringPiece getXlogCategoryName( \ constexpr inline folly::StringPiece getXlogCategoryName( \
folly::StringPiece, \ folly::StringPiece, \
...@@ -585,8 +585,8 @@ constexpr const char* xlogStripFilename( ...@@ -585,8 +585,8 @@ constexpr const char* xlogStripFilename(
* We want each .cpp file that uses xlog.h to get its own separate * We want each .cpp file that uses xlog.h to get its own separate
* implementation of the following functions and variables. * implementation of the following functions and variables.
*/ */
namespace {
namespace xlog_detail { namespace xlog_detail {
namespace {
/** /**
* The default getXlogCategoryName() function. * The default getXlogCategoryName() function.
* *
...@@ -636,5 +636,5 @@ constexpr inline bool isXlogCategoryOverridden(T) { ...@@ -636,5 +636,5 @@ constexpr inline bool isXlogCategoryOverridden(T) {
* statement. * statement.
*/ */
::folly::XlogFileScopeInfo xlogFileScopeInfo; ::folly::XlogFileScopeInfo xlogFileScopeInfo;
} // namespace xlog_detail
} // namespace } // namespace
} // namespace xlog_detail
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment