Commit 5cbaa0fd authored by Vladimir Tkachev's avatar Vladimir Tkachev Committed by Jordan DeLong

Remove byLine(const char*) method

Summary:
Many callers of byLine method use it by providing arguments for File
explicit constructors. Added function breaks byLine(file desciptor)
use case. Commenting it out until File constructors are made exlicit to
fix failing tests.

Test Plan: unittest

Reviewed By: lucian@fb.com

FB internal diff: D1133938

Blame Revision: D1129497
parent 7e31a318
...@@ -135,12 +135,4 @@ inline auto byLine(File file, char delim = '\n') ...@@ -135,12 +135,4 @@ inline auto byLine(File file, char delim = '\n')
| resplit(delim); | resplit(delim);
} }
/**
* Ditto, take the filename and opens it
*/
inline auto byLine(const char* fileName, char delim = '\n')
-> decltype(byLine(File(fileName))) {
return byLine(File(fileName), delim);
}
}} // !folly::gen }} // !folly::gen
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment