Commit 7685dc55 authored by Samuel Miller's avatar Samuel Miller Committed by Facebook GitHub Bot

fix test getX509() call

Summary:
Previous change added dynamic cast but forgot to update class which `getX509()`
is invoked on. Might as well use the cleaner `tryExtractX509()` method anyway.

Reviewed By: abakiaydin

Differential Revision: D32741497

fbshipit-source-id: 3c9ca5340a8ca0f72acdcfe13cd68e87ae8022cf
parent a4f059fb
......@@ -1141,16 +1141,12 @@ TEST(AsyncSSLSocketTest, GetClientCertificate) {
auto clientSelfCert = cliSocket->getSelfCertificate();
CHECK(clientSelfCert);
auto serverOpenSSLPeerCert =
dynamic_cast<const OpenSSLTransportCertificate*>(serverPeerCert);
CHECK(serverOpenSSLPeerCert);
auto serverX509 = serverOpenSSLPeerCert->getX509();
auto serverX509 =
folly::OpenSSLTransportCertificate::tryExtractX509(serverPeerCert);
CHECK(serverX509);
auto clientOpenSSLSelfCert =
dynamic_cast<const OpenSSLTransportCertificate*>(clientSelfCert);
CHECK(clientOpenSSLSelfCert);
auto clientX509 = clientSelfCert->getX509();
auto clientX509 =
folly::OpenSSLTransportCertificate::tryExtractX509(clientSelfCert);
CHECK(clientX509);
// The two certs should be the same.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment