Commit 7d52648f authored by Andrew Huang's avatar Andrew Huang Committed by Facebook GitHub Bot

Fix SSLSessionTest for TravisCI (Ubuntu)

Summary:
These tests pass in our build system, and fail on other platforms (Ubuntu, Darwin). Specifically, they cause our folly's CI to fail, since it's run on Ubuntu.

The tests fail because TLS 1.3 is being enabled for these tests. In retrospect, that *should* cause session resumption to fail, since no additional reads are being done on the socket after the handshake. I'm not quite sure yet why they pass in our build system.

Reviewed By: yfeldblum

Differential Revision: D23513991

fbshipit-source-id: 0a401d19300d8ca7da3f9b5f8263959eac826f8c
parent 0887fa5e
......@@ -47,12 +47,10 @@ void getctx(
std::shared_ptr<folly::SSLContext> serverCtx) {
clientCtx->ciphers("ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH");
clientCtx->loadTrustedCertificates(kTestCA);
clientCtx->enableTLS13();
serverCtx->ciphers("ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH");
serverCtx->loadCertificate(kTestCert);
serverCtx->loadPrivateKey(kTestKey);
serverCtx->enableTLS13();
}
class SSLSessionTest : public testing::Test {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment