Commit 8b53f907 authored by Robin Cheng's avatar Robin Cheng Committed by Facebook GitHub Bot

Skip a test in StackTraceTest under TSAN because it calls signal unsafe functions.

Summary: Apparently the code says, being signal unsafe is OK because the signal is created with raise(). So let's just skip that test under TSAN.

Reviewed By: yfeldblum

Differential Revision: D23484012

fbshipit-source-id: 697234b9f57db97c6c6aaf8131058d3ecec3d059
parent 2044c0c6
...@@ -95,6 +95,11 @@ TEST(StackTraceTest, Simple) { ...@@ -95,6 +95,11 @@ TEST(StackTraceTest, Simple) {
} }
TEST(StackTraceTest, Signal) { TEST(StackTraceTest, Signal) {
if (folly::kIsSanitizeThread) {
// TSAN doesn't like signal-unsafe functions in a signal handler regardless
// of how the signal is raised. So skip the test in that case.
SKIP() << "Not supported for TSAN";
}
struct sigaction sa; struct sigaction sa;
memset(&sa, 0, sizeof(sa)); memset(&sa, 0, sizeof(sa));
sa.sa_sigaction = handler; sa.sa_sigaction = handler;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment