Make sure doCallback() doesn't write into Executor if it's nullptr
Summary: SemiFuture implementation assumes that it's always safe to read Executor (if Executor is DeferredExecutor - then SemiFuture can never be completed until via is called, otherwise Executor is nullptr and we should never overwrite it). doCallback() however was unconditionally overwritting Executor, which resulted in TSAN reports. Reviewed By: yfeldblum Differential Revision: D14063047 fbshipit-source-id: 7553c8a2d0cbda05ad07b87297a334a69ee77f9c
Showing
Please register or sign in to comment